smith-agents 0.12.4 → 0.12.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e2c791c5165889ff1098cc5c92976b1affe2c3f82108815fda1c98fae56c0430
-  data.tar.gz: 5b7d1d9f41e2949c335d6dc8b26a7f69aff73c2edf4ee39e100760ca3c4f4145
+  metadata.gz: 663a12c4a26041ded1da57a8bd899213cc28d330eae1d42a9dc3e4fdbda4dd87
+  data.tar.gz: c997927bbcea376c0db21a92aacdc21e510ac3c8e664d4ebb1eb0f8282cd2b32
 SHA512:
-  metadata.gz: e76354065df47cf04703bc41cda18256df9f2118a9d714f046f3fe04c567256d969be828235b0a6da2ff0ee83fe8953ba8c381ed4209c4f49776cde1658ab5d0
-  data.tar.gz: 3e73cddd45cd37191712cc2ed4d5cdc1fe62dbe07a2de73b86bd626f43eda0ba74efcbf8b40fabbbc15db21e6517495567ac346c4339f3c9864e316894170d3f
+  metadata.gz: 27cc5f8437f8325afde26cd1816f8ca007a1c0f43b0ea02cc14cdcd49c17504cc5b2a22934c8b26ddcac132f5d2dc28f40e9e6fcde8976e01b3d4438523235b2
+  data.tar.gz: d621799d104e1b3b1ba97f14974afb6fa01c99cd179f8817471a55148d0587c9b2e333d47a0ab016855e48b8ab7739badb5db72c22e6730294f23da4947bc96d

data/CHANGELOG.md

@@ -4,6 +4,27 @@ All notable changes to Smith are documented in this file.
 
 Format follows [Keep a Changelog](https://keepachangelog.com/en/1.1.0/). Versioning follows [Semantic Versioning](https://semver.org/spec/v2.0.0.html). Smith is pre-1.0 and under active development; expect occasional contract tightening between minor versions until 1.0.
 
+## [0.12.5] - 2026-10-13
+
+### Fixed
+
+- A streamed step's requests are each sent once: its chat takes a copy of
+  the agent's config (its context, or RubyLLM's) with RubyLLM's HTTP retries
+  (`max_retries`) off, its model resolved again as RubyLLM resolves a chat
+  built with a context (the same id and provider, and the agent's own
+  `assume_model_exists`, so a model RubyLLM lists keeps its output limit and
+  thinking options). Retrying a stream read the next response's error into
+  the buffer the first had filled, so the provider's words were lost: a
+  refusal for want of credit reached Smith as a bare "Invalid request"
+  (`RubyLLM::BadRequestError`) and was never classified as
+  `RubyLLM::PaymentRequiredError`, and a spend-cap 429 as a plain rate limit.
+  A stream that failed part way was sent again, its text streamed twice.
+  Every provider failure of a streamed request, a transient one at connect
+  time included, now goes straight to the step's fallbacks and retries, so
+  a streamed step that should ride out an outage declares them. Calls that
+  do not stream, and requests OpenAI's Responses route sends whole, keep
+  RubyLLM's retries. The global config and the agent's are never changed.
+
 ## [0.12.4] - 2026-10-13
 
 ### Changed

data/README.md

@@ -30,7 +30,7 @@ What you get:
 
 ```ruby
 # Gemfile
-gem "smith-agents", "0.12.4", require: "smith"
+gem "smith-agents", "0.12.5", require: "smith"
 ```
 
 In a Rails app:

data/docs/AGENTS.md

@@ -155,7 +155,17 @@ reason and message id, with `mode: :stream`), and a replayed step streams again
 (unless a response memo kept its reply: then its sink gets the text at once).
 Graph inspection shows the stream, and runtime readiness reports a missing sink
 (`:stream_sink_missing`) and an agent whose calls go to the Responses API
-(`:stream_whole_replies`).
+(`:stream_whole_replies`). A streamed step's requests are each sent once:
+its chat takes a copy of the agent's config with RubyLLM's HTTP retries
+(`max_retries`) off and its model resolved again as RubyLLM resolves a chat
+built with a context (a model RubyLLM lists keeps its limits), since a
+retried stream loses the first response's error body (a refusal for want of
+credit would reach Smith as a bare "Invalid request") or streams its text
+again. Every provider failure of a streamed request, a transient one at
+connect time included, takes the step's fallbacks and retries directly, so
+declare them (`fallback_models`, `retry_on Smith::AgentError`) on a streamed
+step that should ride out an outage. A request OpenAI's Responses route sends
+whole keeps the retries.
 
 ## Batch mode
 

data/docs/ERRORS_AND_RETRIES.md

@@ -113,8 +113,9 @@ naming `RubyLLM::PaymentRequiredError` makes a step that meets it wait for
 credit instead of failing, even when a fallback then fails some other way.
 `Smith::Providers::Anthropic::Batches#submit` raises it too. Any other error
 stays as it is: a rate limit whose message mentions a quota (Gemini's) is a
-rate limit. RubyLLM's own HTTP retries (`max_retries`) may repeat a 429 or a
-streamed refusal before Smith sees it; a refused request is not charged.
+rate limit. RubyLLM's own HTTP retries (`max_retries`) may repeat a 429 of a
+call that does not stream before Smith sees it (a refused request is not
+charged); a streamed call is sent once, so its refusal reaches Smith whole.
 
 Name only errors that mean your own systems failed. A provider's own failure
 (`RubyLLM::Error`, or its HTTP client's `Faraday::Error`) is the provider's

data/lib/smith/agent/attempt_chat.rb

@@ -0,0 +1,44 @@
+# frozen_string_literal: true
+
+module Smith
+  class Agent
+    module AttemptChat
+      private
+
+      # An attempt's chat. A streamed step's sends each request it streams
+      # over the wire once: RubyLLM's HTTP retries would send it again on an
+      # error, its error body already read into the first request's buffer
+      # (so a refusal for want of credit reaches Smith as a bare "Invalid
+      # request", never classified) or its text already streamed (the
+      # retry's text would join it). Smith's fallbacks and the step's
+      # retries take their place. Its chat takes a copy of the agent's config
+      # (its context, or RubyLLM's) without the retries, and resolves its
+      # model again as RubyLLM builds a chat with a context (the same id and
+      # provider, and the agent's own assume_model_exists, so a model RubyLLM
+      # knows keeps its limits), before any hold attaches to its provider. A
+      # request OpenAI's Responses route sends answers whole, unstreamed,
+      # and keeps the retries.
+      def attempt_chat(agent_class, model_reference)
+        chat = agent_class.chat(**model_reference.chat_options, **bridge_workflow_inputs(agent_class))
+        return chat unless @step_stream && streams_over_the_wire?(chat)
+
+        sent_once(chat, agent_class)
+      end
+
+      def sent_once(chat, agent_class)
+        model = chat.model
+        config = (agent_class.context&.config || RubyLLM.config).dup
+        config.max_retries = 0
+        chat.with_context(RubyLLM::Context.new(config))
+        chat.with_model(model.id, provider: model.provider,
+                                  assume_exists: agent_class.chat_kwargs.fetch(:assume_model_exists, false))
+      end
+
+      def streams_over_the_wire?(chat)
+        return false unless chat.respond_to?(:with_context) && chat.respond_to?(:with_model)
+
+        (chat.params[:openai_api_mode] || chat.params["openai_api_mode"]).to_s != "responses"
+      end
+    end
+  end
+end

data/lib/smith/agent/provider_completion.rb

@@ -147,7 +147,7 @@ module Smith
       # rubocop:enable Metrics/AbcSize
 
       def prepared_attempt_chat(agent_class, prepared_input, model_reference, shape)
-        chat = agent_class.chat(**model_reference.chat_options, **bridge_workflow_inputs(agent_class))
+        chat = attempt_chat(agent_class, model_reference)
         add_prepared_input(chat, prepared_input, observed_model_reference(chat, fallback: model_reference).provider)
         continue_paused_loop(chat)
         shaped_chat(chat, model_reference, shape)

data/lib/smith/agent/provider_streaming.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require_relative "attempt_chat"
+
 module Smith
   class Agent
     # The provider calls of a streamed step (Smith::Streaming): before a
@@ -8,6 +10,8 @@ module Smith
     # reason is read from the stream (Providers::StreamFacts), as a
     # streamed reply keeps no raw body.
     module ProviderStreaming
+      include AttemptChat
+
       # Room for what a pause adds besides its messages (its retry, the
       # attempt's usage).
       PAUSE_MARGIN = 4096

data/lib/smith/version.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
 module Smith
-  VERSION = "0.12.4"
+  VERSION = "0.12.5"
   EXECUTION_SEMANTICS_VERSION = "7"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: smith-agents
 version: !ruby/object:Gem::Version
-  version: 0.12.4
+  version: 0.12.5
 platform: ruby
 authors:
 - Samuel Ralak
@@ -161,6 +161,7 @@ files:
 - lib/generators/smith/install/templates/workflow_state.rb.tt
 - lib/smith.rb
 - lib/smith/agent.rb
+- lib/smith/agent/attempt_chat.rb
 - lib/smith/agent/chat_construction.rb
 - lib/smith/agent/completion.rb
 - lib/smith/agent/completion_usage_recording.rb