smile-identity-core 0.1.1 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 584ee28900df6fe47ae9b0a5420139011b7066ade042871e25457ad885cafd8c
-  data.tar.gz: 12659892472717e03ba992186da1f79f131d19275ffca69b92def3332b1c9d59
+  metadata.gz: 433c708dc96d30936d66a28a8722bb0947390d154c0d2ace346ce8381b237fe6
+  data.tar.gz: 84f5459883048c3ee08eb9ee38d6e890d910e4d3a133b39d35eb932603140d70
 SHA512:
-  metadata.gz: a48e3c826a5b4c2b04cc1d276a6599d850b3edd01823365c1777b7346bf38a8e71ffa1f38528840d99dc868a65f9d7e91e6f225b703e88b0f74b79ba48da37c8
-  data.tar.gz: 205bd0c4eb54335a2cd25657df8c036fc174f6285a1543053e216f766df556841cbfbe1bd492616fa00af604afd7e508219ab9ac5a2545262eb8f16ffcc51c88
+  metadata.gz: badf204f3108464b9e9eaef9884b38f446a7bb26a7f6b72e39e90b6a7a64c474bcc14f22f637cbdeecb6533c487a340ccdfe6d18558b90c10857c8cdbe90c112
+  data.tar.gz: dc5e0266ec8007cd88b41d35164cbb3fa71fc299207779817678f8a75663ecd455ea536a6ee13a0d94cfdfc67ca93f3eaae2feed223dd4059bedcf025d8abb92

data/CHANGELOG.md

@@ -4,3 +4,12 @@ All notable changes to this project will be documented in this file.
 ## [0.1.0] - 2019-07-19
 ### Added
 The first release version of Web Api.
+
+## [0.1.1] - 2019-07-23
+### Updated
+Some package configurations were added.
+
+## [0.2.0] - 2019-08-14
+### Added
+Removed two parameters: optional_callback and return_job_status in the submit_job function in favour of an options hash.
+Introduced return_history and image_links

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    smile-identity-core (0.1.1)
+    smile-identity-core (0.2.0)
       rubyzip (~> 1.2, >= 1.2.3)
       typhoeus (~> 1.0, >= 1.0.1)
 

data/README.md

@@ -4,7 +4,7 @@ The official Smile Identity gem exposes two classes namely, the Web API and Auth
 
 The Web API allows you as the Partner to validate a user’s identity against the relevant Identity Authorities/Third Party databases that Smile Identity has access to using ID information provided by your customer/user (including photo for compare).
 
-The Auth Smile class allows you as the Partner to generate a sec key to interact with our servers.
+The Signature class allows you as the Partner to generate a sec key to interact with our servers.
 
 ## Documentation
 

data/lib/smile-identity-core/version.rb

@@ -1,3 +1,3 @@
 module SmileIdentityCore
-  VERSION = "0.1.1"
+  VERSION = "0.2.0"
 end

data/lib/smile-identity-core/web_api.rb

@@ -27,16 +27,16 @@ module SmileIdentityCore
 
     end
 
-    def submit_job(partner_params, images, id_info, optional_callback, return_job_status)
+    def submit_job(partner_params, images, id_info, options)
       self.partner_params = partner_params
       self.images = images
       @timestamp = Time.now.to_i
 
       self.id_info = id_info
-      self.return_job_status = return_job_status
+      self.options = options
 
-      if !optional_callback.empty?
-        @callback_url = optional_callback
+      if options[:optional_callback] && options[:optional_callback].length > 0
+        @callback_url = options[:optional_callback]
       end
 
       if partner_params[:job_type].to_i == 1
@@ -95,22 +95,21 @@ module SmileIdentityCore
       @id_info = id_info
     end
 
-    def return_job_status=(return_job_status)
-      if return_job_status == nil
-        raise ArgumentError.new('Please ensure that you send through return_job_status')
-      end
-
-      if !!return_job_status != return_job_status
-        raise ArgumentError.new('return_job_status needs to be a boolean')
+    def options=(options)
+      updated_options = {}
+      [:optional_callback, :return_job_status, :return_image_links, :return_history].map do |key|
+        if key != :optional_callback
+          updated_options[key] = check_boolean(key, options[key])
+        end
       end
 
-      @return_job_status = return_job_status
+      @options = updated_options
     end
 
     private
 
     def validate_return_data
-      if @callback_url.empty? && !@return_job_status
+      if (!@callback_url || @callback_url.empty?) && !@options[:return_job_status]
         raise ArgumentError.new("Please choose to either get your response via the callback or job status query")
       end
     end
@@ -121,6 +120,18 @@ module SmileIdentityCore
       end
     end
 
+    def check_boolean(key, bool)
+      if (!bool)
+        bool = false;
+      end
+
+      if !!bool != bool
+        raise ArgumentError.new("#{key} needs to be a boolean")
+      end
+
+      return bool
+    end
+
     def determine_sec_key
       hash_signature = Digest::SHA256.hexdigest([@partner_id.to_i, @timestamp].join(":"))
       public_key = OpenSSL::PKey::RSA.new(Base64.decode64(@api_key))
@@ -264,7 +275,7 @@ module SmileIdentityCore
 
       request.on_complete do |response|
         if response.success?
-          if @return_job_status
+          if @options[:return_job_status]
             return query_job_status
           else
             return
@@ -294,7 +305,8 @@ module SmileIdentityCore
         user_id: @partner_params[:user_id],
         job_id: @partner_params[:job_id],
         partner_id: @partner_id,
-        image_links: "false", # we hardcode to false for now
+        image_links: @options[:return_image_links],
+        history: @options[:return_history]
       }.to_json
 
       url = "#{@url}/job_status"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: smile-identity-core
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.2.0
 platform: ruby
 authors:
 - Ridhwana
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-07-23 00:00:00.000000000 Z
+date: 2019-08-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler