smartsend-ruby 0.5.0 → 0.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d36b8c30a86a4866accdd796d49fde62d5e2fe8454460d1a28d21620f52d57db
-  data.tar.gz: 00c0cf8b2b5f219f03b4ccdc06aecdf3353c183909dd417721a19a927e784c2e
+  metadata.gz: c45ce36e82559cb441b9b08910b5d8013a74a9ba7ac286394f71bb989ee75dea
+  data.tar.gz: 5167540923efdbcc3278b8c79d09d21be7a097f8c37dd4e85884f9a437d7a5c8
 SHA512:
-  metadata.gz: 6462b9a13139bf477a86c27aa5a5bdbdd5b53c56923b94f4fece41108bbc6373f2522a056ed7c7b5220dc07eeedabccd9daa57f487b7bf66591fd7be49af3e26
-  data.tar.gz: 89df2896fa3dac223e5333cd43f7c2cbca5b2fcef7a5f3a33d82d5f3bb66b1be33500153a3d361c9e5db8a14f2a8fc5e0fa7f520fa29bd084da54528cd83c6aa
+  metadata.gz: abe6b8111118a639fcc3fa42442e15e9542c9b2d004536552dfa5d94655dd501eae30ef90f5364d0cb41c5e073c6f8e667ab8379811d330d97637130fb8d14b1
+  data.tar.gz: 81eadfc5a5fd8d1762b04ed533ac73e61da3d37b36661cf7f1e092b5a8e3c2f77eca8bf40cdd8d1c7f1f51a344ec2974cbb274be0238cf1eeba724d636e858a9

data/README.md

@@ -153,6 +153,10 @@ account.valid?
 
 ## Changelog
 
+### [0.5.1] - 2018-05-25
+* Compare parcel ids as string
+* Abillity to log requests
+
 ### [0.5.0] - 2018-05-15
 * Find label by tracking_code
 

data/lib/smartsend/client.rb

@@ -2,15 +2,21 @@ require 'http'
 require 'logger'
 
 class Smartsend::Client
+  @@logging = false
 
-  def initialize(account=nil, debug: false)
+  def self.with_logs
+    @@logging = true
+    yield
+    @@logging = false
+  end
+
+  def initialize(account=nil)
     @account = account || Smartsend.account
-    @debug = debug
   end
 
   def post(path, params)
-    debug("POST #{path}")
-    debug(params)
+    log("POST #{path}")
+    log(params)
 
     request do
       http.post(url(path), json: params)
@@ -18,7 +24,7 @@ class Smartsend::Client
   end
 
   def get(path)
-    debug("GET #{path}")
+    log("GET #{path}")
 
     request do
       http.get(url(path))
@@ -32,8 +38,8 @@ class Smartsend::Client
   def request
     response = yield
 
-    debug(response)
-    debug(response.body.to_s)
+    log(response)
+    log(response.body.to_s)
 
     case response.code
     when (200..299)
@@ -74,8 +80,8 @@ class Smartsend::Client
 
   private
 
-  def debug(value)
-    Logger.new($stdout).debug(value) if @debug
+  def log(value)
+    Logger.new($stdout).log(value) if @@logging
   end
 
   BASE_URL = 'http://smartsend-prod.apigee.net/api/v1'.freeze

data/lib/smartsend/label.rb

@@ -2,7 +2,7 @@ class Smartsend::Label
   attr_accessor :tracking_code, :url, :pdf
 
   def self.find_by_tracking_code(tracking_code, account: nil)
-    response = Smartsend::Client.new(account, debug: true).get("shipments/tracking/#{tracking_code}/labels")
+    response = Smartsend::Client.new(account).get("shipments/tracking/#{tracking_code}/labels")
 
     if response.success?
       label = new

data/lib/smartsend/shipment.rb

@@ -28,7 +28,7 @@ class Smartsend::Shipment
 
       response['data']['parcels'].each do |parcel_response|
         parcel = parcels.find do |item|
-          item.internal_id == parcel_response['parcel_internal_id']
+          item.internal_id.to_s == parcel_response['parcel_internal_id'].to_s
         end
 
         parcel&.label_url = parcel_response.dig('pdf', 'link')

data/lib/smartsend/version.rb

@@ -1,3 +1,3 @@
 module Smartsend
-  VERSION = "0.5.0"
+  VERSION = "0.5.1"
 end

data/test/test_shipment.rb

@@ -71,7 +71,7 @@ class ShipmentTest < Minitest::Test
 
     # add one or more parcels/fulfillments to the shipment
     parcel = Smartsend::Parcel.new(
-      internal_id: "123456789", # your internal parcel id
+      internal_id: 123456789, # your internal parcel id
       internal_reference: "123456789",
       weight: 1.25,
       height: 21,

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: smartsend-ruby
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.5.1
 platform: ruby
 authors:
 - Aske Hansen