smartsend-ruby 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0e21904f9f72b5f2539f62b745eae8ebd0e796ac
-  data.tar.gz: b8fc28840c4ace20f5e760f05f47008fc950cbfd
+  metadata.gz: 31f5d50cd758e048368ed4208cb76d4bf015b24d
+  data.tar.gz: 521b79b970af201b0def8cadc432b50ca4d592b4
 SHA512:
-  metadata.gz: 1dce17d09126216ec231abefee7a2e4ee8b7840e0e529d8cf12d8a18dab39d2b8fc4de84dbc6ddd88adeeee0cdf6b0c1a259506fdaa0320b6caac65a698af34d
-  data.tar.gz: 8bc153718756d6ddd37b6a15cf43362ae4511f16261f5dbd5aa194a37de1ec52af912ed413d4ac05f20ed7d732e342342ddab64ac3d8538838180af06f49cc7f
+  metadata.gz: 304eeeca29e60ff755246261364455fbeb90fe15f8b8943a6cbb9125fff69d2fd908df91f80a68c84f786f8fedcec9e34dfb8ed504a07071918782afa9e14360
+  data.tar.gz: 65a5658a830cb9fd620baa76513a9d7994fd41abe9361665d537175db877d9872263972ffb6f61a11d716613e3ba7ec3bbe025393fc0c3f2b32d4991ca196148

data/Gemfile.lock

@@ -0,0 +1,35 @@
+PATH
+  remote: .
+  specs:
+    smartsend-ruby (0.0.1)
+      http (~> 2.2)
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    addressable (2.5.2)
+      public_suffix (>= 2.0.2, < 4.0)
+    domain_name (0.5.20170404)
+      unf (>= 0.0.5, < 1.0.0)
+    http (2.2.2)
+      addressable (~> 2.3)
+      http-cookie (~> 1.0)
+      http-form_data (~> 1.0.1)
+      http_parser.rb (~> 0.6.0)
+    http-cookie (1.0.3)
+      domain_name (~> 0.5)
+    http-form_data (1.0.3)
+    http_parser.rb (0.6.0)
+    public_suffix (3.0.1)
+    unf (0.1.4)
+      unf_ext
+    unf_ext (0.0.7.4)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  smartsend-ruby!
+
+BUNDLED WITH
+   1.14.6

data/README.md

@@ -1,6 +1,6 @@
 # README
 
-This is a ruby wrapper for the Smartsend.io api.
+A ruby wrapper for the Smartsend.io api.
 
 Before beginning you need a Smartsend account.
 
@@ -29,6 +29,8 @@ Smartsend.configure(
 This creates a label.
 
 ```ruby
+
+# initalize a new order
 order = Smartsend::Order.new(
   order_number: "AC12345789",
   carrier: "postdanmark", # postdanmark/gls/bring
@@ -36,9 +38,12 @@ order = Smartsend::Order.new(
   return: false,
   total_price: 199.75,
   shipping_price: 49,
-  currency: "DKK"
+  currency: "DKK",
+  sms_notification: "12345678",
+  email_notification: "contact@smartsend.io"
 )
 
+# set the receiver of the order
 order.receiver = Smartsend::Receiver.new(
   id: "123456", # your internal customer id
   company: "Smart Send",
@@ -50,11 +55,10 @@ order.receiver = Smartsend::Receiver.new(
   city: "Copenhagen",
   country: "DK",
   phone: "12345678",
-  mail: "contact@smartsend.io",
-  sms_notification: "12345678",
-  email_notification: "contact@smartsend.io"
+  mail: "contact@smartsend.io"
 )
 
+# set the receiver of the order
 order.sender = Smartsend::Sender.new(
   company: "Smart Send",
   name1: "Henrik Hansen",
@@ -64,11 +68,11 @@ order.sender = Smartsend::Sender.new(
   zip: "2100",
   city: "Copenhagen",
   country: "DK",
-  sms: "12345678",
+  phone: "12345678",
   mail: "contact@smartsend.io"
 )
 
-# you can ship to a droppoint by defining an agent
+# you can ship to a droppoint by seting an agent
 order.agent = Smartsend::Agent.new(
   id: "7224", # droppoint id
   type: "PDK", # droppoint provider
@@ -84,6 +88,7 @@ order.agent = Smartsend::Agent.new(
   mail: "contact@smartsend.io"
 )
 
+# add one or more parcels/fulfillments to the order
 parcel = Smartsend::Parcel.new(
   shipped_at: DateTime.now,
   reference: "123456789", # your internal parcel id
@@ -99,12 +104,13 @@ parcel = Smartsend::Parcel.new(
   ]
 )
 
+# add items to the parcel
 parcel_item = Smartsend::ParcelItem.new(
   sku: "ABC123",
   title: "ABC123",
   quantity: 2,
-  unitweight: 1.25,
-  unitprice: 144.5,
+  unit_weight: 1.25,
+  unit_price: 144.5,
   currency: "DKK"
 )
 

data/lib/smartsend/agent.rb

@@ -1,11 +1,11 @@
 class Smartsend::Agent < Smartsend::Address
-  attr_accessor :carrier
+  attr_accessor :type
 
   def serialize
     super.merge(
       id: @id,
       agentno: @id,
-      agenttype: @carrier
+      agenttype: @type
     )
   end
 

data/lib/smartsend/client.rb

@@ -5,12 +5,43 @@ class Smartsend::Client
   BASE_URL = 'http://smartsend-prod.apigee.net/v7/booking'.freeze
 
   def post(path, params)
-    response = http.post("#{BASE_URL}/#{path}", json: params)
-    response = JSON.parse(response)
+    request do
+      http.post("#{BASE_URL}/#{path}", json: params)
+    end
+  end
+
+  def request
+    response = yield
+
+    Rails.logger.debug(response.to_s) if defined?(Rails)
+
+    if /^2/ === response.code.to_s
+      Response.new(JSON.parse(response)).successful!
+    else
+      Response.new(response).failed!
+    end
+  end
+
+  class Response < SimpleDelegator
+
+    def successful!
+      @success = true
+      self
+    end
+
+    def failed!
+      @success = false
+      self
+    end
+
+    def success?
+      @success
+    end
 
-    Rails.logger.debug(response) if defined?(Rails)
+    def failed?
+      !@success
+    end
 
-    response
   end
 
   private

data/lib/smartsend/order.rb

@@ -11,9 +11,12 @@ class Smartsend::Order
   def save!
     response = Smartsend::Client.new.post('order', self.serialize)
 
-    update_label_url_tracking_codes(response)
-
-    self
+    if response.success?
+      update_label_url_tracking_codes(response)
+      self
+    else
+      response
+    end
   end
 
   def update_label_url_tracking_codes(response)

data/lib/smartsend/version.rb

@@ -1,3 +1,3 @@
 module Smartsend
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/test/test_addresses.rb

@@ -40,7 +40,7 @@ class AddressesTest < Minitest::Test
   end
 
   def test_agent_serializing
-    receiver = Smartsend::Agent.new(address.merge(carrier: 'PDK'))
+    receiver = Smartsend::Agent.new(address.merge(type: 'PDK'))
 
     assert_equal({
       "id": 1,

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: smartsend-ruby
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Aske Hansen
@@ -32,6 +32,7 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - Gemfile
+- Gemfile.lock
 - README.md
 - Rakefile
 - lib/smartsend-ruby.rb