smartphone_finder-cli 1.0.7 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 267f0b35016f9acb28c770bcd01c980f3277166b
-  data.tar.gz: cb1a125f7fe77c37077b0af43edd361d548f895a
+SHA256:
+  metadata.gz: cb96a908bcfc9703dde3f8950c2119ac194905b57a679024dd5b35c68d069e6d
+  data.tar.gz: 296558344d6ab1b6b28d7ccce2ba6c7567e4f3ea5b84c03239fa1079f67181e9
 SHA512:
-  metadata.gz: 60efba0114b691a6f8c00de828e7c5beaa2c1c8bbdcc95cbc88d539d86aa94b924239032827231fe988f709db9eba7ce16256f3c4539a2d86117b252956b1a94
-  data.tar.gz: d2b82d10e7c0f7513413254e4015ec3371f0f41991b5c1d68ce16340113ddbb8cb94b39824ccd7e350d6546b06c90860804c51b8339a95b23a7be57953d721f7
+  metadata.gz: 8df7beb2699a0cdb2f8816b0203717ef15b7d4eb3734283ec8cb89f66ec4f7cd01ddb10f2185a4345d344d1c7d030b2b9dfdf5530211d7dc8a65bc3a4372f31d
+  data.tar.gz: e858ba8e92f832dc90dfc285efd55781aa9a0bc67373ee7ed3b765178b86d2f31a496a631e3b90e873ad3b83309bf7178455b60e0ecb07de40faca39318e71ed

data/.gitignore

@@ -1,9 +1,9 @@
-/.bundle/
-/.yardoc
-/Gemfile.lock
-/_yardoc/
-/coverage/
-/doc/
-/pkg/
-/spec/reports/
-/tmp/
+/.bundle/
+/.yardoc
+/Gemfile.lock
+/_yardoc/
+/coverage/
+/doc/
+/pkg/
+/spec/reports/
+/tmp/

data/.rspec

@@ -1,2 +1,2 @@
---format documentation
---color
+--format documentation
+--color

data/.travis.yml

@@ -1,5 +1,5 @@
-sudo: false
-language: ruby
-rvm:
-  - 2.3.1
-before_install: gem install bundler -v 1.13.6
+sudo: false
+language: ruby
+rvm:
+  - 2.3.1
+before_install: gem install bundler -v 1.13.6

data/CODE_OF_CONDUCT.md

@@ -1,74 +1,74 @@
-# Contributor Covenant Code of Conduct
-
-## Our Pledge
-
-In the interest of fostering an open and welcoming environment, we as
-contributors and maintainers pledge to making participation in our project and
-our community a harassment-free experience for everyone, regardless of age, body
-size, disability, ethnicity, gender identity and expression, level of experience,
-nationality, personal appearance, race, religion, or sexual identity and
-orientation.
-
-## Our Standards
-
-Examples of behavior that contributes to creating a positive environment
-include:
-
-* Using welcoming and inclusive language
-* Being respectful of differing viewpoints and experiences
-* Gracefully accepting constructive criticism
-* Focusing on what is best for the community
-* Showing empathy towards other community members
-
-Examples of unacceptable behavior by participants include:
-
-* The use of sexualized language or imagery and unwelcome sexual attention or
-advances
-* Trolling, insulting/derogatory comments, and personal or political attacks
-* Public or private harassment
-* Publishing others' private information, such as a physical or electronic
-  address, without explicit permission
-* Other conduct which could reasonably be considered inappropriate in a
-  professional setting
-
-## Our Responsibilities
-
-Project maintainers are responsible for clarifying the standards of acceptable
-behavior and are expected to take appropriate and fair corrective action in
-response to any instances of unacceptable behavior.
-
-Project maintainers have the right and responsibility to remove, edit, or
-reject comments, commits, code, wiki edits, issues, and other contributions
-that are not aligned to this Code of Conduct, or to ban temporarily or
-permanently any contributor for other behaviors that they deem inappropriate,
-threatening, offensive, or harmful.
-
-## Scope
-
-This Code of Conduct applies both within project spaces and in public spaces
-when an individual is representing the project or its community. Examples of
-representing a project or community include using an official project e-mail
-address, posting via an official social media account, or acting as an appointed
-representative at an online or offline event. Representation of a project may be
-further defined and clarified by project maintainers.
-
-## Enforcement
-
-Instances of abusive, harassing, or otherwise unacceptable behavior may be
-reported by contacting the project team at TODO: Write your email address. All
-complaints will be reviewed and investigated and will result in a response that
-is deemed necessary and appropriate to the circumstances. The project team is
-obligated to maintain confidentiality with regard to the reporter of an incident.
-Further details of specific enforcement policies may be posted separately.
-
-Project maintainers who do not follow or enforce the Code of Conduct in good
-faith may face temporary or permanent repercussions as determined by other
-members of the project's leadership.
-
-## Attribution
-
-This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 1.4,
-available at [http://contributor-covenant.org/version/1/4][version]
-
-[homepage]: http://contributor-covenant.org
-[version]: http://contributor-covenant.org/version/1/4/
+# Contributor Covenant Code of Conduct
+
+## Our Pledge
+
+In the interest of fostering an open and welcoming environment, we as
+contributors and maintainers pledge to making participation in our project and
+our community a harassment-free experience for everyone, regardless of age, body
+size, disability, ethnicity, gender identity and expression, level of experience,
+nationality, personal appearance, race, religion, or sexual identity and
+orientation.
+
+## Our Standards
+
+Examples of behavior that contributes to creating a positive environment
+include:
+
+* Using welcoming and inclusive language
+* Being respectful of differing viewpoints and experiences
+* Gracefully accepting constructive criticism
+* Focusing on what is best for the community
+* Showing empathy towards other community members
+
+Examples of unacceptable behavior by participants include:
+
+* The use of sexualized language or imagery and unwelcome sexual attention or
+advances
+* Trolling, insulting/derogatory comments, and personal or political attacks
+* Public or private harassment
+* Publishing others' private information, such as a physical or electronic
+  address, without explicit permission
+* Other conduct which could reasonably be considered inappropriate in a
+  professional setting
+
+## Our Responsibilities
+
+Project maintainers are responsible for clarifying the standards of acceptable
+behavior and are expected to take appropriate and fair corrective action in
+response to any instances of unacceptable behavior.
+
+Project maintainers have the right and responsibility to remove, edit, or
+reject comments, commits, code, wiki edits, issues, and other contributions
+that are not aligned to this Code of Conduct, or to ban temporarily or
+permanently any contributor for other behaviors that they deem inappropriate,
+threatening, offensive, or harmful.
+
+## Scope
+
+This Code of Conduct applies both within project spaces and in public spaces
+when an individual is representing the project or its community. Examples of
+representing a project or community include using an official project e-mail
+address, posting via an official social media account, or acting as an appointed
+representative at an online or offline event. Representation of a project may be
+further defined and clarified by project maintainers.
+
+## Enforcement
+
+Instances of abusive, harassing, or otherwise unacceptable behavior may be
+reported by contacting the project team at TODO: Write your email address. All
+complaints will be reviewed and investigated and will result in a response that
+is deemed necessary and appropriate to the circumstances. The project team is
+obligated to maintain confidentiality with regard to the reporter of an incident.
+Further details of specific enforcement policies may be posted separately.
+
+Project maintainers who do not follow or enforce the Code of Conduct in good
+faith may face temporary or permanent repercussions as determined by other
+members of the project's leadership.
+
+## Attribution
+
+This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 1.4,
+available at [http://contributor-covenant.org/version/1/4][version]
+
+[homepage]: http://contributor-covenant.org
+[version]: http://contributor-covenant.org/version/1/4/

data/Gemfile

@@ -1,4 +1,4 @@
-source 'https://rubygems.org'
-
-# Specify your gem's dependencies in smartphone_finder.gemspec
-gemspec
+source 'https://rubygems.org'
+
+# Specify your gem's dependencies in smartphone_finder.gemspec
+gemspec

data/LICENSE.txt

@@ -1,21 +1,21 @@
-The MIT License (MIT)
-
-Copyright (c) 2016 TODO: Write your name
-
-Permission is hereby granted, free of charge, to any person obtaining a copy
-of this software and associated documentation files (the "Software"), to deal
-in the Software without restriction, including without limitation the rights
-to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-copies of the Software, and to permit persons to whom the Software is
-furnished to do so, subject to the following conditions:
-
-The above copyright notice and this permission notice shall be included in
-all copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
-THE SOFTWARE.
+The MIT License (MIT)
+
+Copyright (c) 2016 TODO: Write your name
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in
+all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+THE SOFTWARE.

data/README.md

@@ -1,43 +1,43 @@
-# SmartphoneFinder
-
-Welcome to Smartphone Finder Cli Application .with this Application you can search online and find your favorite 
-Mobiles,Tabs and SmartWatches Specifications and price ranges .
-
-This App use the famous website www.gsmarena.com to Scrape the information online .
-
-## Installation
-
-Add this line to your application's Gemfile:
-
-```ruby
-gem 'smartphone_finder-cli'
-```
-
-And then execute:
-
-    $ bundle
-
-Or install it yourself as:
-
-    $ gem install smartphone_finder-cli
-
-## Usage
-
-Run: `smartphone_finder` after installing the gem to start cli app.
-
-## Development
-
-After checking out the repo, run `bin/setup` to install dependencies. Then, run `rake spec` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.
-
-To install this gem onto your local machine, run `bundle exec rake install`. To release a new version, update the version number in `version.rb`, and then run `bundle exec rake release`, which will create a git tag for the version, push git commits and tags, and push the `.gem` file to [rubygems.org](https://rubygems.org).
-
-## Contributing
-
-Bug reports and pull requests are welcome on GitHub at https://github.com/alrawi90/smartphone_finder. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [Contributor Covenant](http://contributor-covenant.org) code of conduct.
-
-
-## License
-
-The gem is available as open source under the terms of the [MIT License](http://opensource.org/licenses/MIT).
-
-# smartphone_finder
+# SmartphoneFinder
+
+Welcome to Smartphone Finder Cli Application .with this Application you can search online and find your favorite 
+Mobiles,Tabs and SmartWatches Specifications and price ranges .
+
+This App use the famous website www.gsmarena.com to Scrape the information online .
+
+## Installation
+
+Add this line to your application's Gemfile:
+
+```ruby
+gem 'smartphone_finder-cli'
+```
+
+And then execute:
+
+    $ bundle
+
+Or install it yourself as:
+
+    $ gem install smartphone_finder-cli
+
+## Usage
+
+Run: `smartphone_finder` after installing the gem to start cli app.
+
+## Development
+
+After checking out the repo, run `bin/setup` to install dependencies. Then, run `rake spec` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.
+
+To install this gem onto your local machine, run `bundle exec rake install`. To release a new version, update the version number in `version.rb`, and then run `bundle exec rake release`, which will create a git tag for the version, push git commits and tags, and push the `.gem` file to [rubygems.org](https://rubygems.org).
+
+## Contributing
+
+Bug reports and pull requests are welcome on GitHub at https://github.com/alrawi90/smartphone_finder. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [Contributor Covenant](http://contributor-covenant.org) code of conduct.
+
+
+## License
+
+The gem is available as open source under the terms of the [MIT License](http://opensource.org/licenses/MIT).
+
+# smartphone_finder

data/Rakefile

@@ -1,6 +1,6 @@
-require "bundler/gem_tasks"
-require "rspec/core/rake_task"
-
-RSpec::Core::RakeTask.new(:spec)
-
-task :default => :spec
+require "bundler/gem_tasks"
+require "rspec/core/rake_task"
+
+RSpec::Core::RakeTask.new(:spec)
+
+task :default => :spec

data/bin/console

@@ -1,14 +1,14 @@
-#!/usr/bin/env ruby
-
-require "bundler/setup"
-require "smartphone_finder"
-
-# You can add fixtures and/or initialization code here to make experimenting
-# with your gem easier. You can also use a different console, if you like.
-
-# (If you use this, don't forget to add pry to your Gemfile!)
-# require "pry"
-# Pry.start
-
-require "irb"
-IRB.start
+#!/usr/bin/env ruby
+
+require "bundler/setup"
+require "smartphone_finder"
+
+# You can add fixtures and/or initialization code here to make experimenting
+# with your gem easier. You can also use a different console, if you like.
+
+# (If you use this, don't forget to add pry to your Gemfile!)
+# require "pry"
+# Pry.start
+
+require "irb"
+IRB.start

data/bin/setup

@@ -1,8 +1,8 @@
-#!/usr/bin/env bash
-set -euo pipefail
-IFS=$'\n\t'
-set -vx
-
-bundle install
-
-# Do any other automated setup that you need to do here
+#!/usr/bin/env bash
+set -euo pipefail
+IFS=$'\n\t'
+set -vx
+
+bundle install
+
+# Do any other automated setup that you need to do here

data/bin/smartphone_finder

@@ -1,5 +1,5 @@
-#!/usr/bin/env ruby
-require_relative '../lib/smartphone_finder.rb'
-#require File.expand_path("../smartphone_finder", __FILE__)
-#require '../lib/smartphone_finder.rb'
+#!/usr/bin/env ruby
+require_relative '../lib/smartphone_finder.rb'
+#require File.expand_path("../smartphone_finder", __FILE__)
+#require '../lib/smartphone_finder.rb'
 SmartphoneFinder::CLI.new.start

data/lib/concerns/helper_methods.rb

@@ -1,40 +1,39 @@
-module HelperMethods
-
-   def obj_exist?
-        self.class.all.detect{|obj| obj.name == self.name}
-    end
-    def list_all(array) #this method will print brands in 3 colomns
-			counter=0
-			sep= "----------------------------------------------------------------"
-			indention=" "
-			extra=" "	
-
-            object =array.max{|a, b| a.length <=> b.length}
-        	width=object.length + 5
-    		while counter <array.size
-	    	     counter <9 ? extra=" " : extra=""
-	             if array.size - counter  >=3
-	                 col_1=array[counter]; col_1_spc=indention*(width - col_1.length)
-	                 col_2=array[counter+1] ;col_2_spc=indention*(width - col_2.length)
-	                 col_3=array[counter+2];
-
-	                 puts "#{counter+1}- #{extra}#{col_1}#{col_1_spc}#{counter+2}- #{extra}#{col_2}#{col_2_spc}#{counter+3}- #{extra}#{col_3}"
-	              elsif array.size - counter  >=2
-	                 col_1=array[counter]; col_1_spc=indention*(width - col_1.length)
-	                 col_2=array[counter+1];
-	                 puts "#{counter+1}- {extra}#{col_1}#{col_1_spc}#{counter+2}- #{extra}#{col_2}"
-	              elsif array.size - counter  >=1
-	                 col_1=array[counter];
-	                 puts "#{counter+1}- #{extra}#{col_1}"
-
-	    			    end
-	    			counter+=3
-	    		end
-	    		
-
-            2.times do
-            puts sep*2
-        end  
-    end
-		
+module HelperMethods
+
+    def obj_exist?
+        self.class.all.detect{|obj| obj.name == self.name}
+    end
+    def list_all(array) #this method will print lists in 3 colomns
+			counter=0
+			sep= "----------------------------------------------------------------"
+			indention=" "
+			extra=" "	
+
+            object =array.max{|a, b| a.length <=> b.length} #get the longest list entry
+        	width=object.length + 5
+    		while counter <array.size
+	    	      counter <9 ? extra=" " : extra=""
+	              if array.size - counter  >=3
+	                 col_1=array[counter]; col_1_spc=indention*(width - col_1.length)
+	                 col_2=array[counter+1] ;col_2_spc=indention*(width - col_2.length)
+	                 col_3=array[counter+2];
+	                 puts "#{counter+1}- #{extra}#{col_1}#{col_1_spc}#{counter+2}- #{extra}#{col_2}#{col_2_spc}#{counter+3}- #{extra}#{col_3}"
+	              elsif array.size - counter  >=2
+	                 col_1=array[counter]; col_1_spc=indention*(width - col_1.length)
+	                 col_2=array[counter+1];
+	                 puts "#{counter+1}- #{extra}#{col_1}#{col_1_spc}#{counter+2}- #{extra}#{col_2}"
+	              elsif array.size - counter  >=1
+	                 col_1=array[counter];
+	                 puts "#{counter+1}- #{extra}#{col_1}"
+
+	    		  end
+	    		  counter+=3
+	    	end
+	    		
+
+            2.times do
+               puts sep*2
+            end  
+    end
+		
 end

data/lib/smartphone_finder/brand.rb

@@ -1,40 +1,40 @@
-require_relative '../concerns/helper_methods.rb'
-
-class SmartphoneFinder::Brand
-    include HelperMethods
-    extend HelperMethods
-    @@all=[]
-    attr_accessor :name ,:url ,:devices
-	def initialize(name , url)
-		@name=name 
-		@url= url
-		@devices=[]
-	    if ! obj_exist?
-		  @@all.push(self)
-	    end
-    end
-    def self.find_by_name(brand_name)
-     	self.all.each do |b|
-		  if b.name.downcase==brand_name.downcase 
-			return b	
-		   end
-		end
-		return SmartphoneFinder::Brand.new(brand_name,nil)
-    end
-    def self.all
-	   @@all 
-     end
-
-    def add_device(device)
-      if !self.devices.detect{|obj| obj.name == device.name}
-        devices.push(device)
-      end
-    end
-	def self.list_brands
-		self.list_all(self.all.collect { |obj| obj.name  })	
-	end
-	def list_devices
-	    self.list_all(self.devices.collect { |obj| obj.name  })
-	end
-	
+require_relative '../concerns/helper_methods.rb'
+
+class SmartphoneFinder::Brand
+    include HelperMethods
+    extend HelperMethods
+    @@all=[]
+    attr_accessor :name ,:url ,:devices
+	def initialize(name , url)
+		@name=name 
+		@url= url
+		@devices=[]
+	    if ! obj_exist?
+		  @@all.push(self)
+	    end
+    end
+    def self.find_by_name(brand_name)
+     	self.all.each do |b|
+		  if b.name.downcase==brand_name.downcase 
+			return b	
+		   end
+		end
+		return SmartphoneFinder::Brand.new(brand_name,nil)
+    end
+    def self.all
+	   @@all 
+     end
+
+    def add_device(device)
+      if !self.devices.detect{|obj| obj.name == device.name}
+        devices.push(device)
+      end
+    end
+	def self.list_brands
+		self.list_all(self.all.collect { |obj| obj.name  })	
+	end
+	def list_devices
+	    self.list_all(self.devices.collect { |obj| obj.name  })
+	end
+	
 end

data/lib/smartphone_finder/cli.rb

@@ -1,163 +1,164 @@
-require_relative '../concerns/helper_methods.rb'
-
-class SmartphoneFinder::CLI
-    include HelperMethods
- 	  @search_results=[]
-
-    attr_accessor :search_results
-	  def start
-       welcome
-       menu
-	  end
-
-	  def welcome
-		  puts ""
-		  puts "welcome to Smartphone Finder version #{SmartphoneFinder::VERSION}"
-	  end
-    def list
-    	puts ""
-    	puts "-----------------------Main Menu------------------------------------------------------------#"
-    	puts "1- Search by brand   #Enter '1' to browse brands and related devices online on gsmarena.com |"
-    	puts "2- Search by keyword #Enter '2' to search for specifed keyword online on gsmarena.com       |" 
-    	puts "3- Exit              #Enter '3' to End application.                                         |"
-    	puts "--------------------------------------------------------------------------------------------#"
-    	puts ""
-      puts "choose an option please"
-
-    end	
-    def search_by_brand
-
-    	#get and display brands
-        show_brands
-        #ask user to choose brand index to list relative devices
-        puts""
-        puts"Enter brand index to list relative devices OR Enter 'menu' to list the main menu"
-        input=gets.strip.to_i
-        if input>0 && input <= SmartphoneFinder::Brand.all.size
-        	#get and display devices
-            size=show_devices(input-1)#returns devices number
-            #choose a device and get/display device specifications
-            puts ""
-        	  show_device_spec(size,"1",input-1)
-        elsif input > SmartphoneFinder::Brand.all.size
-            puts ""
-            puts "invalid brand index" 
-            search_by_brand     
-        else
-        	#puts "invalid option" 
-        	list 
-        	end
-
-    	end	
-      def show_brands
-	      	#call scraper to extract brands list
-	    	puts "Geting Brands ..."
-	    	SmartphoneFinder::Scraper.get_brands
-	    	puts ""
-	    	puts "Listing all brands ..."
-	    	puts ""
-	      SmartphoneFinder::Brand.list_brands
-
-      end	
-      def show_devices(index)
-      	  #call scraper to extract devices list
-          SmartphoneFinder::Scraper.get_devices_by_brand(SmartphoneFinder::Brand.all[index])
-          #listing devices .....
-          brand=SmartphoneFinder::Brand.all[index]
-          puts ""
-          puts "Listing #{brand.name} devices ........"
-          puts ""
-          (SmartphoneFinder::Brand.all[index]).list_devices  
-          return brand.devices.size
-      end
-  	
-      def show_search_results 
-    	  puts "Listing search results  ........"
-        puts ""
-            self.list_all(self.search_results)
-    		
-	    end
-      def search_by_keyword
-  	     puts "-------------------------------------------------"
-  	     puts "Enter your desired keyword here  OR Enter 'menu' to list the main menu"
-  	     keyword = gets.strip
-  	     if keyword=="menu"
-  	          list
-  	     else
-  	         self.search_results= SmartphoneFinder::Scraper.get_by_keyword(keyword)
-  			 if self.search_results.size>0
-  	            show_search_results
-  	            show_device_spec(self.search_results.size,"2")
-  	     else 
-  	          puts "No result meet your search , please try different keyword. Would you like to try again ? Y(es) or N(o)"
-  	          response=gets.strip
-  	          if response.downcase=="y" || response.downcase=="yes" 
-  	            search_by_keyword
-  	          else 
-  	           list
-  	           end 
-  	        end
-  	     end
-	    end
-      def show_device_spec(size,option,index=nil)
-	         if option=="1"
-             puts "Enter device index to show related speceifications , Enter '(B)ack' to go to brevious menu , OR Enter 'menu' to list the main menu"
-           else 
-		          puts "Enter device index to show related speceifications , Enter '(R)etry' to try different keyword , OR Enter 'menu' to list the main menu"
-           end
-		      input_ = gets.strip
-          index_=input_.to_i-1
-
-		      if input_.to_i >0 && input_.to_i <= size
-              SmartphoneFinder::Scraper.get_device_spec(SmartphoneFinder::Device.all[index_])
-              puts "Displaying specifications for #{(SmartphoneFinder::Device.all[index_]).name} devices ........"
-              SmartphoneFinder::Device.all[index_].specifications.display
-              puts ""            
-              #show navigation options
-              puts " Enter 'menu' for main menu , Enter '(B)ack' to go to brevious list "
-              response=gets.strip
-              if response.downcase=="b" || response.downcase=="back" 
-
-                option=="2" ? show_search_results : show_devices(index)
-                show_device_spec(size,option, index )
-              else 
-               list
-              end
-          elsif input_.to_i > size
-            puts ""
-            puts "invalid device index"  
-            show_device_spec(size,option,index)
-
-          elsif (input_.downcase=="r" || input_.downcase=="retry") && option=="2" 
-               search_by_keyword 
-          elsif (input_.downcase=="b" || input_.downcase=="back") && option=="1" 
-               search_by_brand
-          else
-            list			   
-         end
-    end
-	
-	    def menu
-    		list
-    		input=nil
-    		while(input !="3")
-    			puts ""
-    			input=gets.strip
-             if input =="1"
-                search_by_brand
-             elsif input =="2"
-                search_by_keyword
-             elsif input=="3"
-             	  puts ""
-                puts "Thank you for using Smartphone Finder" 
-                puts ""
-                break
-
-             else
-              puts "invalid input"
-              list
-            end
-	    	end
-	    end
-
+require_relative '../concerns/helper_methods.rb'
+
+class SmartphoneFinder::CLI
+    include HelperMethods
+ 	  @search_results=[]
+
+    attr_accessor :search_results
+	  def start
+       welcome
+       menu
+	  end
+
+	  def welcome#welcom user and display the current version
+		  puts ""
+		  puts "welcome to Smartphone Finder version #{SmartphoneFinder::VERSION}"
+	  end
+    def list
+    	puts ""
+    	puts "-----------------------Main Menu------------------------------------------------------------#"
+    	puts "1- Search by brand   #Enter '1' to browse brands and related devices online on gsmarena.com |"
+    	puts "2- Search by keyword #Enter '2' to search for specifed keyword online on gsmarena.com       |" 
+    	puts "3- Exit              #Enter '3' to End application.                                         |"
+    	puts "--------------------------------------------------------------------------------------------#"
+    	puts ""
+      puts "choose an option please"
+
+    end	
+    def search_by_brand
+
+    	#get and display brands
+        show_brands
+        #ask user to choose brand index to list relative devices
+        puts""
+        puts"Enter brand index to list relative devices OR Enter 'menu' to list the main menu"
+        input=gets.strip.to_i
+        if input>0 && input <= SmartphoneFinder::Brand.all.size
+        	#get and display devices
+            size=show_devices(input-1)#returns devices number
+            #choose a device and get/display device specifications
+            puts ""
+        	  show_device_spec(size,"1",input-1)
+        elsif input > SmartphoneFinder::Brand.all.size
+            puts ""
+            puts "invalid brand index" 
+            search_by_brand     
+        else
+        	#puts "invalid option" 
+        	list 
+        	end
+
+    	end	
+      def show_brands
+	      	#call scraper to extract brands list
+	    	puts "Geting Brands ..."
+	    	SmartphoneFinder::Scraper.get_brands
+	    	puts ""
+	    	puts "Listing all brands ..."
+	    	puts ""
+	      SmartphoneFinder::Brand.list_brands
+
+      end	
+      def show_devices(index)
+      	  #call scraper to extract devices list
+          SmartphoneFinder::Scraper.get_devices_by_brand(SmartphoneFinder::Brand.all[index])
+          #listing devices .....
+          brand=SmartphoneFinder::Brand.all[index]
+          puts ""
+          puts "Listing #{brand.name} devices ........"
+          puts ""
+          (SmartphoneFinder::Brand.all[index]).list_devices  
+          return brand.devices.size
+      end
+  	
+      def show_search_results 
+    	  puts "Listing search results  ........"
+        puts ""
+            self.list_all(self.search_results)
+    		
+	    end
+      def search_by_keyword
+  	     puts "-------------------------------------------------"
+  	     puts "Enter your desired keyword here  OR Enter 'menu' to list the main menu"
+  	     keyword = gets.strip
+  	     if keyword=="menu"
+  	          list
+  	     else
+  	         self.search_results= SmartphoneFinder::Scraper.get_by_keyword(keyword)
+  			 if self.search_results.size>0
+  	            show_search_results
+  	            show_device_spec(self.search_results.size,"2")
+  	     else 
+  	          puts "No result meet your search , please try different keyword. Would you like to try again ? Y(es) or N(o)"
+  	          response=gets.strip
+  	          if response.downcase=="y" || response.downcase=="yes" 
+  	            search_by_keyword
+  	          else 
+  	           list
+  	           end 
+  	        end
+  	     end
+	    end
+      def show_device_spec(size,option,index=nil)#displaying device specifications
+	        if option=="1"
+             puts "Enter device index to show related speceifications , Enter '(B)ack' to go to brevious menu , OR Enter 'menu' to list the main menu"
+          else 
+		          puts "Enter device index to show related speceifications , Enter '(R)etry' to try different keyword , OR Enter 'menu' to list the main menu"
+           end
+		      input_ = gets.strip
+          index_=input_.to_i-1
+
+		      if input_.to_i >0 && input_.to_i <= size
+              SmartphoneFinder::Scraper.get_device_spec(SmartphoneFinder::Device.all[index_])
+              puts ""
+              puts "Displaying specifications for #{(SmartphoneFinder::Device.all[index_]).name} devices ........"
+              SmartphoneFinder::Device.all[index_].specifications.display
+              puts ""            
+              #show navigation options
+              puts " Enter 'menu' for main menu , Enter '(B)ack' to go to brevious list "
+              response=gets.strip
+              if response.downcase=="b" || response.downcase=="back" 
+                 #calling the correct method according to the chosen option
+                option=="2" ? show_search_results : show_devices(index)
+                show_device_spec(size,option, index )
+              else 
+               list
+              end
+          elsif input_.to_i > size
+            puts ""
+            puts "invalid device index"  
+            show_device_spec(size,option,index)
+
+          elsif (input_.downcase=="r" || input_.downcase=="retry") && option=="2" 
+               search_by_keyword 
+          elsif (input_.downcase=="b" || input_.downcase=="back") && option=="1" 
+               search_by_brand
+          else
+            list			   
+         end
+    end
+	
+	    def menu
+    		list
+    		input=nil
+    		while(input !="3")
+    			puts ""
+    			input=gets.strip
+             if input =="1"
+                search_by_brand
+             elsif input =="2"
+                search_by_keyword
+             elsif input=="3"
+             	  puts ""
+                puts "Thank you for using Smartphone Finder" 
+                puts ""
+                break
+
+             else
+              puts "invalid input"
+              list
+            end
+	    	end
+	    end
+
 end

data/lib/smartphone_finder/device.rb

@@ -1,23 +1,23 @@
-require_relative '../concerns/helper_methods.rb'
-
-class SmartphoneFinder::Device
-	include HelperMethods
-	extend  HelperMethods
-  @@all=[]
-  attr_accessor :name ,:url ,:brand ,:specifications
-	def initialize(name,url,brand=nil)
-	  @specifications=nil
-      @name=name
-      @url=url
-      @brand=brand
-      if ! obj_exist?
-        @@all.push(self)
-      end
-	end
-
-	def self.all
-	   @@all 
-  end
-
-
-end
+require_relative '../concerns/helper_methods.rb'
+
+class SmartphoneFinder::Device
+	include HelperMethods
+	extend  HelperMethods
+  @@all=[]
+  attr_accessor :name ,:url ,:brand ,:specifications
+	def initialize(name,url,brand=nil)
+	  @specifications=nil
+      @name=name
+      @url=url
+      @brand=brand
+      if ! obj_exist?
+        @@all.push(self)
+      end
+	end
+
+	def self.all
+	   @@all 
+  end
+
+
+end

data/lib/smartphone_finder/scraper.rb

@@ -1,54 +1,55 @@
-class SmartphoneFinder::Scraper
-    DOMAIN="http://gsmarena.com/"
-
-
-	def self.get_brands
-	  html= open(DOMAIN)
-	  scrapped=Nokogiri::HTML(html)	
-	  scrapped.css(".brandmenu-v2 ul li a").each do |e|
-
-	  	   SmartphoneFinder::Brand.new(e.text ,e.attribute("href").value)
-
-	  end
-	end
-	def self.get_devices_by_brand(brand)
-		url=brand.url
-	  html= open(DOMAIN+url)
-	  scrapped=Nokogiri::HTML(html)	
-	  scrapped.css(".makers ul li a").each do |a|
-	  device=SmartphoneFinder::Device.new(a.css("span").text,a.attribute("href").value,brand)
-      brand.add_device(device)
-	  end
-	end
-   def self.get_device_spec(device)
-   	  spec_table=""
-   	  url=device.url
-	  html= open(DOMAIN+url)
-	  scrapped=Nokogiri::HTML(html)	
-	  scrapped.css("#specs-list table").each do |table|
-	  	spec_table=spec_table + table.css("th").text + ":\n"
-	  	table.css("tr").each do |tr|
-	  		spec_table=spec_table + "  " + tr.css(".ttl a").text + " - " + tr.css(".nfo").text + "\n"
-	  	end
-	    spec_table=spec_table + "--------------------------------------------------------------\n"
-	end
-    device.specifications= SmartphoneFinder::Specifications.new(device,spec_table)
-   end
-   def self.get_by_keyword(keyword)
-         self.get_brands
-         search_results=[]
-         html =  open(DOMAIN+"results.php3?sQuickSearch=yes&sName="+keyword)
-         scrapped = Nokogiri::HTML(html)
-         scrapped.css("div.makers ul a").each do |a|
-            device_name_no_php=a.attribute("href").value.split("-")
-            device_name_collector=device_name_no_php[0].split("_");
-            brand=SmartphoneFinder::Brand.find_by_name(device_name_collector[0])
-            device_name_collector.shift
-            device_name=device_name_collector.join(" ")
-            device=SmartphoneFinder::Device.new(device_name,a.attribute("href").value,brand)
-            brand.add_device(device)
-            search_results.push(brand.name + ": " +device_name)
-         end
-         search_results
-   end
+require 'open-uri'
+class SmartphoneFinder::Scraper
+    DOMAIN="http://gsmarena.com/"
+
+
+	def self.get_brands
+	  html= URI.open(DOMAIN)
+	  scrapped=Nokogiri::HTML(html)	
+	  scrapped.css(".brandmenu-v2 ul li a").each do |e|
+
+	  	   SmartphoneFinder::Brand.new(e.text ,e.attribute("href").value)
+
+	  end
+	end
+	def self.get_devices_by_brand(brand)
+		url=brand.url
+	  html= URI.open(DOMAIN+url)
+	  scrapped=Nokogiri::HTML(html)	
+	  scrapped.css(".makers ul li a").each do |a|
+	  device=SmartphoneFinder::Device.new(a.css("span").text,a.attribute("href").value,brand)
+      brand.add_device(device)
+	  end
+	end
+   def self.get_device_spec(device)
+   	  spec_table=""
+   	  url=device.url
+	  html= URI.open(DOMAIN+url)
+	  scrapped=Nokogiri::HTML(html)	
+	  scrapped.css("#specs-list table").each do |table|
+	  	spec_table=spec_table + table.css("th").text + ":\n"
+	  	table.css("tr").each do |tr|
+	  		spec_table=spec_table + "  " + tr.css(".ttl a").text + " - " + tr.css(".nfo").text + "\n"
+	  	end
+	    spec_table=spec_table + "--------------------------------------------------------------\n"
+	end
+    device.specifications= SmartphoneFinder::Specifications.new(device,spec_table)
+   end
+   def self.get_by_keyword(keyword)
+         self.get_brands
+         search_results=[]
+         html =  URI.open(DOMAIN+"results.php3?sQuickSearch=yes&sName="+keyword)
+         scrapped = Nokogiri::HTML(html)
+         scrapped.css("div.makers ul a").each do |a|
+            device_name_no_php=a.attribute("href").value.split("-")
+            device_name_collector=device_name_no_php[0].split("_");
+            brand=SmartphoneFinder::Brand.find_by_name(device_name_collector[0])
+            device_name_collector.shift
+            device_name=device_name_collector.join(" ")
+            device=SmartphoneFinder::Device.new(device_name,a.attribute("href").value,brand)
+            brand.add_device(device)
+            search_results.push(brand.name + ": " +device_name)
+         end
+         search_results
+   end
 end

data/lib/smartphone_finder/specifications.rb

@@ -1,10 +1,10 @@
-class SmartphoneFinder::Specifications
-	attr_accessor :device ,:data
-	def initialize(device,data)
-		@device=device
-		@data=data
-	end
-	def display
-		puts data
-	end
+class SmartphoneFinder::Specifications
+	attr_accessor :device ,:data
+	def initialize(device,data)
+		@device=device
+		@data=data
+	end
+	def display
+		puts data
+	end
 end

data/lib/smartphone_finder/version.rb

@@ -1,3 +1,3 @@
-module SmartphoneFinder
-  VERSION = "1.0.7"
-end
+module SmartphoneFinder
+  VERSION = "1.1.0"
+end

data/lib/smartphone_finder.rb

@@ -1,14 +1,14 @@
-require "nokogiri"
-require "open-uri"
-require_relative "smartphone_finder/version"
-require_relative "smartphone_finder/cli"
-require_relative "smartphone_finder/brand"
-require_relative "smartphone_finder/device"
-require_relative "smartphone_finder/scraper"
-require_relative "smartphone_finder/specifications"
-module SmartphoneFinder
-  # Your code goes here...
-  #puts "it works !"
-  
-
-end
+require "nokogiri"
+require "open-uri"
+require_relative "smartphone_finder/version"
+require_relative "smartphone_finder/cli"
+require_relative "smartphone_finder/brand"
+require_relative "smartphone_finder/device"
+require_relative "smartphone_finder/scraper"
+require_relative "smartphone_finder/specifications"
+module SmartphoneFinder
+  # Your code goes here...
+  #puts "it works !"
+  
+
+end

data/smartphone_finder.gemspec

@@ -1,29 +1,29 @@
-# coding: utf-8
-lib = File.expand_path('../lib', __FILE__)
-$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require 'smartphone_finder/version'
-Gem::Specification.new do |spec|
-  #spec.name          = 'smartphone_finder'
-  spec.authors       = ['Ali ALrawi']
-  spec.email         = ['ali.developer90@gmail.com']
-  spec.description   = 'Phones Specifications CLI App via scraping data online from gsmarena.com'
-  spec.summary       = 'Phones Specifications CLI App'
-  spec.homepage      = 'https://github.com/alrawi90/smartphone_finder'
-  spec.license       = 'MIT'
-
-  spec.files         = `git ls-files`.split($\)#['./lib/smartphone_finder']
-
-  spec.executables   = ["smartphone_finder"]
-  #spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
-  spec.name          = "smartphone_finder-cli"
-  spec.require_paths = ["lib", "lib/smartphone_finder"]
-  spec.version       = '1.0.7'#SmartphoneFinder::VERSION
-
-  # Dependencies
-  spec.add_dependency 'nokogiri', '~> 1.6', '>= 1.6.8'
-
-  # Dev Dependencies
-  spec.add_development_dependency 'bundler', '~> 1.13'
-  spec.add_development_dependency 'rake', '~> 10.0'
-  spec.add_development_dependency 'rspec', '~> 3.0'
-end
+# coding: utf-8
+lib = File.expand_path('../lib', __FILE__)
+$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
+require 'smartphone_finder/version'
+Gem::Specification.new do |spec|
+  #spec.name          = 'smartphone_finder'
+  spec.authors       = ['Ali ALrawi']
+  spec.email         = ['ali.developer90@gmail.com']
+  spec.description   = 'Phones Specifications CLI App via scraping data online from gsmarena.com'
+  spec.summary       = 'Phones Specifications CLI App'
+  spec.homepage      = 'https://github.com/alrawi90/smartphone_finder'
+  spec.license       = 'MIT'
+
+  spec.files         = `git ls-files`.split($\)#['./lib/smartphone_finder']
+
+  spec.executables   = ["smartphone_finder"]
+  #spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
+  spec.name          = "smartphone_finder-cli"
+  spec.require_paths = ["lib", "lib/smartphone_finder"]
+  spec.version       = SmartphoneFinder::VERSION
+
+  # Dependencies
+  spec.add_dependency 'nokogiri', '~> 1.6', '>= 1.6.8'
+
+  # Dev Dependencies
+  spec.add_development_dependency 'bundler', '~> 1.13'
+  spec.add_development_dependency 'rake', '~> 10.0'
+  spec.add_development_dependency 'rspec', '~> 3.0'
+end

data/spec/smartphone_finder_spec.rb

@@ -1,11 +1,11 @@
-require "spec_helper"
-
-describe SmartphoneFinder do
-  it "has a version number" do
-    expect(SmartphoneFinder::VERSION).not_to be nil
-  end
-
-  it "does something useful" do
-    expect(false).to eq(true)
-  end
-end
+require "spec_helper"
+
+describe SmartphoneFinder do
+  it "has a version number" do
+    expect(SmartphoneFinder::VERSION).not_to be nil
+  end
+
+  it "does something useful" do
+    expect(false).to eq(true)
+  end
+end

data/spec/spec_helper.rb

@@ -1,2 +1,2 @@
-$LOAD_PATH.unshift File.expand_path("../../lib", __FILE__)
-require "smartphone_finder"
+$LOAD_PATH.unshift File.expand_path("../../lib", __FILE__)
+require "smartphone_finder"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: smartphone_finder-cli
 version: !ruby/object:Gem::Version
-  version: 1.0.7
+  version: 1.1.0
 platform: ruby
 authors:
 - Ali ALrawi
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2016-11-20 00:00:00.000000000 Z
+date: 2022-07-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
@@ -99,7 +99,6 @@ files:
 - lib/smartphone_finder/scraper.rb
 - lib/smartphone_finder/specifications.rb
 - lib/smartphone_finder/version.rb
-- smartphone_finder-cli-1.0.6.gem
 - smartphone_finder.gemspec
 - spec/smartphone_finder_spec.rb
 - spec/spec_helper.rb
@@ -107,7 +106,7 @@ homepage: https://github.com/alrawi90/smartphone_finder
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -123,9 +122,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.4.8
-signing_key: 
+rubygems_version: 3.3.7
+signing_key:
 specification_version: 4
 summary: Phones Specifications CLI App
 test_files: []