smartest 0.3.3.alpha2 → 0.3.3.alpha3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 396af151370001b4762c6c1a71426fef7c2e0773626080af62496bc068afdc02
-  data.tar.gz: 0b5b6e9e76582dfd91df63fe7e2928fbbd6d0a90101e8f3d9834a91d7b94c109
+  metadata.gz: 46365bf842594d74023e6c47da5b98f28e2f8ad765a035de09a54f5d127db2ee
+  data.tar.gz: 53134bcd0052d5cd8b495b36a9ba8bb1344c6dcb0626d0547dfa49bf6eff005e
 SHA512:
-  metadata.gz: 320397233b8b2e0c46b5d44d6a8bc892d44bfccfc9b63a1db31f868fdc3ac7da7c500902f93b36124f61119dc23b05a3238d3032d7e814defed8c7f5b57f9ef1
-  data.tar.gz: 0b507415bf8e31472e4117371474226fbec62802be8a41d002cc38403967d2a877e60d2a7fb0d0695490e416e1fcf208928f3a6882620208c4d694f425138b37
+  metadata.gz: a5ffe755697e79babe4e54e52d9a2e2a13aee1ade7306dfa7adffd7d9ea6ca75b7b96825b05c713261f420f35b28e980a85b068a94823109bffc0a54774d864a
+  data.tar.gz: c030cd6bfcfb44f8273348f99a36a6213c237c9bd580cd49287351b4bf9b70a04af3b6b7889287f12ffbda747dfd7d6a450b9954bf51f8c2bdf5fb71768027ba

data/README.md

@@ -613,6 +613,18 @@ class PaymentFixture < Smartest::Fixture
 end
 ```
 
+Register the fixture class from `around_suite` before tests request the fixture:
+
+```ruby
+around_suite do |suite|
+  use_fixture PaymentFixture
+  suite.run
+end
+```
+
+`use_fixture` is available inside `around_suite` or `around_test` blocks, not as
+a top-level method in a test file.
+
 The stub affects existing instances and new instances of the target class in
 the current Fiber until it is reset. Other Fibers and Threads continue to see
 the original method unless they apply their own stub. Tests can request the
@@ -625,10 +637,16 @@ end
 ```
 
 Use `simple_stub(Time, :now) { fixed_time }` for singleton methods such as class
-methods. Both helpers call `Smartest::SimpleStub` internally, apply the stub,
-register `cleanup { stub.reset }`, and return the stub object. They are
-available inside `Smartest::Fixture` fixture blocks because they need cleanup to
-tie the stub lifetime to the fixture scope.
+methods. Use `simple_stub_const("AppConfig::PAYMENT_PROVIDER", "fake")` for
+constants. Constant stubs are process-global; avoid concurrent tests that stub
+the same constant.
+
+The method stub helpers call `Smartest::SimpleStub` internally, apply the stub,
+register `cleanup { stub.reset }`, and return the stub object.
+`simple_stub_const` records the previous constant value, replaces it, and
+restores or removes it during cleanup. These helpers are available inside
+`Smartest::Fixture` fixture blocks because they need cleanup to tie the stub
+lifetime to the fixture scope.
 
 `Smartest::SimpleStub#apply` and `#reset` are idempotent in the current Fiber.
 `apply!` raises
@@ -862,7 +880,7 @@ Smartest currently focuses on a small runner API:
 - fixture dependencies through keyword arguments
 - fixture cleanup
 - suite-scoped fixtures through `suite_fixture`
-- fixture-scoped method stubs through `simple_stub_any_instance_of` and `simple_stub`
+- fixture-scoped method and constant stubs
 - suite hooks with `around_suite`
 - test hooks with `around_test`
 - skipped and pending tests through `skip` and `pending`

data/lib/smartest/fixture.rb

@@ -73,12 +73,48 @@ module Smartest
       apply_simple_stub(SimpleStub.new(object.singleton_class, method_name, &block))
     end
 
+    def simple_stub_const(constant_path, value)
+      owner, constant_name = resolve_simple_stub_constant(constant_path)
+      original_defined = owner.const_defined?(constant_name, false)
+      original_value = owner.const_get(constant_name, false) if original_defined
+
+      owner.__send__(:remove_const, constant_name) if original_defined
+      owner.const_set(constant_name, value)
+
+      cleanup do
+        owner.__send__(:remove_const, constant_name) if owner.const_defined?(constant_name, false)
+        owner.const_set(constant_name, original_value) if original_defined
+      end
+
+      value
+    end
+
     def apply_simple_stub(stub)
       stub.apply!
       cleanup { stub.reset }
       stub
     end
 
+    def resolve_simple_stub_constant(constant_path)
+      unless constant_path.is_a?(String) || constant_path.is_a?(Symbol)
+        raise ArgumentError, "constant path must be a String or Symbol"
+      end
+
+      names = constant_path.to_s.split("::")
+      names.shift if names.first == ""
+      raise ArgumentError, "constant path must not be empty" if names.empty?
+
+      names.each do |name|
+        raise ArgumentError, "invalid constant path: #{constant_path}" unless name.match?(/\A[A-Z]\w*\z/)
+      end
+
+      constant_name = names.pop.to_sym
+      owner = names.reduce(Object) { |namespace, name| namespace.const_get(name, false) }
+      raise ArgumentError, "constant owner must be a Module or Class" unless owner.is_a?(Module)
+
+      [owner, constant_name]
+    end
+
     def method_missing(method_name, *args, &block)
       return super if RESERVED_CONTEXT_METHODS.include?(method_name)
 

data/lib/smartest/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Smartest
-  VERSION = "0.3.3.alpha2"
+  VERSION = "0.3.3.alpha3"
 end

data/smartest/simple_stub_test.rb

@@ -63,6 +63,10 @@ class SimpleStubSelfTestClock
   end
 end
 
+module SimpleStubSelfTestConfig
+  PROVIDER = :original_provider
+end
+
 test("simple stub stubs instance methods until reset") do
   existing = SimpleStubSelfTestSubject.new("Alice")
   stub = Smartest::SimpleStub.new(SimpleStubSelfTestSubject, :name) { "stubbed" }
@@ -154,6 +158,66 @@ test("simple_stub applies and resets singleton methods from fixture cleanup") do
   expect(status).to eq(0)
 end
 
+test("simple_stub_const applies and resets existing constants from fixture cleanup") do
+  fixture_class = Class.new(Smartest::Fixture) do
+    fixture :stubbed_provider do
+      simple_stub_const("SimpleStubSelfTestConfig::PROVIDER", :stubbed_provider)
+    end
+  end
+
+  suite = Smartest::Suite.new
+  suite.fixture_classes.add(fixture_class)
+  suite.tests.add(
+    SimpleStubSelfTest.test_case(
+      "uses constant stub fixture",
+      proc do |stubbed_provider:|
+        expect(stubbed_provider).to eq(:stubbed_provider)
+        expect(SimpleStubSelfTestConfig::PROVIDER).to eq(:stubbed_provider)
+      end
+    )
+  )
+  suite.tests.add(
+    SimpleStubSelfTest.test_case(
+      "sees restored constant",
+      proc { expect(SimpleStubSelfTestConfig::PROVIDER).to eq(:original_provider) }
+    )
+  )
+
+  status, = SimpleStubSelfTest.run_suite(suite)
+
+  expect(status).to eq(0)
+end
+
+test("simple_stub_const removes newly defined constants from fixture cleanup") do
+  fixture_class = Class.new(Smartest::Fixture) do
+    fixture :stubbed_missing_provider do
+      simple_stub_const("SimpleStubSelfTestConfig::MISSING_PROVIDER", :stubbed_missing_provider)
+    end
+  end
+
+  suite = Smartest::Suite.new
+  suite.fixture_classes.add(fixture_class)
+  suite.tests.add(
+    SimpleStubSelfTest.test_case(
+      "uses new constant stub fixture",
+      proc do |stubbed_missing_provider:|
+        expect(stubbed_missing_provider).to eq(:stubbed_missing_provider)
+        expect(SimpleStubSelfTestConfig::MISSING_PROVIDER).to eq(:stubbed_missing_provider)
+      end
+    )
+  )
+  suite.tests.add(
+    SimpleStubSelfTest.test_case(
+      "sees removed constant",
+      proc { expect(SimpleStubSelfTestConfig.const_defined?(:MISSING_PROVIDER, false)).to eq(false) }
+    )
+  )
+
+  status, = SimpleStubSelfTest.run_suite(suite)
+
+  expect(status).to eq(0)
+end
+
 test("simple stub preserves receiver self and method blocks") do
   subject = SimpleStubSelfTestSubject.new("Alice")
   stub = Smartest::SimpleStub.new(SimpleStubSelfTestSubject, :yielding_greeting) do |prefix, &block|

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: smartest
 version: !ruby/object:Gem::Version
-  version: 0.3.3.alpha2
+  version: 0.3.3.alpha3
 platform: ruby
 authors:
 - Yusuke Iwaki