smartest 0.3.1.alpha3 → 0.3.1.alpha5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 54a058b1385e1b02dee0e7bfd32fec125f97ba34a3cd854cc60cd6485e24e23e
-  data.tar.gz: f9c842f6014215c3e0112149d89fada21772376d0f71c415b84fcc973f6a902f
+  metadata.gz: a5579f607ea23d2a51683b610acb2a75fdfeb4594e65a2489a8388c0561044f8
+  data.tar.gz: 4fb60cd6e38a79cbb5617a5f536abe773224cf86bb6bb1147c09ecd001aabce6
 SHA512:
-  metadata.gz: 4bec90eb3a0bc710e0de357db1ad45436350169af3e300d3c1fce8028edf67ea46c25cc96e8f9fa2723c7d11af9ae835e42eeda202026fc44bbafbd724f25172
-  data.tar.gz: de52e00edc7033ca5ece8f2d3cce2da0dac84f61727299dee5cc70bae862b9266d901a12702d41f19f5a45a7a016a17ea6694ff5a564289d91083bf7add5c9db
+  metadata.gz: b5177080f4e761cc48b2fc5a67a97121e4dc4897f9a5bef1a7ea70525d4e9f14f41cfddce6d234a910789d3a71dc34c1681eda2ba448c2566086632ba0d1a289
+  data.tar.gz: aa8ddd2fbbdf3f3ce71e5c7c62161b358da6a90339171d6a416c64f548a90677e859eb4ed67dee3d68eb558b43dd9bfda8a1a9a589804430b7d9ede0aa60837c

data/README.md

@@ -141,18 +141,19 @@ predicate matcher, then adds:
 ```text
 smartest/fixtures/playwright_fixture.rb
 smartest/matchers/playwright_matcher.rb
-smartest/example_spec.rb
+smartest/example_browser_test.rb
 ```
 
 It also registers `PlaywrightFixture` and `PlaywrightMatcher`, adds
 `playwright-ruby-client` to the Gemfile test group, runs `bundle install`, runs
+`npm init --yes` when no `package.json` exists yet, runs
 `npm install playwright --save-dev`, and downloads Chromium with
-`npx playwright install chromium`.
+`./node_modules/.bin/playwright install`.
 
 Run the generated browser example with:
 
 ```bash
-bundle exec smartest smartest/example_spec.rb
+bundle exec smartest smartest/example_browser_test.rb
 ```
 
 ## Defining tests

data/lib/smartest/init_browser_generator.rb

@@ -58,7 +58,7 @@ module Smartest
       end
     RUBY
 
-    EXAMPLE_SPEC = <<~RUBY
+    EXAMPLE_BROWSER_TEST = <<~RUBY
       # frozen_string_literal: true
 
       require "test_helper"
@@ -74,12 +74,6 @@ module Smartest
       end
     RUBY
 
-    INSTALL_COMMANDS = [
-      ["bundle", "install"],
-      ["npm", "install", "playwright", "--save-dev"],
-      ["./node_modules/.bin/playwright", "install"]
-    ].freeze
-
     def initialize(root: Dir.pwd, output: $stdout, command_runner: nil)
       @root = root
       @output = output
@@ -99,7 +93,7 @@ module Smartest
       update_gemfile
       install_dependencies
       @output.puts
-      @output.puts "Run your browser test suite with: bundle exec smartest smartest/example_spec.rb"
+      @output.puts "Run your browser test suite with: bundle exec smartest smartest/example_browser_test.rb"
 
       0
     end
@@ -107,11 +101,7 @@ module Smartest
     private
 
     def smartest_files
-      Smartest::InitGenerator::FILES.each_with_object({}) do |(path, contents), files|
-        next if path == "smartest/example_test.rb"
-
-        files[path] = contents
-      end.merge("smartest/example_spec.rb" => EXAMPLE_SPEC)
+      Smartest::InitGenerator::FILES.merge("smartest/example_browser_test.rb" => EXAMPLE_BROWSER_TEST)
     end
 
     def create_file(path, contents)
@@ -170,7 +160,7 @@ module Smartest
     end
 
     def install_dependencies
-      INSTALL_COMMANDS.each do |command|
+      install_commands.each do |command|
         @output.puts "run     #{command.join(" ")}"
         next if @command_runner.call(command, chdir: @root)
 
@@ -178,6 +168,14 @@ module Smartest
       end
     end
 
+    def install_commands
+      commands = [["bundle", "install"]]
+      commands << ["npm", "init", "--yes"] unless File.exist?(File.join(@root, "package.json"))
+      commands << ["npm", "install", "playwright", "--save-dev"]
+      commands << ["./node_modules/.bin/playwright", "install"]
+      commands
+    end
+
     def run_system_command(command, chdir:)
       system(*command, chdir: chdir)
     end

data/lib/smartest/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Smartest
-  VERSION = "0.3.1.alpha3"
+  VERSION = "0.3.1.alpha5"
 end

data/smartest/smartest_test.rb

@@ -2024,9 +2024,8 @@ test("cli browser init generator creates Playwright scaffold and installation co
     status = generator.run
 
     expect(status).to eq(0)
-    expect(File.exist?(File.join(dir, "smartest/example_test.rb"))).to eq(false)
-    expect(File.read(File.join(dir, "smartest/example_spec.rb"))).to include("finds the smartest gem on RubyGems")
-    expect(File.read(File.join(dir, "smartest/example_spec.rb"))).to include('expect(page).to have_url("https://rubygems.org/gems/smartest")')
+    expect(File.read(File.join(dir, "smartest/example_browser_test.rb"))).to include("finds the smartest gem on RubyGems")
+    expect(File.read(File.join(dir, "smartest/example_browser_test.rb"))).to include('expect(page).to have_url("https://rubygems.org/gems/smartest")')
     expect(File.read(File.join(dir, "smartest/fixtures/playwright_fixture.rb"))).to include("class PlaywrightFixture < Smartest::Fixture")
     expect(File.read(File.join(dir, "smartest/fixtures/playwright_fixture.rb"))).to include('require "playwright"')
     expect(File.read(File.join(dir, "smartest/fixtures/playwright_fixture.rb"))).to include('playwright_cli_executable_path: "./node_modules/.bin/playwright"')
@@ -2044,13 +2043,49 @@ test("cli browser init generator creates Playwright scaffold and installation co
     expect(commands).to eq(
       [
         [["bundle", "install"], dir],
+        [["npm", "init", "--yes"], dir],
         [["npm", "install", "playwright", "--save-dev"], dir],
         [["./node_modules/.bin/playwright", "install"], dir]
       ]
     )
     expect(output.string).to include("run     bundle install")
+    expect(output.string).to include("run     npm init --yes")
     expect(output.string).to include("run     npm install playwright --save-dev")
     expect(output.string).to include("run     ./node_modules/.bin/playwright install")
-    expect(output.string).to include("Run your browser test suite with: bundle exec smartest smartest/example_spec.rb")
+    expect(output.string).to include("Run your browser test suite with: bundle exec smartest smartest/example_browser_test.rb")
+  end
+end
+
+test("cli browser init generator skips npm init when package.json already exists") do
+  Dir.mktmpdir do |dir|
+    File.write(File.join(dir, "Gemfile"), <<~RUBY)
+      source "https://rubygems.org"
+
+      gem "smartest"
+    RUBY
+    File.write(File.join(dir, "package.json"), "{\n  \"name\": \"existing\"\n}\n")
+
+    commands = []
+    output = StringIO.new
+    generator = Smartest::InitBrowserGenerator.new(
+      root: dir,
+      output: output,
+      command_runner: ->(command, chdir:) {
+        commands << [command, chdir]
+        true
+      }
+    )
+
+    status = generator.run
+
+    expect(status).to eq(0)
+    expect(commands).to eq(
+      [
+        [["bundle", "install"], dir],
+        [["npm", "install", "playwright", "--save-dev"], dir],
+        [["./node_modules/.bin/playwright", "install"], dir]
+      ]
+    )
+    expect(output.string).not_to include("npm init --yes")
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: smartest
 version: !ruby/object:Gem::Version
-  version: 0.3.1.alpha3
+  version: 0.3.1.alpha5
 platform: ruby
 authors:
 - Yusuke Iwaki