smartest 0.3.1.alpha3 → 0.3.1.alpha4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 54a058b1385e1b02dee0e7bfd32fec125f97ba34a3cd854cc60cd6485e24e23e
-  data.tar.gz: f9c842f6014215c3e0112149d89fada21772376d0f71c415b84fcc973f6a902f
+  metadata.gz: f0ad4d0e55a491b021ce003225cabcec5ceef4e2f3fbfd5f24c5bfbb8064a65b
+  data.tar.gz: ea6b00342dfccdac90f904f90684af1ff69a75865ccaaf50b74803d7fdfd8cfb
 SHA512:
-  metadata.gz: 4bec90eb3a0bc710e0de357db1ad45436350169af3e300d3c1fce8028edf67ea46c25cc96e8f9fa2723c7d11af9ae835e42eeda202026fc44bbafbd724f25172
-  data.tar.gz: de52e00edc7033ca5ece8f2d3cce2da0dac84f61727299dee5cc70bae862b9266d901a12702d41f19f5a45a7a016a17ea6694ff5a564289d91083bf7add5c9db
+  metadata.gz: '099d26d094f730b421d3cfe2d09c8a9391f13a1949e111c00c4c3612fa22510f6403db236a87ca352f4646a695fffc0136d3d9b804acaf0287c4d75d79c900cf'
+  data.tar.gz: f77ea77aa5cb56ecf4df7bdaf5d63537daae371997d2aeca7a66d74abc4a52add7241bb0b922e3c392306dd714405abe267af4ae65dcbeb6f0b3d8c506474a00

data/README.md

@@ -146,8 +146,9 @@ smartest/example_spec.rb
 
 It also registers `PlaywrightFixture` and `PlaywrightMatcher`, adds
 `playwright-ruby-client` to the Gemfile test group, runs `bundle install`, runs
+`npm init --yes` when no `package.json` exists yet, runs
 `npm install playwright --save-dev`, and downloads Chromium with
-`npx playwright install chromium`.
+`./node_modules/.bin/playwright install`.
 
 Run the generated browser example with:
 

data/lib/smartest/init_browser_generator.rb

@@ -74,12 +74,6 @@ module Smartest
       end
     RUBY
 
-    INSTALL_COMMANDS = [
-      ["bundle", "install"],
-      ["npm", "install", "playwright", "--save-dev"],
-      ["./node_modules/.bin/playwright", "install"]
-    ].freeze
-
     def initialize(root: Dir.pwd, output: $stdout, command_runner: nil)
       @root = root
       @output = output
@@ -170,7 +164,7 @@ module Smartest
     end
 
     def install_dependencies
-      INSTALL_COMMANDS.each do |command|
+      install_commands.each do |command|
         @output.puts "run     #{command.join(" ")}"
         next if @command_runner.call(command, chdir: @root)
 
@@ -178,6 +172,14 @@ module Smartest
       end
     end
 
+    def install_commands
+      commands = [["bundle", "install"]]
+      commands << ["npm", "init", "--yes"] unless File.exist?(File.join(@root, "package.json"))
+      commands << ["npm", "install", "playwright", "--save-dev"]
+      commands << ["./node_modules/.bin/playwright", "install"]
+      commands
+    end
+
     def run_system_command(command, chdir:)
       system(*command, chdir: chdir)
     end

data/lib/smartest/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Smartest
-  VERSION = "0.3.1.alpha3"
+  VERSION = "0.3.1.alpha4"
 end

data/smartest/smartest_test.rb

@@ -2044,13 +2044,49 @@ test("cli browser init generator creates Playwright scaffold and installation co
     expect(commands).to eq(
       [
         [["bundle", "install"], dir],
+        [["npm", "init", "--yes"], dir],
         [["npm", "install", "playwright", "--save-dev"], dir],
         [["./node_modules/.bin/playwright", "install"], dir]
       ]
     )
     expect(output.string).to include("run     bundle install")
+    expect(output.string).to include("run     npm init --yes")
     expect(output.string).to include("run     npm install playwright --save-dev")
     expect(output.string).to include("run     ./node_modules/.bin/playwright install")
     expect(output.string).to include("Run your browser test suite with: bundle exec smartest smartest/example_spec.rb")
   end
 end
+
+test("cli browser init generator skips npm init when package.json already exists") do
+  Dir.mktmpdir do |dir|
+    File.write(File.join(dir, "Gemfile"), <<~RUBY)
+      source "https://rubygems.org"
+
+      gem "smartest"
+    RUBY
+    File.write(File.join(dir, "package.json"), "{\n  \"name\": \"existing\"\n}\n")
+
+    commands = []
+    output = StringIO.new
+    generator = Smartest::InitBrowserGenerator.new(
+      root: dir,
+      output: output,
+      command_runner: ->(command, chdir:) {
+        commands << [command, chdir]
+        true
+      }
+    )
+
+    status = generator.run
+
+    expect(status).to eq(0)
+    expect(commands).to eq(
+      [
+        [["bundle", "install"], dir],
+        [["npm", "install", "playwright", "--save-dev"], dir],
+        [["./node_modules/.bin/playwright", "install"], dir]
+      ]
+    )
+    expect(output.string).not_to include("npm init --yes")
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: smartest
 version: !ruby/object:Gem::Version
-  version: 0.3.1.alpha3
+  version: 0.3.1.alpha4
 platform: ruby
 authors:
 - Yusuke Iwaki