smarter_csv 1.6.0 → 1.6.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fd2cf82aafc3b45257fbdfc594ed8e1d3bf2226e59cbee144b3003d8f79ec6cf
-  data.tar.gz: 95df862865e3123cf86194d47107f140f69f2fc91c20aba01d4004e8bffa5d74
+  metadata.gz: 9be5f053e15e157d7d28555b4de894d2761d5918203da45f5fc4e6c5adcc2a3f
+  data.tar.gz: a47394f3d1f985960a64abf1a43ce6ebf9b8217af2c01a0c5f053af8c77c09ae
 SHA512:
-  metadata.gz: df32ae9a380fa4fff0932d56e8a0cacadb8d4ebf7d8124e607f2ba389c3b60f875c300a2137fe04aac2b7eda77850b343af5e58c53e310f90460f96223f3228c
-  data.tar.gz: 107e1dbacdc6293a0c044a91cf237f50fbeab59eb5b032167f55d0fe6c2cf07b079c6cfe296368c03d2c84e64ce3c0e6ad744043397cdc217cd3ab51beb3ab09
+  metadata.gz: f27113af8a5771d89ac5c8783f1f69645c24bb576dafd97de17b0d8db8fff74dc396b42450802f9332c9f8b32a02ee18dabbc5dbc2daa91c75f957a678e99099
+  data.tar.gz: 5b2c2f3cbfc17b43c030c4c4c261962818bfbb2ce1a0ecd88f394682b75b75a64a2d8b6afcc0e4b99b97d39ef4b645de143cbb5f595e7aa9d661e66b1a53e98f

data/CHANGELOG.md

@@ -1,6 +1,9 @@
 
 # SmarterCSV 1.x Change Log
 
+## 1.6.1 (2022-05-06)
+  * unused keys in `key_mapping` generate a warning, no longer raise an exception
+
 ## 1.6.0 (2022-05-03)
   * completely rewrote line parser
   * added methods `SmarterCSV.raw_headers` and `SmarterCSV.headers` to allow easy examination of how the headers are processed.

data/lib/smarter_csv/smarter_csv.rb

@@ -62,6 +62,7 @@ module SmarterCSV
         # cater for the quoted csv data containing the row separator carriage return character
         # in which case the row data will be split across multiple lines (see the sample content in spec/fixtures/carriage_returns_rn.csv)
         # by detecting the existence of an uneven number of quote characters
+
         multiline = line.count(options[:quote_char])%2 == 1 # should handle quote_char nil
         while line.count(options[:quote_char])%2 == 1 # should handle quote_char nil
           next_line = fh.readline(options[:row_sep])
@@ -75,7 +76,6 @@ module SmarterCSV
 
         dataA, data_size = parse(line, options, header_size)
 
-        dataA.map!{|x| x.sub(/(#{options[:col_sep]})+\z/, '')} # remove any unwanted trailing col_sep characters at the end
         dataA.map!{|x| x.strip} if options[:strip_whitespace]
 
         # if all values are blank, then ignore this line
@@ -420,7 +420,7 @@ module SmarterCSV
       if ! key_mappingH.nil? && key_mappingH.class == Hash && key_mappingH.keys.size > 0
         # we can't map keys that are not there
         missing_keys = key_mappingH.keys - headerA
-        raise(SmarterCSV::KeyMappingError, "missing header(s): #{missing_keys.join(",")}") unless missing_keys.empty?
+        puts "WARNING: missing header(s): #{missing_keys.join(",")}" unless missing_keys.empty?
 
         headerA.map!{|x| key_mappingH.has_key?(x) ? (key_mappingH[x].nil? ? nil : key_mappingH[x]) : (options[:remove_unmapped_keys] ? nil : x)}
       end

data/lib/smarter_csv/version.rb

@@ -1,3 +1,3 @@
 module SmarterCSV
-  VERSION = "1.6.0"
+  VERSION = "1.6.1"
 end

data/spec/smarter_csv/duplicate_headers_spec.rb

@@ -17,12 +17,12 @@ describe 'duplicate headers' do
       }.to raise_exception(SmarterCSV::DuplicateHeaders)
     end
 
-    it 'raises error on missing mapped headers and includes missing headers in message' do
+    it 'does not raise error on missing mapped headers and includes missing headers in message' do
+      # the mapping is right, but the underlying csv file is bad
+      options = {:key_mapping => {:email => :a, :firstname => :b, :lastname => :c, :manager_email => :d, :age => :e} }
       expect {
-        # the mapping is right, but the underlying csv file is bad
-        options = {:key_mapping => {:email => :a, :firstname => :b, :lastname => :c, :manager_email => :d, :age => :e} }
         SmarterCSV.process("#{fixture_path}/duplicate_headers.csv", options)
-      }.to raise_exception(SmarterCSV::KeyMappingError, "missing header(s): manager_email")
+      }.not_to raise_exception(SmarterCSV::KeyMappingError)
     end
   end
 

data/spec/smarter_csv/invalid_headers_spec.rb

@@ -28,11 +28,11 @@ describe 'test exceptions for invalid headers' do
     }.to raise_exception(SmarterCSV::MissingHeaders)
   end
 
-  it 'raises error on missing mapped headers and includes missing headers in message' do
+  it 'does not raise error on missing mapped headers and includes missing headers in message' do
+    # :age does not exist in the CSV header
+    options = {:key_mapping => {:email => :a, :firstname => :b, :lastname => :c, :manager_email => :d, :age => :e} }
     expect {
-      # :age does not exist in the CSV header
-      options = {:key_mapping => {:email => :a, :firstname => :b, :lastname => :c, :manager_email => :d, :age => :e} }
       SmarterCSV.process("#{fixture_path}/user_import.csv", options)
-    }.to raise_exception(SmarterCSV::KeyMappingError, "missing header(s): age")
+    }.not_to raise_exception(SmarterCSV::KeyMappingError)
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: smarter_csv
 version: !ruby/object:Gem::Version
-  version: 1.6.0
+  version: 1.6.1
 platform: ruby
 authors:
 - Tilo Sloboda
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-05-03 00:00:00.000000000 Z
+date: 2022-05-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec