smarter_csv 1.4.0 → 1.5.1

data/spec/smarter_csv/hard_sample_spec.rb

@@ -0,0 +1,24 @@
+require 'spec_helper'
+
+fixture_path = 'spec/fixtures'
+
+describe 'can handle the difficult CSV file' do
+
+  it 'loads the data with default values' do
+    data = SmarterCSV.process("#{fixture_path}/hard_sample.csv")
+    data.size.should eq 1
+    item = data.first
+    item.keys.count.should == 48
+    item[:name].should == '#MR1220817'
+    item[:shipping_method].should == 'Livraison Standard GRATUITE, 2-5 jours avec suivi'
+    item[:lineitem_name].should == 'Cire Épilation Nacrée'
+    item[:phone].should == 3366012111111
+  end
+
+  # the main problem is the data line starting with a # character, but not being a comment
+  it 'fails to load the CSV file with incorrectly set comment_regexp' do
+    options = {comment_regexp: /\A#/ }
+    data = SmarterCSV.process("#{fixture_path}/hard_sample.csv", options)
+    data.size.should eq 0
+  end
+end

data/spec/smarter_csv/ignore_comments_spec.rb

@@ -1,30 +1,45 @@
-require 'spec_helper'
-
-fixture_path = 'spec/fixtures'
-
-describe 'be_able_to' do
-  it 'ignore comments in CSV files' do
-    options = {}
-    data = SmarterCSV.process("#{fixture_path}/ignore_comments.csv", options)
-
-    data.size.should eq 5
-
-    # all the keys should be symbols
-    data.each{|item| item.keys.each{|x| x.is_a?(Symbol).should be_truthy}}
-    data.each do |h|
-      h.keys.each do |key|
-        [:"not_a_comment#first_name", :last_name, :dogs, :cats, :birds, :fish].should include( key )
-      end
-    end
-  end
-
-  it 'ignore comments in CSV files with CRLF' do
-    options = {row_sep: "\r\n"}
-    data = SmarterCSV.process("#{fixture_path}/ignore_comments2.csv", options)
-
-    # all the keys should be symbols
-    data.size.should eq 1
-    data.first[:h1].should eq 'a'
-    data.first[:h2].should eq "b\r\n#c"
-  end
-end
+require 'spec_helper'
+
+fixture_path = 'spec/fixtures'
+
+describe 'be_able_to' do
+  it 'by default does not ignore comments in CSV files' do
+    options = {}
+    data = SmarterCSV.process("#{fixture_path}/ignore_comments.csv", options)
+
+    data.size.should eq 8
+
+    # all the keys should be symbols
+    data.each{|item| item.keys.each{|x| x.is_a?(Symbol).should be_truthy}}
+    data.each do |h|
+      h.keys.each do |key|
+        [:"not_a_comment#first_name", :last_name, :dogs, :cats, :birds, :fish].should include( key )
+      end
+    end
+  end
+
+  it 'ignore comments in CSV files using comment_regexp' do
+    options = {comment_regexp: /\A#/}
+    data = SmarterCSV.process("#{fixture_path}/ignore_comments.csv", options)
+
+    data.size.should eq 5
+
+    # all the keys should be symbols
+    data.each{|item| item.keys.each{|x| x.is_a?(Symbol).should be_truthy}}
+    data.each do |h|
+      h.keys.each do |key|
+        [:"not_a_comment#first_name", :last_name, :dogs, :cats, :birds, :fish].should include( key )
+      end
+    end
+  end
+
+  it 'ignore comments in CSV files with CRLF' do
+    options = {row_sep: "\r\n"}
+    data = SmarterCSV.process("#{fixture_path}/ignore_comments2.csv", options)
+
+    # all the keys should be symbols
+    data.size.should eq 1
+    data.first[:h1].should eq 'a'
+    data.first[:h2].should eq "b\r\n#c"
+  end
+end

data/spec/smarter_csv/invalid_headers_spec.rb

@@ -3,28 +3,6 @@ require 'spec_helper'
 fixture_path = 'spec/fixtures'
 
 describe 'test exceptions for invalid headers' do
-  it 'raises error on duplicate headers' do
-    expect {
-      SmarterCSV.process("#{fixture_path}/duplicate_headers.csv", {})
-    }.to raise_exception(SmarterCSV::DuplicateHeaders)
-  end
-
-  it 'raises error on duplicate given headers' do
-    expect {
-      options = {:user_provided_headers => [:a,:b,:c,:d,:a]}
-      SmarterCSV.process("#{fixture_path}/duplicate_headers.csv", options)
-    }.to raise_exception(SmarterCSV::DuplicateHeaders)
-  end
-
-  it 'raises error on duplicate mapped headers' do
-    expect {
-      # the mapping is right, but the underlying csv file is bad
-      options = {:key_mapping => {:email => :a, :firstname => :b, :lastname => :c, :manager_email => :d, :age => :e} }
-      SmarterCSV.process("#{fixture_path}/duplicate_headers.csv", options)
-    }.to raise_exception(SmarterCSV::DuplicateHeaders)
-  end
-
-
   it 'does not raise an error if no required headers are given' do
     options = {:required_headers => nil} # order does not matter
     data = SmarterCSV.process("#{fixture_path}/user_import.csv", options)
@@ -49,4 +27,12 @@ describe 'test exceptions for invalid headers' do
       SmarterCSV.process("#{fixture_path}/user_import.csv", options)
     }.to raise_exception(SmarterCSV::MissingHeaders)
   end
+
+  it 'raises error on missing mapped headers' do
+    expect {
+      # :age does not exist in the CSV header
+      options = {:key_mapping => {:email => :a, :firstname => :b, :lastname => :c, :manager_email => :d, :age => :e} }
+      SmarterCSV.process("#{fixture_path}/user_import.csv", options)
+    }.to raise_exception(SmarterCSV::KeyMappingError)
+  end
 end

data/spec/smarter_csv/no_header_spec.rb

@@ -2,23 +2,28 @@ require 'spec_helper'
 
 fixture_path = 'spec/fixtures'
 
-describe 'be_able_to' do
-  it 'loads_csv_file_without_header' do 
-    options = {:headers_in_file => false, :user_provided_headers => [:a,:b,:c,:d,:e,:f]}
-    data = SmarterCSV.process("#{fixture_path}/no_header.csv", options)
+describe 'no header in file' do
+  let(:headers) { [:a,:b,:c,:d,:e,:f] }
+  let(:options) { {:headers_in_file => false, :user_provided_headers => headers} }
+  subject(:data) { SmarterCSV.process("#{fixture_path}/no_header.csv", options) }
+
+  it 'load the correct number of records' do
     data.size.should == 5
-    # all the keys should be symbols
-    data.each{|item| item.keys.each{|x| x.class.should be == Symbol}}
+  end
 
-    data.each do |item| 
+  it 'uses given symbols for all records' do
+    data.each do |item|
       item.keys.each do |key|
         [:a,:b,:c,:d,:e,:f].should include( key )
       end
     end
-
-    data.each do |h|
-      h.size.should <= 6
-    end
   end
 
+  it 'loads the correct data' do
+    data[0].should == {a: "Dan", b: "McAllister", c: 2, d: 0}
+    data[1].should == {a: "Lucy", b: "Laweless", d: 5, e: 0}
+    data[2].should == {a: "Miles", b: "O'Brian", c: 0, d: 0, e: 0, f: 21}
+    data[3].should == {a: "Nancy", b: "Homes", c: 2, d: 0, e: 1}
+    data[4].should == {a: "Hernán", b: "Curaçon", c: 3, d: 0, e: 0}
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: smarter_csv
 version: !ruby/object:Gem::Version
-  version: 1.4.0
+  version: 1.5.1
 platform: ruby
 authors:
 - Tilo Sloboda
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-02-11 00:00:00.000000000 Z
+date: 2022-04-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -24,6 +24,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Ruby Gem for smarter importing of CSV Files as Array(s) of Hashes, with
   optional features for processing large files in parallel, embedded comments, unusual
   field- and record-separators, flexible mapping of CSV-headers to Hash-keys
@@ -38,6 +52,7 @@ files:
 - ".rvmrc"
 - ".travis.yml"
 - CHANGELOG.md
+- CONTRIBUTORS.md
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -47,6 +62,7 @@ files:
 - lib/smarter_csv/smarter_csv.rb
 - lib/smarter_csv/version.rb
 - smarter_csv.gemspec
+- spec/fixtures/additional_separator.csv
 - spec/fixtures/basic.csv
 - spec/fixtures/binary.csv
 - spec/fixtures/carriage_returns_n.csv
@@ -58,6 +74,7 @@ files:
 - spec/fixtures/empty.csv
 - spec/fixtures/empty_columns_1.csv
 - spec/fixtures/empty_columns_2.csv
+- spec/fixtures/hard_sample.csv
 - spec/fixtures/ignore_comments.csv
 - spec/fixtures/ignore_comments2.csv
 - spec/fixtures/key_mapping.csv
@@ -86,6 +103,7 @@ files:
 - spec/fixtures/valid_unicode.csv
 - spec/fixtures/with_dashes.csv
 - spec/fixtures/with_dates.csv
+- spec/smarter_csv/additional_separator_spec.rb
 - spec/smarter_csv/binary_file2_spec.rb
 - spec/smarter_csv/binary_file_spec.rb
 - spec/smarter_csv/blank_spec.rb
@@ -94,8 +112,10 @@ files:
 - spec/smarter_csv/close_file_spec.rb
 - spec/smarter_csv/column_separator_spec.rb
 - spec/smarter_csv/convert_values_to_numeric_spec.rb
+- spec/smarter_csv/duplicate_headers_spec.rb
 - spec/smarter_csv/empty_columns_spec.rb
 - spec/smarter_csv/extenstions_spec.rb
+- spec/smarter_csv/hard_sample_spec.rb
 - spec/smarter_csv/header_transformation_spec.rb
 - spec/smarter_csv/ignore_comments_spec.rb
 - spec/smarter_csv/invalid_headers_spec.rb
@@ -143,12 +163,13 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements:
 - csv
-rubygems_version: 3.1.4
+rubygems_version: 3.1.6
 signing_key:
 specification_version: 4
 summary: Ruby Gem for smarter importing of CSV Files (and CSV-like files), with lots
   of optional features, e.g. chunked processing for huge CSV files
 test_files:
+- spec/fixtures/additional_separator.csv
 - spec/fixtures/basic.csv
 - spec/fixtures/binary.csv
 - spec/fixtures/carriage_returns_n.csv
@@ -160,6 +181,7 @@ test_files:
 - spec/fixtures/empty.csv
 - spec/fixtures/empty_columns_1.csv
 - spec/fixtures/empty_columns_2.csv
+- spec/fixtures/hard_sample.csv
 - spec/fixtures/ignore_comments.csv
 - spec/fixtures/ignore_comments2.csv
 - spec/fixtures/key_mapping.csv
@@ -188,6 +210,7 @@ test_files:
 - spec/fixtures/valid_unicode.csv
 - spec/fixtures/with_dashes.csv
 - spec/fixtures/with_dates.csv
+- spec/smarter_csv/additional_separator_spec.rb
 - spec/smarter_csv/binary_file2_spec.rb
 - spec/smarter_csv/binary_file_spec.rb
 - spec/smarter_csv/blank_spec.rb
@@ -196,8 +219,10 @@ test_files:
 - spec/smarter_csv/close_file_spec.rb
 - spec/smarter_csv/column_separator_spec.rb
 - spec/smarter_csv/convert_values_to_numeric_spec.rb
+- spec/smarter_csv/duplicate_headers_spec.rb
 - spec/smarter_csv/empty_columns_spec.rb
 - spec/smarter_csv/extenstions_spec.rb
+- spec/smarter_csv/hard_sample_spec.rb
 - spec/smarter_csv/header_transformation_spec.rb
 - spec/smarter_csv/ignore_comments_spec.rb
 - spec/smarter_csv/invalid_headers_spec.rb