smarter_csv 1.17.3 → 1.17.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ec50e8539c6872f9c86c25eabc2982e39846ad07dc5a21021fc687c7661f8084
-  data.tar.gz: 977ce04d8dd225b6042ea03ad0c174305f3ea122340fad052e2c2ada440d6400
+  metadata.gz: 140f9359c26f8903b9075faeb59e9c1fc4b5c4b9dd5fcef664e12bb53fe13073
+  data.tar.gz: 0e7be3195610bcddb77870744a24f0eee9431643c4c28fcbea12d4b8663bb2db
 SHA512:
-  metadata.gz: 0452dc7f15ab31b0cdfad83ca718e17e6456cf6c9826d177e606c5924f3ec72a155c86ee6f9f938540fe3b2ed8f694a981c95cf775b5a38d7f7e44318bc453a3
-  data.tar.gz: c1c9732d6d4393fb2ffa995f0c7bb73cd60f566132d487a86007f8a5a623257365c2324ed894a5b38d681df7cfab67069d9fa2e61fd525ba51675954ddadad7a
+  metadata.gz: 176daa024372ade1d6431e5e4fd5355175cd1ebf03e7a216d70b8ff4554eb259a023969783b53118eba6c3fbf747a08e286ed7daad455ebc5cf8d7b61475d3d1
+  data.tar.gz: 8b1ca7263e5a54fc642c8f76bfd56577f6056784910acdcdcd0f18c6222c8793280016e749f2e08a61485bf8255cf341250ac1250a8d3ff424f8b07b1edbd51b

data/CHANGELOG.md

@@ -2,7 +2,15 @@
 # SmarterCSV 1.x Change Log
 
 > [!TIP]
-> **Upgrading?** The [SmarterCSV Upgrade Wizard](https://tilo.github.io/smarter_csv/upgrade_wizard.html) walks you through what (if anything) you need to change for your specific version. Most hops do not require any changes.
+> **Upgrading?** The [SmarterCSV Upgrade Wizard](https://tilo.github.io/smarter_csv/upgrade_wizard.html) walks you through what (if anything) you need to change for your specific version. Most steps do not require any changes.
+
+## 1.17.4 (2026-06-03)
+
+### Bug Fix
+
+  - fixed [Issue #337](https://github.com/tilo/smarter_csv/issues/337): `Pathname` input no longer worked (regression since 1.17.0); passing a `Pathname` raised `NoMethodError: private method 'gets' called`. `SmarterCSV` now opens any path-like input (`String` or `Pathname`) and reads directly from any already-open IO. Thanks to [Alex Shenia](https://github.com/alexshenia)
+
+
 
 ## 1.17.3 (2026-05-26)
 

data/CONTRIBUTORS.md

@@ -1,4 +1,4 @@
-# A Big Thank You to all 64 Contributors!!
+# A Big Thank You to all 65 Contributors!!
 
 
 A Big Thank you to everyone who filed issues, sent comments, and who contributed with pull requests:
@@ -67,3 +67,4 @@ A Big Thank you to everyone who filed issues, sent comments, and who contributed
  * [Paho Lurie-Gregg](https://github.com/paholg)
  * [Jonas Staškevičius](https://github.com/pirminis)
  * [conorg](https://github.com/conorg)
+ * [Alex Shenia](https://github.com/alexshenia)

data/README.md

@@ -4,7 +4,7 @@
 ![Gem Version](https://img.shields.io/gem/v/smarter_csv) [![codecov](https://codecov.io/gh/tilo/smarter_csv/branch/main/graph/badge.svg?token=1L7OD80182)](https://codecov.io/gh/tilo/smarter_csv) [![Downloads](https://img.shields.io/gem/dt/smarter_csv)](https://rubygems.org/gems/smarter_csv) [![RubyGems](https://img.shields.io/badge/RubyGems-smarter__csv-brightgreen?logo=rubygems&logoColor=white)](https://rubygems.org/gems/smarter_csv) [![Ruby Toolbox](https://img.shields.io/badge/Ruby%20Toolbox-smarter__csv-brightgreen)](https://www.ruby-toolbox.com/projects/smarter_csv) [![Upgrade Wizard](https://img.shields.io/badge/Upgrade%20Wizard-Try%20it-2c7a2c?style=flat)](https://tilo.github.io/smarter_csv/upgrade_wizard.html)
 
 > [!TIP]
-> **Upgrading from an older version?** Use the [SmarterCSV Upgrade Wizard](https://tilo.github.io/smarter_csv/upgrade_wizard.html) to walk through what (if anything) you need to change for your specific version. Most hops do not require any changes.
+> **Upgrading from an older version?** Use the [SmarterCSV Upgrade Wizard](https://tilo.github.io/smarter_csv/upgrade_wizard.html) to walk through what (if anything) you need to change for your specific version. Most steps do not require any changes.
         
   SmarterCSV is a high-performance CSV ingestion and generation for Ruby, focused on fast end-to-end CSV ingestion of real-world data — no silent failures, no surprises, not just tokenization.
 
@@ -336,7 +336,7 @@ For reporting issues, please:
   * open a pull-request adding a test that demonstrates the issue
   * mention your version of SmarterCSV, Ruby, Rails
 
-# [A Special Thanks to all 64 Contributors!](CONTRIBUTORS.md) 🎉🎉🎉
+# [A Special Thanks to all 65 Contributors!](CONTRIBUTORS.md) 🎉🎉🎉
 
 
 ## Contributing

data/docs/upgrade_wizard.html

@@ -153,7 +153,7 @@ button.primary:disabled:hover { background: #e6e6e6; }
 <body>
 
 <h1>SmarterCSV Upgrade Wizard</h1>
-<p class="muted">This wizard walks you from your current version to the latest, one hop at a time.<br><br>Only the questions where you answer "Yes" will show migration steps.<br>Question answered with "No" represent risk-free upgrades.</p><br><br>
+<p class="muted">This wizard walks you from your current version to the latest, one step at a time.<br><br>Only the questions where you answer "Yes" will show migration steps.<br>Question answered with "No" represent risk-free upgrades.</p><br><br>
 
 <div id="app"></div>
 
@@ -228,7 +228,7 @@ function renderHop(series, originalVersion) {
   let body;
   if (hop.actions.length === 0) {
     body = `<div class="hop dropin">
-      Drop-in hop: no code changes needed for ${series}.x &rarr; ${targetRelease}. Just continue.
+      You can upgrade directly to version ${targetRelease}. No changes needed.
     </div>`;
   } else {
     body = `<div class="hop">
@@ -246,7 +246,7 @@ function renderHop(series, originalVersion) {
   }
 
   const nextLabel = hop.to === LATEST ? `Finish at ${targetRelease} &rarr;` : `Continue to ${targetRelease} &rarr;`;
-  const reminder = hop.actions.length === 0 ?  `<p class="reminder">You can upgrade directly to the version showing on the "Continue" button. No changes needed.</p>` :
+  const reminder = hop.actions.length === 0 ?  `<p class="reminder">You can upgrade directly to version ${targetRelease}. No changes needed.</p>` :
     `<p class="reminder">If there are actions listed above, please ensure they are fixed before clicking "Continue".</p>`;
   app.innerHTML = `
     <p class="progress">Upgrading from ${series}.x &rarr; ${targetRelease}</p>
@@ -288,7 +288,7 @@ function renderHop(series, originalVersion) {
       } else if (yesAnswers.length === 0) {
         // All answered, all "No" — nothing applies, upgrade is direct.
         reminderEl.style.display = "";
-        reminderEl.textContent = 'You can upgrade directly to the version showing on the "Continue" button. No changes needed.';
+        reminderEl.textContent = `You can upgrade directly to version ${targetRelease}. No changes needed.`;
       } else {
         // All answered, at least one "Yes" — actions must be applied first.
         reminderEl.style.display = "";
@@ -342,17 +342,21 @@ function renderDone(originalVersion) {
   const fullVersion  = LATEST_RELEASE || LATEST;
   const seriesOnly   = LATEST;
   const summaryHTML  = renderSummary();
+  const introHTML    = decisions.length === 0
+    ? `<p><strong>You can upgrade directly to version ${fullVersion}. No changes needed.</strong></p>
+       <p>You're already in the ${seriesOnly}.x series, so the upgrade is just a Gemfile bump.</p>`
+    : `<p>You've completed all the upgrade steps from ${escapeHTML(originalVersion || "your current version")} to ${fullVersion} (the latest version in the ${seriesOnly}.x series).</p>`;
 
   app.innerHTML = `
     <div class="done">
       <h2>You're done</h2>
-      <p>You've walked all hops from ${escapeHTML(originalVersion || "your current version")} to ${fullVersion} (the latest patch in the ${seriesOnly}.x series).</p>
+      ${introHTML}
       ${summaryHTML}
       <p>Update your <code>Gemfile</code> to:</p>
       <pre><code>gem 'smarter_csv', '~&gt; ${seriesOnly}.0'</code></pre>
       <p>Then run:</p>
       <pre><code>bundle update smarter_csv</code></pre>
-      <p>After that, run your test suite. If anything behaves unexpectedly, click "Start over" and walk back through the hops to find the migration step you might have missed.</p>
+      <p>After that, run your test suite. If anything behaves unexpectedly, click "Start over" and walk back through the steps to find the migration item you might have missed.</p>
       <p class="muted">Questions? Open an issue at <a href="https://github.com/tilo/smarter_csv/issues">github.com/tilo/smarter_csv/issues</a>.</p>
       <p><button id="restart">Start over</button></p>
     </div>
@@ -366,17 +370,17 @@ function renderSummary() {
   const matchedCount = decisions.reduce((n, d) => n + d.matched.length, 0);
   const dropInCount  = decisions.filter(d => d.dropIn).length;
   const intro = matchedCount === 0
-    ? `<p>Good news: <strong>none of the per-hop conditions applied to your code</strong> across the ${decisions.length} hops you walked${dropInCount ? ` (${dropInCount} were drop-in hops)` : ""}. The upgrade should be a clean Gemfile bump.</p>`
-    : `<p>Across ${decisions.length} hops you walked, <strong>${matchedCount} migration step${matchedCount === 1 ? "" : "s"} apply</strong> to your code. Review and apply them before running <code>bundle update</code>:</p>`;
+    ? `<p>Good news &mdash; <strong>none of the conditions applied to your code</strong>. The upgrade is just a Gemfile bump.</p>`
+    : `<p>Apply the following <strong>${matchedCount} change${matchedCount === 1 ? "" : "s"}</strong> to your code, then run <code>bundle update</code>:</p>`;
 
   const list = decisions.map(d => {
     const targetRelease = latestReleaseFor(d.to);
     const heading = `<p class="summary-hop-heading"><strong>${d.from}.x &rarr; ${targetRelease}</strong></p>`;
     if (d.dropIn) {
-      return `<div class="summary-hop">${heading}<p class="muted">Drop-in hop &mdash; no code changes needed.</p></div>`;
+      return `<div class="summary-hop">${heading}<p class="muted">No code changes needed for this step.</p></div>`;
     }
     if (d.matched.length === 0) {
-      return `<div class="summary-hop">${heading}<p class="muted">None of the conditions on this hop applied to your code.</p></div>`;
+      return `<div class="summary-hop">${heading}<p class="muted">None of the conditions in this step applied to your code.</p></div>`;
     }
     const items = d.matched.map(a => `<li><strong>If</strong> ${a["if"]}<br>&rarr; ${a.then}</li>`).join("");
     return `<div class="summary-hop">${heading}<ul>${items}</ul></div>`;

data/lib/smarter_csv/reader.rb

@@ -32,13 +32,14 @@ module SmarterCSV
     # rubocop:disable Naming/MethodName
     def headerA
       record_warning(type: :deprecation, code: :header_a_method) do
-        "Deprecarion Warning: 'headerA' will be removed in future versions. Use 'headders'"
+        "Deprecation Warning: 'headerA' will be removed in future versions. Use 'headers'"
       end
       @headerA
     end
     # rubocop:enable Naming/MethodName
 
-    # first parameter: filename or input object which responds to readline method
+    # first parameter: a path (String or Pathname) to open, or an already-open readable IO
+    # (anything responding to #gets — File, StringIO, Tempfile, Zlib::GzipReader, pipes, ...)
     def initialize(input, given_options = {})
       @input = input
       @has_rails = !!defined?(Rails)
@@ -123,7 +124,14 @@ module SmarterCSV
       @verbose = options[:verbose]
 
       begin
-        fh = input.is_a?(String) ? File.open(input, "r:#{options[:file_encoding]}") : input
+        # Decide whether `input` is an already-open, readable stream or a path we must open.
+        # The reader reads lines via #gets (see file_io.rb and PeekableIO), so a public #gets
+        # is exactly what we need: real IOs (File, StringIO, Tempfile, Zlib::GzipReader, pipes,
+        # custom non-seekable streams) expose it, while path-like inputs (String, Pathname) do
+        # not — their only #gets is the private Kernel#gets. 1.17.0 narrowed this to
+        # input.is_a?(String), which sent Pathname down the IO branch and then called its
+        # private Kernel#gets, raising "private method 'gets' called" (issue #337).
+        fh = input.respond_to?(:gets) ? input : File.open(input, "r:#{options[:file_encoding]}")
 
         # Rewindable inputs (File, Tempfile, StringIO, Zlib::GzipReader, ...) use
         # native rewind for auto-detection — no wrapper overhead in the hot loop.
@@ -272,10 +280,14 @@ module SmarterCSV
         start_time  = Process.clock_gettime(Process::CLOCK_MONOTONIC) if on_start || on_complete
 
         if on_start
-          input_meta = if @input.is_a?(String)
-                         { input: @input, file_size: (File.size(@input) rescue nil) }
-                       else
+          # Same path-vs-IO distinction as the File.open above: an already-open IO responds
+          # to #gets and we can't know its on-disk size, so we report its class name. A
+          # path-like input (String, or a Pathname via #to_path) gets its path and file size.
+          input_meta = if @input.respond_to?(:gets)
                          { input: @input.class.name, file_size: nil }
+                       else
+                         path = @input.respond_to?(:to_path) ? @input.to_path : @input
+                         { input: path, file_size: (File.size(path) rescue nil) }
                        end
           on_start.call(input_meta.merge(col_sep: options[:col_sep], row_sep: options[:row_sep]))
         end

data/lib/smarter_csv/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module SmarterCSV
-  VERSION = "1.17.3"
+  VERSION = "1.17.4"
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: smarter_csv
 version: !ruby/object:Gem::Version
-  version: 1.17.3
+  version: 1.17.4
 platform: ruby
 authors:
 - Tilo Sloboda
 bindir: bin
 cert_chain: []
-date: 2026-05-27 00:00:00.000000000 Z
+date: 2026-06-03 00:00:00.000000000 Z
 dependencies: []
 description: |
   SmarterCSV is a high-performance CSV reader and writer for Ruby focused on