smarter_csv 1.0.5 → 1.0.6

data/README.md

@@ -194,12 +194,11 @@ Or install it yourself as:
     $ gem install smarter_csv
 
 
-## Known Bugs
-
- * if :col_sep (e.g. a comma) appears inside a quoted field, smarter_csv <= 1.0.4 incorrectly splits on that :col_sep
+## Changes
 
+#### 1.0.6 (2013-05-19)
 
-## Changes
+ * bugfix : quoted fields are now correctly parsed
 
 #### 1.0.5 (2013-05-08)
 

data/lib/smarter_csv.rb

@@ -1,4 +1,4 @@
+require 'csv'
 require "smarter_csv/version"
 require "extensions/hash.rb"
 require "smarter_csv/smarter_csv.rb"
-

data/lib/smarter_csv/smarter_csv.rb

@@ -22,7 +22,12 @@ module SmarterCSV
         # the first line of a CSV file contains the header .. it might be commented out, so we need to read it anyhow
         header = f.readline.sub(options[:comment_regexp],'').chomp(options[:row_sep])
         header = header.gsub(options[:strip_chars_from_headers], '') if options[:strip_chars_from_headers]
-        file_headerA = header.split(options[:col_sep]).map{|x| x.gsub(%r/options[:quote_char]/,'')}
+        if header =~ %r{#{options[:quote_char]}}
+          file_headerA = CSV.parse( header ).flatten
+        else
+          file_headerA =  header.split(options[:col_sep])
+        end
+        file_headerA.map!{|x| x.gsub(%r/options[:quote_char]/,'') }
         file_headerA.map!{|x| x.strip}  if options[:strip_whitespace]
         file_headerA.map!{|x| x.gsub(/\s+/,'_')}
         file_headerA.map!{|x| x.downcase }   if options[:downcase_header]
@@ -69,7 +74,12 @@ module SmarterCSV
         next  if  line =~ options[:comment_regexp]  # ignore all comment lines if there are any
         line.chomp!    # will use $/ which is set to options[:col_sep]
 
-        dataA = line.split(options[:col_sep])   # ISSUE 4 : BUG : this splits incorrectly if , is inside quoted fields
+        if line =~ %r{#{options[:quote_char]}}
+          dataA = CSV.parse( line ).flatten
+        else
+          dataA =  line.split(options[:col_sep])
+        end
+        dataA.map!{|x| x.gsub(%r/options[:quote_char]/,'') }
         dataA.map!{|x| x.strip}  if options[:strip_whitespace]
         hash = Hash.zip(headerA,dataA)  # from Facets of Ruby library
         # make sure we delete any key/value pairs from the hash, which the user wanted to delete:

data/lib/smarter_csv/version.rb

@@ -1,3 +1,3 @@
 module SmarterCSV
-  VERSION = "1.0.5"
+  VERSION = "1.0.6"
 end

data/smarter_csv.gemspec

@@ -6,12 +6,13 @@ Gem::Specification.new do |gem|
   gem.email         = ["tilo.sloboda@gmail.com\n"]
   gem.description   = %q{Ruby Gem for smarter importing of CSV Files as Array(s) of Hashes, with optional features for processing large files in parallel, embedded comments, unusual field- and record-separators, flexible mapping of CSV-headers to Hash-keys}
   gem.summary       = %q{Ruby Gem for smarter importing of CSV Files (and CSV-like files), with lots of optional features, e.g. chunked processing for huge CSV files}
-  gem.homepage      = ""
+  gem.homepage      = "https://github.com/tilo/smarter_csv"
 
   gem.files         = `git ls-files`.split($\)
   gem.executables   = gem.files.grep(%r{^bin/}).map{ |f| File.basename(f) }
   gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
   gem.name          = "smarter_csv"
   gem.require_paths = ["lib"]
+  gem.requirements  = ['csv'] # for CSV.parse() only needed in case we have quoted fields
   gem.version       = SmarterCSV::VERSION
 end

metadata

@@ -1,31 +1,29 @@
---- !ruby/object:Gem::Specification 
+--- !ruby/object:Gem::Specification
 name: smarter_csv
-version: !ruby/object:Gem::Version 
-  version: 1.0.5
+version: !ruby/object:Gem::Version
+  version: 1.0.6
+  prerelease: 
 platform: ruby
-authors: 
-- |
-  Tilo Sloboda
+authors:
+- ! 'Tilo Sloboda
 
+'
 autorequire: 
 bindir: bin
 cert_chain: []
-
-date: 2013-05-09 00:00:00 Z
+date: 2013-05-20 00:00:00.000000000 Z
 dependencies: []
+description: Ruby Gem for smarter importing of CSV Files as Array(s) of Hashes, with
+  optional features for processing large files in parallel, embedded comments, unusual
+  field- and record-separators, flexible mapping of CSV-headers to Hash-keys
+email:
+- ! 'tilo.sloboda@gmail.com
 
-description: Ruby Gem for smarter importing of CSV Files as Array(s) of Hashes, with optional features for processing large files in parallel, embedded comments, unusual field- and record-separators, flexible mapping of CSV-headers to Hash-keys
-email: 
-- |
-  tilo.sloboda@gmail.com
-
+'
 executables: []
-
 extensions: []
-
 extra_rdoc_files: []
-
-files: 
+files:
 - .gitignore
 - .rvmrc
 - Gemfile
@@ -37,31 +35,30 @@ files:
 - lib/smarter_csv/smarter_csv.rb
 - lib/smarter_csv/version.rb
 - smarter_csv.gemspec
-homepage: ""
+homepage: https://github.com/tilo/smarter_csv
 licenses: []
-
-metadata: {}
-
 post_install_message: 
 rdoc_options: []
-
-require_paths: 
+require_paths:
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement 
-  requirements: 
-  - &id001 
-    - ">="
-    - !ruby/object:Gem::Version 
-      version: "0"
-required_rubygems_version: !ruby/object:Gem::Requirement 
-  requirements: 
-  - *id001
-requirements: []
-
+required_ruby_version: !ruby/object:Gem::Requirement
+  none: false
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
+  none: false
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+requirements:
+- csv
 rubyforge_project: 
-rubygems_version: 2.0.3
+rubygems_version: 1.8.15
 signing_key: 
-specification_version: 4
-summary: Ruby Gem for smarter importing of CSV Files (and CSV-like files), with lots of optional features, e.g. chunked processing for huge CSV files
+specification_version: 3
+summary: Ruby Gem for smarter importing of CSV Files (and CSV-like files), with lots
+  of optional features, e.g. chunked processing for huge CSV files
 test_files: []
-

checksums.yaml

@@ -1,7 +0,0 @@
---- 
-SHA1: 
-  metadata.gz: ed29542688f14930b2c88be160a092ba0e7e0398
-  data.tar.gz: 6ce2d29c27af35540f83a44f7c1af1a1f3da988e
-SHA512: 
-  metadata.gz: a88bbcfc69a77beb3ef9fbcd68d48d17880e57264f4755426d0f44c64d06905ba496de9805f48cb2c83373da2ba0bb893dd71a55556fed61016b6696a4a35d95
-  data.tar.gz: 73de0af3b952a8dc4a32f1c823162f718aeedd5304f553b4690100a245c81d68edda0280e3646e965e5c3d260176a884ea64f6a43adb3c62ae26e4bcef2bbfc7