smartcar 3.2.0 → 3.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: af85a8f04bb5ecfd37182ae539ef60e5ca4e9487edf5db544109417df43d82d0
-  data.tar.gz: 5f2ccac9657e5e5b122b32943fa48845aa0acd5319dccc8836fd6b3cbf063ced
+  metadata.gz: 93454e55a42ab20160c545c9bda459e98c85fe5596519f704ffa001bcef5896f
+  data.tar.gz: 0a8148c0f6678079467ee10d58b8564b2dec7e08127a3e7691e734503fc4128b
 SHA512:
-  metadata.gz: 47abd5b611ddc7089be88614c2b79a4d2c33db498f1254eea55f2ed1426b795752b47b7e08e9ac8825086790313738f16affdf536ebed450963b36fd0d1305e3
-  data.tar.gz: 3ffef0a6f8f06da4c9f70a6798a9f701521831cdc30bbc183e613515b2b9520a492bd2d9e686a5c4cca0421d42def98bc0ccb6c4239cabd1d7b250ba5416f31d
+  metadata.gz: a5fb72f2ee3aab427c7eefd12628947eb3f5e8644f40f898acea27cdc1b6c47d7d1085b936b7661df699a31baa59e162efa7641cce7b18b823796cd6d392bc3b
+  data.tar.gz: dc0ab7c95a537ea9a87c7e8f11ef13de8f8bd752625e0ec0418896de573a05d635837499e2744f53f7881a13c42cf9265e6799727bb68e424c4f57dccdd62370

data/.rubocop.yml

@@ -12,7 +12,7 @@ Naming/AccessorMethodName:
   Enabled: false
 
 # Disabling this until we figure out a better way than using openstruct
-# Currently we use open struct because this gives us an object representing the JSON 
+# Currently we use open struct because this gives us an object representing the JSON
 # with accessor style methods.
 Style/OpenStructUse:
   Enabled: false
@@ -30,3 +30,9 @@ Metrics/MethodLength:
 
 Metrics/ClassLength:
   Max: 200
+
+Metrics/CyclomaticComplexity:
+  Max: 10
+
+Metrics/PerceivedComplexity:
+  Max: 10

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    smartcar (3.2.0)
+    smartcar (3.3.0)
       oauth2 (~> 1.4)
       recursive-open-struct (~> 1.1.3)
 

data/README.md

@@ -101,7 +101,7 @@ Example Usage for calling the reports API with oAuth token
 Example Usage for oAuth -
 ```ruby
 # To get the redirect URL :
-2.5.5 :002 > options = {test_mode: true}
+2.5.5 :002 > options = {mode: 'test'}
 2.5.5 :003 > require 'smartcar'
 2.5.5 :004 > client = Smartcar::AuthClient.new(options)
 2.5.5 :005 > url = client.get_auth_url(["read_battery","read_charge","read_fuel","read_location","control_security","read_odometer","read_tires","read_vin","read_vehicle_info"], {flags: ["country:DE"]})

data/lib/smartcar/auth_client.rb

@@ -14,15 +14,17 @@ module Smartcar
     # @option options[:client_id] [String] - Client ID, if not passed fallsback to ENV['SMARTCAR_CLIENT_ID']
     # @option options[:client_secret] [String] - Client Secret, if not passed fallsback to ENV['SMARTCAR_CLIENT_SECRET']
     # @option options[:redirect_uri] [String] - Redirect URI, if not passed fallsback to ENV['SMARTCAR_REDIRECT_URI']
-    # @option options[:test_mode] [Boolean] - Setting this to 'true' runs it in test mode.
-    #
+    # @option options[:test_mode] [Boolean] - [DEPRECATED], please use `mode` instead.
+    # Launch Smartcar Connect in [test mode](https://smartcar.com/docs/guides/testing/).
+    # @option options[:mode] [String] - Determine what mode Smartcar Connect should be launched in.
+    # Should be one of test, live or simulated.
     # @return [Smartcar::AuthClient] Returns a Smartcar::AuthClient Object that has other methods
     def initialize(options)
       options[:redirect_uri] ||= get_config('SMARTCAR_REDIRECT_URI')
       options[:client_id] ||= get_config('SMARTCAR_CLIENT_ID')
       options[:client_secret] ||= get_config('SMARTCAR_CLIENT_SECRET')
-      options[:mode] = options[:test_mode].is_a?(TrueClass) ? TEST : LIVE
       options[:origin] = ENV['SMARTCAR_AUTH_ORIGIN'] || AUTH_ORIGIN
+      options[:mode] = determine_mode(options[:test_mode], options[:mode]) || 'live'
       super
     end
 

data/lib/smartcar/base.rb

@@ -22,7 +22,7 @@ module Smartcar
       # @param data [Hash] request body if needed.
       #
       # @return [Hash] The response Json parsed as a hash.
-      define_method verb do |path, data = nil, headers = {}|
+      define_method verb do |path, query_params = {}, data = nil, headers = {}|
         response = service.send(verb) do |request|
           request_headers = {}
           request_headers['Authorization'] = auth_type == BASIC ? "Basic #{token}" : "Bearer #{token}"
@@ -32,6 +32,7 @@ module Smartcar
             "Smartcar/#{VERSION} (#{RbConfig::CONFIG['host_os']}; #{RbConfig::CONFIG['arch']}) Ruby v#{RUBY_VERSION}"
           request.headers = request_headers.merge(headers)
           complete_path = "/v#{version}#{path}"
+          complete_path += "?#{URI.encode_www_form(query_params.compact)}" unless query_params.empty?
           if verb == :get
             request.url complete_path, data
           else
@@ -46,17 +47,6 @@ module Smartcar
       end
     end
 
-    # This requires a proc 'PATH' to be defined in the class
-    # @param path [String] resource path
-    # @param query_params [Hash] query params
-    # @param auth [String] type of auth
-    #
-    # @return [Object]
-    def fetch(path:, query_params: {})
-      path += "?#{URI.encode_www_form(query_params)}" unless query_params.empty?
-      get(path)
-    end
-
     private
 
     # gets a smartcar API service/client

data/lib/smartcar/utils.rb

@@ -127,5 +127,25 @@ module Smartcar
 
       path.split('/').reject(&:empty?).join('_').to_sym
     end
+
+    # takes query parameters and returns them as a string
+    # EX - {'country': 'DE', 'flags': true} -> "county:DE flags:true"
+    def stringify_params(query_params)
+      query_params&.map { |key, value| "#{key}:#{value}" }&.join(' ')
+    end
+
+    def determine_mode(test_mode, mode)
+      unless mode.nil?
+        unless %w[test live simulated].include? mode
+          raise 'The "mode" parameter MUST be one of the following: \'test\', \'live\', \'simulated\''
+        end
+
+        return mode
+      end
+      return if test_mode.nil?
+
+      warn '[DEPRECATION] The "test_mode" parameter is deprecated, please use the "mode" parameter instead.'
+      test_mode.is_a?(TrueClass) ? 'test' : 'live'
+    end
   end
 end

data/lib/smartcar/vehicle.rb

@@ -11,6 +11,7 @@ module Smartcar
   # @attr [Hash] options
   # @attr unit_system [String] Unit system to represent the data in, defaults to Imperial
   # @attr version [String] API version to be used.
+  # @attr flags [Hash] Object of flags where key is the name of the flag and value is string or boolean value.
   # @attr service [Faraday::Connection] An optional connection object to be used for requests.
   class Vehicle < Base
     attr_reader :id
@@ -77,6 +78,7 @@ module Smartcar
       @unit_system = options[:unit_system] || METRIC
       @version = options[:version] || Smartcar.get_api_version
       @service = options[:service]
+      @query_params = { flags: stringify_params(options[:flags]) }
 
       raise InvalidParameterValue.new, "Invalid Units provided : #{@unit_system}" unless UNITS.include?(@unit_system)
       raise InvalidParameterValue.new, 'Vehicle ID (id) is a required field' if id.nil?
@@ -177,11 +179,11 @@ module Smartcar
       define_method method do
         body, headers = case item[:type]
                         when :post
-                          post(item[:path].call(id), item[:body])
+                          post(item[:path].call(id), @query_params, item[:body])
                         when :delete
-                          delete(item[:path].call(id))
+                          delete(item[:path].call(id), @query_params)
                         else
-                          fetch(path: item[:path].call(id))
+                          get(item[:path].call(id), @query_params)
                         end
         build_aliases(build_response(body, headers), item[:aliases])
       end
@@ -195,7 +197,7 @@ module Smartcar
     # @return [OpenStruct] And object representing the JSON response mentioned in https://smartcar.com/docs/api#get-application-permissions
     #  and a meta attribute with the relevant items from response headers.
     def permissions(paging = {})
-      response, headers = fetch(path: METHODS.dig(:permissions, :path).call(id), query_params: paging)
+      response, headers = get(METHODS.dig(:permissions, :path).call(id), @query_params.merge(paging))
       build_response(response, headers)
     end
 
@@ -206,7 +208,7 @@ module Smartcar
     # @return [OpenStruct] An object representing the JSON response and a meta attribute
     #   with the relevant items from response headers.
     def subscribe!(webhook_id)
-      response, headers = post(METHODS.dig(:subscribe!, :path).call(id, webhook_id), {})
+      response, headers = post(METHODS.dig(:subscribe!, :path).call(id, webhook_id), @query_params)
       build_aliases(build_response(response, headers), METHODS.dig(:subscribe!, :aliases))
     end
 
@@ -220,7 +222,8 @@ module Smartcar
       # swapping off the token with amt for unsubscribe.
       access_token = token
       self.token = amt
-      response, headers = delete(METHODS.dig(:unsubscribe!, :path).call(id, webhook_id))
+      response, headers = delete(METHODS.dig(:unsubscribe!, :path).call(id, webhook_id),
+                                 @query_params)
       self.token = access_token
       build_response(response, headers)
     end
@@ -233,7 +236,7 @@ module Smartcar
     #  an OpenStruct object of the requested attribute or taises if it is an error.
     def batch(paths)
       request_body = { requests: paths.map { |path| { path: path } } }
-      response, headers = post("/vehicles/#{id}/batch", request_body)
+      response, headers = post("/vehicles/#{id}/batch", @query_params, request_body)
       process_batch_response(response, headers)
     end
 
@@ -249,7 +252,7 @@ module Smartcar
     #   response body and a "meta" attribute with the relevant items from response headers.
     def request(method, path, body = {}, headers = {})
       path = "/vehicles/#{id}/#{path}"
-      raw_response, headers = send(method.downcase, path, body, headers)
+      raw_response, headers = send(method.downcase, path, @query_params, body, headers)
       meta = build_meta(headers)
       json_to_ostruct({ body: raw_response, meta: meta })
     end

data/lib/smartcar/version.rb

@@ -2,5 +2,5 @@
 
 module Smartcar
   # Gem current version number
-  VERSION = '3.2.0'
+  VERSION = '3.3.0'
 end

data/lib/smartcar.rb

@@ -38,6 +38,7 @@ module Smartcar
   @api_version = '2.0'
 
   class << self
+    include Smartcar::Utils
     # Module method Used to set api version to be used.
     # This method can be used at the top to set the version and any
     # following request will use the version set here unless overridden
@@ -67,7 +68,10 @@ module Smartcar
     # @option options [String] :client_secret Client Secret that overrides ENV
     # @option options [String] :version API version to use, defaults to what is globally set
     # @option options [Hash] :flags A hash of flag name string as key and a string or boolean value.
-    # @option options [Boolean] :test_mode Whether to use test mode or not.
+    # @option options[Boolean] :test_mode [DEPRECATED], please use `mode` instead.
+    # Launch Smartcar Connect in test mode(https://smartcar.com/docs/guides/testing/).
+    # @option options [String] :mode Determine what mode Smartcar Connect should be launched in.
+    # Should be one of test, live or simulated.
     # @option options [String] :test_mode_compatibility_level this is required argument while using
     # test mode with a real vin. For more information refer to docs.
     # @option options [Faraday::Connection] :service Optional connection object to be used for requests
@@ -88,9 +92,9 @@ module Smartcar
 
       base_object.token = generate_basic_auth(options, base_object)
 
-      base_object.build_response(*base_object.fetch(
-        path: PATHS[:compatibility],
-        query_params: build_compatibility_params(vin, scope, country, options)
+      base_object.build_response(*base_object.get(
+        PATHS[:compatibility],
+        build_compatibility_params(vin, scope, country, options)
       ))
     end
 
@@ -112,7 +116,7 @@ module Smartcar
           service: options[:service]
         }
       )
-      base_object.build_response(*base_object.fetch(path: PATHS[:user]))
+      base_object.build_response(*base_object.get(PATHS[:user]))
     end
 
     # Module method Returns a paged list of all vehicles connected to the application for the current authorized user.
@@ -134,9 +138,9 @@ module Smartcar
           service: options[:service]
         }
       )
-      base_object.build_response(*base_object.fetch(
-        path: PATHS[:vehicles],
-        query_params: paging
+      base_object.build_response(*base_object.get(
+        PATHS[:vehicles],
+        paging
       ))
     end
 
@@ -169,15 +173,15 @@ module Smartcar
         scope: scope.join(' '),
         country: country
       }
-      query_params[:flags] = options[:flags].map { |key, value| "#{key}:#{value}" }.join(' ') if options[:flags]
-      query_params[:mode] = options[:test_mode].is_a?(TrueClass) ? 'test' : 'live' unless options[:test_mode].nil?
+      query_params[:flags] = stringify_params(options[:flags])
 
-      if options[:test_mode_compatibility_level]
-        query_params[:test_mode_compatibility_level] =
-          options[:test_mode_compatibility_level]
-        query_params[:mode] = 'test'
-      end
+      mode = determine_mode(options[:test_mode], options[:mode])
 
+      unless options[:test_mode_compatibility_level].nil?
+        query_params[:test_mode_compatibility_level] = options[:test_mode_compatibility_level]
+        mode = 'test'
+      end
+      query_params[:mode] = mode unless mode.nil?
       query_params
     end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: smartcar
 version: !ruby/object:Gem::Version
-  version: 3.2.0
+  version: 3.3.0
 platform: ruby
 authors:
 - Ashwin Subramanian
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2022-05-03 00:00:00.000000000 Z
+date: 2022-08-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler