smartcar 1.0.0 → 1.0.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9d9a7ac2f2c91af854e62d5c52e799ac7948e2904a4997341847fd8845ffade3
-  data.tar.gz: 23557ce0dbd44d4df30eae96c1ad12557ebd4514e839e3ff59e16cbc120102e4
+  metadata.gz: 20f8c410ca2e09b81f481f66f8790b9040688dec92973825d7a7ba72cec14a7d
+  data.tar.gz: 5c748df1b3c987a00df29e1f7f65ae8c89c76ad7473acfc8135c27ddad94fe15
 SHA512:
-  metadata.gz: 4592facfcef32121f865d424bf57ac42e9954150d652f1b1183bea553df60f1d5e569e4bc2933cc5e188b26655f65fd1395e457ebad440a2bc5488d3b1a629d3
-  data.tar.gz: 0ca054815ce5849735181bf513ff52bd8df81bc2732e185281b2257dd6ec0a879222187f95cfea410e7113406ff62fda4a87835f05a2991f46931df1cc4bcd65
+  metadata.gz: 4bdbd39d8887437f76f53ccea2cdc8f6ae618d5a13558713c44b74ca21ab01fbe960b8d8b66104ace8df1a4c3de2d8a2308e3fe6ec000c9a80b721abda0fca09
+  data.tar.gz: 71f27cea632e1578e878f9bb6c7caa921890236515facc7435f6b17aa2faa1c198c8e7bfd4064fd90ec37ee2533d31aae362b1f0c13ce867b43380d3add3fcbc

data/.travis.yml

@@ -1,7 +1,29 @@
----
 sudo: false
 language: ruby
 cache: bundler
+services:
+- xvfb
+addons:
+  firefox: latest
 rvm:
-  - 2.5.5
-before_install: gem install bundler -v 2.0.2
+- 2.5
+- 2.6
+- 2.7
+before_install:
+  - gem install bundler -v 2.1.2
+  - wget https://github.com/mozilla/geckodriver/releases/download/v0.26.0/geckodriver-v0.26.0-linux64.tar.gz
+  - mkdir geckodriver
+  - tar -xzf geckodriver-v0.26.0-linux64.tar.gz -C geckodriver
+  - export PATH=$PATH:$PWD/geckodriver
+# install:
+# - firefox -headless &
+deploy:
+  provider: rubygems
+  api_key: $RUBYGEMSAPI_KEY
+  gem: smartcar
+  gemspec: ruby-sdk.gemspec
+  on:
+    tags: true
+    branch: master
+    rvm: 2.5
+  skip_cleanup: 'true'

data/CODE_OF_CONDUCT.md

@@ -55,7 +55,7 @@ further defined and clarified by project maintainers.
 ## Enforcement
 
 Instances of abusive, harassing, or otherwise unacceptable behavior may be
-reported by contacting the project team at Ashwin.Subramanian@ooma.com. All
+reported by contacting the project team at support@smartcar.com. All
 complaints will be reviewed and investigated and will result in a response that
 is deemed necessary and appropriate to the circumstances. The project team is
 obligated to maintain confidentiality with regard to the reporter of an incident.

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    smartcar (1.0.0)
+    smartcar (1.0.7)
       oauth2 (~> 1.4)
 
 GEM
@@ -12,8 +12,8 @@ GEM
     diff-lcs (1.3)
     faraday (1.0.1)
       multipart-post (>= 1.2, < 3)
-    jwt (2.2.1)
-    multi_json (1.14.1)
+    jwt (2.2.2)
+    multi_json (1.15.0)
     multi_xml (0.6.0)
     multipart-post (2.1.1)
     oauth2 (1.4.4)
@@ -22,7 +22,7 @@ GEM
       multi_json (~> 1.3)
       multi_xml (~> 0.5)
       rack (>= 1.2, < 3)
-    rack (2.2.2)
+    rack (2.2.3)
     rake (12.3.3)
     redcarpet (3.5.0)
     rspec (3.9.0)
@@ -50,7 +50,7 @@ DEPENDENCIES
   bundler (~> 2.0)
   byebug (~> 11.0)
   rake (~> 12.3, >= 12.3.3)
-  redcarpet
+  redcarpet (~> 3.5.0)
   rspec (~> 3.0)
   selenium-webdriver (~> 3.142)
   smartcar!

data/README.md

@@ -107,10 +107,10 @@ Smartcar::ExternalServiceError (API error - {"error":"vehicle_state_error","mess
 Example Usage for oAuth -
 ```ruby
 # To get the redirect URL :
-2.5.5 :002 > options = {test_mode: true,scope: ["read_battery","read_charge","read_fuel","read_location","control_security","read_odometer","read_tires","read_vin","read_vehicle_info"]}
+2.5.5 :002 > options = {test_mode: true,scope: ["read_battery","read_charge","read_fuel","read_location","control_security","read_odometer","read_tires","read_vin","read_vehicle_info"],flags: ["country:DE"]}
 2.5.5 :003 > require 'smartcar'
 2.5.5 :004 > url = Smartcar::Oauth.authorization_url(options)
- => "https://connect.smartcar.com/oauth/authorize?approval_prompt=auto&client_id=2715c6b2-eba8-4fda-85b1-8d849733a344&mode=test&redirect_uri=http%3A%2F%2Flocalhost%3A8000%2Fcallback&response_type=code&scope=read_battery+read_charge+read_fuel+read_location+control_security+read_odometer+read_tires+read_vin+read_vehicle_info"
+ => "https://connect.smartcar.com/oauth/authorize?approval_prompt=auto&client_id=2715c6b2-eba8-4fda-85b1-8d849733a344&mode=test&redirect_uri=http%3A%2F%2Flocalhost%3A8000%2Fcallback&response_type=code&scope=read_battery+read_charge+read_fuel+read_location+control_security+read_odometer+read_tires+read_vin+read_vehicle_info&flags=country%3ADE"
 # Redirect user to the above URL.
 # After authentication user control reaches the callback URL with code.
 # Use the code from the parameters and request a token
@@ -123,7 +123,32 @@ Example Usage for oAuth -
 
 ## Development
 
-To install this gem onto your local machine, run `bundle exec rake install`. To release a new version, update the version number in `version.rb`, and then run `bundle exec rake release`, which will create a git tag for the version, push git commits and tags, and push the `.gem` file to [rubygems.org](https://rubygems.org).
+To install this gem onto your local machine, run `bundle exec rake install`.
+
+To run tests, make sure you have the env variables setup for client id and secret.
+```shell
+export INTEGRATION_CLIENT_ID=<client id>
+export INTEGRATION_CLIENT_SECRET=<client secret>
+```
+
+Tests can be run using either default rake command OR specific rspec command.
+```ruby
+bundle exec rake spec
+```
+
+Releasing to rubygems right now cannot be automated because of MFA ([source](https://github.com/rubygems/rubygems/issues/3092)). For now the process is to run the gem build and push commands locally and manually enter in the Rubygems MFA code (available on 1password). Steps for that would be :
+
+```
+# After merging to master, checkout to master and pull code locally, then run the following
+gem build
+  Successfully built RubyGem
+  Name: smartcar
+  Version: <version>
+  File: smartcar-<version>.gem
+# now push the gem built by the build command. This would ask for the MFA code
+gem push smartcar-<version>.gem
+```
+In general it is a good advice to create a tag for every release. If not for the above mentioned MFA bug, creating a tag for a commit on master and pushing the tag would trigger travis to deploy to rubygems automatically.
 
 ## Contributing
 

data/lib/smartcar.rb

@@ -11,6 +11,7 @@ require "smartcar/location"
 require "smartcar/odometer"
 require "smartcar/tire_pressure"
 require "smartcar/vin"
+require "smartcar/vehicle_attributes"
 require "smartcar/vehicle"
 require "smartcar/user"
 

data/lib/smartcar/base.rb

@@ -12,6 +12,8 @@ module Smartcar
     BEARER = 'BEARER'.freeze
     # Constant for Basic auth type
     BASIC = 'BASIC'.freeze
+    # Number of seconds to wait for response
+    REQUEST_TIMEOUT = 310
 
     attr_accessor :token, :error, :meta
 
@@ -66,7 +68,7 @@ module Smartcar
     #
     # @return [OAuth2::AccessToken] An initialized AccessToken instance that acts as service client
     def service
-      @service ||= Faraday.new(url: SITE)
+      @service ||= Faraday.new(url: SITE, request: { timeout: REQUEST_TIMEOUT })
     end
   end
 end

data/lib/smartcar/oauth.rb

@@ -1,83 +1,95 @@
 module Smartcar
-  # Oauth class to take care of the Oauth 2.0 with genomelink APIs
+  # Oauth class to take care of the Oauth 2.0 with Smartcar APIs
   #
   class Oauth < Base
     extend Utils
-    class << self
-      # Generate the OAuth authorization URL.
-      #
-      # By default users are not shown the permission dialog if they have already
-      # approved the set of scopes for this application. The application can elect
-      # to always display the permissions dialog to the user by setting
-      # approval_prompt to `force`.
-      #
-      # @param options [Hash]
-      # @option options[:state] [String] - OAuth state parameter passed to the
-      # redirect uri. This parameter may be used for identifying the user who
-      # initiated the request.
-      # @option options[:test_mode] [Boolean] - Setting this to 'true' runs it in test mode.
-      # @option options[:force_prompt] [Boolean] - Setting `force_prompt` to
-      # `true` will show the permissions approval screen on every authentication
-      # attempt, even if the user has previously consented to the exact scope of
-      # permissions.
-      # @option options[:make] [String] - `make' is an optional parameter that allows
-      # users to bypass the car brand selection screen.
-      # For a complete list of supported makes, please see our
-      # [API Reference](https://smartcar.com/docs/api#authorization) documentation.
-      # @option options[:scope] [Array of Strings] - array of scopes that specify what the user can access
-      #   EXAMPLE : ['read_odometer', 'read_vehicle_info', 'required:read_location']
-      # For further details refer to https://smartcar.com/docs/guides/scope/
-      #
-      # @return [String] URL where user needs to be redirected for authorization
-      def authorization_url(options)
-        parameters = {
-          redirect_uri: get_config('REDIRECT_URI'),
-          approval_prompt: options[:force_prompt] ? FORCE : AUTO,
-          mode: options[:test_mode] ? TEST : LIVE,
-          response_type: CODE
-        }
-        parameters[:scope] = options[:scope].join(' ') if options[:scope]
-        %I(state make).each do |parameter|
-          parameters[:parameter] = options[:parameter] unless options[:parameter].nil?
-        end
+    # By default users are not shown the permission dialog if they have already
+    # approved the set of scopes for this application. The application can elect
+    # to always display the permissions dialog to the user by setting
+    # approval_prompt to `force`.
+    #
+    # @param options [Hash]
+    # @option options[:client_id] [String] - Client ID, if not passed fallsback to ENV['CLIENT_ID']
+    # @option options[:client_secret] [String] - Client Secret, if not passed fallsback to ENV['CLIENT_SECRET']
+    # @option options[:redirect_uri] [String] - Redirect URI, if not passed fallsback to ENV['REDIRECT_URI']
+    # @option options[:state] [String] - OAuth state parameter passed to the
+    # redirect uri. This parameter may be used for identifying the user who
+    # initiated the request.
+    # @option options[:test_mode] [Boolean] - Setting this to 'true' runs it in test mode.
+    # @option options[:force_prompt] [Boolean] - Setting `force_prompt` to
+    # `true` will show the permissions approval screen on every authentication
+    # attempt, even if the user has previously consented to the exact scope of
+    # permissions.
+    # @option options[:make] [String] - `make' is an optional parameter that allows
+    # users to bypass the car brand selection screen.
+    # For a complete list of supported makes, please see our
+    # [API Reference](https://smartcar.com/docs/api#authorization) documentation.
+    # @option options[:scope] [Array of Strings] - array of scopes that specify what the user can access
+    #   EXAMPLE : ['read_odometer', 'read_vehicle_info', 'required:read_location']
+    # For further details refer to https://smartcar.com/docs/guides/scope/
+    # @option options[:flags] [Array of Strings] - an optional array of early access features to enable.
+    #
+    # @return [Smartcar::Oauth] Returns a Smartcar::Oauth Object that has other methods
+    def initialize(options)
+      @redirect_uri = options[:redirect_uri] || get_config('REDIRECT_URI')
+      @client_id = options[:client_id] || get_config('CLIENT_ID')
+      @client_secret = options[:client_secret] || get_config('CLIENT_SECRET')
 
-        client.auth_code.authorize_url(parameters)
+      @auth_parameters = {
+        redirect_uri: @redirect_uri,
+        approval_prompt: options[:force_prompt] ? FORCE : AUTO,
+        mode: options[:test_mode] ? TEST : LIVE,
+        response_type: CODE
+      }
+      
+      %I(scope flags).each do |parameter|
+        @auth_parameters[parameter] = options[parameter].join(' ') unless options[parameter].nil?
       end
-
-      # [get_token description]
-      # @param auth_code [String] This is the code that is returned after use r
-      # visits and authorizes on the authorization URL.
-      #
-      # @return [Hash] Hash of token, refresh token, expiry info and token type
-      def get_token(auth_code)
-        client.auth_code
-          .get_token(
-            auth_code,
-            redirect_uri: get_config('REDIRECT_URI')
-          ).to_hash
+      %I(state make).each do |parameter|
+        @auth_parameters[parameter] = options[parameter] unless options[parameter].nil?
       end
+    end
 
-      # [refresh_token description]
-      # @param token_hash [Hash] This is the hash that is returned with the
-      # get_token method
-      #
-      # @return [Hash] Hash of token, refresh token, expiry info and token type
-      def refresh_token(token_hash)
-        token_object = OAuth2::AccessToken.from_hash(client, token_hash)
-        token_object = token_object.refresh!
-        token_object.to_hash
-      end
+    # Generate the OAuth authorization URL.
+    #
+    # @return [String] Authorization URL string
+    def authorization_url
+      client.auth_code.authorize_url(@auth_parameters)
+    end
 
-      private
-      # gets the Oauth Client object
-      #
-      # @return [OAuth2::Client] A Oauth Client object.
-      def client
-        @client ||= OAuth2::Client.new( get_config('CLIENT_ID'),
-          get_config('CLIENT_SECRET'),
-          :site => OAUTH_PATH
-        )
-      end
+    # Generates the tokens hash using the code returned in oauth process.
+    # @param auth_code [String] This is the code that is returned after user
+    # visits and authorizes on the authorization URL.
+    #
+    # @return [Hash] Hash of token, refresh token, expiry info and token type
+    def get_token(auth_code)
+      client.auth_code
+        .get_token(
+          auth_code,
+          redirect_uri: @redirect_uri
+        ).to_hash
+    end
+
+    # Refreshing the access token
+    # @param token_hash [Hash] This is the hash that is returned with the
+    # get_token method
+    #
+    # @return [Hash] Hash of token, refresh token, expiry info and token type
+    def refresh_token(token_hash)
+      token_object = OAuth2::AccessToken.from_hash(client, token_hash)
+      token_object = token_object.refresh!
+      token_object.to_hash
+    end
+
+    private
+    # gets the Oauth Client object
+    #
+    # @return [OAuth2::Client] A Oauth Client object.
+    def client
+      @client ||= OAuth2::Client.new( @client_id,
+        @client_secret,
+        :site => OAUTH_PATH
+      )
     end
   end
 end

data/lib/smartcar/vehicle.rb

@@ -47,16 +47,20 @@ module Smartcar
     # API - https://smartcar.com/docs/api#connect-compatibility
     # @param vin [String] VIN of the vehicle to be checked
     # @param scope [Array of Strings] - array of scopes
+    # @param country [String] An optional country code according to
+    # [ISO 3166-1 alpha-2](https://en.wikipedia.org/wiki/ISO_3166-1_alpha-2).
+    # Defaults to US.
     #
     # @return [Boolean] true or false
-    def self.compatible?(vin:, scope:)
+    def self.compatible?(vin:, scope:, country: 'US')
       raise InvalidParameterValue.new, "vin is a required field" if vin.nil?
       raise InvalidParameterValue.new, "scope is a required field" if scope.nil?
 
       response, meta = new(token: 'none', id: 'none').fetch(path: COMPATIBLITY_PATH,
         options: {
           vin: vin,
-          scope: scope.join(' ')
+          scope: scope.join(' '),
+          country: country
         },
         auth: BASIC
       )

data/lib/smartcar/version.rb

@@ -1,4 +1,4 @@
 module Smartcar
   # Gem current version number
-  VERSION = "1.0.0"
+  VERSION = "1.0.7"
 end

data/ruby-sdk.gemspec

@@ -12,6 +12,10 @@ Gem::Specification.new do |spec|
   spec.summary = %q{Ruby Gem to access smartcar APIs (https://smartcar.com/docs/)}
   spec.description = %q{This is a ruby gem to access the smartcar APIs. It includes the API classes and the OAuth system.}
   spec.license = "MIT"
+  spec.metadata    = {
+    "source_code_uri" => "https://github.com/smartcar/ruby-sdk",
+    "documentation_uri" => "https://www.rubydoc.info/gems/smartcar",
+  }
   spec.files = Dir.chdir(File.expand_path('..', __FILE__)) do
     `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: smartcar
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.7
 platform: ruby
 authors:
 - Ashwin Subramanian
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-06-12 00:00:00.000000000 Z
+date: 2020-10-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -155,7 +155,9 @@ files:
 homepage: https://rubygems.org/gems/smartcar
 licenses:
 - MIT
-metadata: {}
+metadata:
+  source_code_uri: https://github.com/smartcar/ruby-sdk
+  documentation_uri: https://www.rubydoc.info/gems/smartcar
 post_install_message: 
 rdoc_options: []
 require_paths:
@@ -171,7 +173,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.6
+rubygems_version: 3.0.8
 signing_key: 
 specification_version: 4
 summary: Ruby Gem to access smartcar APIs (https://smartcar.com/docs/)