smart_proxy_shellhooks 0.9.2 → 0.9.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7b2c88465e5cf570a7ac3caef625e845080138ac6ec5620a8022cd8f4313e054
-  data.tar.gz: 266f82a068b1036ca4bb2ceaf1c5224069992b0c0a98af78ae632a76b4774e5c
+  metadata.gz: 1e061eb911543192bd2bbe883ec1cd187c6fa4959caad88fed0b262e9eff07fb
+  data.tar.gz: f8ceeacfd512558776ae6b8f5599e8e3142e4484970dfafef67ce788ddf3fac8
 SHA512:
-  metadata.gz: 9db0fdd198401f0251d49b084f31c389e410fe21b2eccc4a8c16a106358c14993b66437b241836e7e5f08f7e1b8ab1a69b7635136f7906b336e08cd50d77054e
-  data.tar.gz: 635a2716f4d2ec5c5eaa21989a1560c61704b8d9a45f1362438adb3aca030fcb54c3e5dea82aa585a1f8f12148ec6f7e0f71e90db2554549abebfa44be3812a1
+  metadata.gz: 79088ea74e01d619f1841345f0da3e0decddcd570a2b2458902be94a6a03c520c2868240908bf7a38d6284a0598a1ba62e7e3ff3b8574628204af3511be04a6c
+  data.tar.gz: 800ebeef19985c96fd2101328a2f1953090baedf9397d74922ba65fc3239ef069a6971949c547147cfe87b878121e94ad4dcfea002f8e3d7ec408dabd2a3aa9c

data/README.md

@@ -1,16 +1,16 @@
 # Smart Proxy Shell Hooks
 
-Provides an endpoint for foreman_webhooks plugin executing binaries (shell scripts, python scripts, anything). Remember CGI? :-)
+Provides an endpoint for foreman_webhooks plugin executing binaries (shell scripts, python scripts, anything).
 
 ## Installation
 
-Install the plugin using the foreman-installer. Never enable this service via HTTP endpoint, only HTTPS with authentication using client certificate should be used.
+Install the plugin using the foreman-installer. Never enable this service via HTTP endpoint, only HTTPS with authentication using client certificate and with trusted hosts should be used.
 
-Open up `/var/lib/foreman/shellhooks` to see some examples, these are harmless stubs that does nothing.
+Open up `/var/lib/foreman-proxy/shellhooks` to see some examples, these are harmless stubs that do nothing as a starting point.
 
 ## Writing scripts
 
-Script must be placed in `/var/lib/foreman/shellhooks` having a name consisting of alphanums, dash or underscore. The file must be executable. To see list of availble and valid scripts matching the requirements, perform:
+Script must be placed in `/var/lib/foreman-proxy/shellhooks` having a name consisting of alphanums, dash or underscore. The file must be executable. To see list of availble and valid scripts matching the requirements, perform:
 
     $ curl -s https://localhost:9090/shellhook/ | jq
     {
@@ -34,7 +34,7 @@ To execute an example script which prints input back to output (smart-proxy log)
 
 To find out if the script was executed, open up smart-proxy log:
 
-    2020-08-27T12:23:37 eabe1a74 [I] Started POST /shellhook/print_body 
+    2020-08-27T12:23:37 eabe1a74 [I] Started POST /shellhook/print_body
     2020-08-27T12:23:37 eabe1a74 [D] Headers: {"HTTP_HOST"=>"localhost:9090", "HTTP_USER_AGENT"=>"curl/7.69.1", "HTTP_ACCEPT"=>"*/*", "HTTP_VERSION"=>"HTTP/1.1"}
     2020-08-27T12:23:37 eabe1a74 [D] Body: This is a test
     2020-08-27T12:23:37 eabe1a74 [I] Finished POST /shellhook/print_body with 200 (0.68 ms)
@@ -66,5 +66,5 @@ This can be useful for passing database ID or other simple fields so standard JS
 * The return (exit) value is only logged into the smart-proxy logger.
 * Optionally HTTP headers X-Shellhook-Arg-1 to N are passed as arguments.
 * HTTP return code is 200 when script was executed (not output) or non-200 when the plugin failed (not script).
-* Keep in mind all the input is usafe, clean every individual data element or argument to prevent security vulnerability.
+* Keep in mind all the input is unsafe, clean every individual data element or argument to prevent security vulnerability.
 * Example templates are shipped with foreman_webhooks plugin and few scripts with this plugin.

data/examples/print_args

@@ -1,5 +1,5 @@
 #!/bin/sh
 #
-# Prints all arguments
+# Prints all arguments to stderr
 #
-echo "$@"
+echo "$@" >&2

data/lib/smart_proxy_shellhooks/shellhooks.rb

@@ -6,7 +6,6 @@ module Proxy::ShellHooks
 
     default_settings :directory => '/var/lib/foreman/shellhooks'
 
-    http_rackup_path File.expand_path('shellhooks_http_config.ru', File.expand_path('../', __FILE__))
-    https_rackup_path File.expand_path('shellhooks_http_config.ru', File.expand_path('../', __FILE__))
+    rackup_path File.expand_path('shellhooks_http_config.ru', __dir__)
   end
 end

data/lib/smart_proxy_shellhooks/version.rb

@@ -1,5 +1,5 @@
 module Proxy
   module ShellHooks
-    VERSION = '0.9.2'
+    VERSION = '0.9.3'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: smart_proxy_shellhooks
 version: !ruby/object:Gem::Version
-  version: 0.9.2
+  version: 0.9.3
 platform: ruby
 authors:
 - Lukas Zapletal
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-03-16 00:00:00.000000000 Z
+date: 2024-05-15 00:00:00.000000000 Z
 dependencies: []
 description: Provides easy integration with 3rd parties for Foreman
 email: lzap+spam@redhat.com
@@ -50,7 +50,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.4
+rubygems_version: 3.5.9
 signing_key:
 specification_version: 4
 summary: Run shell scripts via Foreman webhooks