smart_proxy_remote_execution_ssh 0.10.2 → 0.10.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e155b0459ac25c633c9c38de0d288b22779f5ea7f6d82146e5505b83cfd7e12e
-  data.tar.gz: 700810a05b8fac1b57ebcc4ca52c5c2de45575dac1b81fe9b84f5c066c6f1dad
+  metadata.gz: 243be2829c2dded953adf5e312e936d3ec6d6ef19ce3474d4f174fd5bd8d89f2
+  data.tar.gz: fb9b33c7dabf90b89921cfbee5bfe6e94b130cc224b7889941171de01c087860
 SHA512:
-  metadata.gz: 11d92de711f06ee33deabf98442e5eb998a24cbd78f8b548a977cd2189a19e7ee998106d8935dbbfe7f1d7b74cc0fc7eb924430fb6f6a98b9565bcde09f917fd
-  data.tar.gz: f23cce7baef47c6651c1ef894b7f39d27b6b043153ed04e388940bab4898633689acd5aa66587be5f01651037d754357c8dd79f162e3d8a72a3430d6f7294efd
+  metadata.gz: 97d3dd475293be10577c24ecf99679bf8e1d68712246d547f791f995e1b9c93661580343aaf10a45a7b62a479be34e2602ad817b20258b29cf48de7ac049ef12
+  data.tar.gz: 5deb80acfeecb4185acd0ec5eca8cf190e05fc01883f7a7a5dac25b0b2be26135f8b7a8905ad55f4ed80d8aa58835d41eded4b313d121d1c53d419450d7d7175

data/lib/smart_proxy_remote_execution_ssh/multiplexed_ssh_connection.rb

@@ -22,10 +22,12 @@ module Proxy::RemoteExecution::Ssh::Runners
 
   class AuthenticationMethod
     attr_reader :name
+    attr_accessor :errors
     def initialize(name, prompt: nil, password: nil)
       @name = name
       @prompt = prompt
       @password = password
+      @errors = nil
     end
 
     def ssh_command_prefix
@@ -67,12 +69,18 @@ module Proxy::RemoteExecution::Ssh::Runners
     def establish!
       @available_auth_methods ||= available_authentication_methods
       method = @available_auth_methods.find do |method|
-        if try_auth_method(method)
+        pm = try_auth_method(method)
+        method.errors = pm.stderr
+        if pm.status.zero?
           @available_auth_methods.unshift(method).uniq!
           true
         end
       end
-      method || raise("Could not establish connection to remote host using any available authentication method, tried #{@available_auth_methods.map(&:name).join(', ')}")
+      return method if method
+
+      msg = "Could not establish connection to remote host using any available authentication method, tried #{@available_auth_methods.map(&:name).join(', ')}"
+      method_errors = @available_auth_methods.map { |method| "Authentication method '#{method.name}' failed with:\n#{method.errors}" }.join("\n")
+      raise "#{msg}\n\n#{method_errors}"
     end
 
     def disconnect!
@@ -119,11 +127,10 @@ module Proxy::RemoteExecution::Ssh::Runners
       if pm.status.zero?
         logger.debug("Established connection using authentication method #{method.name}")
         @socket = socket_file
-        true
       else
         logger.debug("Failed to establish connection using authentication method #{method.name}")
-        false
       end
+      pm
     end
 
     def settings
@@ -148,7 +155,7 @@ module Proxy::RemoteExecution::Ssh::Runners
       ssh_options << "-o Port=#{@ssh_port}" if @ssh_port
       ssh_options << "-o IdentityFile=#{@client_private_key_file}" if @client_private_key_file
       ssh_options << "-o IdentitiesOnly=yes"
-      ssh_options << "-o StrictHostKeyChecking=no"
+      ssh_options << "-o StrictHostKeyChecking=accept-new"
       ssh_options << "-o UserKnownHostsFile=#{prepare_known_hosts}" if @host_public_key
       ssh_options << "-o LogLevel=#{ssh_log_level(true)}"
       ssh_options << "-o ControlMaster=auto"

data/lib/smart_proxy_remote_execution_ssh/runners/script_runner.rb

@@ -161,17 +161,19 @@ module Proxy::RemoteExecution::Ssh::Runners
     end
 
     def preflight_checks
-      ensure_remote_command(cp_script_to_remote("#!/bin/sh\nexec true", 'test'),
+      script = cp_script_to_remote("#!/bin/sh\nexec true")
+      ensure_remote_command(script,
         error: 'Failed to execute script on remote machine, exit code: %{exit_code}.'
       )
       unless @user_method.is_a? NoopUserMethod
-        path = cp_script_to_remote("#!/bin/sh\nexec #{@user_method.cli_command_prefix} true", 'effective-user-test')
-        ensure_remote_command(path,
+        ensure_remote_command("#{@user_method.cli_command_prefix} #{script}",
                               error: 'Failed to change to effective user, exit code: %{exit_code}',
                               tty: true,
                               user_method: @user_method,
                               close_stdin: false)
       end
+      # The path should already be escaped
+      ensure_remote_command("rm #{script}")
     end
 
     def prepare_start

data/lib/smart_proxy_remote_execution_ssh/version.rb

@@ -1,7 +1,7 @@
 module Proxy
   module RemoteExecution
     module Ssh
-      VERSION = '0.10.2'
+      VERSION = '0.10.4'
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: smart_proxy_remote_execution_ssh
 version: !ruby/object:Gem::Version
-  version: 0.10.2
+  version: 0.10.4
 platform: ruby
 authors:
 - Ivan Nečas
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-10-25 00:00:00.000000000 Z
+date: 2024-03-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -192,7 +192,7 @@ homepage: https://github.com/theforeman/smart_proxy_remote_execution_ssh
 licenses:
 - GPL-3.0
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -207,8 +207,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.6
-signing_key: 
+rubygems_version: 3.3.26
+signing_key:
 specification_version: 4
 summary: Ssh remote execution provider for Foreman Smart-Proxy
 test_files: []