smart_proxy_dns_infoblox 0.0.6 → 0.0.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 93913c19fdbb004b2265f61341b782c234eb4b7d
-  data.tar.gz: 063e1118acfb2a85593c2b774d382663239493dc
+SHA256:
+  metadata.gz: 5cfadf774e686f392163cab090cda18e690ae0c89a2ecfcd54e1c6d916fb7ef5
+  data.tar.gz: cc14db4c7b8931fb8e49310aa9eba1d9570b34530c1048f2e556de9b345192a1
 SHA512:
-  metadata.gz: 9fd8344ceffca0e6344b0ba7c2b86fd540df89fc2089f51e32d11e3179092f6dcf5137b46673c9a8e73a53acadd644bdc275bb8a32ca9412b661d64c22fea612
-  data.tar.gz: 90300ea7cc4e2083ed376fe7138c93e00352287847494ab020bbd0cc0eda8668d1be9138631cfc2d9c28fc03c049d00e19e30c5463dcdc68198ecb113e6e855b
+  metadata.gz: 2f12f800f8df1cfb0673a3a0e30b0196fae46ee4b42c505d66da87e155311ec02fc375a9ae132a9e558a7779990b93183d1d0343eb83e4ea10ff71b7053451dc
+  data.tar.gz: 97d0999844145b63635f671164933b825003b29c2ec656ae1ca6545a69b1ba7a43970aa077dffc34c96c622f81b2b32d089f7346a4a1446019ac1db392b32939

data/README.md

@@ -1,6 +1,6 @@
 # SmartProxyDnsInfoblox
 
-*Introduction here*
+[![Build Status](https://travis-ci.org/theforeman/smart_proxy_dns_infoblox.svg?branch=master)](https://travis-ci.org/theforeman/smart_proxy_dns_infoblox)
 
 This plugin adds a new DNS provider for managing records in MyService.
 
@@ -11,6 +11,16 @@ for how to install Smart Proxy plugins
 
 This plugin is compatible with Smart Proxy 1.10 or higher.
 
+Example installation command via foreman-installer:
+
+```
+# foreman-installer --enable-foreman-proxy-plugin-dns-infoblox \
+--foreman-proxy-dns-provider infoblox \
+--foreman-proxy-plugin-dns-infoblox-dns-server 192.168.201.2 \
+--foreman-proxy-plugin-dns-infoblox-username admin \
+--foreman-proxy-plugin-dns-infoblox-password infoblox
+```
+
 ## Configuration
 
 To enable this DNS provider, edit `/etc/foreman-proxy/settings.d/dns.yml` and set:
@@ -21,6 +31,43 @@ Configuration options for this plugin are in `/etc/foreman-proxy/settings.d/dns_
 
 * example_setting: change this as an example
 
+## SSL
+
+The plugin enforces HTTPS server certificate verification. Follow a standard CA cert installation procedure for your operating system. It's possible to either download the server certificate from Infoblox web UI or use openssl command to extract it from server response. Here are example steps for Red Hat compatible systems:
+
+```
+# update-ca-trust enable
+# openssl s_client -showcerts -connect 192.168.201.2:443 </dev/null | openssl x509 -text >/etc/pki/ca-trust/source/anchors/infoblox.crt
+# update-ca-trust extract
+```
+
+For Debian-compatible systems:
+
+```
+# openssl s_client -showcerts -connect 192.168.201.2:443 </dev/null | openssl x509 -text >/usr/local/share/ca-certificates/infoblox.crt
+# update-ca-certificates
+```
+
+To test the CA certificate, a simple curl query can be used. This is a positive test:
+
+```
+# curl -u admin:infoblox https://192.168.201.2/wapi/v2.0/network
+[
+    {
+        "_ref": "network/ZG5zLm5ldHdvcmskMTkyLjE2OC4yMDIuMC8yNC8w:192.168.202.0/24/default",
+        "network": "192.168.202.0/24",
+        "network_view": "default"
+    }
+]
+```
+
+And a negative one:
+
+```
+# curl -u admin:infoblox https://192.168.201.2/wapi/v2.0/network
+curl: (60) SSL certificate problem: self signed certificate
+```
+
 ## Contributing
 
 Fork and send a Pull Request. Thanks!

data/lib/smart_proxy_dns_infoblox/dns_infoblox_main.rb

@@ -3,7 +3,6 @@ module Proxy::Dns::Infoblox
     attr_reader :connection
 
     def initialize(host, connection, ttl)
-      ENV['WAPI_VERSION']='2.0'
       @connection = connection
       super(host, ttl)
     end

data/lib/smart_proxy_dns_infoblox/dns_infoblox_version.rb

@@ -1,7 +1,7 @@
 module Proxy
   module Dns
     module Infoblox
-      VERSION = '0.0.6'
+      VERSION = '0.0.7'.freeze
     end
   end
 end

data/lib/smart_proxy_dns_infoblox/plugin_configuration.rb

@@ -13,10 +13,12 @@ module Proxy::Dns::Infoblox
                                       ::Infoblox::Connection.new(:username => settings[:username],
                                                                  :password => settings[:password],
                                                                  :host => settings[:dns_server],
-                                                                 :ssl_opts => {:verify => false})
+                                                                 :ssl_opts => { :verify => true },
+                                                                 :logger => ::Proxy::LogBuffer::Decorator.instance)
                                     end)
       container_instance.dependency :dns_provider,
-                                    lambda {::Proxy::Dns::Infoblox::Record.new(
+                                    lambda {
+                                      ::Proxy::Dns::Infoblox::Record.new(
                                         settings[:dns_server],
                                         container_instance.get_dependency(:connection),
                                         settings[:dns_ttl]) }

data/test/configuration_test.rb

@@ -15,7 +15,7 @@ class InfobloxProviderWiringTest < Test::Unit::TestCase
     assert_equal 'user', connection.username
     assert_equal 'password', connection.password
     assert_equal 'https://a_host', connection.host
-    assert_equal({:verify => false}, connection.ssl_opts)
+    assert_equal({ :verify => true }, connection.ssl_opts)
   end
 
   def test_dns_provider_wiring

data/test/infoblox_test.rb

@@ -3,7 +3,6 @@ require 'dns_common/dns_common'
 require 'infoblox'
 require 'smart_proxy_dns_infoblox/dns_infoblox_main'
 
-
 class InfobloxTest < Test::Unit::TestCase
   class DummyRecord
     attr_accessor :ipv6addr, :view

data/test/integration_test.rb

@@ -0,0 +1,61 @@
+require 'test_helper'
+require 'dns_common/dns_common'
+require 'smart_proxy_dns_infoblox'
+require 'smart_proxy_dns_infoblox/dns_infoblox_main'
+require "rack/test"
+require 'json'
+
+module Proxy::Dns
+  module DependencyInjection
+    include Proxy::DependencyInjection::Accessors
+    def container_instance
+    end
+  end
+end
+
+require 'dns/dns_api'
+
+ENV['RACK_ENV'] = 'test'
+
+class IntegrationTest < ::Test::Unit::TestCase
+  include Rack::Test::Methods
+
+  class DnsProviderForTesting < Proxy::Dns::Infoblox::Record
+    def initialize
+    end
+  end
+
+  def app
+    app = Proxy::Dns::Api.new
+    app.helpers.server = @server
+    app
+  end
+
+  def setup
+    @server = DnsProviderForTesting.new
+  end
+
+  def test_create_a_record
+    @server.expects(:create_a_record).with("test.com", "192.168.33.33")
+    post '/', :fqdn => 'test.com', :value => '192.168.33.33', :type => 'A'
+    assert last_response.ok?, "Last response was not ok: #{last_response.status} #{last_response.body}"
+  end
+
+  def test_create_ptr_record
+    @server.expects(:create_ptr_record).with("test.com", "33.33.168.192.in-addr.arpa")
+    post '/', :fqdn => 'test.com', :value => '33.33.168.192.in-addr.arpa', :type => 'PTR'
+    assert last_response.ok?, "Last response was not ok: #{last_response.status} #{last_response.body}"
+  end
+
+  def test_delete_a_record
+    @server.expects(:remove_a_record).with("test.com")
+    delete '/test.com'
+    assert last_response.ok?, "Last response was not ok: #{last_response.status} #{last_response.body}"
+  end
+
+  def test_delete_ptr_record
+    @server.expects(:remove_ptr_record).with("33.33.168.192.in-addr.arpa")
+    delete '/33.33.168.192.in-addr.arpa'
+    assert last_response.ok?, "Last response was not ok: #{last_response.status} #{last_response.body}"
+  end
+end

metadata

@@ -1,15 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: smart_proxy_dns_infoblox
 version: !ruby/object:Gem::Version
-  version: 0.0.6
+  version: 0.0.7
 platform: ruby
 authors:
 - Matthew Nicholson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-07-18 00:00:00.000000000 Z
-dependencies: []
+date: 2018-12-12 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.50.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.50.0
 description: Infoblox DNS provider plugin for Foreman's smart proxy
 email:
 - matthew.a.nicholson@gmail.com
@@ -28,6 +42,7 @@ files:
 - lib/smart_proxy_dns_infoblox/plugin_configuration.rb
 - test/configuration_test.rb
 - test/infoblox_test.rb
+- test/integration_test.rb
 - test/test_helper.rb
 homepage: https://github.com/theforeman/smart_proxy_dns_infoblox
 licenses:
@@ -49,11 +64,12 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.12
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: Infoblox DNS provider plugin for Foreman's smart proxy
 test_files:
-- test/infoblox_test.rb
 - test/test_helper.rb
 - test/configuration_test.rb
+- test/integration_test.rb
+- test/infoblox_test.rb