smart_init 4.2.0 → 5.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7a0d2189c40504fff065e0606ff59bb2c529ea2df100a5d835ae88ba1b89abea
-  data.tar.gz: 536894bb01f7dca209c6686bf0ac7e6960ca257069608e737731f01dd0c36a48
+  metadata.gz: c940aeebc57ccfda08563113bada6dfb76719ab15de983801edeb532df79c022
+  data.tar.gz: ab037fe33f3536b862c66e9b66b3c372f96648e4d69bb4d542bc9533c5a22fe2
 SHA512:
-  metadata.gz: d54eea8c78672566034ac4401764942b760a1f39b3be1b69fec278537a2573ad027ccb19c74d1e2e3a2f5d4248b743eb8eff76d0f15ce6560245d06b924bf0fb
-  data.tar.gz: 65aa81859e5589a1ee31f6f0d7ec119ab46570b3aa6167bccac2355dad097e68be337fc6ee3f8afec58d2b4b385a34c0ebabe3977273ce5bd09b632e6979ea19
+  metadata.gz: 5afb3dd23c4b4ee6bbcf435e1708f1bc82799d4d918d589bb96397b71423f2338888a20bdf236e352acd76c4d82c2edf84f002830358e9f6b1d9faad8985d0c4
+  data.tar.gz: 276f69b1ec9b740f700e13c4153b68a377ad1f44bb35ce8efe33046dd9657c20c4ad50d6d90ce995df74597a6d590a6600f6fe021e8344bacb13cad747941600

data/LICENSE.txt

@@ -1,4 +1,4 @@
-Copyright (c) 2013 pawurb
+Copyright (c) 2021 Paweł Urbanek
 
 MIT License
 
@@ -19,4 +19,4 @@ MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
 NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
 LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
 OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
-WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

data/README.md

@@ -1,4 +1,4 @@
-# Smart Init [![Build Status](https://travis-ci.org/pawurb/smart_init.svg)](https://travis-ci.org/pawurb/smart_init) [![Gem Version](https://badge.fury.io/rb/smart_init.svg)](https://badge.fury.io/rb/smart_init)
+# Smart Init - Simple service objects in Ruby [![Build Status](https://travis-ci.org/pawurb/smart_init.svg)](https://travis-ci.org/pawurb/smart_init) [![Gem Version](https://badge.fury.io/rb/smart_init.svg)](https://badge.fury.io/rb/smart_init)
 
 Do you find yourself writing a lot of boilerplate code like this?
 
@@ -32,6 +32,8 @@ gem 'smart_init'
 You can use it either by extending a module:
 
 ```ruby
+require 'smart_init'
+
 class ApiClient
   extend SmartInit
 
@@ -214,21 +216,3 @@ client.api_token = 'new_token' => # NoMethodError (undefined method `api_token='
 client.timeout_length => 100
 client.timeout_length = 150 => # NoMethodError (undefined method `timeout_length=' called for #<SemiPublicReadersSemiPublicAccessorsApiClient:0x000...>)
 ```
-
-## Arguments API
-
-Alternatively you can use an API without hash arguments, default values, public readers, or public accessors support:
-
-```ruby
-class Calculator < SmartInit::Base
-  initialize_with_args :data
-  is_callable
-
-  def call
-    ...
-    result
-  end
-end
-
-Calculator.call(data) => result
-```

data/lib/smart_init/main.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module SmartInit
   def is_callable(opts={})
     method_name = if name_from_opts = opts[:method_name]
@@ -6,18 +8,17 @@ module SmartInit
       :call
     end
 
-    define_singleton_method method_name do |*parameters|
-      new(*parameters).public_send(method_name)
+    define_singleton_method method_name do |**parameters|
+      new(**parameters).public_send(method_name)
     end
   end
 
   def initialize_with_hash(*required_attrs, **attributes_and_options)
-
     public_readers = attributes_and_options.delete(:public_readers) || []
     public_accessors = attributes_and_options.delete(:public_accessors) || []
     if  public_readers == true || public_accessors == true
-      public_readers = required_attrs
-      public_accessors = required_attrs if public_accessors == true
+      public_readers = required_attrs + attributes_and_options.keys
+      public_accessors = required_attrs + attributes_and_options.keys if public_accessors == true
     else
       public_readers += public_accessors
     end
@@ -50,28 +51,6 @@ module SmartInit
   end
 
   alias initialize_with initialize_with_hash
-
-  def initialize_with_args *attributes
-    define_method :initialize do |*parameters|
-      if attributes.count != parameters.count
-        raise ArgumentError, "wrong number of arguments (given #{parameters.count}, expected #{attributes.count})"
-      end
-
-      attributes.zip(parameters).each do |pair|
-        name = pair[0]
-        value = pair[1]
-        instance_variable_set("@#{name}", value)
-      end
-    end
-
-    instance_eval do
-      attr_reader(*attributes)
-
-      attributes.each do |method_name|
-        private method_name
-      end
-    end
-  end
 end
 
 class SmartInit::Base

data/lib/smart_init/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module SmartInit
-  VERSION = "4.2.0"
+  VERSION = "5.0.2"
 end

data/lib/smart_init.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'smart_init/main'
 
 module SmartInit

data/smart_init.gemspec

@@ -3,19 +3,23 @@ lib = File.expand_path('../lib', __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'smart_init/version'
 
-Gem::Specification.new do |gem|
-  gem.name          = "smart_init"
-  gem.version       = SmartInit::VERSION
-  gem.authors       = ["pawurb"]
-  gem.email         = ["p.urbanek89@gmail.com"]
-  gem.summary       = %q{ Remove Ruby initializer boilerplate code }
-  gem.description   = %q{ A smart DSL for ruby initializers boilerplate }
-  gem.homepage      = "http://github.com/pawurb/smart_init"
-  gem.files         = `git ls-files`.split("\n")
-  gem.test_files    = gem.files.grep(%r{^(test)/})
-  gem.require_paths = ["lib"]
-  gem.license       = "MIT"
-  gem.add_development_dependency "rake"
-  gem.add_development_dependency "byebug"
-  gem.add_development_dependency "test-unit"
+Gem::Specification.new do |s|
+  s.name          = "smart_init"
+  s.version       = SmartInit::VERSION
+  s.authors       = ["pawurb"]
+  s.email         = ["p.urbanek89@gmail.com"]
+  s.summary       = %q{ Remove Ruby initializer boilerplate code }
+  s.description   = %q{ A smart DSL for ruby initializers boilerplate }
+  s.homepage      = "http://github.com/pawurb/smart_init"
+  s.files         = `git ls-files`.split("\n")
+  s.test_files    = s.files.grep(%r{^(test)/})
+  s.require_paths = ["lib"]
+  s.license       = "MIT"
+  s.add_development_dependency "rake"
+  s.add_development_dependency "byebug"
+  s.add_development_dependency "test-unit"
+
+  if s.respond_to?(:metadata=)
+    s.metadata = { "rubygems_mfa_required" => "true" }
+  end
 end

data/test/test_hash_api.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "test/unit"
 require_relative '../lib/smart_init/main'
 

data/test/test_hash_public_accessors.rb

@@ -1,8 +1,10 @@
+# frozen_string_literal: true
+
 require "byebug"
 require "test/unit"
 require_relative '../lib/smart_init/main'
 
-class TestAllPublic
+class TestAllPublicAccessors
   extend SmartInit
   initialize_with :attribute_1, :attribute_2, public_accessors: true
   is_callable
@@ -12,7 +14,7 @@ class TestAllPublic
   end
 end
 
-class TestSomePublic
+class TestSomePublicAccessors
   extend SmartInit
   initialize_with :attribute_1, :attribute_2, public_accessors: [:attribute_1]
   is_callable
@@ -22,7 +24,7 @@ class TestSomePublic
   end
 end
 
-class TestDefaultPublic
+class TestDefaultPublicAccessors
   extend SmartInit
   initialize_with :attribute_1, attribute_2: 2, public_accessors: [:attribute_2]
 
@@ -31,9 +33,9 @@ class TestDefaultPublic
   end
 end
 
-class HashApiPublicTest < Test::Unit::TestCase
+class HashApiPublicTestAccessors < Test::Unit::TestCase
   def test_all_public
-    service = TestAllPublic.new(attribute_1: "a", attribute_2: "b")
+    service = TestAllPublicAccessors.new(attribute_1: "a", attribute_2: "b")
     assert_nothing_raised do
       service.attribute_1 = "c"
       service.attribute_2 = "d"
@@ -43,7 +45,7 @@ class HashApiPublicTest < Test::Unit::TestCase
   end
 
   def test_some_public
-    service = TestSomePublic.new(attribute_1: "a", attribute_2: "b")
+    service = TestSomePublicAccessors.new(attribute_1: "a", attribute_2: "b")
     assert_nothing_raised do
       service.attribute_1 = "c"
     end
@@ -57,7 +59,7 @@ class HashApiPublicTest < Test::Unit::TestCase
   end
 
   def test_default_public
-    service = TestDefaultPublic.new(attribute_1: "a")
+    service = TestDefaultPublicAccessors.new(attribute_1: "a")
     assert_nothing_raised do
       service.attribute_2 = 3
     end

data/test/test_hash_public_mixed.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "byebug"
 require "test/unit"
 require_relative '../lib/smart_init/main'

data/test/test_hash_public_readers.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "byebug"
 require "test/unit"
 require_relative '../lib/smart_init/main'
@@ -31,6 +33,15 @@ class TestDefaultPublic
   end
 end
 
+class TestDefaultAllPublic
+  extend SmartInit
+  initialize_with :attribute_1, attribute_2: 2, public_readers: true
+
+  def call
+    [attribute_1, attribute_2]
+  end
+end
+
 class HashApiPublicTest < Test::Unit::TestCase
   def test_all_public
     service = TestAllPublic.new(attribute_1: "a", attribute_2: "b")
@@ -54,5 +65,11 @@ class HashApiPublicTest < Test::Unit::TestCase
       service.attribute_1
     end
   end
+
+  def test_default_all_public
+    service = TestDefaultAllPublic.new(attribute_1: "a")
+    assert_equal service.attribute_1, "a"
+    assert_equal service.attribute_2, 2
+  end
 end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: smart_init
 version: !ruby/object:Gem::Version
-  version: 4.2.0
+  version: 5.0.2
 platform: ruby
 authors:
 - pawurb
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-04-12 00:00:00.000000000 Z
+date: 2022-02-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -69,7 +69,6 @@ files:
 - lib/smart_init/main.rb
 - lib/smart_init/version.rb
 - smart_init.gemspec
-- test/test_args_api.rb
 - test/test_hash_api.rb
 - test/test_hash_public_accessors.rb
 - test/test_hash_public_mixed.rb
@@ -77,7 +76,8 @@ files:
 homepage: http://github.com/pawurb/smart_init
 licenses:
 - MIT
-metadata: {}
+metadata:
+  rubygems_mfa_required: 'true'
 post_install_message: 
 rdoc_options: []
 require_paths:
@@ -93,12 +93,11 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.6
+rubygems_version: 3.1.6
 signing_key: 
 specification_version: 4
 summary: Remove Ruby initializer boilerplate code
 test_files:
-- test/test_args_api.rb
 - test/test_hash_api.rb
 - test/test_hash_public_accessors.rb
 - test/test_hash_public_mixed.rb

data/test/test_args_api.rb

@@ -1,77 +0,0 @@
-require "test/unit"
-require_relative '../lib/smart_init/main'
-
-class TestClass
-  extend SmartInit
-  initialize_with_args :attribute_1, :attribute_2
-  is_callable
-
-  def call
-    [attribute_1, attribute_2]
-  end
-end
-
-class TestNoInit
-  extend SmartInit
-  is_callable
-
-  def call
-    'result'
-  end
-end
-
-class TestMethodName
-  extend SmartInit
-
-  is_callable method_name: :run!
-
-  def run!
-    true
-  end
-end
-
-def test_object
-  @_test_object ||= TestClass.new("attr_1_value", "attr_2_value")
-end
-
-class StandardApiTest < Test::Unit::TestCase
-  def test_number_of_attributes
-    assert_nothing_raised do
-      TestClass.new(
-        "attr_1_value",
-        "attr_2_value"
-      )
-    end
-
-    assert_raise ArgumentError do
-      TestClass.new(
-        "attr_1_value"
-      )
-    end
-  end
-
-  def test_instance_variables
-    assert_equal test_object.instance_variable_get("@attribute_1"), "attr_1_value"
-  end
-
-  def test_private_getters
-    error = assert_raise NoMethodError do
-      test_object.attribute_1
-    end
-    assert_match("private method", error.message)
-
-    assert_equal test_object.send(:attribute_1), "attr_1_value"
-  end
-
-  def test_is_callable
-    assert_equal TestClass.call("a", "b"), ["a", "b"]
-  end
-
-  def test_is_callable_no_initializers
-    assert_equal TestNoInit.call, 'result'
-  end
-
-  def test_is_callable_method_name
-    assert_equal TestMethodName.run!, true
-  end
-end