smart_init 4.0.1 → 4.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cd5270377f234cbd06c6e2fe3b720b960cfc51b87b81de97d4e08857d3204b72
-  data.tar.gz: a556d1a56de6b827ae421cc8a8994d88a32966d4c72ba9b27ea8f91bab61d63a
+  metadata.gz: fedc150bbb8aeed53e1bcc08073e643175a5fbe49f909a20c17cac145a95f969
+  data.tar.gz: 71c028b8b52b4ef553fd0d6a5711b913bac1fc8d46e4ca41d067b5e4441a5fa1
 SHA512:
-  metadata.gz: d2477b6ac9b6fc5dff757732cf96c76de0faf943485dee2c76f0eb50555fdce9b536dfb723e0a816b118d5a54fa506ac8850b5354e1344d5695fe0b4c3e60fd6
-  data.tar.gz: 5082e9640fdc6eefb1298a4fde60a25537d27e7c54737f075ad3fa144ce29e5cff7e39a0c3ce3ed5181d50ee70793fbfe5c018131494539cfb6484f3f89b668d
+  metadata.gz: e1ec743157b4a687d902d08023654604db4c9ec502448313e9eb79f3e621cb0f43fa293fcba5bcd31018e14cfeb8dd149f937ac89a1cadf1ff0bcb28e226751a
+  data.tar.gz: 681f6bd9c9b9e75580154bde00819894ff3a3f0bbe9598041e21123b4d63284d7d01deda8e374fc462f41d55245c731ee64a70f12380ef2f77f15d2a570ca64f

data/README.md

@@ -37,7 +37,6 @@ class ApiClient
 
   initialize_with :network_provider, :api_token
 end
-
 ```
 
 or subclassing:
@@ -46,7 +45,6 @@ or subclassing:
 class ApiClient < SmartInit::Base
   initialize_with :network_provider, :api_token
 end
-
 ```
 
 Now you can just:
@@ -113,7 +111,6 @@ end
 
 Adder.call(num_a: 2) => 4
 Adder.call(num_a: 2, num_b: 3) => 5
-
 ```
 
 ### Readers access
@@ -123,7 +120,6 @@ Contrary to using Struct, by default the reader methods are not publicly exposed
 ```ruby
 client = ApiClient.new(network_provider: Faraday.new, api_token: 'secret_token')
 client.api_token => # NoMethodError (private method `api_token' called for #<ApiClient:0x000..>)
-
 ```
 
 Optionally you can make all or subset of readers public using the `public_readers` config option. It accepts `true` or an array of method names as an argument.
@@ -133,7 +129,7 @@ class PublicApiClient < SmartInit::Base
   initialize_with :network_provider, :api_token, public_readers: true
 end
 
-client = ApiClient.new(network_provider: Faraday.new, api_token: 'secret_token')
+client = PublicApiClient.new(network_provider: Faraday.new, api_token: 'secret_token')
 client.network_provider => #<Faraday::Connection:0x000...>
 client.api_token => 'secret_token'
 ```
@@ -143,7 +139,7 @@ class SemiPublicApiClient < SmartInit::Base
   initialize_with :network_provider, :api_token, public_readers: [:network_provider]
 end
 
-client = ApiClient.new(network_provider: Faraday.new, api_token: 'secret_token')
+client = SemiPublicApiClient.new(network_provider: Faraday.new, api_token: 'secret_token')
 client.network_provider => #<Faraday::Connection:0x000...>
 client.api_token => 'secret_token' => # NoMethodError (private method `api_token' called for #<ApiClient:0x000...>)
 ```

data/lib/smart_init/main.rb

@@ -15,11 +15,19 @@ module SmartInit
     public_readers_filter = -> (el) {
       el.is_a?(Hash) && el.keys == [:public_readers]
     }
+    attributes = attributes.map do |el|
+      if el.is_a?(Hash)
+        el.map { |k, v| { k => v } }
+      else
+       el
+      end
+    end.flatten
+
     public_readers = attributes.select(&public_readers_filter)
     attributes.delete_if(&public_readers_filter)
     required_attrs = attributes.select { |el| el.is_a?(Symbol) }
 
-    default_value_attrs = attributes.select { |el| el.is_a?(Hash) }.first || {}
+    default_value_attrs = attributes.select { |el| el.is_a?(Hash) }.reduce(Hash.new, :merge) || {}
 
     define_method :initialize do |*parameters|
       parameters = [{}] if parameters == []

data/lib/smart_init/version.rb

@@ -1,3 +1,3 @@
 module SmartInit
-  VERSION = "4.0.1"
+  VERSION = "4.1.0"
 end

data/test/test_hash_public_readers.rb

@@ -22,6 +22,15 @@ class TestSomePublic
   end
 end
 
+class TestDefaultPublic
+  extend SmartInit
+  initialize_with :attribute_1, attribute_2: 2, public_readers: [:attribute_2]
+
+  def call
+    [attribute_1, attribute_2]
+  end
+end
+
 class HashApiPublicTest < Test::Unit::TestCase
   def test_all_public
     service = TestAllPublic.new(attribute_1: "a", attribute_2: "b")
@@ -36,4 +45,14 @@ class HashApiPublicTest < Test::Unit::TestCase
       service.attribute_2
     end
   end
+
+  def test_default_public
+    service = TestDefaultPublic.new(attribute_1: "a")
+    assert_equal service.attribute_2, 2
+
+    assert_raise NoMethodError do
+      service.attribute_1
+    end
+  end
 end
+

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: smart_init
 version: !ruby/object:Gem::Version
-  version: 4.0.1
+  version: 4.1.0
 platform: ruby
 authors:
 - pawurb
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-12-27 00:00:00.000000000 Z
+date: 2020-03-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -91,7 +91,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
+rubygems_version: 3.0.6
 signing_key: 
 specification_version: 4
 summary: Remove Ruby initializer boilerplate code