smart_init 4.0.0 → 4.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8f5bd5f6cfd9709e9378b01463ba8473b77aa3c1b17caf8fdbf5743ec26d506a
-  data.tar.gz: 756791cbea14b145fddb9b2b3d96a7c4b595bc3dea91c8998e78f26802b6d323
+  metadata.gz: cd5270377f234cbd06c6e2fe3b720b960cfc51b87b81de97d4e08857d3204b72
+  data.tar.gz: a556d1a56de6b827ae421cc8a8994d88a32966d4c72ba9b27ea8f91bab61d63a
 SHA512:
-  metadata.gz: 4b5e72ebb4d1eb6299db75ccd64ef4e8189ad0047ceb64106baddfff678fc80ec33da75adb7dd8a92553df62aaa5005825715f2e89cbae630d6f65230fe88a92
-  data.tar.gz: f4286bc008ec50a1519c0bb3b33bedd67b44db78bb4e27e72592a3843db2163a345af4bcf38d8261fe492961fa0f48d8b36f1f5cd3c3a32595171666b4e74054
+  metadata.gz: d2477b6ac9b6fc5dff757732cf96c76de0faf943485dee2c76f0eb50555fdce9b536dfb723e0a816b118d5a54fa506ac8850b5354e1344d5695fe0b4c3e60fd6
+  data.tar.gz: 5082e9640fdc6eefb1298a4fde60a25537d27e7c54737f075ad3fa144ce29e5cff7e39a0c3ce3ed5181d50ee70793fbfe5c018131494539cfb6484f3f89b668d

data/.travis.yml

@@ -1,7 +1,7 @@
 rvm:
-  - 2.4.4
   - 2.5.3
   - 2.6.5
+  - 2.7.0
 notifications:
   email: false
 

data/README.md

@@ -1,4 +1,4 @@
-# Smart Init [![Build Status](https://travis-ci.org/pawurb/smart_init.svg)](https://travis-ci.org/pawurb/smart_init) [![Gem Version](https://badge.fury.io/rb/smart_init.svg)](http://badge.fury.io/rb/smart_init)
+# Smart Init [![Build Status](https://travis-ci.org/pawurb/smart_init.svg)](https://travis-ci.org/pawurb/smart_init) [![Gem Version](https://badge.fury.io/rb/smart_init.svg)](https://badge.fury.io/rb/smart_init)
 
 Do you find yourself writing a lot of boilerplate code like that?
 
@@ -64,41 +64,9 @@ client = ApiClient.new(network_provider: Faraday.new)
 # ArgumentError (missing required attribute api_token)
 ```
 
-### Readers access
-
-Contrary to using Struct, by default the reader methods are not publicly exposed:
-
-```ruby
-client = ApiClient.new(network_provider: Faraday.new, api_token: 'secret_token')
-client.api_token => # NoMethodError (private method `api_token' called for #<ApiClient:0x000..>)
-
-```
-
-Optionally you can make all or subset of readers public using the `public_readers` config option. It accepts `true` or an array of method names as an argument.
-
-```ruby
-class PublicApiClient < SmartInit::Base
-  initialize_with :network_provider, :api_token, public_readers: true
-end
-
-client = ApiClient.new(network_provider: Faraday.new, api_token: 'secret_token')
-client.network_provider => #<Faraday::Connection:0x000...>
-client.api_token => 'secret_token'
-```
-
-```ruby
-class SemiPublicApiClient < SmartInit::Base
-  initialize_with :network_provider, :api_token, public_readers: [:network_provider]
-end
-
-client = ApiClient.new(network_provider: Faraday.new, api_token: 'secret_token')
-client.network_provider => #<Faraday::Connection:0x000...>
-client.api_token => 'secret_token' => # NoMethodError (private method `api_token' called for #<ApiClient:0x000...>)
-```
-
 ### Making the object callable
 
-You can also use `is_callable` method:
+You can use the `is_callable` method:
 
 ```ruby
 class Calculator < SmartInit::Base
@@ -148,9 +116,41 @@ Adder.call(num_a: 2, num_b: 3) => 5
 
 ```
 
+### Readers access
+
+Contrary to using Struct, by default the reader methods are not publicly exposed:
+
+```ruby
+client = ApiClient.new(network_provider: Faraday.new, api_token: 'secret_token')
+client.api_token => # NoMethodError (private method `api_token' called for #<ApiClient:0x000..>)
+
+```
+
+Optionally you can make all or subset of readers public using the `public_readers` config option. It accepts `true` or an array of method names as an argument.
+
+```ruby
+class PublicApiClient < SmartInit::Base
+  initialize_with :network_provider, :api_token, public_readers: true
+end
+
+client = ApiClient.new(network_provider: Faraday.new, api_token: 'secret_token')
+client.network_provider => #<Faraday::Connection:0x000...>
+client.api_token => 'secret_token'
+```
+
+```ruby
+class SemiPublicApiClient < SmartInit::Base
+  initialize_with :network_provider, :api_token, public_readers: [:network_provider]
+end
+
+client = ApiClient.new(network_provider: Faraday.new, api_token: 'secret_token')
+client.network_provider => #<Faraday::Connection:0x000...>
+client.api_token => 'secret_token' => # NoMethodError (private method `api_token' called for #<ApiClient:0x000...>)
+```
+
 ## Arguments API
 
-Alternatively you can use an API without hash arguments and default values:
+Alternatively you can use an API without hash arguments,  default values and public readers support:
 
 ```ruby
 class Calculator < SmartInit::Base

data/lib/smart_init/main.rb

@@ -17,9 +17,9 @@ module SmartInit
     }
     public_readers = attributes.select(&public_readers_filter)
     attributes.delete_if(&public_readers_filter)
-    required_attrs = attributes.select { |attr| attr.is_a?(Symbol) }
+    required_attrs = attributes.select { |el| el.is_a?(Symbol) }
 
-    default_value_attrs = attributes.select { |attr| attr.is_a?(Hash) }.first || {}
+    default_value_attrs = attributes.select { |el| el.is_a?(Hash) }.first || {}
 
     define_method :initialize do |*parameters|
       parameters = [{}] if parameters == []
@@ -27,7 +27,6 @@ module SmartInit
         raise ArgumentError, "invalid input, expected hash of attributes"
       end
 
-
       required_attrs.each do |required_attr|
         unless parameters.first.has_key?(required_attr)
           raise ArgumentError, "missing required attribute #{required_attr}"
@@ -77,9 +76,11 @@ module SmartInit
     end
 
     instance_eval do
-      private
-
       attr_reader(*attributes)
+
+      attributes.each do |method_name|
+        private method_name
+      end
     end
   end
 end

data/lib/smart_init/version.rb

@@ -1,3 +1,3 @@
 module SmartInit
-  VERSION = "4.0.0"
+  VERSION = "4.0.1"
 end

data/test/test_args_api.rb

@@ -55,9 +55,10 @@ class StandardApiTest < Test::Unit::TestCase
   end
 
   def test_private_getters
-    assert_raise NoMethodError do
+    error = assert_raise NoMethodError do
       test_object.attribute_1
     end
+    assert_match("private method", error.message)
 
     assert_equal test_object.send(:attribute_1), "attr_1_value"
   end

data/test/test_hash_api.rb

@@ -58,10 +58,12 @@ class HashApiTest < Test::Unit::TestCase
   end
 
   def test_private_readers
-    service = TestServiceDefaults.call(attribute_1: "a")
-    assert_raise NoMethodError do
-      service.attribute_1
+    service = TestServiceDefaults.new(attribute_1: "a")
+    error = assert_raise NoMethodError do
+      service.attribute_2
     end
+
+    assert_match("private method", error.message)
   end
 
   def test_integer_defaults

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: smart_init
 version: !ruby/object:Gem::Version
-  version: 4.0.0
+  version: 4.0.1
 platform: ruby
 authors:
 - pawurb
@@ -91,7 +91,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.6
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: Remove Ruby initializer boilerplate code