smart_init 3.3.0 → 3.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6348b5da71d03671ec74c8a43d2400e84076b4510fae3cb61f1db3da92752ba9
-  data.tar.gz: 95879658e1ff5b439206ad61c8472659d4331e058e1841d83bef56eaea3eb254
+  metadata.gz: '0892f8aa5ed6cba8c888e4a44e67ab3b7fd95fae4648c227593d3ce517fa07f4'
+  data.tar.gz: 927c461dfc531d9b21d365609b2f86be35a14102fde2bba092f672d8d55a9d16
 SHA512:
-  metadata.gz: 3239515e6cfee5cfc1a1be8b12d6b4799ede9e8ca020f4d7c8ee38d8ab6f2e61d80c9d1f86563c5302779f47d232dda0cd44db8a5164439522dfbd33abc450b2
-  data.tar.gz: 60abdec0ed7227d03bdc6d1c93d955202ea64ce31a6ade006a0b0c9a3f25c547bda222d0c8a349242789be5e8d1b70609f9a29ea11855cbb8b3981dce1d57d6c
+  metadata.gz: 3de078331f718dc999244841c6e3b2e0321af77e43352fde4593c2b08f45e680f98685480fe7455192d9b2d44e804f610ef3ddd588b810700750d116a3c9b1b6
+  data.tar.gz: 6523291cb5c8b9a9af044b82ff85c6b2d3c0814a25d506ed2c1d8502b355ba15e33211cd0ebfc45bc859848b7e571a8e83668d5f4d30194970f2c3e452170836

data/.travis.yml

@@ -1,7 +1,7 @@
 rvm:
   - 2.4.4
   - 2.5.3
-  - 2.6.0
+  - 2.6.5
 notifications:
   email: false
 

data/README.md

@@ -15,7 +15,7 @@ end
 
 Gem provides a simple DSL for getting rid of it. It offers an alternative to using `Struct.new` which does not check for number of parameters provided in initializer, exposes getters and instantiates unecessary class instances.
 
-**Smart Init** offers a unified api for stateless service objects, accepting values in initializer and exposing one public class method `call` which instantiates new objects and accepts arguments passed to initializer.
+**Smart Init** offers a unified API convention for stateless service objects, accepting values in initializer and exposing one public class method `call` which instantiates new objects and accepts arguments passed to initializer.
 
 Check out [this blog post](https://pawelurbanek.com/2018/02/12/ruby-on-rails-service-objects-and-testing-in-isolation/) for my reasoning behind this approach to service object pattern.
 
@@ -64,6 +64,15 @@ object = ApiClient.new(network_provider: Faraday.new)
 # ArgumentError (missing required attribute api_token)
 ```
 
+Contrary to using Struct, reader methods are not publicly exposed:
+
+```ruby
+object = ApiClient.new(network_provider: Faraday.new, api_token: 'secret_token')
+object.api_token
+
+# NoMethodError (private method `api_token' called for #<ApiClient:0x00007fe911876a48>)
+```
+
 You can also use `is_callable` method:
 
 ```ruby
@@ -114,9 +123,9 @@ Adder.call(num_a: 2, num_b: 3) => 5
 
 ```
 
-## Legacy Arguments API
+## Arguments API
 
-Alternatively you can a legacy API without hash arguments and default values:
+Alternatively you can use an API without hash arguments and default values:
 
 ```ruby
 class Calculator < SmartInit::Base

data/lib/smart_init/main.rb

@@ -16,6 +16,7 @@ module SmartInit
     default_value_attrs = attributes.select { |attr| attr.is_a?(Hash) }.first || {}
 
     define_method :initialize do |*parameters|
+      parameters = [{}] if parameters == []
       unless parameters.first.is_a?(Hash)
         raise ArgumentError, "invalid input, expected hash of attributes"
       end

data/lib/smart_init/version.rb

@@ -1,3 +1,3 @@
 module SmartInit
-  VERSION = "3.3.0"
+  VERSION = "3.4.0"
 end

data/test/test_hash_api.rb

@@ -21,6 +21,16 @@ class TestServiceDefaults
   end
 end
 
+class TestServiceAllDefaults
+  extend SmartInit
+  initialize_with attribute_1: "default_value_1", attribute_2: "default_value_2", attribute_3: "default_value_3"
+  is_callable
+
+  def call
+    [attribute_1, attribute_2, attribute_3]
+  end
+end
+
 class TestHashIntegerDefaults
   extend SmartInit
   initialize_with :attribute_1, attribute_2: 2
@@ -62,4 +72,8 @@ class HashApiTest < Test::Unit::TestCase
       TestService.call("invalid_input here")
     end
   end
+
+  def test_all_defaults
+    assert_equal TestServiceAllDefaults.call, ["default_value_1", "default_value_2", "default_value_3"]
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: smart_init
 version: !ruby/object:Gem::Version
-  version: 3.3.0
+  version: 3.4.0
 platform: ruby
 authors:
 - pawurb
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-01-02 00:00:00.000000000 Z
+date: 2019-11-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -76,7 +76,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.0
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Remove Ruby initializer boilerplate code