smart_init 3.0.0 → 3.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8dee28a188d21cf07e256ca0fd7ef9be6200e7397226b4b4e26b7f995b94acf5
-  data.tar.gz: fef3f5bad20e6cf3df03dd27a69df4aa429d304098b1acc60426a00c0a8eafd0
+  metadata.gz: 7c160db7dd46c5dc77e00e49404e2354519b12ef5200265160586a57ae9fc711
+  data.tar.gz: e378b890b6cc8c3c86301d227405ac80f14176b3d3a7e1b673578e4ba7cdcca4
 SHA512:
-  metadata.gz: d47fbddd944636439c176a32d5d62871669d5c9ffb505f7b6180e28bc52ac7f91bb9e7699c14378e89b811671ef3626f888ea84916e17ccde3daff96538e1255
-  data.tar.gz: 32751fb0cda8bc3713f57da5368ae8dde9dbf90ab7b95a1671b61eec17ed69de249d58fa116e4127260291bdeb34c62e962a690a9ee2970929bf1a7733376332
+  metadata.gz: 8d6ad48780eac79e681a956709af68dcda5f51c15796c74df575fe233df25f9f5c1817c2feea9a16b17f131d6228d0f7e3d3394676c4a73e891e0e823848d82d
+  data.tar.gz: a47ab03b8918c0b34e7efec5200dc2f3831a47571ca888b642cd709db52ad13831ebd9af8beecb55cc29fa8f94a6024ab886c3589e4cb6bc4156a4645d231866

data/README.md

@@ -50,6 +50,8 @@ object = ApiClient.new(network_provider: Faraday.new, api_token: 'secret_token')
 # <ApiClient:0x007fa16684ec20 @network_provider=Faraday<...>, @api_token="secret_token">
 ```
 
+
+
 You can also use `is_callable` method:
 
 ```ruby

data/lib/smart_init/main.rb

@@ -10,8 +10,10 @@ module SmartInit
     default_value_attrs = attributes.select { |attr| attr.is_a?(Hash) }.first || {}
 
     define_method :initialize do |*parameters|
-      if required_attrs.count > parameters.first.count
-        raise ArgumentError, "wrong number of arguments (given #{parameters.count}, expected at least #{required_attrs.count})"
+      required_attrs.each do |required_attr|
+        unless parameters.first.has_key?(required_attr)
+          raise ArgumentError, "missing required attribute #{required_attr}"
+        end
       end
 
       (required_attrs + default_value_attrs.keys).each do |attribute|
@@ -23,7 +25,7 @@ module SmartInit
     instance_eval do
       private
 
-      attr_reader *(required_attrs + default_value_attrs.keys)
+      attr_reader(*(required_attrs + default_value_attrs.keys).compact)
     end
   end
 
@@ -43,10 +45,9 @@ module SmartInit
     instance_eval do
       private
 
-      attr_reader *attributes
+      attr_reader(*attributes)
     end
   end
-
 end
 
 class SmartInit::Base

data/lib/smart_init/version.rb

@@ -1,3 +1,3 @@
 module SmartInit
-  VERSION = "3.0.0"
+  VERSION = "3.1.0"
 end

data/test/{test_keywords_api.rb → test_api.rb}

@@ -1,7 +1,7 @@
 require "test/unit"
 require_relative '../lib/smart_init/main'
 
-class TestKeywords
+class TestService
   extend SmartInit
   initialize_with :attribute_1, :attribute_2
   is_callable
@@ -11,7 +11,7 @@ class TestKeywords
   end
 end
 
-class TestKeywordsDefaults
+class TestServiceDefaults
   extend SmartInit
   initialize_with :attribute_1, attribute_2: "default_value_2", attribute_3: "default_value_3"
   is_callable
@@ -21,7 +21,7 @@ class TestKeywordsDefaults
   end
 end
 
-class TestKeywordsIntegerDefaults
+class TestHashIntegerDefaults
   extend SmartInit
   initialize_with :attribute_1, attribute_2: 2
   is_callable
@@ -31,29 +31,29 @@ class TestKeywordsIntegerDefaults
   end
 end
 
-class KeywordsApiTest < Test::Unit::TestCase
+class HashApiTest < Test::Unit::TestCase
   def test_keywords
-    assert_equal TestKeywords.call(attribute_1: "a", attribute_2: "b"), ["a", "b"]
+    assert_equal TestService.call(attribute_1: "a", attribute_2: "b"), ["a", "b"]
 
     assert_raise ArgumentError do
-      TestKeywords.new(
+      TestService.new(
         attribute_1: "a"
       )
     end
   end
 
   def test_keywords_defaults
-    assert_equal TestKeywordsDefaults.call(attribute_1: "a"), ["a", "default_value_2", "default_value_3"]
-    assert_equal TestKeywordsDefaults.call(attribute_1: "a", attribute_2: "b"), ["a", "b", "default_value_3"]
+    assert_equal TestServiceDefaults.call(attribute_1: "a"), ["a", "default_value_2", "default_value_3"]
+    assert_equal TestServiceDefaults.call(attribute_1: "a", attribute_2: "b"), ["a", "b", "default_value_3"]
   end
 
   def test_integer_defaults
-    assert_equal TestKeywordsIntegerDefaults.call(attribute_1: 1), [1, 2]
+    assert_equal TestHashIntegerDefaults.call(attribute_1: 1), [1, 2]
   end
 
-  private
-
-  def test_object
-    @_test_object ||= TestClass.new("attr_1_value", "attr_2_value")
+  def test_missing_attributes
+    assert_raise ArgumentError do
+      TestService.call(attribute_1: "a", invalid_attribute: "b")
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: smart_init
 version: !ruby/object:Gem::Version
-  version: 3.0.0
+  version: 3.1.0
 platform: ruby
 authors:
 - pawurb
@@ -55,7 +55,7 @@ files:
 - lib/smart_init/main.rb
 - lib/smart_init/version.rb
 - smart_init.gemspec
-- test/test_keywords_api.rb
+- test/test_api.rb
 - test/test_v1_api.rb
 homepage: http://github.com/pawurb/smart_init
 licenses: