smart_field_constraints 0.1.0 → 0.1.1

data/CHANGELOG.rdoc

@@ -1,5 +1,9 @@
 == master
 
+== 0.1.1 / 2009-03-15
+
+* Fix limits for integer columns being interpreted incorrectly [Michael Grosser]
+
 == 0.1.0 / 2008-12-14
 
 * Remove the PluginAWeek namespace
@@ -8,8 +12,8 @@
 == 0.0.2 / 2008-06-22
 
 * Remove log files from gems
-* Don't check length validation constraints if models were loaded prior to the plugin being loaded [grosser]
-* Refactor FormHelper extension to allow for others to easily extend the plugin for things like textarea lengths [grosser]
+* Don't check length validation constraints if models were loaded prior to the plugin being loaded [Michael Grosser]
+* Refactor FormHelper extension to allow for others to easily extend the plugin for things like textarea lengths [Michael Grosser]
 * Add support for tracking validates_size_of validations
 
 == 0.0.1 / 2008-05-05

data/README.rdoc

@@ -59,7 +59,7 @@ HTML:
 Since the +maxlength+ attribute is not W3C-compliant for textareas, it is not
 included in the types of fields that will be automatically assigned length
 constraints.  However, you can easily add this yourself by extending the plugin
-yourself.
+yourself.  For an example of this see smart_field_constraints_textarea[http://github.com/grosser/smart_field_constraints_textarea].
 
 == Caveats
 

data/Rakefile

@@ -5,7 +5,7 @@ require 'rake/contrib/sshpublisher'
 
 spec = Gem::Specification.new do |s|
   s.name              = 'smart_field_constraints'
-  s.version           = '0.1.0'
+  s.version           = '0.1.1'
   s.platform          = Gem::Platform::RUBY
   s.summary           = 'Intelligently applies a maxlength attribute for text fields based on column constraints and validations'
   

data/lib/smart_field_constraints/extensions/form_helper.rb

@@ -42,8 +42,15 @@ module SmartFieldConstraints
         
         # Finds the maximum length according to column limits
         def column_limit
-          if column = object.class.columns_hash[method_name]
-            column.limit
+          column = object.class.columns_hash[method_name]
+          
+          if column && limit = column.limit
+            if column.text?
+              limit
+            elsif column.number?
+              # Length is bound by the upper limit of the number + 1 (for negatives)
+              Math.log10(2 ** (limit * 8 - 1)).ceil + 1
+            end
           end
         end
     end

data/test/app_root/db/migrate/001_create_users.rb

@@ -1,6 +1,7 @@
 class CreateUsers < ActiveRecord::Migration
   def self.up
-    create_table :users do |t|
+    create_table :users, :id => false do |t|
+      t.integer :id, :limit => 4, :null => false # For limit for testing purposes
       t.string :login, :limit => 12
       t.string :password, :limit => 16
       t.text :biography

data/test/helpers/form_helper_test.rb

@@ -57,7 +57,7 @@ class FormHelperWithValidationConstraintsTest < ActionView::TestCase
   end
 end
 
-class FormHelperWithColumnConstraintsTest < ActionView::TestCase
+class FormHelperWithStringColumnConstraintsTest < ActionView::TestCase
   tests ActionView::Helpers::FormHelper
   
   def setup
@@ -85,6 +85,18 @@ class FormHelperWithColumnConstraintsTest < ActionView::TestCase
   end
 end
 
+class FormHelperWithNumberColumnConstraintsTest < ActionView::TestCase
+  tests ActionView::Helpers::FormHelper
+  
+  def setup
+    @user = User.new
+  end
+  
+  def test_should_add_maxlength
+    assert_equal '<input id="user_id" maxlength="11" name="user[id]" size="30" type="text" />', text_field(:user, :id)
+  end
+end
+
 class FormHelperForModelNotTrackedTest < ActionView::TestCase
   tests ActionView::Helpers::FormHelper
   

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: smart_field_constraints
 version: !ruby/object:Gem::Version 
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors: 
 - Aaron Pfeifer
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2008-12-14 00:00:00 -05:00
+date: 2009-03-15 00:00:00 -04:00
 default_executable: 
 dependencies: []