smart_domain 0.1.0 → 0.1.2

data/lib/smart_domain/event/handler.rb

@@ -37,7 +37,7 @@ module SmartDomain
       # @param event [SmartDomain::Event::Base] Event to handle
       # @raise [NotImplementedError] If not implemented by subclass
       def handle(event)
-        raise NotImplementedError, "#{self.class.name} must implement #handle(event)"
+        raise NotImplementedError, 'Subclasses must implement #handle(event)'
       end
 
       # Check if this handler can handle a specific event type
@@ -48,7 +48,7 @@ module SmartDomain
       # @param event_type [String] Event type to check
       # @return [Boolean] True if handler can handle this event type
       def can_handle?(event_type)
-        raise NotImplementedError, "#{self.class.name} must implement #can_handle?(event_type)"
+        raise NotImplementedError, 'Subclasses must implement #can_handle?(event_type)'
       end
 
       # Handle event asynchronously using ActiveJob
@@ -58,12 +58,14 @@ module SmartDomain
       #
       # @param event [SmartDomain::Event::Base] Event to handle
       # @raise [RuntimeError] If ActiveJob is not loaded
+      # @raise [ValidationError] If event is invalid
       def handle_async(event)
         unless defined?(ActiveJob)
           raise "ActiveJob is required for async event handling. Please require 'active_job' in your application."
         end
 
-        event.validate!
+        raise ValidationError, "Event validation failed: #{event.errors.full_messages.join(', ')}" unless event.valid?
+
         HandlerJob.perform_later(self.class.name, event.to_h)
       end
     end

data/lib/smart_domain/event/mixins.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require "active_support/concern"
+require 'active_support/concern'
 
 module SmartDomain
   module Event
@@ -89,6 +89,14 @@ module SmartDomain
         attribute :changed_fields, default: -> { [] }
         attribute :old_values, default: -> { {} }
         attribute :new_values, default: -> { {} }
+
+        validate :changed_fields_must_not_be_empty
+
+        private
+
+        def changed_fields_must_not_be_empty
+          errors.add(:changed_fields, "can't be blank") if changed_fields.blank? || changed_fields.empty?
+        end
       end
 
       # Helper to extract changes from an ActiveRecord model
@@ -150,6 +158,8 @@ module SmartDomain
 
       included do
         attribute :reason, :string
+
+        validates :reason, presence: true
       end
     end
   end

data/lib/smart_domain/event/registration.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
-require_relative "../handlers/audit_handler"
-require_relative "../handlers/metrics_handler"
+require_relative '../handlers/audit_handler'
+require_relative '../handlers/metrics_handler'
 
 module SmartDomain
   module Event
@@ -86,8 +86,8 @@ module SmartDomain
         # Log what was registered
         if include_audit || include_metrics
           handlers_registered = []
-          handlers_registered << "audit" if include_audit
-          handlers_registered << "metrics" if include_metrics
+          handlers_registered << 'audit' if include_audit
+          handlers_registered << 'metrics' if include_metrics
 
           logger.info "[SmartDomain::Registration] Standard handlers registered for #{domain} domain: " \
                       "#{handlers_registered.join(', ')} (#{events.size} events)"

data/lib/smart_domain/generators/domain_generator.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 
 # Load the domain generator
-require_relative "../../generators/smart_domain/domain/domain_generator"
+require_relative '../../generators/smart_domain/domain/domain_generator'

data/lib/smart_domain/generators/install_generator.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 
 # Load the install generator
-require_relative "../../generators/smart_domain/install/install_generator"
+require_relative '../../generators/smart_domain/install/install_generator'

data/lib/smart_domain/handlers/audit_handler.rb

@@ -41,7 +41,7 @@ module SmartDomain
       # @param event_type [String] Event type to check
       # @return [Boolean] True if event belongs to this domain
       def can_handle?(event_type)
-        return true if @domain == "*"
+        return true if @domain == '*'
 
         event_type.start_with?("#{@domain}.")
       end
@@ -49,7 +49,7 @@ module SmartDomain
       # Handle audit logging for an event
       # @param event [SmartDomain::Event::Base] Event to audit
       def handle(event)
-        action = event.event_type.split(".").last
+        action = event.event_type.split('.').last
 
         # 1. Log to Rails logger (structured)
         log_audit_event(event, action)
@@ -117,17 +117,15 @@ module SmartDomain
         return unless defined?(AuditEvent)
 
         AuditEvent.create!(
-          event_type: event.event_type.upcase.tr(".", "_"),
-          event_category: map_event_category(event.event_type),
-          user_id: extract_actor_id(event),
+          event_id: event.event_id,
+          event_type: event.event_type,
+          aggregate_id: event.aggregate_id,
+          aggregate_type: event.aggregate_type,
           organization_id: event.organization_id,
-          ip_address: extract_ip_address(event),
-          user_agent: extract_user_agent(event),
-          old_values: extract_old_values(event),
-          new_values: extract_new_values(event),
-          occurred_at: event.occurred_at,
+          category: map_event_category(event.event_type),
           risk_level: assess_risk_level(event.event_type),
-          compliance_flags: build_compliance_flags(event)
+          event_data: event.to_h,
+          occurred_at: event.occurred_at
         )
       rescue StandardError => e
         @logger.warn "[SmartDomain::AuditHandler] Failed to write to audit table: #{e.message}"
@@ -138,14 +136,14 @@ module SmartDomain
       # @return [String] Audit category
       def map_event_category(event_type)
         case event_type
-        when /^auth\./
-          "authentication"
+        when /^auth\.|logged_in|logged_out|login|logout|authenticated|password/
+          'authentication'
         when /accessed|viewed|patient\./
-          "data_access"
+          'data_access'
         when /created|updated|deleted|assigned|removed/
-          "admin_action"
+          'admin_action'
         else
-          "system_event"
+          'system_event'
         end
       end
 
@@ -155,11 +153,11 @@ module SmartDomain
       def assess_risk_level(event_type)
         case event_type
         when /suspended|deleted|revoked|failed|rejected/
-          "HIGH"
+          'HIGH'
         when /updated|changed|assigned/
-          "MEDIUM"
+          'MEDIUM'
         else
-          "LOW"
+          'LOW'
         end
       end
 
@@ -167,35 +165,35 @@ module SmartDomain
       # @param event [SmartDomain::Event::Base] Event
       # @return [String, nil] Actor ID
       def extract_actor_id(event)
-        event.try(:actor_id) || event.attributes["actor_id"]
+        event.try(:actor_id) || event.attributes['actor_id']
       end
 
       # Extract ip_address from event (SecurityContextMixin)
       # @param event [SmartDomain::Event::Base] Event
       # @return [String, nil] IP address
       def extract_ip_address(event)
-        event.try(:ip_address) || event.attributes["ip_address"]
+        event.try(:ip_address) || event.attributes['ip_address']
       end
 
       # Extract user_agent from event (SecurityContextMixin)
       # @param event [SmartDomain::Event::Base] Event
       # @return [String, nil] User agent
       def extract_user_agent(event)
-        event.try(:user_agent) || event.attributes["user_agent"]
+        event.try(:user_agent) || event.attributes['user_agent']
       end
 
       # Extract old_values from event (ChangeTrackingMixin)
       # @param event [SmartDomain::Event::Base] Event
       # @return [Hash, nil] Old values
       def extract_old_values(event)
-        event.try(:old_values) || event.attributes["old_values"]
+        event.try(:old_values) || event.attributes['old_values']
       end
 
       # Extract new_values from event (ChangeTrackingMixin)
       # @param event [SmartDomain::Event::Base] Event
       # @return [Hash, nil] New values
       def extract_new_values(event)
-        event.try(:new_values) || event.attributes["new_values"]
+        event.try(:new_values) || event.attributes['new_values']
       end
 
       # Build compliance flags for audit record

data/lib/smart_domain/handlers/metrics_handler.rb

@@ -36,7 +36,7 @@ module SmartDomain
       # @param event_type [String] Event type to check
       # @return [Boolean] True if event belongs to this domain
       def can_handle?(event_type)
-        return true if @domain == "*"
+        return true if @domain == '*'
 
         event_type.start_with?("#{@domain}.")
       end
@@ -47,7 +47,14 @@ module SmartDomain
         metric_name = build_metric_name(event)
         tags = build_metric_tags(event)
 
+        # Emit counter metric
         emit_metric(metric_name, tags)
+
+        # Emit timing metric if duration is present
+        if event.respond_to?(:duration) && event.duration
+          timing_name = "#{metric_name}.duration"
+          emit_metric(timing_name, tags.merge(duration_ms: event.duration))
+        end
       rescue StandardError => e
         # Never fail on metrics handler errors
         @logger.warn "[SmartDomain::MetricsHandler] Metrics collection failed: #{e.message}"

data/lib/smart_domain/integration/active_record.rb

@@ -145,14 +145,12 @@ module SmartDomain
         return if @pending_domain_events.blank?
 
         @pending_domain_events.each do |event|
-          begin
-            SmartDomain::Event.bus.publish(event)
-          rescue StandardError => e
-            # Log error but don't raise (events should be fire-and-forget)
-            logger = defined?(Rails) ? Rails.logger : Logger.new($stdout)
-            logger.error "[SmartDomain] Failed to publish event: #{e.message}"
-            logger.error e.backtrace.join("\n")
-          end
+          SmartDomain::Event.bus.publish(event)
+        rescue StandardError => e
+          # Log error but don't raise (events should be fire-and-forget)
+          logger = defined?(Rails) ? Rails.logger : Logger.new($stdout)
+          logger.error "[SmartDomain] Failed to publish event: #{e.message}"
+          logger.error e.backtrace.join("\n")
         end
 
         clear_domain_events

data/lib/smart_domain/railtie.rb

@@ -12,8 +12,8 @@ module SmartDomain
 
     # Add generators to load path
     generators do
-      require_relative "generators/install_generator"
-      require_relative "generators/domain_generator"
+      require_relative 'generators/install_generator'
+      require_relative 'generators/domain_generator'
     end
 
     # Configuration hook
@@ -27,35 +27,35 @@ module SmartDomain
 
     # Rake tasks
     rake_tasks do
-      load "smart_domain/tasks/domains.rake"
+      load 'smart_domain/tasks/domains.rake'
     end
 
-    private
-
     # Load all domain setup files
     def self.load_domain_setups
-      setup_files = Dir[Rails.root.join("app/domains/**/setup.rb")]
+      setup_files = Dir[Rails.root.join('app/domains/**/setup.rb')]
 
       setup_files.each do |setup_file|
-        begin
-          require setup_file
-
-          # Extract domain module name from path
-          # e.g., app/domains/user_management/setup.rb -> UserManagement
-          domain_path = setup_file.gsub(Rails.root.join("app/domains/").to_s, "")
-          domain_name = domain_path.split("/").first.camelize
-
-          # Call setup! method if defined
-          domain_module = domain_name.constantize rescue nil
-          if domain_module && domain_module.respond_to?(:setup!)
-            domain_module.setup!
-            Rails.logger.info "[SmartDomain] Loaded domain: #{domain_name}"
-          end
-        rescue StandardError => e
-          Rails.logger.error "[SmartDomain] Failed to load domain setup: #{setup_file}"
-          Rails.logger.error e.message
-          Rails.logger.error e.backtrace.join("\n")
+        require setup_file
+
+        # Extract domain module name from path
+        # e.g., app/domains/user_management/setup.rb -> UserManagement
+        domain_path = setup_file.gsub(Rails.root.join('app/domains/').to_s, '')
+        domain_name = domain_path.split('/').first.camelize
+
+        # Call setup! method if defined
+        domain_module = begin
+          domain_name.constantize
+        rescue StandardError
+          nil
+        end
+        if domain_module.respond_to?(:setup!)
+          domain_module.setup!
+          Rails.logger.info "[SmartDomain] Loaded domain: #{domain_name}"
         end
+      rescue StandardError => e
+        Rails.logger.error "[SmartDomain] Failed to load domain setup: #{setup_file}"
+        Rails.logger.error e.message
+        Rails.logger.error e.backtrace.join("\n")
       end
     end
   end

data/lib/smart_domain/tasks/domains.rake

@@ -1,43 +1,47 @@
 # frozen_string_literal: true
 
 namespace :active_domain do
-  desc "List all registered domains"
+  desc 'List all registered domains'
   task domains: :environment do
-    setup_files = Dir[Rails.root.join("app/domains/**/setup.rb")]
+    setup_files = Dir[Rails.root.join('app/domains/**/setup.rb')]
 
     if setup_files.empty?
-      puts "No domains found in app/domains/"
-      puts "Generate your first domain with: rails generate active_domain:domain User"
+      puts 'No domains found in app/domains/'
+      puts 'Generate your first domain with: rails generate active_domain:domain User'
     else
-      puts "Registered domains:"
+      puts 'Registered domains:'
       setup_files.each do |setup_file|
-        domain_path = setup_file.gsub(Rails.root.join("app/domains/").to_s, "")
-        domain_name = domain_path.split("/").first
+        domain_path = setup_file.gsub(Rails.root.join('app/domains/').to_s, '')
+        domain_name = domain_path.split('/').first
         puts "  - #{domain_name}"
       end
       puts "\nTotal: #{setup_files.size} domain(s)"
     end
   end
 
-  desc "Reload all domain setups"
+  desc 'Reload all domain setups'
   task reload: :environment do
-    setup_files = Dir[Rails.root.join("app/domains/**/setup.rb")]
+    setup_files = Dir[Rails.root.join('app/domains/**/setup.rb')]
 
     puts "Reloading #{setup_files.size} domain(s)..."
 
     setup_files.each do |setup_file|
       load setup_file
 
-      domain_path = setup_file.gsub(Rails.root.join("app/domains/").to_s, "")
-      domain_name = domain_path.split("/").first.camelize
+      domain_path = setup_file.gsub(Rails.root.join('app/domains/').to_s, '')
+      domain_name = domain_path.split('/').first.camelize
 
-      domain_module = domain_name.constantize rescue nil
-      if domain_module && domain_module.respond_to?(:setup!)
+      domain_module = begin
+        domain_name.constantize
+      rescue StandardError
+        nil
+      end
+      if domain_module.respond_to?(:setup!)
         domain_module.setup!
         puts "  ✓ #{domain_name}"
       end
     end
 
-    puts "Done!"
+    puts 'Done!'
   end
 end

data/lib/smart_domain/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module SmartDomain
-  VERSION = "0.1.0"
+  VERSION = '0.1.2'
 end

data/lib/smart_domain.rb

@@ -1,38 +1,38 @@
 # frozen_string_literal: true
 
-require "active_model"
-require "active_support"
-require "active_support/core_ext"
-require "active_record"
-require "logger"
+require 'active_model'
+require 'active_support'
+require 'active_support/core_ext'
+require 'active_record'
+require 'logger'
 
-require_relative "smart_domain/version"
-require_relative "smart_domain/configuration"
+require_relative 'smart_domain/version'
+require_relative 'smart_domain/configuration'
 
 # Event system
-require_relative "smart_domain/event/base"
-require_relative "smart_domain/event/mixins"
-require_relative "smart_domain/event/handler"
-require_relative "smart_domain/event/adapters/memory"
+require_relative 'smart_domain/event/base'
+require_relative 'smart_domain/event/mixins'
+require_relative 'smart_domain/event/handler'
+require_relative 'smart_domain/event/adapters/memory'
 
 # Handlers
-require_relative "smart_domain/handlers/audit_handler"
-require_relative "smart_domain/handlers/metrics_handler"
+require_relative 'smart_domain/handlers/audit_handler'
+require_relative 'smart_domain/handlers/metrics_handler'
 
 # Event registration
-require_relative "smart_domain/event/registration"
+require_relative 'smart_domain/event/registration'
 
 # Domain patterns
-require_relative "smart_domain/domain/exceptions"
-require_relative "smart_domain/domain/policy"
-require_relative "smart_domain/domain/service"
+require_relative 'smart_domain/domain/exceptions'
+require_relative 'smart_domain/domain/policy'
+require_relative 'smart_domain/domain/service'
 
 # Rails integration
-require_relative "smart_domain/integration/active_record"
-require_relative "smart_domain/integration/multi_tenancy"
+require_relative 'smart_domain/integration/active_record'
+require_relative 'smart_domain/integration/multi_tenancy'
 
 # Railtie (loads automatically if Rails is present)
-require_relative "smart_domain/railtie" if defined?(Rails::Railtie)
+require_relative 'smart_domain/railtie' if defined?(Rails::Railtie)
 
 # SmartDomain - Domain-Driven Design and Event-Driven Architecture for Rails
 #

data/smart_domain.gemspec

@@ -1,14 +1,14 @@
 # frozen_string_literal: true
 
-require_relative "lib/smart_domain/version"
+require_relative 'lib/smart_domain/version'
 
 Gem::Specification.new do |spec|
-  spec.name = "smart_domain"
+  spec.name = 'smart_domain'
   spec.version = SmartDomain::VERSION
-  spec.authors = ["Rachid Al Maach"]
-  spec.email = ["rachid@qraft.nl"]
+  spec.authors = ['Rachid Al Maach']
+  spec.email = ['rachid@qraft.nl']
 
-  spec.summary = "Smart Domain-Driven Design and Event-Driven Architecture for Rails"
+  spec.summary = 'Smart Domain-Driven Design and Event-Driven Architecture for Rails'
   spec.description = <<~DESC
     SmartDomain brings battle-tested DDD/EDA patterns to Rails applications.
     Inspired by the Aeyes healthcare platform, it provides domain events,
@@ -16,13 +16,14 @@ Gem::Specification.new do |spec|
     Features 70% boilerplate reduction through intelligent event handling and
     AI-augmented development patterns.
   DESC
-  spec.homepage = "https://github.com/rachid/smart_domain"
-  spec.license = "MIT"
-  spec.required_ruby_version = ">= 3.0.0"
+  spec.homepage = 'https://github.com/rachid/smart_domain'
+  spec.license = 'MIT'
+  spec.required_ruby_version = '>= 3.0.0'
 
-  spec.metadata["homepage_uri"] = spec.homepage
-  spec.metadata["source_code_uri"] = "https://github.com/rachid/smart_domain"
-  spec.metadata["changelog_uri"] = "https://github.com/rachid/smart_domain/blob/main/CHANGELOG.md"
+  spec.metadata['homepage_uri'] = spec.homepage
+  spec.metadata['source_code_uri'] = 'https://github.com/rachid/smart_domain'
+  spec.metadata['changelog_uri'] = 'https://github.com/rachid/smart_domain/blob/main/CHANGELOG.md'
+  spec.metadata['rubygems_mfa_required'] = 'true'
 
   spec.files = Dir.chdir(__dir__) do
     `git ls-files -z`.split("\x0").reject do |f|
@@ -31,23 +32,23 @@ Gem::Specification.new do |spec|
     end
   end
 
-  spec.bindir = "exe"
+  spec.bindir = 'exe'
   spec.executables = spec.files.grep(%r{\Aexe/}) { |f| File.basename(f) }
-  spec.require_paths = ["lib"]
+  spec.require_paths = ['lib']
 
   # Core dependencies
-  spec.add_dependency "rails", ">= 7.0"
-  spec.add_dependency "activemodel", ">= 7.0"
-  spec.add_dependency "activesupport", ">= 7.0"
-  spec.add_dependency "activerecord", ">= 7.0"
+  spec.add_dependency 'activemodel', '>= 7.0'
+  spec.add_dependency 'activerecord', '>= 7.0'
+  spec.add_dependency 'activesupport', '>= 7.0'
+  spec.add_dependency 'rails', '>= 7.0'
 
   # Development dependencies
-  spec.add_development_dependency "rspec", "~> 3.12"
-  spec.add_development_dependency "rspec-rails", "~> 6.0"
-  spec.add_development_dependency "factory_bot_rails", "~> 6.2"
-  spec.add_development_dependency "faker", "~> 3.2"
-  spec.add_development_dependency "rubocop", "~> 1.50"
-  spec.add_development_dependency "rubocop-rails", "~> 2.19"
-  spec.add_development_dependency "rubocop-rspec", "~> 2.20"
-  spec.add_development_dependency "sqlite3", ">= 2.1"
+  spec.add_development_dependency 'factory_bot_rails', '~> 6.2'
+  spec.add_development_dependency 'faker', '~> 3.2'
+  spec.add_development_dependency 'rspec', '~> 3.12'
+  spec.add_development_dependency 'rspec-rails', '~> 6.0'
+  spec.add_development_dependency 'rubocop', '~> 1.50'
+  spec.add_development_dependency 'rubocop-rails', '~> 2.19'
+  spec.add_development_dependency 'rubocop-rspec', '~> 2.20'
+  spec.add_development_dependency 'sqlite3', '>= 2.1'
 end