smaak 0.1.6 → 0.1.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6176a9640dcdb10ed78ac51b33d272cfcce6b4a8
-  data.tar.gz: 0ccff319f89b625a988f4565a8d0d2bc9dc35d7f
+  metadata.gz: 01d73a7bae2454b5626a8a50fd7028c62cf071b0
+  data.tar.gz: e562fc1e85c951f86b4dedb8fbdcc9ebf17487c6
 SHA512:
-  metadata.gz: 00b783a3d6db9dceb9f353b7c889a5bf595f6158d2594d13b87ac1a9dfddb57f8bbf47c754d19fc7b8f7908cee78e971e6affb451ed7adfd5ee99081e8796c96
-  data.tar.gz: 706a6ad29291fd7327bce6b803fcd7bb20f61696f7121a899b9150c0a692b4b263cfba7248f951b9c00caf241644cc1b9acd4bd6a2dfb517b903eb2574efa1a1
+  metadata.gz: 4305d3436bea55aba4e63b131792edb6b6df5715a8537519703930f8774ceb74c878bdf5cb2a06345ad0e96f75879ebb7c40b49d368dab289219b2e05b90a910
+  data.tar.gz: a52f81b5f4a7b5dad3991bac7720c2af94cfffbf0bf791f101ca794f1cb5a78f96547158b9c06680920693276103d414f602cdbe2e68f58da4f68ea65052519e

data/README.md

@@ -12,6 +12,14 @@ The signing of an HTTP request and the placement of the signature in an Authoriz
 
 Smaak verifies an AuthMessage signed in the Authorization header by looking at nonce, expiry, recipient and pre-shared key. The order of headers signed is important for signature verification.
 
+### Requires
+
+In order for smaak to utilize adaptors and technology you choose, ensure to require the necessary libraries. For example:
+
+    require 'rack'
+    require 'net'
+    require 'net/http'
+
 ### Example Server
 
 A Smaak::Server operates on an instance of an HTTP request received. The Smaak module can be told about different request technology implementations by providing an adaptor to a request technology (Smaak::add_request_adaptor). The gem ships with a Rack::Request adaptor. Call Smaak::create_adaptor with your request to get an instance of an adaptor.

data/lib/smaak/auth_message.rb

@@ -61,7 +61,6 @@ module Smaak
     end
 
     def verify(psk)
-      return false if expired?
       return false if not psk_match?(psk)
       true
     end

data/lib/smaak/server.rb

@@ -39,15 +39,28 @@ module Smaak
     end
 
     def verify_auth_message(auth_message)
-      return false if not auth_message_unique?(auth_message)
-      return false if not auth_message.intended_for_recipient?(@key.export)
+      if not auth_message_unique?(auth_message)
+        puts "[smaak error]: message not unique"
+        return false
+      end
+      if not auth_message.intended_for_recipient?(@key.export)
+        puts "[smaak error]: message not unique"
+        return false
+      end
       identifier = auth_message.identifier
       if @association_store[identifier].nil?
-        puts "Unknown associate #{identifier}"
+        puts "[smaak error]: unknown associate #{identifier}"
+        return false
+      end
+      if auth_message.expired?
+        puts "[smaak error]: message expired. Are the sender and receiver's clocks in sync?"
         return false
       end
       psk = @association_store[identifier]['psk']
-      return false if not auth_message.verify(psk)
+      if not auth_message.verify(psk)
+        puts "[smaak error]: PSK mismatch"
+        return false
+      end
       true
     end
 

data/lib/smaak/version.rb

@@ -1,3 +1,3 @@
 module Smaak
-  VERSION = "0.1.6"
+  VERSION = "0.1.8"
 end

data/spec/lib/smaak/auth_message_spec.rb

@@ -132,11 +132,6 @@ describe Smaak::AuthMessage do
   end
 
   context "when asked to verify the message" do
-    it "should check message expiry and return false if the message has expired" do
-      expect(@iut).to(receive(:expired?)).and_return(true)
-      expect(@iut.verify(Smaak::Crypto::obfuscate_psk(@test_psk))).to eq(false)
-    end
-
     it "should try and match the PSK and return false if it cannot" do
       expect(@iut).to(receive(:psk_match?)).and_return(false)
       expect(@iut.verify(Smaak::Crypto::obfuscate_psk(@test_psk))).to eq(false)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: smaak
 version: !ruby/object:Gem::Version
-  version: 0.1.6
+  version: 0.1.8
 platform: ruby
 authors:
 - Ernst van Graan
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-06 00:00:00.000000000 Z
+date: 2015-07-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: persistent-cache