sluggi 1.2.0 → 1.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 96fa3f419d83aa9dd9df2699072fc12c8c3e786b45fcf8d19fe7adca90fd5438
-  data.tar.gz: 853a52b8ff87cb5833a56ca6d889f2cecce7d56763e6d5c9fed2b1a91a806368
+  metadata.gz: 8defbc5cc0371b0519aa658cafe635cca4fdde6dc72f0467d461dbece5626271
+  data.tar.gz: 8fd633be45bf0a35cc4853ea625c5368e219db60b60cca90f749fdf5ac7646e1
 SHA512:
-  metadata.gz: 4f135200b99655e4437f10e077355f84bdcbe5b474eb72148644a0b9b72fc43a3d3da38f78b6f45951a98fc41bbdf36d60a6b711c93767763ac4cf91937ad423
-  data.tar.gz: edd20ee1f9d8d63c3e3d6a21e1d51fb229b5bf35510d2b53b6029cdbbc2eedbfcc35cd4d70a25a701db9cdfbf0cd71256602af5d540af54eef5dcfd7944a0f99
+  metadata.gz: 6b49d66d863cdf218f9df93fe4d15e608148e2e77b7c280f62b56ea3e48d2abeb97a63b66a5058e65854f5c302c5dad04871586e4a98b415745cddc57402a208
+  data.tar.gz: 7d8dbae0fe73f1ecabcee3587364cfaa88cf65080fb20d4e4b172bf47c1f6d87bd6d5dd4d48c694577ef24077afc6f1bb7d014b5cf7d6cea36d6e2fbb6d9c24f

data/README.md

@@ -3,7 +3,7 @@
 [![Gem Version](http://img.shields.io/gem/v/sluggi.svg)](http://rubygems.org/gems/sluggi)
 [![Build Status](http://img.shields.io/travis/neighborland/sluggi.svg)](https://travis-ci.org/neighborland/sluggi)
 
-Sluggi is a simple [friendly_id](https://github.com/norman/friendly_id)-inspired slugging library for ActiveRecord models.
+Sluggi is a simple [friendly_id](https://github.com/norman/friendly_id)-inspired slugging library for ActiveRecord models. It is faster than `friendly_id` (see below for benchmarks).
 
 It provides basic slugs, slug history, and the ability to define multiple slug candidates.
 
@@ -129,20 +129,23 @@ Cat.find_by_slug('tuxedo-stan')
 
 ### Model with Slug Candidates
 
-Override `#slug_candidates` to define cascading candidate values for slugs. This is useful to avoid
-uniqueness conflicts.
+Override `#slug_candidates` to define cascading candidate values for slugs.
+This is useful to avoid uniqueness conflicts. Do not override `#slug_value` -
+the default implementation in `Model` will call `#slug_candidates` and
+works with or without `History`.
 
 ```ruby
 class Cat < ActiveRecord::Base
   include Sluggi::Slugged
 
-  def name_and_id
-    "#{name}-#{id}"
-  end
-
-  # the first unused value in the list is used
+  # The first unused value in the list is used.
+  # Each item may be a value or a lambda.
+  # Use a lambda to defer expensive unique value calculations.
   def slug_candidates
-    [name, name_and_id]
+    [
+      name,
+      -> { "#{name}-#{Cat.count}" }
+    ]
   end
 
   def slug_value_changed?
@@ -158,11 +161,41 @@ cat.slug
 
 cat_2 = Cat.create(name: 'Tuxedo Stan')
 cat_2.slug
-=> 'tuxedo-stan-2'
-cat_2.id
-=> 2
+=> 'tuxedo-stan-456'
+```
+
+## Performance
+
+Run the benchmark script: `ruby bench.rb`. This script is based on the
+benchmark script from `friendly_id`.
+
+Here are some anecdotal results using ruby 2.5.3:
 
 ```
+                                                  SLUGGI      FRIENDLY_ID
+1) find (id) - direct ActiveRecord                0.092318    0.093049
+2) find (in-table slug)                           0.102773    0.259542
+3) find (in-table slug; using finders module)     0.098183    0.108248
+4) find (external slug)                           0.670229    0.832791
+5) insert (plain AR / no slug)                    0.345077    0.345105
+6) insert (in-table-slug)                         0.666451    0.815505
+7) insert (in-table-slug; using finders module)   0.668737    0.744433
+8) insert (external slug)                         2.480790    2.849761
+```
+
+Notes:
+
+Sluggi is at least 10% faster in every benchmark.
+
+1) Baseline (does not use either gem)
+2) 0.44x
+3) 0.90x
+4) 0.80x
+5) Baseline (does not use either gem)
+6) 0.82x
+7) 0.90x
+8) 0.87x
+
 
 ## Alternatives
 

data/lib/sluggi/history.rb

@@ -39,11 +39,10 @@ module Sluggi
     end
 
     def create_slug
-      value = clean_slug(slug_value)
-      return if value.blank?
-      return if slugs.first&.slug == value
-      self.class.find_slugs(value).delete_all # revert to previous slug & put first
-      slugs.create(slug: value)
+      return if slug.blank?
+      return if slugs.first&.slug == slug
+      self.class.find_slugs(slug).delete_all # revert to previous slug & put first
+      slugs.create(slug: slug)
     end
   end
 end

data/lib/sluggi/model.rb

@@ -11,6 +11,13 @@ module Sluggi
       before_validation :set_slug
     end
 
+    module ClassMethods
+      # Define this so that History can override it.
+      def slug_exists?(name)
+        exists?(slug: name)
+      end
+    end
+
     def to_param
       errors.any? ? slug_was : slug
     end
@@ -31,11 +38,12 @@ module Sluggi
     # these are generally good to override:
 
     def slug_value
-      slug_candidates.each do |value|
+      slug_candidates.each do |item|
+        value = item.respond_to?(:call) ? item.call : item
         next if value.blank?
         candidate = clean_slug(value)
         return candidate if candidate == slug
-        return candidate unless self.class.exists?(slug: candidate)
+        return candidate unless self.class.slug_exists?(candidate)
       end
       nil
     end

data/lib/sluggi/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Sluggi
-  VERSION = "1.2.0"
+  VERSION = "1.3.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sluggi
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.3.0
 platform: ruby
 authors:
 - Tee Parham
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-11-21 00:00:00.000000000 Z
+date: 2018-11-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord