slkecho 1.2.0 → 1.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6d32f248314a8ecc59325cf6cb2092a53ef4bfed9e9866ad46c0ad09076e79d2
-  data.tar.gz: 377be48a2826d3a0df573127cb06add79bb25a0a31fb4c152a7eb709faee127c
+  metadata.gz: '06487abc9f5c53432e2d6e93f0db427338c44d34c51e766b4bb9aa4b45c20e07'
+  data.tar.gz: f6e04c8fd4433d136d5d8262862d213a3aa8a1181d7fc03c8744cd20fe9b34cf
 SHA512:
-  metadata.gz: 3aa071ad29e150bcb983f3c674ba6aaccda853fc8ff65fe93395a92e86e7e4190e39f5dcfcad9f88019b74986ccd2bba41556ee5a5b5f8a3d720686e072f12bb
-  data.tar.gz: 6293abc9ec4d005d50fa5fdc1672e6e981713957ee3a9548ef86d9c2c0a4d2a9c4c8a1f2da06d19738ddad31613f9345159321df5dd59088cd65c3d17eb056cf
+  metadata.gz: 96d474087c4760de85be2bd90a6d3f144a24505396b7a6a5eaedc357fd1f010ec4164234202d620ccd3f5f30d75be3f4d69c8a907df578950919f1fa2f48d386
+  data.tar.gz: 8a27c49d64315fa4652c12a1736a350c3a31e68c305309ef6e4d4ebec8cdb6edf343dd32a75af5ae6e63fac6ef76d528a44bd5549fa83d310a62c21486c1cb1f

data/CHANGELOG.md

@@ -1,5 +1,17 @@
 ## [Unreleased]
 
+## [v1.3.0] - 2024-01-08
+
+- chore: Improved description of username option
+- feat: Add --icon-url option
+- refactor: Remove `Slkecho::Options` initialize method
+- refactor: Summarize arguments of `Slkecho::SlackRequest::PostMessage#request` to params
+- refactor: Summarize arguments of `Slkecho::SlackClient#post_message` to params
+
+## [v1.2.1] - 2024-01-08
+
+- fix: Not implemented to username specified
+
 ## [v1.2.0] - 2024-01-08
 
 - feat: Add --username option

data/lib/slkecho/cli.rb

@@ -16,12 +16,7 @@ module Slkecho
 
       user_id = mention_to_user_id(options.mention)
 
-      @slack_client.post_message(
-        channel: options.channel,
-        message: options.message,
-        subject: options.subject,
-        user_id: user_id
-      )
+      @slack_client.post_message(post_message_params_from(options, user_id))
     end
 
     def mention_to_user_id(mention)
@@ -34,6 +29,17 @@ module Slkecho
       user["id"]
     end
 
+    def post_message_params_from(options, user_id)
+      Slkecho::SlackClient::PostMessageParams.new(
+        channel: options.channel,
+        message: options.message,
+        subject: options.subject,
+        user_id: user_id,
+        username: options.username,
+        icon_url: options.icon_url
+      )
+    end
+
     def self.run(argv)
       cli = new(
         option_parser: Slkecho::OptionParser.new,

data/lib/slkecho/option_parser.rb

@@ -2,7 +2,7 @@
 
 module Slkecho
   class OptionParser
-    def option_parser
+    def option_parser # rubocop:disable Metrics/AbcSize
       @option_parser ||= ::OptionParser.new do |o|
         o.banner = "Usage: slkecho [options] message"
         o.program_name = "slkecho"
@@ -10,7 +10,8 @@ module Slkecho
         o.on("-c", "--channel CHANNEL", "Slack channel to post the message") { @options.channel = _1 }
         o.on("-s", "--subject SUBJECT", "Subject of message") { @options.subject = _1 }
         o.on("-m", "--mention EMAIL", "Mention to user by email") { @options.mention = _1 }
-        o.on("--username USERNAME", "Username to post the message") { @options.username = _1 }
+        o.on("--username USERNAME", "Set your bot's user name") { @options.username = _1 }
+        o.on("--icon-url ICON_URL", "URL to an image to use as the icon for this message") { @options.icon_url = _1 }
       end
     end
 

data/lib/slkecho/options.rb

@@ -2,14 +2,6 @@
 
 module Slkecho
   class Options
-    attr_accessor :channel, :subject, :mention, :message, :username
-
-    def initialize(channel: nil, subject: nil, mention: nil, message: nil, username: nil)
-      @channel = channel
-      @subject = subject
-      @mention = mention
-      @message = message
-      @username = username
-    end
+    attr_accessor :channel, :subject, :mention, :message, :username, :icon_url
   end
 end

data/lib/slkecho/slack_client.rb

@@ -9,6 +9,8 @@ require_relative "slack_request/post_message"
 
 module Slkecho
   class SlackClient
+    PostMessageParams = Slkecho::SlackRequest::PostMessage::Params
+
     def initialize(slack_api_token:)
       @slack_api_token = slack_api_token
 
@@ -26,9 +28,9 @@ module Slkecho
                                               .request(email: email)
     end
 
-    def post_message(channel:, message:, subject: nil, user_id: nil)
+    def post_message(params)
       Slkecho::SlackRequest::PostMessage.new(slack_api_token: @slack_api_token)
-                                        .request(channel: channel, message: message, subject: subject, user_id: user_id)
+                                        .request(params)
     end
   end
 end

data/lib/slkecho/slack_request/post_message.rb

@@ -3,6 +3,8 @@
 module Slkecho
   module SlackRequest
     class PostMessage
+      Params = Struct.new(:channel, :message, :subject, :user_id, :username, :icon_url, keyword_init: true)
+
       def initialize(slack_api_token:)
         @slack_api_token = slack_api_token
 
@@ -15,10 +17,10 @@ module Slkecho
         }
       end
 
-      def request(channel:, message:, subject: nil, user_id: nil)
+      def request(params)
         response = @http.post(
           @uri.path,
-          request_body(channel: channel, message: message, subject: subject, user_id: user_id).to_json,
+          request_body(params).to_json,
           @headers
         )
         raise Slkecho::SlackRequestError, response.body unless response.is_a?(Net::HTTPSuccess)
@@ -29,14 +31,15 @@ module Slkecho
         true
       end
 
-      def request_body(channel:, message:, subject: nil, user_id: nil, username: nil)
+      def request_body(params)
         body = {
-          "channel" => channel,
+          "channel" => params.channel,
           "blocks" => [],
-          "username" => username
+          "username" => params.username,
+          "icon_url" => params.icon_url
         }
-        body["blocks"] << header_block(subject) unless subject.nil?
-        body["blocks"] << section_block(message, user_id: user_id)
+        body["blocks"] << header_block(params.subject) unless params.subject.nil?
+        body["blocks"] << section_block(params.message, user_id: params.user_id)
 
         body
       end

data/lib/slkecho/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Slkecho
-  VERSION = "1.2.0"
+  VERSION = "1.3.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: slkecho
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.3.0
 platform: ruby
 authors:
 - okonomi