slim-attributes 0.6.4 → 0.6.6

data/README

@@ -11,14 +11,12 @@ Measuring with just ActiveRecord code - fetching stuff from the database - we se
 Installation
 ============
 
-Slim attributes works with ruby 1.8.6+ and 1.9.1+.
-
-You're going to need the mysql headers for this to work.
+Slim attributes works with ruby 1.8.x.  Ruby 1.9 support exists, but a bug in rails prevents it working (see Bugs for further info).
 
 Try:
-gem install slim-attributes -- --with-mysql-config
+sudo gem install slim-attributes
 or:
-gem install slim-attributes
+sudo gem install slim-attributes -- --with-mysql-config
 
 then add this to environment.rb:
 require 'slim_attributes'
@@ -38,10 +36,19 @@ So this is an alternative implementation of all_hashes that returns a 'fake hash
 The field contents are then instantiated into Ruby strings on demand - ruby strings are only made if you need them.  Note that if you always look at all the columns when you fetch data from the database then this won't necessarily be faster that the unpatched mysql adapter.  But it won't be much slower either, and we do expect that most times not all the columns from a result set are accessed.
 
 
-===========
+Bugs
+====
+
+Slim attributes will not work correctly with rails and ruby 1.9.1 until Rails 2.3.5 is released due to this ticket:
+https://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/3156-mysql_adapterrb-redefines-all_hashes-multiple-times-under-ruby-19
+
+
+Warranty
+========
 
-No warranty - this gem has been tested, but not in all environments.  However, that said, we are using it in our production environment with good results.
-Please report bugs to sdsykes at symbol gmail pip com.
+No warranty - this gem has been extensively tested, but not in all environments.  
+We are using it in our production environment with very good results.
+Please report bugs to sdsykes at symbol gmail pip com or via the github issue tracking system.
 
 
 Credits

data/Rakefile

@@ -13,6 +13,7 @@ begin
     s.files = FileList["[A-Z]*", "{ext,lib,test}/**/*"]
     s.extensions = "ext/extconf.rb"
   end
+  Jeweler::GemcutterTasks.new
 rescue LoadError
   puts "Jeweler not available. Install it with: sudo gem install technicalpickles-jeweler -s http://
 gems.github.com"

data/VERSION.yml

@@ -1,4 +1,4 @@
 --- 
-:patch: 4
 :major: 0
 :minor: 6
+:patch: 6

data/ext/extconf.rb

@@ -1,12 +1,27 @@
-# this code is borrowed from Mysql/Ruby, credit to TOMITA Masahiro
+# this code was originally borrowed from Mysql/Ruby, credit to TOMITA Masahiro
 # it works for me under OS X and Fedora, hope it works for you also
 
 require 'mkmf'
 
+# Improved detection of mysql_config
+# Code from DataObjects do_mysql adapter
+# All instances of mysql_config on PATH ...
+def mysql_config_paths
+  ENV['PATH'].split(File::PATH_SEPARATOR).collect do |path|
+    [ "#{path}/mysql_config", "#{path}/mysql_config5" ].
+      detect { |bin| File.exist?(bin) }
+  end
+end
+
+# The first mysql_config binary on PATH ...
+def default_mysql_config_path
+  mysql_config_paths.compact.first
+end
+
 if /mswin32/ =~ RUBY_PLATFORM
   inc, lib = dir_config('mysql')
   exit 1 unless have_library("libmysql")
-elsif mc = with_config('mysql-config') then
+elsif mc = with_config('mysql-config', default_mysql_config_path) then
   mc = 'mysql_config' if mc == true
   cflags = `#{mc} --cflags`.chomp
   exit 1 if $? != 0

data/test/slim_attributes_test.rb

@@ -4,7 +4,7 @@
 require 'rubygems'
 require 'active_record'
 require 'active_record/version'
-require 'slim_attributes'
+require File.dirname(__FILE__) + '/../lib/slim_attributes'
 require 'test/unit'
 require File.dirname(__FILE__) + "/products"
 require File.dirname(__FILE__) + "/slim_db_test_utils"
@@ -16,6 +16,11 @@ class SlimAttributesTest < Test::Unit::TestCase
     Product.make_some_products
   end
 
+  def test_slim_attributes_is_proxying_results
+    x = Product.find(:first)
+    assert_equal Mysql::Result::RowHash, x.instance_variable_get(:@attributes).class
+  end
+
   def test_finds_all
     items = Product.find(:all)
     assert items.size == 100, "must find all 100 items"
@@ -138,8 +143,11 @@ class SlimAttributesTest < Test::Unit::TestCase
       item1.name = "bar"
       assert_equal "product_0", item3.name, "name must be original from cached query"
       item2.name << "_test"
-# unmodified rails fails this test, it's ok
-#      check_attributes_for(item3, 0)
+# unmodified rails fails this test because the attributes are not dupped, only the
+# hash containing them is
+# but this test is useful - it shows that the rowhash has not been made
+# into a real hash before dup in called in the query cache code
+      check_attributes_for(item3, 0)
     end
   end
   

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: slim-attributes
 version: !ruby/object:Gem::Version 
-  version: 0.6.4
+  version: 0.6.6
 platform: ruby
 authors: 
 - Stephen Sykes
@@ -9,11 +9,13 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-07-12 00:00:00 +03:00
+date: 2009-10-10 00:00:00 +03:00
 default_executable: 
 dependencies: []
 
-description: Slim attributes boosts speed in Rails/Mysql ActiveRecord Models by avoiding instantiating Hashes for each result row, and lazily instantiating attributes as needed.
+description: |-
+  Slim attributes boosts speed in Rails/Mysql ActiveRecord Models by avoiding
+      instantiating Hashes for each result row, and lazily instantiating attributes as needed.
 email: sdsykes@gmail.com
 executables: []
 
@@ -23,8 +25,8 @@ extra_rdoc_files:
 - README
 files: 
 - MIT_LICENCE
-- Rakefile
 - README
+- Rakefile
 - VERSION.yml
 - ext/extconf.rb
 - ext/slim_attrib_ext.c
@@ -36,9 +38,10 @@ files:
 - test/slim_db_test_utils.rb
 has_rdoc: true
 homepage: http://github.com/sdsykes/slim-attributes
+licenses: []
+
 post_install_message: 
 rdoc_options: 
-- --inline-source
 - --charset=UTF-8
 require_paths: 
 - lib
@@ -57,9 +60,12 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.3.1
+rubygems_version: 1.3.5
 signing_key: 
-specification_version: 2
+specification_version: 3
 summary: Slim-attributes - lazy instantiation of attributes for ActiveRecord
-test_files: []
-
+test_files: 
+- test/benchmark.rb
+- test/products.rb
+- test/slim_attributes_test.rb
+- test/slim_db_test_utils.rb