slacken 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 25a6903ad8c0859f0fd8140f05528957baf272aa
-  data.tar.gz: e251a3b49123a5fc4b04d20e07067bdacca79feb
+  metadata.gz: 748574f85629230126187b4628430c5d8831f491
+  data.tar.gz: 8dfea56b37ed82aac7597ce7fd33fe3ed87b98dc
 SHA512:
-  metadata.gz: f603ab28cf2342146a68b18c0b154a8d776036494ff4cbb687ea52fce82745f8eb1091acb1bdb933f73be31d785ca4d30a5c855d5ff285a1ec77a1e50b41457e
-  data.tar.gz: 188a11057e56f4afb82720fb281e14948449da79a86ae948eb00a1faf7641126505274ab6595e516baa5c80a8b5a47f1aa776ea58919b37f6e97436ce0ac2135
+  metadata.gz: 4fbccd9ac94194719631dff4cef4d5ed07fecad897b6b55169162a0bb828c5d3b3ab1947595eb223f74d0c8283f4ed91f36ec9f1cca2a42dd7b6b489b9059f60
+  data.tar.gz: c5f1cf5dca2d0c5fb4cc24055a02a94101e3b46d8ed76652ab0c9605594a0ae1cccf1d95041cef1cc74bc5175291e209ef23bfd4c3dd28716442aa5edec0ad3f

data/lib/slacken/table_element.rb

@@ -2,22 +2,33 @@ require 'kosi'
 
 module Slacken
   class TableElement
-    attr_reader :header, :columns
     def initialize(children)
-      thead, tbody = children.slice(0, 2)
-      @header = thead.child # tr tag
-      @columns = tbody.children # tr tags
+      if children.first.type.name == :thead
+        thead, tbody = children.slice(0, 2)
+        @header = thead.child # tr tag
+        @columns = tbody.children # tr tags
+      else
+        @header = nil
+        @columns = children
+      end
     end
 
     def render
-      head = header.children.map(&:to_s)
-      body = columns.map { |cl| cl.children.map(&:to_s) }
-      table = Kosi::Table.new(header: head).render(body)
-      table.to_s.chomp
+      Kosi::Table.new(table_head).render(table_body).to_s.chomp
     end
 
     def to_s
       render
     end
+
+    private
+
+    def table_head
+      @header ? { header: @header.children.map(&:to_s) } : {}
+    end
+
+    def table_body
+      @columns.map { |column| column.children.map(&:to_s) }
+    end
   end
 end

data/lib/slacken/version.rb

@@ -1,3 +1,3 @@
 module Slacken
-  VERSION = "0.1.2"
+  VERSION = "0.1.3"
 end

data/spec/slacken_spec.rb

@@ -269,6 +269,36 @@ describe Slacken do
       end
     end
 
+    context 'when table without thead is given' do
+      let(:source) do
+        <<-EOS.unindent
+          <table>
+          <tr>
+          <td>Without</td>
+          </tr>
+          <tr>
+          <td>thead</td>
+          </tr>
+          </table>
+        EOS
+      end
+
+      it 'converts html to table notation' do
+        should eq <<-EOS.unindent.chomp
+          +-------+
+          |Without|
+          |thead  |
+          +-------+
+        EOS
+      end
+    end
+
+    context 'when empty table is given' do
+      let(:source) { '<table></table>' }
+
+      it { should eq '' }
+    end
+
     context 'when img is given' do
       let(:source) { "<p><img src='#{src}' alt='#{alt}'></p>" }
       let(:src) { 'http://cdn.qiita.com/logo.png' }

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: slacken
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Tomoya Chiba