slack_page_speed 0.0.8 → 0.0.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e471a023a7b3da86129fb1778186644208c0174e
-  data.tar.gz: b8b8233436752ed9bb85d1c2ce27f795ea1e4782
+  metadata.gz: a1f2ee944b27870c04b4c53165b2be99bebc37ab
+  data.tar.gz: 9044bc0f9b50ba3224915bc1cca55ff906a3c0df
 SHA512:
-  metadata.gz: ee04bfebdb8aaa77d94e04c7535a2f4003d77094dc5e62c97743705192520cd86b4dc08b8d27d5c16028d1a4b6afdad355f2545a86dfc54281cab273658e9f11
-  data.tar.gz: f418d704cb4f9903728705a1b2b3fdfbdf7e6bd89ff3f7855e78c7837c66e0eac4ce8e71835a7eab67644b1d0006b88464ae8c025ee57c5f2dee29b43d614c49
+  metadata.gz: 01e423e75ef8941ff47322902900710c4b7bd470fc3c0a54828526c6c95d4e55e469e92d3671a6a0c09ed05a17cc7a2f339ebc56307636092f293db93c0106dd
+  data.tar.gz: 7fb328d2e6701dfed3d2041bbab6d2ab98a4bbb9b3171217279c1779e54d6b56b1607a1507b1e10a46de99a85220afc67d1b207423acb4fdafc4df3b7b7c3e96

data/lib/slack_page_speed.rb

@@ -22,43 +22,19 @@ class SlackPageSpeed
     @message              = configuration_info['include_timestamp'] ? "Page performance scores for #{Date.today.strftime('%d/%m/%Y')}. \n" : ''
     @threshold            = configuration_info['threshold'].to_i
     @results              = {}
-# @page_list            = %w(
-#   credit-cards/
-#   life-insurance/
-#   energy/
-#   home-insurance/
-#   travel-insurance/
-#   car-insurance/
-#   Homepage
-# )
     @page_list            = configuration_info['page_list']
+    @logging              = configuration_info['logging']
 
-# @run_results = [{}, {}, {}]
-    @run_results          = [{}]
+    @run_results = [{}, {}, {}]
     @page_list.each do |page|
       search_string  = page.gsub('-', '+').gsub('/', '')
-      search_string  = search_string + '+switch' if page == 'energy/'
-      search_string  = 'compare+the+market' if page == 'Homepage'
       @results[page] = { search_string: search_string }
       @run_results.each do |run_result|
         run_result[page] = { search_string: search_string }
       end
     end
 
-# Gets google page rank
-    def get_gpr(page, search_string, iteration)
-      puts page
-      response = JSON.parse(HTTParty.get("https://www.googleapis.com/customsearch/v1element?key=#{@pagespeed_api_key}&rsz=filtered_cse&num=10&hl=en&prettyPrint=false&source=gcsc&gss=.com&q=#{search_string}&sort=&googlehost=www.google.co.uk&oq=#{search_string}&gs_l=partner.12...31030.31885.0.34635.7.7.0.0.0.0.73.428.7.7.0.gsnos%2Cn%3D13...0.864j151518j7..1ac.1.25.partner..7.0.0.-WiGDitO8Y8&callback=google.search.Search.apiary19818&nocache=1502961217931").body.chomp[49..-3])
-      begin
-        @run_results[iteration][page][:rank] = response['results'].index { |result_property| result_property['url'].include? 'comparethemarket.com' } + 1
-      rescue NoMethodError => e
-        puts "Not on the front page of Google results for '#{page}'.\nResults were: \n"
-        response['results'].each { |result| puts result['url'] }
-        raise e
-      end
-    end
-
-# Gets google pagespeed score for a 'page'
+    # Gets google pagespeed score for a 'page'
     def get_gps_score(page, strategy, iteration)
       response = HTTParty.get("https://www.googleapis.com/pagespeedonline/v2/runPagespeed?url=#{@domain + page.gsub('Homepage', '') + '?src=TSTT'}&strategy=#{strategy}&key=#{@pagespeed_api_key}")
       unless response.response.code == '200' && JSON.parse(response.body)['responseCode'] != '400'
@@ -69,14 +45,14 @@ class SlackPageSpeed
       @run_results[iteration][page][strategy.to_sym] = score
     end
 
-# runs a new WebPageTest test based on the url supplied
+    # runs a new WebPageTest test based on the url supplied
     def start_wpt_test(page, iteration)
       response = HTTParty.get("http://www.webpagetest.org/runtest.php?url=#{@domain + page.gsub('Homepage', '') + '?src=TSTT'}&location=Dulles.3G&f=json&fvonly=1&k=#{@webpagetest_api_key}")
       raise "Couldn't get WebPageTest score for #{page}" unless response.response.code == '200'
       @run_results[iteration][page][:results_url] = JSON.parse(response.body)['data']['jsonUrl']
     end
 
-# waits until the status of the run at 'results_url' is 200 (test finished)
+    # waits until the status of the run at 'results_url' is 200 (test finished)
     def wait_for_wpt_results(page, result_url, iteration)
       361.times do
         @response = HTTParty.get(result_url)
@@ -87,7 +63,7 @@ class SlackPageSpeed
       @run_results[iteration][page][:speed_index] = (JSON.parse(@response.body)['data']['runs']['1']['firstView']['SpeedIndex'].to_f / 1000).round(2)
     end
 
-# Send a slack message with all the scores
+    # Send a slack message with all the scores
     def slack_notify(message)
       HTTParty.post(@slack_post_url,
                     body:    { 'channel': "##{@slack_channel}", 'icon_emoji': @slack_bot_emoji, 'username': @slack_username, 'text': message }.to_json,
@@ -138,7 +114,6 @@ class SlackPageSpeed
     @page_list.each do |page|
       @run_results.length.times do |iteration|
         start_wpt_test(page, iteration)
-        # get_gpr(page, @results[page][:search_string], iteration)
       end
     end
 
@@ -156,27 +131,24 @@ class SlackPageSpeed
       end
 
       # Reset the temporary results array
-      # @results[page][:rank]        = []
       @results[page][:speed_index] = []
       @results[page][:desktop]     = []
       @results[page][:mobile]      = []
 
       # Add all results to an array of results for each numerical result type
       @run_results.each do |result|
-        # @results[page][:rank].push(result[page][:rank])
         @results[page][:speed_index].push(result[page][:speed_index])
         @results[page][:desktop].push(result[page][:desktop])
         @results[page][:mobile].push(result[page][:mobile])
       end
 
       # Calculate the mean speed, desktop and mobile scores, and the mode search ranking
-      # @results[page][:rank]        = @results[page][:rank].max_by { |i| @results[page][:rank].count(i) }
       @results[page][:desktop]     = @results[page][:desktop].max_by { |i| @results[page][:desktop].count(i) }
       @results[page][:mobile]      = @results[page][:mobile].max_by { |i| @results[page][:mobile].count(i) }
       @results[page][:speed_index] = (@results[page][:speed_index].inject(:+)/@run_results.length).round(2)
 
       # Build the slack message
-      puts @results if ENV['logging'] == 'true'
+      puts @results if @logging
       @message += "\n*" + page + ':*'
       @message += "\n     desktop score: " + @results[page][:desktop].to_s
       @message += get_old_score(@results[page][:desktop], page, :desktop)
@@ -184,22 +156,20 @@ class SlackPageSpeed
       @message += get_old_score(@results[page][:mobile], page, :mobile)
       @message += "\n     SpeedIndex: " + @results[page][:speed_index].to_s
       @message += get_old_score(@results[page][:speed_index].to_f, page, :speed_index) + "\n"
-      # @message += "\n     Google Search Rank: " + @results[page][:rank].to_s
-      # @message += get_old_score(@results[page][:rank].to_f, page, :rank) + "\n"
     end
 
-# Add an '@here' to the slack notification if any score has regressed
+    # Add an '@here' to the slack notification if any score has regressed
     @message += ' <!here> Something is worse than last time!' if @message.include?(@regression_emoji)
     puts @message
     slack_notify(@message)
-# Create the scores history file if this is the first run
+    # Create the scores history file if this is the first run
     File.new(@history_file, 'w') unless File.exist?(@history_file)
     write_new_scores
   end
 
   def configure
     config_file = File.open('configuration.yml', 'w+')
-    config_file.write("""---
+    config_file.write("" "---
 ##############
 ## Required ##
 ##############
@@ -221,6 +191,7 @@ improvement_emoji: ':racehorse:'
 minimal_change_emoji: ':no_mouth:'
 regression_emoji: ':no-entry:'
 include_timestamp: true
-threshold: '2'""")
+threshold: '2'
+logging: true" "")
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: slack_page_speed
 version: !ruby/object:Gem::Version
-  version: 0.0.8
+  version: 0.0.9
 platform: ruby
 authors:
 - Abi Travers, Andy Barnett, Dan Clissold, Tom Dane