slack_messaging 3.1.0 → 3.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b90f38dcdaf24ec98961f9cf3311570daf0087c1308b63483762d158f04161f7
-  data.tar.gz: 5e8fdef06dd5285ff63d922ca7e1b8e18eef0149104e26a155d8d1bb5916576e
+  metadata.gz: 12ec2e4beafc03f085a3a1752070bce7e030cd02e1e57378229400f39a2284ee
+  data.tar.gz: f6c4e26dcb8799058f144e24aee9ddf1d4f2f05c0b91deba9f19d5cd1d414303
 SHA512:
-  metadata.gz: 2461540b052fc9a790da9e2e11da01b496d08260db928c61c7e11dcd67add9a75e15feab6f03f8dcb029807db6f6205a3fa517d358bc629f606732bed3397b7f
-  data.tar.gz: 17dcb6ba4aa5f6c98d29611c3e08bb05080aa009c66de4e97ded5194fb31dd3296d4bae091ec9eedc59f142e8d4d862c1d28809a705a0f5282652c1f4f6b049c
+  metadata.gz: c3dff63c5569a13e0a713b2e34ca6ef7f22a7ce858523bee5a8483b59b8c17d7053302e3a0f25a670b2ff3ce794f8bd1aef25500e2766594e51b2f35d12ad8ea
+  data.tar.gz: 41dc15d6314e4ae1721b2e26163b1e4d6f006f9c7ae6ed93d5ff394b29e98f6399e16f604515eefa54663cb6328356fd31843d6da5228bdf92173889b0380c98

data/Gemfile.lock

@@ -5,7 +5,7 @@ PATH
       activesupport (~> 6.0)
       gli (~> 2.10)
       hashie (~> 4.1)
-      highline_wrapper (~> 0.1.0)
+      highline_wrapper (~> 1.0)
       httparty (~> 0.18)
       json (~> 2.5)
       rack (~> 2.2)
@@ -13,7 +13,7 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (6.1.2.1)
+    activesupport (6.1.3)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (>= 1.6, < 2)
       minitest (>= 5.1)
@@ -23,11 +23,11 @@ GEM
     coderay (1.1.3)
     concurrent-ruby (1.1.8)
     diff-lcs (1.4.4)
-    faker (2.15.1)
+    faker (2.16.0)
       i18n (>= 1.6, < 2)
     ffi (1.14.2)
     formatador (0.2.5)
-    gli (2.19.2)
+    gli (2.20.0)
     guard (2.16.2)
       formatador (>= 0.2.4)
       listen (>= 2.7, < 4.0)
@@ -44,12 +44,12 @@ GEM
       rspec (>= 2.99.0, < 4.0)
     hashie (4.1.0)
     highline (2.0.3)
-    highline_wrapper (0.1.0)
+    highline_wrapper (1.0.0)
       highline (~> 2.0)
     httparty (0.18.1)
       mime-types (~> 3.0)
       multi_xml (>= 0.5.2)
-    i18n (1.8.8)
+    i18n (1.8.9)
       concurrent-ruby (~> 1.0)
     json (2.5.1)
     listen (3.4.1)
@@ -59,8 +59,8 @@ GEM
     method_source (1.0.0)
     mime-types (3.3.1)
       mime-types-data (~> 3.2015)
-    mime-types-data (3.2020.1104)
-    minitest (5.14.3)
+    mime-types-data (3.2021.0225)
+    minitest (5.14.4)
     multi_xml (0.6.0)
     nenv (0.3.0)
     notiffany (0.1.3)
@@ -93,7 +93,7 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.10.0)
     rspec-support (3.10.2)
-    rubocop (1.10.0)
+    rubocop (1.11.0)
       parallel (~> 1.10)
       parser (>= 3.0.0.0)
       rainbow (>= 2.2.2, < 4.0)
@@ -113,7 +113,7 @@ GEM
     zeitwerk (2.4.2)
 
 PLATFORMS
-  x86_64-darwin-19
+  x86_64-darwin-20
 
 DEPENDENCIES
   bundler (~> 2.2)
@@ -126,4 +126,4 @@ DEPENDENCIES
   slack_messaging!
 
 BUNDLED WITH
-   2.2.9
+   2.2.4

data/README.md

@@ -86,7 +86,7 @@ I hope you enjoy printing fun and specialized messages to Slack!
 
 ### Tests
 
-To run the tests, run `bundle exec rspec` from the command line. GitHub Actions will also run the tests upon every commit to make sure they're up to date and that everything is working correctly. Locally, you can also run `bundle exec guard` to automatically run tests as you develop!
+To run the tests, run `bundle exec rspec` from the command-line. GitHub Actions will also run the tests upon every commit to make sure they're up to date and that everything is working correctly. Locally, you can also run `bundle exec guard` to automatically run tests as you develop!
 
 ## Contributing
 

data/bin/slack-messaging

@@ -21,19 +21,20 @@ DOCUMENTATION
     see Slack Messaging's GitHub repo: https://github.com/emmahsax/slack_messaging
 "
 
+pre do |global, _command, _options, _args|
+  SlackMessaging::Config.load(global[:config])
+  true
+end
+
 desc 'Prints a variety of messages to Slack'
 command 'send' do |c|
-  pre do |global, _command, _options, _args|
-    SlackMessaging::Config.load(global[:config])
-    true
-  end
-
   c.action do |_global_options, options, args|
     SlackMessaging::Send.execute(args, options)
   end
 end
 
 desc 'Sets up a Slack Messaging config file at ~/.slack_messaging.yml'
+skips_pre
 command 'setup' do |c|
   c.action do
     SlackMessaging::Setup.execute

data/lib/slack_messaging/config.rb

@@ -2,27 +2,29 @@
 
 module SlackMessaging
   class Config
-    def self.config
-      config_data.to_hash
-    end
+    class << self
+      def method_missing(method, args = false)
+        config_data.send(method, args)
+      end
 
-    def self.load(path)
-      load_config(path)
-      config
-    end
+      def load(path)
+        load_config(path)
+        config
+      end
 
-    def self.config_data
-      @config_data ||= Hashie::Mash.new
-    end
+      private def config
+        config_data.to_hash
+      end
 
-    def self.method_missing(method, args = false)
-      config_data.send(method, args)
-    end
+      private def config_data
+        @config_data ||= Hashie::Mash.new
+      end
 
-    def self.load_config(file)
-      raise MissingConfig, "Missing configuration file: #{file}" unless File.exist?(file)
+      private def load_config(file)
+        raise StandardError, "Missing configuration file: #{file}" unless File.exist?(file)
 
-      YAML.load_file(file).each { |key, value| config_data.assign_property(key, value) }
+        YAML.load_file(file).each { |key, value| config_data.assign_property(key, value) }
+      end
     end
   end
 end

data/lib/slack_messaging/default_paths.rb

@@ -2,12 +2,14 @@
 
 module SlackMessaging
   class DefaultPaths
-    def self.config
-      File.join(home, '.slack_messaging.yml')
-    end
+    class << self
+      def config
+        File.join(home, '.slack_messaging.yml')
+      end
 
-    def self.home
-      ENV['HOME'] || '.'
+      private def home
+        ENV['HOME'] || '.'
+      end
     end
   end
 end

data/lib/slack_messaging/send.rb

@@ -2,21 +2,23 @@
 
 module SlackMessaging
   class Send
-    attr_accessor :options
+    class << self
+      attr_accessor :options
 
-    def self.execute(args, _options = nil)
-      if args.empty?
-        message = SlackMessaging::RandomMessage.acquire_random_quote
-        print_message(message)
-      else
-        args.each do |arg_message|
-          print_message(arg_message)
+      def execute(args, _options = nil)
+        if args.empty?
+          message = SlackMessaging::RandomMessage.acquire_random_quote
+          print_message(message)
+        else
+          args.each do |arg_message|
+            print_message(arg_message)
+          end
         end
       end
-    end
 
-    def self.print_message(message)
-      SlackMessaging::NotifySlack.new(message).perform
+      private def print_message(message)
+        SlackMessaging::NotifySlack.new(message).perform
+      end
     end
   end
 end

data/lib/slack_messaging/setup.rb

@@ -2,91 +2,83 @@
 
 module SlackMessaging
   class Setup
-    def self.execute
-      if config_file_exists?
-        answer = highline.ask_yes_no(
-          "It looks like the #{default_config} file already exists. Do you wish to replace it? (y/n)"
-        )
-        puts
-      else
-        answer = true
-      end
-
-      create_or_update_config_file(ask_config_questions) if answer
-    end
+    class << self
+      # rubocop:disable Style/ConditionalAssignment
+      def execute
+        if config_file_exists?
+          answer = highline.ask_yes_no(
+            "It looks like the #{default_config} file already exists. Do you wish to replace it? (y/n)",
+            { required: true }
+          )
+        else
+          answer = true
+        end
 
-    def self.create_or_update_config_file(answers)
-      contents = generate_config_file(answers)
-      puts "\nCreating or updating your #{default_config} file..."
-      File.open(default_config, 'w') { |file| file.puts contents }
-      puts "\nDone!"
-    end
+        create_or_update_config_file(ask_config_questions) if answer
+      end
+      # rubocop:enable Style/ConditionalAssignment
 
-    def self.generate_config_file(answers)
-      file_contents = ''.dup
-      file_contents << "slack:\n"
-      file_contents << "  channel: #{answers[:channel].tr('#', '').strip}\n"
-      file_contents << "  username: #{answers[:username].strip}\n"
-      file_contents << "  webhook_url: #{answers[:webhook_url].strip}\n"
-      file_contents << "  icon_emoji: '#{answers[:icon_emoji].strip}'"
-      file_contents
-    end
+      private def create_or_update_config_file(answers)
+        contents = generate_config_file(answers)
+        puts "Creating or updating your #{default_config} file..."
+        File.open(default_config, 'w') { |file| file.puts contents }
+        puts "\nDone!"
+      end
 
-    def self.config_file_exists?
-      File.exist?(default_config)
-    end
+      private def generate_config_file(answers)
+        file_contents = ''.dup
+        file_contents << "slack:\n"
+        file_contents << "  channel: #{answers[:channel].tr('#', '').strip}\n"
+        file_contents << "  username: #{answers[:username].strip}\n"
+        file_contents << "  webhook_url: #{answers[:webhook_url].strip}\n"
+        file_contents << "  icon_emoji: '#{answers[:icon_emoji].strip}'"
+        file_contents
+      end
 
-    # rubocop:disable Metrics/MethodLength
-    def self.ask_config_questions
-      answers = {}
+      private def config_file_exists?
+        File.exist?(default_config)
+      end
 
-      answers[:webhook_url] = ask_question(
-        "What is your Slack webhook URL? If you don't have one yet, please navigate" \
-        ' to https://api.slack.com/messaging/webhooks to create one, and then come back' \
-        ' here and paste it in the Terminal.',
-        required: true
-      )
+      # rubocop:disable Metrics/MethodLength
+      private def ask_config_questions
+        answers = {}
 
-      answers[:channel] = ask_question(
-        "\nWhat slack channel do you wish to post to? (default is \"#general\")"
-      ) || 'general'
+        answers[:webhook_url] = ask_question(
+          "What is your Slack webhook URL? If you don't have one yet, please navigate" \
+          ' to https://api.slack.com/messaging/webhooks to create one, and then come back' \
+          ' here and paste it in the Terminal.',
+          required: true
+        )
 
-      answers[:username] = ask_question(
-        "\nWhat slack username do you wish to post as? (default is \"Let's Get Quoty\")"
-      ) || "Let's Get Quoty"
+        answers[:channel] = ask_question(
+          'What slack channel do you wish to post to? (default is "#general")'
+        ) || 'general'
 
-      answers[:icon_emoji] = ask_question(
-        "\nWhat emoji would you like to post with (include the colons at the beginning and end" \
-        ' of the emoji name)? (default is ":mailbox_with_mail:")'
-      ) || ':mailbox_with_mail:'
+        answers[:username] = ask_question(
+          "What slack username do you wish to post as? (default is \"Let's Get Quoty\")"
+        ) || "Let's Get Quoty"
 
-      answers
-    end
-    # rubocop:enable Metrics/MethodLength
+        answers[:icon_emoji] = ask_question(
+          'What emoji would you like to post with (include the colons at the beginning and end' \
+          ' of the emoji name)? (default is ":mailbox_with_mail:")'
+        ) || ':mailbox_with_mail:'
 
-    # rubocop:disable Metrics/MethodLength
-    def self.ask_question(prompt, required: false)
-      answer = highline.ask(prompt)
+        answers
+      end
+      # rubocop:enable Metrics/MethodLength
 
-      if required
-        if answer.empty?
-          puts "\nThis question is required.\n\n"
-          ask_question(prompt, required: true)
-        else
-          answer
-        end
-      else
+      private def ask_question(prompt, required: false)
+        answer = highline.ask(prompt, { required: required })
         answer.empty? ? nil : answer
       end
-    end
-    # rubocop:enable Metrics/MethodLength
 
-    def self.highline
-      @highline ||= HighlineWrapper.new
-    end
+      private def highline
+        @highline ||= HighlineWrapper.new
+      end
 
-    def self.default_config
-      SlackMessaging::DefaultPaths.config
+      private def default_config
+        SlackMessaging::DefaultPaths.config
+      end
     end
   end
 end

data/lib/slack_messaging/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module SlackMessaging
-  VERSION = '3.1.0'
+  VERSION = '3.1.1'
 end

data/spec/slack_messaging/setup_spec.rb

@@ -109,25 +109,6 @@ describe SlackMessaging::Setup do
       subject.send(:ask_config_questions)
     end
 
-    it 'should recurse if the slack URL is not given' do
-      allow(highline_wrapper).to receive(:ask).with(
-        "What is your Slack webhook URL? If you don't have one yet, please navigate" \
-        ' to https://api.slack.com/messaging/webhooks to create one, and then come back' \
-        ' here and paste it in the Terminal.'
-      ).and_return('', Faker::Internet.url)
-      allow(highline_wrapper).to receive(:ask).with(
-        "\nWhat slack channel do you wish to post to? (default is \"#general\")"
-      ).and_return('')
-      allow(highline_wrapper).to receive(:ask).with(
-        "\nWhat slack username do you wish to post as? (default is \"Let's Get Quoty\")"
-      ).and_return('')
-      allow(highline_wrapper).to receive(:ask).with(
-        "\nWhat emoji would you like to post with (include the colons at the beginning and end of the emoji name)? (default is \":mailbox_with_mail:\")"
-      ).and_return('')
-      expect(subject).to receive(:ask_question).at_least(:twice).and_call_original
-      subject.send(:ask_config_questions)
-    end
-
     it 'should return the defaults if nothing is given' do
       slack_url = Faker::Internet.url
       defaults = {
@@ -141,13 +122,13 @@ describe SlackMessaging::Setup do
         required: true
       ).and_return(slack_url)
       allow(subject).to receive(:ask_question).with(
-        "\nWhat slack channel do you wish to post to? (default is \"#general\")"
+        'What slack channel do you wish to post to? (default is "#general")'
       ).and_return(nil)
       allow(subject).to receive(:ask_question).with(
-        "\nWhat slack username do you wish to post as? (default is \"Let's Get Quoty\")"
+        "What slack username do you wish to post as? (default is \"Let's Get Quoty\")"
       ).and_return(nil)
       allow(subject).to receive(:ask_question).with(
-        "\nWhat emoji would you like to post with (include the colons at the beginning and end of the emoji name)? (default is \":mailbox_with_mail:\")"
+        'What emoji would you like to post with (include the colons at the beginning and end of the emoji name)? (default is ":mailbox_with_mail:")'
       ).and_return(nil)
       expect(subject.send(:ask_config_questions)).to eq(defaults)
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: slack_messaging
 version: !ruby/object:Gem::Version
-  version: 3.1.0
+  version: 3.1.1
 platform: ruby
 authors:
 - Emma Sax
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-03-02 00:00:00.000000000 Z
+date: 2021-03-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -58,14 +58,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.1.0
+        version: '1.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.1.0
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: httparty
   requirement: !ruby/object:Gem::Requirement