slack_messaging 2.2.0 → 3.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bd3e90f703693ae103c78862c1c506cc48dcab4f04065d4aee1b6e60a9cab9da
-  data.tar.gz: 9cf11baa6f0d033e3c944a7a6d30255eb4ed94233a3a54cfa277c59566bdd91b
+  metadata.gz: 5c4c7aef44ea0d755210046e0f211673f25e69fca20f702304b3943c11ae3903
+  data.tar.gz: 27ba520ee53f03706b1b64dae70d768825990c2bad7680901b912f74e4a956ca
 SHA512:
-  metadata.gz: cc3b3d202c84093c07a6d0aae39f05dad04aa16a7b28fb66a57b4399e4f1bccdff049909d92fba9a56431a4171422d589a3b616c56b7ee72dad2aca0d48e5560
-  data.tar.gz: cab8ff992b73a96e41f4f8cb996df80b644ec304a58292d728f54ba5b3965695d4421c5f1df6819aad530981be893a1bfe8fb2c51cf2338142440787f3eff390
+  metadata.gz: 3fc66d9bda665075b85519d8d5bf7d0ef8b87fb81c882e73a1e8d24d4fd816e64f3204ba08606991b3246b4e9f568689ed1be1585b55d6362015e550ef7c4395
+  data.tar.gz: 34ec445b8de695759dd74382e18dab2be6ad74eed7d341e0b4ee67941231d97f469a17da68b83226c3aa229e8a1c57b52e6ac293d69d01ec70e3d8b70906ed96

data/Gemfile

@@ -1,4 +1,5 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
-# Specify your gem's dependencies in slack_messaging.gemspec
 gemspec

data/Guardfile

@@ -1,4 +1,6 @@
-guard :rspec, cmd: 'bundle exec rspec', all_on_start: true  do
+# frozen_string_literal: true
+
+guard :rspec, cmd: 'bundle exec rspec', all_on_start: true do
   watch(%r{^spec/.+_spec\.rb$})
   watch(%r{^lib/(.+)\.rb$})     { |m| "spec/lib/#{m[1]}_spec.rb" }
   watch('spec/spec_helper.rb')  { 'spec' }

data/LICENSE.md

@@ -0,0 +1,11 @@
+Copyright (c) 2014 Emma Sax. All rights reserved.
+
+Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met:
+
+1. Redistributions of source code must retain the above copyright notice, this list of conditions, and the following disclaimer.
+
+2. Redistributions in binary form must reproduce the above copyright notice, this list of conditions, and the following disclaimer in the documentation and/or other materials provided with the distribution.
+
+3. Neither the name of the copyright holder nor the names of its contributors may be used to endorse or promote products derived from this software without specific prior written permission.
+
+THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

data/README.md

@@ -1,4 +1,4 @@
-# Slack Messaging [![Maintainability](https://api.codeclimate.com/v1/badges/9aabbea68d6522f4b308/maintainability)](https://codeclimate.com/github/emmahsax/slack_messaging/maintainability) [![Main](https://github.com/emmahsax/slack_messaging/actions/workflows/main.yml/badge.svg)](https://github.com/emmahsax/slack_messaging/actions/workflows/main.yml)
+# Slack Messaging [![Main](https://github.com/emmahsax/slack_messaging/actions/workflows/main.yml/badge.svg)](https://github.com/emmahsax/slack_messaging/actions/workflows/main.yml)
 
 This is a simple project designed to post messages to a given Slack channel as a bot.
 
@@ -22,7 +22,7 @@ Or install it yourself as:
 gem install slack_messaging
 ```
 
-### Usage
+## Usage
 
 This project requires a config file that should look like this:
 
@@ -53,7 +53,7 @@ mv ~/.slack_messaging.yml /PATH/TO/FILE/config.yml
 And then you can pass in that specific file location like this:
 
 ```bash
-slack-messaging --config="/PATH/TO/FILE/config.yml" slack
+slack-messaging --config="/PATH/TO/FILE/config.yml" send
 ```
 
 Once the config file is set up, the project is ready to go!
@@ -61,7 +61,7 @@ Once the config file is set up, the project is ready to go!
 To print a friendly message to Slack, run:
 
 ```bash
-slack-messaging slack
+slack-messaging send
 ```
 
 Here, no specific message is being given to print to Slack, so slack_messaging will choose a random quote. The random quotes are selected using the [Quotable API](http://api.quotable.io/).
@@ -69,13 +69,13 @@ Here, no specific message is being given to print to Slack, so slack_messaging w
 However, what if you wanted to print something specific? Well, you can! Just run:
 
 ```bash
-slack-messaging slack 'MESSAGE 1'
+slack-messaging send 'MESSAGE 1'
 ```
 
 You can even print multiple messages at once:
 
 ```bash
-slack-messaging slack 'MESSAGE 1' 'MESSAGE 2' 'MESSAGE 3' ... 'MESSAGE N'
+slack-messaging send 'MESSAGE 1' 'MESSAGE 2' 'MESSAGE 3' ... 'MESSAGE N'
 ```
 
 The output of slack_messaging will look something like this:
@@ -84,19 +84,29 @@ The output of slack_messaging will look something like this:
 
 I hope you enjoy printing fun and specialized messages to Slack!
 
-### Tests
+## Tests
 
-To run the tests, run `bundle exec rspec` from the command line. GitHub Actions will also run the tests upon every commit to make sure they're up to date and that everything is working correctly. Locally, you can also run `bundle exec guard` to automatically run tests as you develop! There are currently only tests for the `notify_slack` and `random_message` classes. Feel free to help us add more!
+To run the tests, run `bundle exec rspec` from the command-line. GitHub Actions will also run the tests upon every commit to make sure they're up to date and that everything is working correctly. Locally, you can also run `bundle exec guard` to automatically run tests as you develop!
 
-## Contributing
+---
+
+### Contributing
 
 To submit a feature request, bug ticket, etc, please submit an official [GitHub Issue](https://github.com/emmahsax/slack_messaging/issues/new).
 
-To report any security vulnerabilities, please view this project's [Security Policy](https://github.com/emmahsax/slack_messaging/security/policy).
+### Security Policy
+
+To report any security vulnerabilities, please view this repository's [Security Policy](https://github.com/emmahsax/slack_messaging/security/policy).
+
+### Licensing
+
+For information on licensing, please see [LICENSE.md](https://github.com/emmahsax/slack_messaging/blob/main/LICENSE.md).
+
+### Code of Conduct
 
 When interacting with this repository, please follow [Contributor Covenant's Code of Conduct](https://contributor-covenant.org).
 
-## Releasing
+### Releasing
 
 To make a new release of this gem:
 

data/Rakefile

@@ -1 +1,3 @@
+# frozen_string_literal: true
+
 require 'bundler/gem_tasks'

data/bin/slack-messaging

@@ -1,4 +1,7 @@
 #!/usr/bin/env ruby
+
+# frozen_string_literal: true
+
 require 'rubygems'
 require 'gli'
 require_relative '../lib/slack_messaging'
@@ -10,29 +13,30 @@ version SlackMessaging::VERSION
 
 wrap_help_text :verbatim
 
-flag [:config], :desc => 'Slack Messaging config file path', :default_value => SlackMessaging::DefaultPaths.config
+flag [:config], desc: 'Slack Messaging config file path', default_value: SlackMessaging::DefaultPaths.config
 
-program_long_desc """
+program_long_desc "
 DOCUMENTATION
     For documentation and help in setting up your configuration files,
     see Slack Messaging's GitHub repo: https://github.com/emmahsax/slack_messaging
-"""
+"
 
-desc 'Prints a variety of messages to Slack'
-command 'slack' do |c|
-  pre do |global, command, options, args|
-    SlackMessaging::Config.load(global[:config])
-    true
-  end
+pre do |global, _command, _options, _args|
+  SlackMessaging::Config.load(global[:config])
+  true
+end
 
-  c.action do |global_options, options, args|
-    SlackMessaging::Slack.execute(args, options)
+desc 'Prints a variety of messages to Slack'
+command 'send' do |c|
+  c.action do |_global_options, options, args|
+    SlackMessaging::Send.execute(args, options)
   end
 end
 
 desc 'Sets up a Slack Messaging config file at ~/.slack_messaging.yml'
+skips_pre
 command 'setup' do |c|
-  c.action do ||
+  c.action do
     SlackMessaging::Setup.execute
   end
 end

data/lib/slack_messaging.rb

@@ -1,10 +1,14 @@
+# frozen_string_literal: true
+
 require 'yaml'
 require 'hashie'
 require 'httparty'
-require 'highline'
+require 'highline_wrapper'
 require 'json'
 
-Dir[File.expand_path(File.join(File.dirname(File.absolute_path(__FILE__)), 'slack_messaging')) + '/**/*.rb'].each do |file|
+files = "#{File.expand_path(File.join(File.dirname(File.absolute_path(__FILE__)), 'slack_messaging'))}/**/*.rb"
+
+Dir[files].each do |file|
   require_relative file
 end
 

data/lib/slack_messaging/config.rb

@@ -1,27 +1,30 @@
+# frozen_string_literal: true
+
 module SlackMessaging
   class Config
-    def self.config
-      config_data.to_hash
-    end
+    class << self
+      def method_missing(method, args = false)
+        config_data.send(method, args)
+      end
 
-    def self.load(path)
-      load_config(path)
-      config
-    end
+      def load(path)
+        load_config(path)
+        config
+      end
 
-    private
+      private def config
+        config_data.to_hash
+      end
 
-    def self.config_data
-      @config_data ||= Hashie::Mash.new
-    end
+      private def config_data
+        @config_data ||= Hashie::Mash.new
+      end
 
-    def self.method_missing(method, args = false)
-      config_data.send(method, args)
-    end
+      private def load_config(file)
+        raise StandardError, "Missing configuration file: #{file}" unless File.exist?(file)
 
-    def self.load_config(file)
-      raise MissingConfig, "Missing configuration file: #{file}" unless File.exist?(file)
-      YAML.load_file(file).each { |key, value| config_data.assign_property(key, value) }
+        YAML.load_file(file).each { |key, value| config_data.assign_property(key, value) }
+      end
     end
   end
 end

data/lib/slack_messaging/default_paths.rb

@@ -1,13 +1,15 @@
+# frozen_string_literal: true
+
 module SlackMessaging
   class DefaultPaths
-    def self.config
-      File.join(self.home, '.slack_messaging.yml')
-    end
-
-    private
+    class << self
+      def config
+        File.join(home, '.slack_messaging.yml')
+      end
 
-    def self.home
-      ENV['HOME'] ? ENV['HOME'] : '.'
+      private def home
+        ENV['HOME'] || '.'
+      end
     end
   end
 end

data/lib/slack_messaging/notify_slack.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module SlackMessaging
   class NotifySlack
     attr_accessor :text, :channel, :webhook_url, :username, :icon_url, :icon_emoji

data/lib/slack_messaging/random_message.rb

@@ -1,10 +1,12 @@
+# frozen_string_literal: true
+
 module SlackMessaging
   class RandomMessage
     def self.acquire_random_quote
       random_quote = HTTParty.get('http://api.quotable.io/random', headers: { 'Content-Type': 'application/json' }).body
       quote_content = JSON.parse(random_quote)['content']
       quote_author = JSON.parse(random_quote)['author']
-      return "\"#{quote_content}\"" + "\n" + "—#{quote_author}"
+      "\"#{quote_content}\"\n—#{quote_author}"
     end
   end
 end

data/lib/slack_messaging/send.rb

@@ -0,0 +1,24 @@
+# frozen_string_literal: true
+
+module SlackMessaging
+  class Send
+    class << self
+      attr_accessor :options
+
+      def execute(args, _options = nil)
+        if args.empty?
+          message = SlackMessaging::RandomMessage.acquire_random_quote
+          print_message(message)
+        else
+          args.each do |arg_message|
+            print_message(arg_message)
+          end
+        end
+      end
+
+      private def print_message(message)
+        SlackMessaging::NotifySlack.new(message).perform
+      end
+    end
+  end
+end

data/lib/slack_messaging/setup.rb

@@ -1,81 +1,87 @@
+# frozen_string_literal: true
+
 module SlackMessaging
   class Setup
-    def self.execute
-      if config_file_exists?
-        answer = highline.ask_yes_no("It looks like the #{default_config} file already exists. Do you wish to replace it? (y/n)")
-
-        unless answer
-          puts "\nExiting because you selected to not replace the #{default_config} file..."
-          exit
+    class << self
+      # rubocop:disable Style/ConditionalAssignment
+      def execute
+        if config_file_exists?
+          answer = highline.ask_yes_no(
+            "It looks like the #{default_config} file already exists. Do you wish to replace it? (y/n)",
+            { required: true }
+          )
+        else
+          answer = true
         end
-      end
-
-      create_or_update_config_file(ask_config_questions)
-    end
-
-    private
-
-    def self.create_or_update_config_file(answers)
-      contents = generate_config_file(answers)
-      puts "\nCreating or updating your #{default_config} file..."
-      File.open(default_config, 'w') { |file| file.puts contents }
-      puts "\nDone!"
-    end
-
-    def self.generate_config_file(answers)
-      file_contents = ''
-      file_contents << "slack:\n"
-      file_contents << "  channel: #{answers[:channel].tr('#', '').strip}\n"
-      file_contents << "  username: #{answers[:username].strip}\n"
-      file_contents << "  webhook_url: #{answers[:webhook_url].strip}\n"
-      file_contents << "  icon_emoji: '#{answers[:icon_emoji].strip}'"
-      file_contents
-    end
-
-    def self.config_file_exists?
-      File.exists?(default_config)
-    end
 
-    def self.ask_config_questions
-      answers = {}
-
-      answers[:webhook_url] = ask_question(
-        "\nWhat is your Slack webhook URL? If you don't have one yet, please navigate" \
-        " to https://api.slack.com/messaging/webhooks to create one, and then come back" \
-        " here and paste it in the Terminal."
-      )
-
-      unless answers[:webhook_url]
-        puts "\nExiting because Slack webhoook is required..."
-        exit
+        create_or_update_config_file(ask_config_questions) if answer
       end
+      # rubocop:enable Style/ConditionalAssignment
 
-      answers[:channel] = ask_question(
-        "\nWhat slack channel do you wish to post to? (default is \"#general\")"
-      ) || 'general'
+      private def create_or_update_config_file(answers)
+        contents = generate_config_file(answers)
+        puts "Creating or updating your #{default_config} file..."
+        File.open(default_config, 'w') { |file| file.puts contents }
+        puts 'Done!'
+      end
 
-      answers[:username] = ask_question(
-        "\nWhat slack username do you wish to post as? (default is \"Let's Get Quoty\")"
-      ) || "Let's Get Quoty"
+      private def generate_config_file(answers)
+        file_contents = ''.dup
+        file_contents << "slack:\n"
+        file_contents << "  channel: #{answers[:channel].tr('#', '').strip}\n"
+        file_contents << "  username: #{answers[:username].strip}\n"
+        file_contents << "  webhook_url: #{answers[:webhook_url].strip}\n"
+        file_contents << "  icon_emoji: '#{answers[:icon_emoji].strip}'"
+        file_contents
+      end
 
-      answers[:icon_emoji] = ask_question(
-        "\nWhat emoji would you like to post with (include the colons at the beginning and end of the emoji name)? (default is \":mailbox_with_mail:\")"
-      ) || ":mailbox_with_mail:"
+      private def config_file_exists?
+        File.exist?(default_config)
+      end
 
-      answers
-    end
+      # rubocop:disable Metrics/MethodLength
+      private def ask_config_questions
+        answers = {}
+
+        answers[:webhook_url] = ask_question(
+          "What is your Slack webhook URL? If you don't have one yet, please navigate" \
+          ' to https://api.slack.com/messaging/webhooks to create one, and then come back' \
+          ' here and paste it in the Terminal.',
+          nil,
+          required: true
+        )
+
+        answers[:channel] = ask_question(
+          'What slack channel do you wish to post to? (default is "#general")',
+          '#general'
+        )
+
+        answers[:username] = ask_question(
+          "What slack username do you wish to post as? (default is \"Let's Get Quoty\")",
+          "Let's Get Quoty"
+        )
+
+        answers[:icon_emoji] = ask_question(
+          'What emoji would you like to post with (include the colons at the beginning and end' \
+          ' of the emoji name)? (default is ":mailbox_with_mail:")',
+          ':mailbox_with_mail:'
+        )
+
+        answers
+      end
+      # rubocop:enable Metrics/MethodLength
 
-    def self.ask_question(prompt)
-      answer = highline.ask(prompt)
-      answer.empty? ? nil : answer
-    end
+      private def ask_question(prompt, default, required: false)
+        highline.ask(prompt, { default: default, required: required })
+      end
 
-    def self.highline
-      @highline ||= SlackMessaging::HighlineCli.new
-    end
+      private def highline
+        @highline ||= HighlineWrapper.new
+      end
 
-    def self.default_config
-      SlackMessaging::DefaultPaths.config
+      private def default_config
+        SlackMessaging::DefaultPaths.config
+      end
     end
   end
 end

data/lib/slack_messaging/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module SlackMessaging
-  VERSION = '2.2.0'
+  VERSION = '3.1.3'
 end

data/spec/slack_messaging/config_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'slack_messaging'
 
@@ -23,13 +25,13 @@ describe SlackMessaging::Config do
 
     let(:config_file) do
       {
-        'domain': domain,
-        'slack': {
-          'slack_option': true,
-          'username': Faker::Name.name,
-          'icon_url': Faker::Internet.url,
-          'channel': Faker::Lorem.word,
-          'webhook': Faker::Internet.url
+        domain: domain,
+        slack: {
+          slack_option: true,
+          username: Faker::Name.name,
+          icon_url: Faker::Internet.url,
+          channel: Faker::Lorem.word,
+          webhook: Faker::Internet.url
         }
       }
     end

data/spec/slack_messaging/notify_slack_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'slack_messaging'
 
@@ -10,12 +12,12 @@ describe SlackMessaging::NotifySlack do
 
   let(:config_file) do
     {
-      'slack': {
-        'slack_option': true,
-        'username': username,
-        'icon_emoji': emoji,
-        'channel': channel,
-        'webhook_url': webhook
+      slack: {
+        slack_option: true,
+        username: username,
+        icon_emoji: emoji,
+        channel: channel,
+        webhook_url: webhook
       }
     }
   end
@@ -26,20 +28,18 @@ describe SlackMessaging::NotifySlack do
     SlackMessaging::Config.load(Faker::Lorem.word)
   end
 
-  subject { SlackMessaging::NotifySlack }
+  subject { SlackMessaging::NotifySlack.new(sentence) }
 
   it 'should call HTTParty' do
     expect(HTTParty).to receive(:post)
-    message = subject.new(sentence)
-    message.perform
+    subject.perform
   end
 
-    it 'should define certain values' do
-    message = subject.new(sentence)
-    expect(message.text).to eq(sentence)
-    expect(message.channel).to eq(channel)
-    expect(message.username).to eq(username)
-    expect(message.webhook_url).to eq(webhook)
-    expect(message.icon_emoji).to eq(emoji)
+  it 'should define certain values' do
+    expect(subject.text).to eq(sentence)
+    expect(subject.channel).to eq(channel)
+    expect(subject.username).to eq(username)
+    expect(subject.webhook_url).to eq(webhook)
+    expect(subject.icon_emoji).to eq(emoji)
   end
 end

data/spec/slack_messaging/random_message_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'slack_messaging'
 

data/spec/slack_messaging/setup_spec.rb

@@ -1,9 +1,10 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'slack_messaging'
 
 describe SlackMessaging::Setup do
-  let(:response) { double(:response, readline: true, to_s: Faker::Lorem.sentence) }
-  let(:highline_cli) { double(:highline_cli, ask: response, ask_yes_no: true) }
+  let(:highline_wrapper) { double(:highline_wrapper, ask: Faker::Lorem.word, ask_yes_no: true) }
   let(:answers) do
     {
       channel: Faker::Lorem.word,
@@ -14,20 +15,21 @@ describe SlackMessaging::Setup do
   end
 
   before do
-    allow(SlackMessaging::HighlineCli).to receive(:new).and_return(highline_cli)
+    allow(HighlineWrapper).to receive(:new).and_return(highline_wrapper)
     allow(subject).to receive(:puts)
   end
 
   after do
-    SlackMessaging::Setup.instance_variable_set("@highline", nil)
+    SlackMessaging::Setup.instance_variable_set('@highline', nil)
   end
 
   subject { SlackMessaging::Setup }
 
   describe '#self.execute' do
     it 'should ask a question if the config file exists' do
+      allow(subject).to receive(:config_file_exists?).and_return(true)
       allow(File).to receive(:exists?).and_return(true)
-      expect(highline_cli).to receive(:ask_yes_no).and_return(true)
+      expect(highline_wrapper).to receive(:ask_yes_no).and_return(true)
       allow(subject).to receive(:create_or_update_config_file).and_return(true)
       allow(subject).to receive(:ask_config_questions).and_return(true)
       subject.execute
@@ -35,18 +37,19 @@ describe SlackMessaging::Setup do
 
     it 'should call to create or update the config file' do
       allow(File).to receive(:exists?).and_return(true)
-      allow(highline_cli).to receive(:ask_yes_no).and_return(true)
+      allow(highline_wrapper).to receive(:ask_yes_no).and_return(true)
       expect(subject).to receive(:create_or_update_config_file).and_return(true)
       expect(subject).to receive(:ask_config_questions).and_return(true)
       subject.execute
     end
 
-    it 'should exit if the user opts not to continue' do
+    it 'should skip if the user opts not to continue' do
+      allow(subject).to receive(:config_file_exists?).and_return(true)
       allow(File).to receive(:exists?).and_return(true)
-      allow(highline_cli).to receive(:ask_yes_no).and_return(false)
+      allow(highline_wrapper).to receive(:ask_yes_no).and_return(false)
       expect(subject).not_to receive(:create_or_update_config_file)
       expect(subject).not_to receive(:ask_config_questions)
-      expect{ subject.execute }.to raise_error(SystemExit)
+      subject.execute
     end
   end
 
@@ -72,61 +75,66 @@ describe SlackMessaging::Setup do
 
   describe '#self.config_file_exists?' do
     it 'should return true if the file exists' do
-      allow(File).to receive(:exists?).and_return(true)
+      allow(File).to receive(:exist?).and_return(true)
       expect(subject.send(:config_file_exists?)).to eq(true)
     end
 
     it 'should return false if the file does not exist' do
-      allow(File).to receive(:exists?).and_return(false)
+      allow(File).to receive(:exist?).and_return(false)
       expect(subject.send(:config_file_exists?)).to eq(false)
     end
   end
 
   describe '#self.ask_question' do
     it 'should use highline to ask a question' do
-      expect(highline_cli).to receive(:ask).and_return('')
-      subject.send(:ask_question, Faker::Lorem.sentence)
+      expect(highline_wrapper).to receive(:ask).and_return('')
+      subject.send(:ask_question, Faker::Lorem.sentence, nil)
     end
 
     it 'should return nil if the highline client gets an empty string' do
-      allow(highline_cli).to receive(:ask).and_return('')
-      expect(subject.send(:ask_question, Faker::Lorem.sentence)).to be_nil
+      allow(highline_wrapper).to receive(:ask).and_return(nil)
+      expect(subject.send(:ask_question, Faker::Lorem.sentence, nil)).to be_nil
     end
 
     it 'should return the answer if it is given' do
       answer = Faker::Lorem.sentence
-      allow(highline_cli).to receive(:ask).and_return(answer)
-      expect(subject.send(:ask_question, Faker::Lorem.sentence)).to be(answer)
+      allow(highline_wrapper).to receive(:ask).and_return(answer)
+      expect(subject.send(:ask_question, Faker::Lorem.sentence, :default)).to be(answer)
     end
   end
 
   describe '#self.ask_config_questions' do
     it 'should call to ask at least four questions' do
-      expect(subject).to receive(:ask_question).at_least(4).times
+      expect(subject).to receive(:ask_question).at_least(4).times.and_return(Faker::Lorem.word)
       subject.send(:ask_config_questions)
     end
 
-    it 'should exit if the slack URL is not given' do
-      allow(subject).to receive(:ask_question).and_return(nil)
-      expect{ subject.send(:ask_config_questions) }.to raise_error(SystemExit)
-    end
-
     it 'should return the defaults if nothing is given' do
       slack_url = Faker::Internet.url
+      defaults = {
+        channel: 'general',
+        username: "Let's Get Quoty",
+        webhook_url: slack_url,
+        icon_emoji: ':mailbox_with_mail:'
+      }
       allow(subject).to receive(:ask_question).with(
-        "\nWhat is your Slack webhook URL? If you don't have one yet, please navigate" \
-        " to https://api.slack.com/messaging/webhooks to create one, and then come back" \
-        " here and paste it in the Terminal."
+        "What is your Slack webhook URL? If you don't have one yet, please navigate to https://api.slack.com/messaging/webhooks to create one, and then come back here and paste it in the Terminal.",
+        nil,
+        required: true
       ).and_return(slack_url)
-      allow(subject).to receive(:ask_question).and_return(nil)
-      expect(subject.send(:ask_config_questions)).to eq(
-        {
-          channel: 'general',
-          username: "Let's Get Quoty",
-          webhook_url: slack_url,
-          icon_emoji: ":mailbox_with_mail:"
-        }
-      )
+      allow(subject).to receive(:ask_question).with(
+        'What slack channel do you wish to post to? (default is "#general")',
+        '#general'
+      ).and_return('general')
+      allow(subject).to receive(:ask_question).with(
+        "What slack username do you wish to post as? (default is \"Let's Get Quoty\")",
+        "Let's Get Quoty"
+      ).and_return("Let's Get Quoty")
+      allow(subject).to receive(:ask_question).with(
+        'What emoji would you like to post with (include the colons at the beginning and end of the emoji name)? (default is ":mailbox_with_mail:")',
+        ':mailbox_with_mail:'
+      ).and_return(':mailbox_with_mail:')
+      expect(subject.send(:ask_config_questions)).to eq(defaults)
     end
   end
 end

data/spec/spec_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'faker'
 require 'pry'
 
@@ -34,7 +36,7 @@ RSpec.configure do |config|
     expectations.include_chain_clauses_in_custom_matcher_descriptions = true
   end
 
-  config.filter_run :focus => true
+  config.filter_run focus: true
   config.run_all_when_everything_filtered = true
 
   # rspec-mocks config goes here. You can use an alternate test double

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: slack_messaging
 version: !ruby/object:Gem::Version
-  version: 2.2.0
+  version: 3.1.3
 platform: ruby
 authors:
 - Emma Sax
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-02-25 00:00:00.000000000 Z
+date: 2021-06-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -53,19 +53,19 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '4.1'
 - !ruby/object:Gem::Dependency
-  name: highline
+  name: highline_wrapper
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '1.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '1.1'
 - !ruby/object:Gem::Dependency
   name: httparty
   requirement: !ruby/object:Gem::Requirement
@@ -192,6 +192,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.9'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.10'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.10'
 description: Sending Personalized Slack Messages to a Slack channel of your choice.
 email:
 executables:
@@ -200,9 +214,8 @@ extensions: []
 extra_rdoc_files: []
 files:
 - Gemfile
-- Gemfile.lock
 - Guardfile
-- LICENSE
+- LICENSE.md
 - QuoteExample.png
 - README.md
 - Rakefile
@@ -210,21 +223,19 @@ files:
 - lib/slack_messaging.rb
 - lib/slack_messaging/config.rb
 - lib/slack_messaging/default_paths.rb
-- lib/slack_messaging/highline_cli.rb
 - lib/slack_messaging/notify_slack.rb
 - lib/slack_messaging/random_message.rb
+- lib/slack_messaging/send.rb
 - lib/slack_messaging/setup.rb
-- lib/slack_messaging/slack.rb
 - lib/slack_messaging/version.rb
 - spec/slack_messaging/config_spec.rb
-- spec/slack_messaging/highline_cli_spec.rb
 - spec/slack_messaging/notify_slack_spec.rb
 - spec/slack_messaging/random_message_spec.rb
 - spec/slack_messaging/setup_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/emmahsax/slack_messaging
 licenses:
-- MIT
+- BSD-3-Clause
 metadata: {}
 post_install_message:
 rdoc_options: []
@@ -234,21 +245,20 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '2.4'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.3
+rubygems_version: 3.2.15
 signing_key:
 specification_version: 4
 summary: Personalized Slack Messages
 test_files:
 - spec/spec_helper.rb
 - spec/slack_messaging/config_spec.rb
-- spec/slack_messaging/highline_cli_spec.rb
 - spec/slack_messaging/notify_slack_spec.rb
 - spec/slack_messaging/random_message_spec.rb
 - spec/slack_messaging/setup_spec.rb

data/Gemfile.lock

@@ -1,106 +0,0 @@
-PATH
-  remote: .
-  specs:
-    slack_messaging (2.2.0)
-      activesupport (~> 6.0)
-      gli (~> 2.10)
-      hashie (~> 4.1)
-      highline (~> 2.0)
-      httparty (~> 0.18)
-      json (~> 2.5)
-      rack (~> 2.2)
-
-GEM
-  remote: https://rubygems.org/
-  specs:
-    activesupport (6.1.2.1)
-      concurrent-ruby (~> 1.0, >= 1.0.2)
-      i18n (>= 1.6, < 2)
-      minitest (>= 5.1)
-      tzinfo (~> 2.0)
-      zeitwerk (~> 2.3)
-    coderay (1.1.3)
-    concurrent-ruby (1.1.8)
-    diff-lcs (1.4.4)
-    faker (2.15.1)
-      i18n (>= 1.6, < 2)
-    ffi (1.14.2)
-    formatador (0.2.5)
-    gli (2.19.2)
-    guard (2.16.2)
-      formatador (>= 0.2.4)
-      listen (>= 2.7, < 4.0)
-      lumberjack (>= 1.0.12, < 2.0)
-      nenv (~> 0.1)
-      notiffany (~> 0.0)
-      pry (>= 0.9.12)
-      shellany (~> 0.0)
-      thor (>= 0.18.1)
-    guard-compat (1.2.1)
-    guard-rspec (4.7.3)
-      guard (~> 2.1)
-      guard-compat (~> 1.1)
-      rspec (>= 2.99.0, < 4.0)
-    hashie (4.1.0)
-    highline (2.0.3)
-    httparty (0.18.1)
-      mime-types (~> 3.0)
-      multi_xml (>= 0.5.2)
-    i18n (1.8.8)
-      concurrent-ruby (~> 1.0)
-    json (2.5.1)
-    listen (3.4.1)
-      rb-fsevent (~> 0.10, >= 0.10.3)
-      rb-inotify (~> 0.9, >= 0.9.10)
-    lumberjack (1.2.8)
-    method_source (1.0.0)
-    mime-types (3.3.1)
-      mime-types-data (~> 3.2015)
-    mime-types-data (3.2020.1104)
-    minitest (5.14.3)
-    multi_xml (0.6.0)
-    nenv (0.3.0)
-    notiffany (0.1.3)
-      nenv (~> 0.1)
-      shellany (~> 0.0)
-    pry (0.14.0)
-      coderay (~> 1.1)
-      method_source (~> 1.0)
-    rack (2.2.3)
-    rake (13.0.3)
-    rb-fsevent (0.10.4)
-    rb-inotify (0.10.1)
-      ffi (~> 1.0)
-    rspec (3.10.0)
-      rspec-core (~> 3.10.0)
-      rspec-expectations (~> 3.10.0)
-      rspec-mocks (~> 3.10.0)
-    rspec-core (3.10.1)
-      rspec-support (~> 3.10.0)
-    rspec-expectations (3.10.1)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.10.0)
-    rspec-mocks (3.10.2)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.10.0)
-    rspec-support (3.10.2)
-    shellany (0.0.1)
-    thor (1.1.0)
-    tzinfo (2.0.4)
-      concurrent-ruby (~> 1.0)
-    zeitwerk (2.4.2)
-
-PLATFORMS
-  x86_64-darwin-19
-
-DEPENDENCIES
-  bundler (~> 2.2)
-  faker (~> 2.15)
-  guard-rspec (~> 4.3)
-  pry (~> 0.13)
-  rake (~> 13.0)
-  rspec (~> 3.9)
-  slack_messaging!
-
-BUNDLED WITH
-   2.2.9

data/LICENSE

@@ -1,22 +0,0 @@
-Copyright (c) 2014 Emma Sax
-
-MIT License
-
-Permission is hereby granted, free of charge, to any person obtaining
-a copy of this software and associated documentation files (the
-"Software"), to deal in the Software without restriction, including
-without limitation the rights to use, copy, modify, merge, publish,
-distribute, sublicense, and/or sell copies of the Software, and to
-permit persons to whom the Software is furnished to do so, subject to
-the following conditions:
-
-The above copyright notice and this permission notice shall be
-included in all copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
-EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
-MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
-NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
-LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
-OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
-WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

data/lib/slack_messaging/highline_cli.rb

@@ -1,33 +0,0 @@
-module SlackMessaging
-  class HighlineCli
-    def ask(prompt)
-      highline_client.ask(prompt) do |conf|
-        conf.readline = true
-      end.to_s
-    end
-
-    def ask_yes_no(prompt)
-      answer = highline_client.ask(prompt) do |conf|
-        conf.readline = true
-      end.to_s
-
-      answer.empty? ? true : !!(answer =~ /^y/i)
-    end
-
-    def ask_options(prompt, choices)
-      choices_as_string_options = ''
-      choices.each { |choice| choices_as_string_options << "#{choices.index(choice) + 1}. #{choice}\n" }
-      compiled_prompt = "#{prompt}\n#{choices_as_string_options.strip}"
-
-      index = highline_client.ask(compiled_prompt) do |conf|
-        conf.readline = true
-      end.to_i - 1
-
-      choices[index]
-    end
-
-    private def highline_client
-      @highline_client ||= HighLine.new
-    end
-  end
-end

data/lib/slack_messaging/slack.rb

@@ -1,22 +0,0 @@
-module SlackMessaging
-  class Slack
-    attr_accessor :options
-
-    def self.execute(args, options = nil)
-      if args.empty?
-        message = SlackMessaging::RandomMessage.acquire_random_quote
-        print_message(message)
-      else
-        args.each do |message|
-          print_message(message)
-        end
-      end
-    end
-
-    private
-
-    def self.print_message(message)
-      SlackMessaging::NotifySlack.new(message).perform
-    end
-  end
-end

data/spec/slack_messaging/highline_cli_spec.rb

@@ -1,49 +0,0 @@
-require 'spec_helper'
-require 'slack_messaging'
-
-describe SlackMessaging::HighlineCli do
-  let(:response) { double(:response, readline: true, to_i: 3) }
-  let(:highline_client) { double(:highline_cli, ask: response) }
-
-  before do
-    allow(HighLine).to receive(:new).and_return(highline_client)
-  end
-
-  describe '#ask' do
-    it 'should ask the highline client ask'do
-      expect(highline_client).to receive(:ask)
-      subject.ask(Faker::Lorem.sentence)
-    end
-
-    it 'should return a string' do
-      expect(subject.ask(Faker::Lorem.sentence)).to be_a(String)
-    end
-  end
-
-  describe '#ask_yes_no' do
-    it 'should ask the highline client ask'do
-      expect(highline_client).to receive(:ask)
-      subject.ask_yes_no(Faker::Lorem.sentence)
-    end
-
-    it 'should return a boolean' do
-      expect(subject.ask_yes_no(Faker::Lorem.sentence)).to be_falsey
-    end
-
-    it 'should return true if we say yes' do
-      allow(response).to receive(:to_s).and_return('y')
-      expect(subject.ask_yes_no(Faker::Lorem.sentence)).to be_truthy
-    end
-  end
-
-  describe '#ask_options' do
-    it 'should ask the highline client ask'do
-      expect(highline_client).to receive(:ask)
-      subject.ask_options(Faker::Lorem.sentence, ['one', 'two', 'three'])
-    end
-
-    it 'should return a string from the options' do
-      expect(subject.ask_options(Faker::Lorem.sentence, ['one', 'two', 'three'])).to be_a(String)
-    end
-  end
-end