slack_message 1.7.0 → 1.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a2cd232d81a66a48c9543a5b910c335bca7a82474a60472d03f7cffab3fce0d0
-  data.tar.gz: c27312311ff02ee414f2882461fe5ea9b5c07d9d8e99847ae7af33faf4a31283
+  metadata.gz: f4d33554e024d1c51aeb2bb6ee5397c16142dbcc1a314720f30e7fab3d12325d
+  data.tar.gz: 6e297c58c27ca6109d51fc5b267c3248928deaf7422d57e6b9e9aa0533e525b5
 SHA512:
-  metadata.gz: 69352d5eb8d4f6837f66ba042817bfe0a51c3483356bbc64ded0cbc60fc7e72c084ea39df542a93bf79a6c0a8c4ad860cdb9791f28d807edb5b1c859b13f129f
-  data.tar.gz: 740af84829c6b258b4788b5f83901f242a5732e98737781efb288ee426ed232726823d9fdde453da6c7d83eb55607733e1d4b55757580676921b37abba1c70ad
+  metadata.gz: bf1e3caebf3d58c238c46be5f3b62a925ade7d077998a7a73ac1c9fdb3d5f0859ecb6c0f338ad2cc666a7157d166cd8cda4fa91e9e5dacb3a77bf168cb9ccf50
+  data.tar.gz: '08de1a2fe10e3da489169e11d478e7afb93fd557e6da00d1af1a42f6697a351f3b281ea66aafd80594738f6b25457fdb18c9a5bf766caee339d2b7cc5db51e02'

data/CHANGELOG.md

@@ -2,7 +2,23 @@
 
 ## [Unreleased]
 
+## [1.9.0] - 2021-10-27
+- Add many validations so that trying to add e.g. empty text won't succeed.
+  Previously that would be accepted but return `invalid_blocks` from the API.
+
+## [1.8.1] - 2021-10-08
+- Cleaned that rspec code a bit, added more matchers for real world use.
+
+## [1.8.0] - 2021-10-07
+- Added the ability to test in RSpec.
+
+## [1.7.1] - 2021-10-06
+- Fixed literally a syntax issue.
+- Fixed specs.
+- Fixed API to include JSON since consumers may not have loaded it.
+
 ## [1.7.0] - 2021-10-06
+- THIS RELEASE IS BADLY BROKEN.
 - Added new error messages when API configuration is wrong / missing.
 - Fixed issue with `instance_eval` and using methods within block.
 - Fixed issue with sectionless `list_item`.

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    slack_message (1.2.0)
+    slack_message (1.9.0)
 
 GEM
   remote: https://rubygems.org/

data/README.md

@@ -214,6 +214,48 @@ SlackMessage.post_to('#general') do
 end
 ```
 
+### Testing
+
+You can do some basic testing against SlackMessage, at least if you use RSpec!
+You'll need to require and include the testing behavior like this, in your
+spec_helper file:
+
+```ruby
+require 'slack_message/rspec'
+
+RSpec.configure do |config|
+  include SlackMessage::RSpec
+
+  # your other config
+end
+```
+
+This will stop API calls for posting messages, and will allow you access to
+some custom matchers:
+
+```ruby
+expect {
+  SlackMessage.post_to('#general') { text "foo" }
+}.to post_slack_message_to('#general').with_content_matching(/foo/)
+
+expect {
+  SlackMessage.post_as(:schmoebot) { text "foo" }
+}.to post_slack_message_as(:schmoebot)
+
+expect {
+  SlackMessage.post_as(:schmoebot) { text "foo" }
+}.to post_slack_message_as('Schmoe Bot')
+ 
+expect {
+  SlackMessage.post_to('#general') { text "foo" }
+}.to post_to_slack
+```
+
+Be forewarned, I'm frankly not that great at more complicated RSpec matchers,
+so I'm guessing there are some bugs. Also, because the content of a message
+gets turned into a complex JSON object, matching against content isn't capable
+of very complicated regexes.
+
 Opinionated Stances
 ------------
 
@@ -225,6 +267,8 @@ opinionated stances on how to make use of that API. For instance:
 * Generally, same goes for the `emoji` flag on almost every text element.
 * It's possible to ask for a `blank_line` in sections, even though that concept
   isn't real. In this case, a text line containing only an emspace is rendered.
+* It's easy to configure a bot for consistent name / channel use. My previous
+  use of SlackNotifier led to frequently inconsistent names.
 
 What it Doesn't Do
 ------------

data/lib/slack_message/api.rb

@@ -1,5 +1,6 @@
 require 'net/http'
 require 'net/https'
+require 'json'
 
 class SlackMessage::Api
   def self.user_id_for(email)
@@ -44,9 +45,9 @@ class SlackMessage::Api
       channel: target,
       username: profile[:name],
       blocks: payload
-    }.to_json
+    }
 
-    response = Net::HTTP.post_form uri, { payload: params }
+    response = execute_post_form(uri, params, profile[:handle])
 
     # let's try to be helpful about error messages
     if response.body == "invalid_token"
@@ -63,4 +64,8 @@ class SlackMessage::Api
 
     response
   end
+
+  def self.execute_post_form(uri, params, _profile)
+    Net::HTTP.post_form uri, { payload: params.to_json }
+  end
 end

data/lib/slack_message/configuration.rb

@@ -27,6 +27,10 @@ module SlackMessage::Configuration
 
   ###
 
+  def self.clear_profiles! # test harness, mainly
+    @@profiles = {}
+  end
+
   def self.add_profile(handle = :default, name:, url:, default_channel: nil)
     if @@profiles.include?(handle)
       warn "WARNING: Overriding profile '#{handle}' in SlackMessage config"

data/lib/slack_message/dsl.rb

@@ -6,7 +6,7 @@ class SlackMessage::Dsl
   def initialize(block)
     # Delegate missing methods to caller scope. Thanks 2008:
     # https://www.dan-manges.com/blog/ruby-dsls-instance-eval-with-delegation
-    @caller_self = eval("self", block.binding
+    @caller_self = eval("self", block.binding)
 
     @body = []
     @default_section = Section.new
@@ -52,6 +52,10 @@ class SlackMessage::Dsl
   def context(text)
     finalize_default_section
 
+    if text == "" || text.nil?
+      raise ArgumentError, "tried to create a context block without a value"
+    end
+
     @body.push({ type: "context", elements: [{
       type: "mrkdwn", text: text
     }]})
@@ -110,6 +114,10 @@ class SlackMessage::Dsl
     end
 
     def text(msg)
+      if msg == "" || msg.nil?
+        raise ArgumentError, "tried to create text node without a value"
+      end
+
       if @body.include?(:text)
         @body[:text][:text] << "\n#{msg}"
 
@@ -119,14 +127,16 @@ class SlackMessage::Dsl
     end
 
     def ul(elements)
-      raise Arguments, "please pass an array" unless elements.respond_to?(:map)
+      raise ArgumentError, "please pass an array" unless elements.respond_to?(:map)
+
       text(
         elements.map { |text| "#{EMSPACE}• #{text}" }.join("\n")
       )
     end
 
     def ol(elements)
-      raise Arguments, "please pass an array" unless elements.respond_to?(:map)
+      raise ArgumentError, "please pass an array" unless elements.respond_to?(:map)
+
       text(
         elements.map.with_index(1) { |text, idx| "#{EMSPACE}#{idx}. #{text}" }.join("\n")
       )
@@ -186,6 +196,10 @@ class SlackMessage::Dsl
     end
 
     def list_item(title, value)
+      if value == "" || value.nil?
+        raise ArgumentError, "can't create a list item for '#{title}' without a value"
+      end
+
       @list.add(title, value)
     end
 

data/lib/slack_message/rspec.rb

@@ -0,0 +1,168 @@
+require 'rspec/expectations'
+require 'rspec/mocks'
+
+# Honestly, this code is what happens when you do not understand the RSpec
+# custom expectation API really at all, but you really want to create your
+# matcher. This code is soo baaad.
+#
+# We override API calls by entirely replacing the low-level API method. Then we
+# use our overridden version to capture and record calls. When someone creates
+# a new expectation, an object is created, so we allow that object to register
+# itself to receive notification when a slack message _would have_ been posted.
+#
+# Then once the expectation is fulfilled, that class unregisters itself so that
+# it can be cleaned up properly.
+#
+
+module SlackMessage::RSpec
+  extend RSpec::Matchers::DSL
+
+  @@listeners = []
+
+  def self.register_expectation_listener(expectation_instance)
+    @@listeners << expectation_instance
+  end
+
+  def self.unregister_expectation_listener(expectation_instance)
+    @@listeners.delete(expectation_instance)
+  end
+
+  FauxResponse = Struct.new(:code, :body)
+
+  def self.included(_)
+    SlackMessage::Api.singleton_class.undef_method(:execute_post_form)
+    SlackMessage::Api.define_singleton_method(:execute_post_form) do |uri, params, profile|
+      @@listeners.each do |listener|
+        listener.record_call(params.merge(profile: profile, uri: uri))
+      end
+
+      return FauxResponse.new('200', 'ok')
+    end
+  end
+
+  # w/ channel
+  matcher :post_slack_message_to do |expected|
+    match do |actual|
+      @instance ||= PostTo.new
+      @instance.with_channel(expected)
+
+      actual.call
+      @instance.enforce_expectations
+    end
+
+    chain :with_content_matching do |content|
+      @instance ||= PostTo.new
+      @instance.with_content_matching(content)
+    end
+
+    failure_message { @instance.failure_message }
+    failure_message_when_negated { @instance.failure_message_when_negated }
+
+    supports_block_expectations
+  end
+
+  # no channel
+  matcher :post_to_slack do |expected|
+    match do |actual|
+      @instance ||= PostTo.new
+
+      actual.call
+      @instance.enforce_expectations
+    end
+
+    chain :with_content_matching do |content|
+      @instance ||= PostTo.new
+      @instance.with_content_matching(content)
+    end
+
+    failure_message { @instance.failure_message }
+    failure_message_when_negated { @instance.failure_message_when_negated }
+
+    supports_block_expectations
+  end
+
+  # name / profile matcher
+  matcher :post_slack_message_as do |expected|
+     match do |actual|
+      @instance ||= PostTo.new
+      @instance.with_profile(expected)
+
+      actual.call
+      @instance.enforce_expectations
+    end
+
+    chain :with_content_matching do |content|
+      @instance ||= PostTo.new
+      @instance.with_content_matching(content)
+    end
+
+    failure_message { @instance.failure_message }
+    failure_message_when_negated { @instance.failure_message_when_negated }
+
+    supports_block_expectations
+  end
+
+  class PostTo
+    def initialize
+      @captured_calls = []
+      @content = nil
+      @channel = nil
+      @profile = nil
+
+      SlackMessage::RSpec.register_expectation_listener(self)
+    end
+
+    def record_call(deets)
+      @captured_calls.push(deets)
+    end
+
+    def with_channel(channel)
+      @channel = channel
+    end
+
+    def with_content_matching(content)
+      raise ArgumentError unless content.is_a? Regexp
+      @content = content
+    end
+
+    def with_profile(profile)
+      @profile = profile
+    end
+
+    def enforce_expectations
+      SlackMessage::RSpec.unregister_expectation_listener(self)
+
+      @captured_calls
+        .filter { |call| !@channel || call[:channel] == @channel }
+        .filter { |call| !@profile || [call[:profile], call[:username]].include?(@profile) }
+        .filter { |call| !@content || call.fetch(:blocks).to_s =~ @content }
+        .any?
+    end
+
+    def failure_message
+      "expected block to #{failure_expression}"
+    end
+
+    def failure_message_when_negated
+      "expected block not to #{failure_expression}"
+    end
+
+    def failure_expression
+      concat = []
+
+      if @channel
+        concat << "post a slack message to '#{@channel}'"
+      elsif @profile
+        concat << "post a slack message as '#{@profile}'"
+      else
+        concat << "post a slack message"
+      end
+
+      if @content
+        concat << "with content matching #{@content.inspect}"
+      end
+
+      concat.join " "
+    end
+  end
+end

data/slack_message.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |gem|
   gem.name        = 'slack_message'
-  gem.version     = "1.7.0"
+  gem.version     = "1.9.0"
   gem.summary     = "A nice DSL for composing rich messages in Slack"
   gem.authors     = ["Joe Mastey"]
   gem.email       = 'hello@joemastey.com'

data/spec/slack_message_spec.rb

@@ -1,15 +1,12 @@
 require 'spec_helper'
 
 RSpec.describe SlackMessage do
-  it "includes a bunch of stuff" do
-    expect(SlackMessage).to respond_to(:post_to)
-  end
-
   describe "API convenience" do
     it "can grab user IDs" do
-      allow(SlackMessage::Api).to receive(:api_request)
-        .with(/hello@joemastey.com/)
-        .and_return({ "user" => { "id" => "ABC123" }})
+      SlackMessage.configure { |c| c.api_token = "asdf" }
+      allow(Net::HTTP).to receive(:start).and_return(
+        double(code: "200", body: '{ "user": { "id": "ABC123" }}')
+      )
 
       result = SlackMessage.user_id_for("hello@joemastey.com")
       expect(result).to eq("ABC123")
@@ -49,7 +46,7 @@ RSpec.describe SlackMessage do
 
     it "raises errors for missing configuration" do
       SlackMessage.configure do |config|
-        #config.api_token = "abc123"
+        config.api_token = nil
       end
 
       expect {
@@ -63,7 +60,6 @@ RSpec.describe SlackMessage do
         config.add_profile(:nonstandard, name: 'another profile', url: 'http://hooks.slack.com/1234/')
       end
 
-
       expect(SlackMessage.configuration.profile(:default)[:name]).to eq('default profile')
       expect(SlackMessage.configuration.profile(:nonstandard)[:name]).to eq('another profile')
 
@@ -72,4 +68,55 @@ RSpec.describe SlackMessage do
       }.to raise_error(ArgumentError)
     end
   end
+
+  describe "custom expectations" do
+    before do
+      SlackMessage.configure do |config|
+        config.clear_profiles!
+        config.add_profile(name: 'default profile', url: 'http://hooks.slack.com/1234/')
+      end
+    end
+
+    it "can assert expectations against posts" do
+      expect {
+        SlackMessage.post_to('#lieutenant') { text "foo" }
+      }.not_to post_slack_message_to('#general')
+
+      expect {
+        SlackMessage.post_to('#general') { text "foo" }
+      }.to post_slack_message_to('#general').with_content_matching(/foo/)
+    end
+
+    it "resets state properly" do
+      expect {
+        SlackMessage.post_to('#general') { text "foo" }
+      }.to post_slack_message_to('#general')
+
+      expect { }.not_to post_slack_message_to('#general')
+    end
+
+    it "lets you assert by profile name" do
+      SlackMessage.configure do |config|
+        config.add_profile(:schmoebot, name: 'Schmoe', url: 'http://hooks.slack.com/1234/', default_channel: '#schmoes')
+      end
+
+      expect {
+        SlackMessage.post_as(:schmoebot) { text "foo" }
+      }.to post_slack_message_to('#schmoes')
+
+      expect {
+        SlackMessage.post_as(:schmoebot) { text "foo" }
+      }.to post_slack_message_as(:schmoebot)
+
+      expect {
+        SlackMessage.post_as(:schmoebot) { text "foo" }
+      }.to post_slack_message_as('Schmoe').with_content_matching(/foo/)
+    end
+
+    it "can assert more generally too tbh" do
+      expect {
+        SlackMessage.post_to('#general') { text "foo" }
+      }.to post_to_slack.with_content_matching(/foo/)
+    end
+  end
 end

data/spec/spec_helper.rb

@@ -1,4 +1,5 @@
 require_relative '../lib/slack_message'
+require_relative '../lib/slack_message/rspec'
 
 # This file was generated by the `rspec --init` command. Conventionally, all
 # specs live under a `spec` directory, which RSpec adds to the `$LOAD_PATH`.
@@ -49,4 +50,6 @@ RSpec.configure do |config|
   # test failures related to randomization by passing the same `--seed` value
   # as the one that triggered the failure.
   Kernel.srand config.seed
+
+  include SlackMessage::RSpec
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: slack_message
 version: !ruby/object:Gem::Version
-  version: 1.7.0
+  version: 1.9.0
 platform: ruby
 authors:
 - Joe Mastey
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-10-06 00:00:00.000000000 Z
+date: 2021-10-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -70,6 +70,7 @@ files:
 - lib/slack_message/api.rb
 - lib/slack_message/configuration.rb
 - lib/slack_message/dsl.rb
+- lib/slack_message/rspec.rb
 - slack_message.gemspec
 - spec/slack_message_spec.rb
 - spec/spec_helper.rb