slack-ruby-client 1.0.0 → 1.1.0

data/spec/slack/real_time/client_spec.rb

@@ -73,7 +73,7 @@ RSpec.describe Slack::RealTime::Client do
 
       before do
         allow(Slack::RealTime::Socket).to(
-          receive(:new).with(url, ping: 30, logger: Slack::Logger.default).and_return(socket)
+          receive(:new).with(url, { ping: 30, logger: Slack::Logger.default }).and_return(socket)
         )
         allow(socket).to receive(:connect!)
         allow(socket).to receive(:start_sync)
@@ -124,7 +124,7 @@ RSpec.describe Slack::RealTime::Client do
         expect(client.web_client).to be_a Slack::Web::Client
       end
       it 'remembers socket' do
-        expect(client.instance_variable_get('@socket')).to eq socket
+        expect(client.instance_variable_get(:@socket)).to eq socket
       end
       it 'cannot be invoked twice' do
         expect do
@@ -138,7 +138,7 @@ RSpec.describe Slack::RealTime::Client do
         end
 
         it 'cannot be invoked twice' do
-          client.instance_variable_set('@socket', nil) # caused by a :close callback
+          client.instance_variable_set(:@socket, nil) # caused by a :close callback
           expect do
             client.stop!
           end.to raise_error Slack::RealTime::Client::ClientNotStartedError
@@ -175,7 +175,7 @@ RSpec.describe Slack::RealTime::Client do
           end
 
           it 'returns false when event is nil' do
-            expect(client.send(:run_handlers, 'example', {})).to be nil
+            expect(client.send(:run_handlers, 'example', {})).to be_nil
           end
         end
       end
@@ -186,7 +186,7 @@ RSpec.describe Slack::RealTime::Client do
 
       before do
         allow(Slack::RealTime::Socket).to(
-          receive(:new).with(url, ping: 30, logger: Slack::Logger.default).and_return(socket)
+          receive(:new).with(url, { ping: 30, logger: Slack::Logger.default }).and_return(socket)
         )
         allow(socket).to receive(:connect!)
         allow(socket).to receive(:start_async)
@@ -255,7 +255,7 @@ RSpec.describe Slack::RealTime::Client do
 
       before do
         allow(Slack::RealTime::Socket).to(
-          receive(:new).with(url, ping: 30, logger: Slack::Logger.default).and_return(socket)
+          receive(:new).with(url, { ping: 30, logger: Slack::Logger.default }).and_return(socket)
         )
         allow(socket).to receive(:connect!)
         allow(socket).to receive(:start_sync)
@@ -301,7 +301,7 @@ RSpec.describe Slack::RealTime::Client do
         expect(client.web_client).to be_a Slack::Web::Client
       end
       it 'remembers socket' do
-        expect(client.instance_variable_get('@socket')).to eq socket
+        expect(client.instance_variable_get(:@socket)).to eq socket
       end
       it 'cannot be invoked twice' do
         expect do
@@ -315,7 +315,7 @@ RSpec.describe Slack::RealTime::Client do
         end
 
         it 'cannot be invoked twice' do
-          client.instance_variable_set('@socket', nil) # caused by a :close callback
+          client.instance_variable_set(:@socket, nil) # caused by a :close callback
           expect do
             client.stop!
           end.to raise_error Slack::RealTime::Client::ClientNotStartedError
@@ -336,7 +336,7 @@ RSpec.describe Slack::RealTime::Client do
     let(:url) { 'wss://mpmulti-w5tz.slack-msgs.com/websocket/uid' }
 
     it 'sets store to nil' do
-      expect(client.store).to be nil
+      expect(client.store).to be_nil
     end
     it "doesn't handle events" do
       event = Slack::RealTime::Event.new(
@@ -347,10 +347,10 @@ RSpec.describe Slack::RealTime::Client do
       client.send(:dispatch, event)
     end
     it 'self' do
-      expect(client.self).to be nil
+      expect(client.self).to be_nil
     end
     it 'team' do
-      expect(client.team).to be nil
+      expect(client.team).to be_nil
     end
     describe 'to_s' do
       it 'defaults to class instance' do
@@ -367,7 +367,7 @@ RSpec.describe Slack::RealTime::Client do
         expect(client.websocket_ping).to eq 30
       end
       it "doesn't set proxy" do
-        expect(client.websocket_proxy).to be nil
+        expect(client.websocket_proxy).to be_nil
       end
       it 'defaults logger' do
         expect(client.send(:logger)).to be_a ::Logger
@@ -443,7 +443,7 @@ RSpec.describe Slack::RealTime::Client do
         end
         it 'creates a connection with custom ping', vcr: { cassette_name: 'web/rtm_start' } do
           expect(Slack::RealTime::Concurrency::Mock::WebSocket).to(
-            receive(:new).with(url, nil, ping: 15).and_return(ws)
+            receive(:new).with(url, nil, { ping: 15 }).and_return(ws)
           )
           client.start!
         end
@@ -474,10 +474,12 @@ RSpec.describe Slack::RealTime::Client do
           expect(Slack::RealTime::Concurrency::Mock::WebSocket).to receive(:new).with(
             url,
             nil,
-            ping: 30,
-            proxy: {
-              origin: 'http://username:password@proxy.example.com',
-              headers: { 'User-Agent' => 'ruby' }
+            {
+              ping: 30,
+              proxy: {
+                origin: 'http://username:password@proxy.example.com',
+                headers: { 'User-Agent' => 'ruby' }
+              }
             }
           ).and_return(ws)
           client.start!
@@ -507,7 +509,7 @@ RSpec.describe Slack::RealTime::Client do
 
           it 'calls rtm_start with start options', vcr: { cassette_name: 'web/rtm_start' } do
             expect(client.web_client).to(
-              receive(:rtm_start).with(simple_latest: true).and_call_original
+              receive(:rtm_start).with({ simple_latest: true }).and_call_original
             )
             client.start!
           end

data/spec/slack/real_time/event_handlers/channel_spec.rb

@@ -20,7 +20,7 @@ RSpec.describe Slack::RealTime::Client, vcr: { cassette_name: 'web/rtm_start' }
       expect(channel.is_archived).to be true
     end
     it 'channel_created' do
-      expect(client.channels['C024BE91L']).to be nil
+      expect(client.channels['C024BE91L']).to be_nil
       event = Slack::RealTime::Event.new(
         'type' => 'channel_created',
         'channel' => {
@@ -32,23 +32,23 @@ RSpec.describe Slack::RealTime::Client, vcr: { cassette_name: 'web/rtm_start' }
       )
       client.send(:dispatch, event)
       channel = client.channels['C024BE91L']
-      expect(channel).not_to be nil
+      expect(channel).not_to be_nil
       expect(channel.name).to eq 'fun'
       expect(channel.creator).to eq 'U04KB5WQR'
       expect(channel.created).to eq 1_360_782_804
     end
     it 'channel_deleted' do
-      expect(client.channels['C0HLE0BBL']).not_to be nil
+      expect(client.channels['C0HLE0BBL']).not_to be_nil
       event = Slack::RealTime::Event.new(
         'type' => 'channel_deleted',
         'channel' => 'C0HLE0BBL'
       )
       client.send(:dispatch, event)
-      expect(client.channels['C0HLE0BBL']).to be nil
+      expect(client.channels['C0HLE0BBL']).to be_nil
     end
     context 'channel_joined' do
       it 'creates channel' do
-        expect(client.channels['CDEADBEEF']).to be nil
+        expect(client.channels['CDEADBEEF']).to be_nil
         event = Slack::RealTime::Event.new(
           'type' => 'channel_joined',
           'channel' => {
@@ -58,11 +58,11 @@ RSpec.describe Slack::RealTime::Client, vcr: { cassette_name: 'web/rtm_start' }
         )
         client.send(:dispatch, event)
         channel = client.channels['CDEADBEEF']
-        expect(channel).not_to be nil
+        expect(channel).not_to be_nil
         expect(channel.name).to eq 'beef'
       end
       it 'updates channel' do
-        expect(client.channels['CDEADBEEF']).to be nil
+        expect(client.channels['CDEADBEEF']).to be_nil
         client.channels['CDEADBEEF'] =
           Slack::RealTime::Models::Channel.new('id' => 'CDEADBEEF', name: 'beef')
         event = Slack::RealTime::Event.new(
@@ -75,7 +75,7 @@ RSpec.describe Slack::RealTime::Client, vcr: { cassette_name: 'web/rtm_start' }
         )
         client.send(:dispatch, event)
         channel = client.channels['CDEADBEEF']
-        expect(channel).not_to be nil
+        expect(channel).not_to be_nil
         expect(channel.updated).to be true
       end
     end

data/spec/slack/real_time/event_handlers/group_spec.rb

@@ -9,7 +9,7 @@ RSpec.describe Slack::RealTime::Client, vcr: { cassette_name: 'web/rtm_start' }
       expect(client.groups.count).to eq 1
     end
     it 'group_joined' do
-      expect(client.groups['CDEADBEEF']).to be nil
+      expect(client.groups['CDEADBEEF']).to be_nil
       event = Slack::RealTime::Event.new(
         'type' => 'group_joined',
         'channel' => {
@@ -19,7 +19,7 @@ RSpec.describe Slack::RealTime::Client, vcr: { cassette_name: 'web/rtm_start' }
       )
       client.send(:dispatch, event)
       group = client.groups['CDEADBEEF']
-      expect(group).not_to be nil
+      expect(group).not_to be_nil
       expect(group.name).to eq 'beef'
     end
     it 'group_left' do

data/spec/slack/real_time/event_handlers/im_spec.rb

@@ -9,7 +9,7 @@ RSpec.describe Slack::RealTime::Client, vcr: { cassette_name: 'web/rtm_start' }
       expect(client.ims.count).to eq 10
     end
     it 'im_created' do
-      expect(client.ims['CDEADBEEF']).to be nil
+      expect(client.ims['CDEADBEEF']).to be_nil
       event = Slack::RealTime::Event.new(
         'type' => 'im_created',
         'channel' => {
@@ -19,7 +19,7 @@ RSpec.describe Slack::RealTime::Client, vcr: { cassette_name: 'web/rtm_start' }
       )
       client.send(:dispatch, event)
       im = client.ims['CDEADBEEF']
-      expect(im).not_to be nil
+      expect(im).not_to be_nil
       expect(im.name).to eq 'beef'
     end
     it 'im_open' do

data/spec/slack/real_time/store_spec.rb

@@ -4,9 +4,9 @@ require 'spec_helper'
 RSpec.describe Slack::RealTime::Store do
   it 'can be initialized with an empty hash' do
     store = described_class.new(Hashie::Mash.new)
-    expect(store.self).to be nil
+    expect(store.self).to be_nil
     expect(store.groups.count).to eq 0
-    expect(store.team).to be nil
+    expect(store.team).to be_nil
     expect(store.teams.count).to eq 0
   end
 end

data/spec/slack/slack_spec.rb

@@ -22,7 +22,7 @@ describe Slack do
   context 'globals' do
     let(:command) do
       "\"#{slack}\" --vcr-cassette-name=web/auth_test_success " \
-      '--slack-api-token=token -d auth test 2>&1'
+        '--slack-api-token=token -d auth test 2>&1'
     end
 
     it 'enables request and response logging with -d' do
@@ -44,7 +44,7 @@ describe Slack do
     context 'bad auth' do
       let(:command) do
         "\"#{slack}\" --vcr-cassette-name=web/auth_test_error " \
-        '--slack-api-token=token auth test 2>&1'
+          '--slack-api-token=token auth test 2>&1'
       end
 
       it 'fails with an exception' do
@@ -56,7 +56,7 @@ describe Slack do
     context 'good auth' do
       let(:command) do
         "\"#{slack}\" --vcr-cassette-name=web/auth_test_success " \
-        '--slack-api-token=token auth test 2>&1'
+          '--slack-api-token=token auth test 2>&1'
       end
 
       it 'succeeds' do
@@ -79,7 +79,7 @@ describe Slack do
   describe '#users' do
     let(:command) do
       "\"#{slack}\" --vcr-cassette-name=web/users_list " \
-      '--slack-api-token=token users list --presence=true 2>&1'
+        '--slack-api-token=token users list --presence=true 2>&1'
     end
 
     it 'list' do

data/spec/slack/version_spec.rb

@@ -3,6 +3,6 @@ require 'spec_helper'
 
 describe Slack do
   it 'has a version' do
-    expect(Slack::VERSION).not_to be nil
+    expect(Slack::VERSION).not_to be_nil
   end
 end

data/spec/slack/web/api/endpoints/admin_apps_requests_spec.rb

@@ -5,4 +5,9 @@ require 'spec_helper'
 
 RSpec.describe Slack::Web::Api::Endpoints::AdminAppsRequests do
   let(:client) { Slack::Web::Client.new }
+  context 'admin.apps.requests_cancel' do
+    it 'requires request_id' do
+      expect { client.admin_apps_requests_cancel }.to raise_error ArgumentError, /Required arguments :request_id missing/
+    end
+  end
 end

data/spec/slack/web/api/endpoints/admin_users_unsupportedVersions_spec.rb

@@ -0,0 +1,8 @@
+# frozen_string_literal: true
+# This file was auto-generated by lib/tasks/web.rake
+
+require 'spec_helper'
+
+RSpec.describe Slack::Web::Api::Endpoints::AdminUsersUnsupportedversions do
+  let(:client) { Slack::Web::Client.new }
+end

data/spec/slack/web/api/endpoints/bookmarks_spec.rb

@@ -0,0 +1,40 @@
+# frozen_string_literal: true
+# This file was auto-generated by lib/tasks/web.rake
+
+require 'spec_helper'
+
+RSpec.describe Slack::Web::Api::Endpoints::Bookmarks do
+  let(:client) { Slack::Web::Client.new }
+  context 'bookmarks_add' do
+    it 'requires channel_id' do
+      expect { client.bookmarks_add(title: %q[], type: %q[]) }.to raise_error ArgumentError, /Required arguments :channel_id missing/
+    end
+    it 'requires title' do
+      expect { client.bookmarks_add(channel_id: %q[], type: %q[]) }.to raise_error ArgumentError, /Required arguments :title missing/
+    end
+    it 'requires type' do
+      expect { client.bookmarks_add(channel_id: %q[], title: %q[]) }.to raise_error ArgumentError, /Required arguments :type missing/
+    end
+  end
+  context 'bookmarks_edit' do
+    it 'requires bookmark_id' do
+      expect { client.bookmarks_edit(channel_id: %q[]) }.to raise_error ArgumentError, /Required arguments :bookmark_id missing/
+    end
+    it 'requires channel_id' do
+      expect { client.bookmarks_edit(bookmark_id: %q[]) }.to raise_error ArgumentError, /Required arguments :channel_id missing/
+    end
+  end
+  context 'bookmarks_list' do
+    it 'requires channel_id' do
+      expect { client.bookmarks_list }.to raise_error ArgumentError, /Required arguments :channel_id missing/
+    end
+  end
+  context 'bookmarks_remove' do
+    it 'requires bookmark_id' do
+      expect { client.bookmarks_remove(channel_id: %q[]) }.to raise_error ArgumentError, /Required arguments :bookmark_id missing/
+    end
+    it 'requires channel_id' do
+      expect { client.bookmarks_remove(bookmark_id: %q[]) }.to raise_error ArgumentError, /Required arguments :channel_id missing/
+    end
+  end
+end

data/spec/slack/web/api/endpoints/custom_specs/chat_spec.rb

@@ -14,11 +14,13 @@ RSpec.describe Slack::Web::Api::Endpoints::Chat do
     it 'automatically converts attachments and blocks into JSON' do
       expect(client).to receive(:post).with(
         'chat.postEphemeral',
-        channel: 'channel',
-        text: 'text',
-        user: '123',
-        attachments: '[]',
-        blocks: '[]'
+        {
+          channel: 'channel',
+          text: 'text',
+          user: '123',
+          attachments: '[]',
+          blocks: '[]'
+        }
       )
       client.chat_postEphemeral(
         channel: 'channel',
@@ -88,10 +90,12 @@ RSpec.describe Slack::Web::Api::Endpoints::Chat do
     it 'automatically converts attachments and blocks into JSON' do
       expect(client).to receive(:post).with(
         'chat.postMessage',
-        channel: 'channel',
-        text: 'text',
-        attachments: '[]',
-        blocks: '[]'
+        {
+          channel: 'channel',
+          text: 'text',
+          attachments: '[]',
+          blocks: '[]'
+        }
       )
       client.chat_postMessage(channel: 'channel', text: 'text', attachments: [], blocks: [])
     end
@@ -131,11 +135,13 @@ RSpec.describe Slack::Web::Api::Endpoints::Chat do
     it 'automatically converts attachments and blocks into JSON' do
       expect(client).to receive(:post).with(
         'chat.update',
-        channel: 'channel',
-        text: 'text',
-        ts: ts,
-        attachments: '[]',
-        blocks: '[]'
+        {
+          channel: 'channel',
+          text: 'text',
+          ts: ts,
+          attachments: '[]',
+          blocks: '[]'
+        }
       )
       client.chat_update(channel: 'channel', text: 'text', ts: ts, attachments: [], blocks: [])
     end
@@ -148,9 +154,9 @@ RSpec.describe Slack::Web::Api::Endpoints::Chat do
     end
 
     context 'text, attachment and blocks arguments' do
-      it 'requires text, attachments or blocks' do
+      it 'requires text, attachments, blocks or reply_broadcast' do
         expect { client.chat_update(channel: 'channel', ts: ts) }.to(
-          raise_error(ArgumentError, /Required arguments :text, :attachments or :blocks missing/)
+          raise_error(ArgumentError, /Required arguments :text, :attachments, :blocks or :reply_broadcast missing/)
         )
       end
       it 'only text' do
@@ -171,6 +177,12 @@ RSpec.describe Slack::Web::Api::Endpoints::Chat do
           client.chat_update(channel: 'channel', ts: ts, blocks: [])
         end.not_to raise_error
       end
+      it 'only reply_broadcast' do
+        expect(client).to receive(:post).with('chat.update', hash_including(reply_broadcast: true))
+        expect do
+          client.chat_update(channel: 'channel', ts: ts, reply_broadcast: true)
+        end.not_to raise_error
+      end
       it 'all text, attachments and blocks' do
         expect(client).to(
           receive(:post)

data/spec/slack/web/api/endpoints/custom_specs/dialog_spec.rb

@@ -8,8 +8,10 @@ RSpec.describe Slack::Web::Api::Endpoints::Dialog do
     it 'automatically converts dialog into JSON' do
       expect(client).to receive(:post).with(
         'dialog.open',
-        trigger_id: '12345.98765.abcd2358fdea',
-        dialog: '[]'
+        {
+          trigger_id: '12345.98765.abcd2358fdea',
+          dialog: '[]'
+        }
       )
       client.dialog_open(trigger_id: '12345.98765.abcd2358fdea', dialog: [])
     end

data/spec/slack/web/api/endpoints/custom_specs/views_spec.rb

@@ -10,7 +10,7 @@ RSpec.describe Slack::Web::Api::Endpoints::Views do
       let(:view_str) { '{"celery":"man"}' }
 
       it 'automatically converts view into JSON' do
-        expect(client).to receive(:post).with('views.open', trigger_id: trigger_id, view: view_str)
+        expect(client).to receive(:post).with('views.open', { trigger_id: trigger_id, view: view_str })
         client.views_open(trigger_id: trigger_id, view: { celery: 'man' })
       end
     end
@@ -19,7 +19,7 @@ RSpec.describe Slack::Web::Api::Endpoints::Views do
       let(:view_str) { 'celery man' }
 
       it 'leaves view as is' do
-        expect(client).to receive(:post).with('views.open', trigger_id: trigger_id, view: view_str)
+        expect(client).to receive(:post).with('views.open', { trigger_id: trigger_id, view: view_str })
         client.views_open(trigger_id: trigger_id, view: 'celery man')
       end
     end
@@ -32,10 +32,14 @@ RSpec.describe Slack::Web::Api::Endpoints::Views do
       let(:view_str) { '{"celery":"man"}' }
 
       it 'automatically converts view into JSON' do
-        expect(client).to receive(:post).with('views.publish',
-                                              user_id: user_id,
-                                              trigger_id: trigger_id,
-                                              view: view_str)
+        expect(client).to receive(:post).with(
+          'views.publish',
+          {
+            trigger_id: trigger_id,
+            user_id: user_id,
+            view: view_str
+          }
+        )
         client.views_publish(user_id: user_id, trigger_id: trigger_id, view: { celery: 'man' })
       end
     end
@@ -44,10 +48,14 @@ RSpec.describe Slack::Web::Api::Endpoints::Views do
       let(:view_str) { 'celery man' }
 
       it 'leaves view as is' do
-        expect(client).to receive(:post).with('views.publish',
-                                              user_id: user_id,
-                                              trigger_id: trigger_id,
-                                              view: view_str)
+        expect(client).to receive(:post).with(
+          'views.publish',
+          {
+            user_id: user_id,
+            trigger_id: trigger_id,
+            view: view_str
+          }
+        )
         client.views_publish(user_id: user_id, trigger_id: trigger_id, view: 'celery man')
       end
     end
@@ -58,7 +66,7 @@ RSpec.describe Slack::Web::Api::Endpoints::Views do
       let(:view_str) { '{"celery":"man"}' }
 
       it 'automatically converts view into JSON' do
-        expect(client).to receive(:post).with('views.push', trigger_id: trigger_id, view: view_str)
+        expect(client).to receive(:post).with('views.push', { trigger_id: trigger_id, view: view_str })
         client.views_push(trigger_id: trigger_id, view: { celery: 'man' })
       end
     end
@@ -67,7 +75,7 @@ RSpec.describe Slack::Web::Api::Endpoints::Views do
       let(:view_str) { 'celery man' }
 
       it 'leaves view as is' do
-        expect(client).to receive(:post).with('views.push', trigger_id: trigger_id, view: view_str)
+        expect(client).to receive(:post).with('views.push', { trigger_id: trigger_id, view: view_str })
         client.views_push(trigger_id: trigger_id, view: 'celery man')
       end
     end
@@ -78,7 +86,7 @@ RSpec.describe Slack::Web::Api::Endpoints::Views do
       let(:view_str) { '{"celery":"man"}' }
 
       it 'automatically converts view into JSON' do
-        expect(client).to receive(:post).with('views.update', view: view_str)
+        expect(client).to receive(:post).with('views.update', { view: view_str })
         client.views_update(view: { celery: 'man' })
       end
     end
@@ -87,7 +95,7 @@ RSpec.describe Slack::Web::Api::Endpoints::Views do
       let(:view_str) { 'celery man' }
 
       it 'leaves view as is' do
-        expect(client).to receive(:post).with('views.update', view: view_str)
+        expect(client).to receive(:post).with('views.update', { view: view_str })
         client.views_update(view: 'celery man')
       end
     end

data/spec/slack/web/api/pagination/cursor_spec.rb

@@ -8,7 +8,7 @@ RSpec.describe Slack::Web::Api::Pagination::Cursor do
     let(:cursor) { described_class.new(client, 'users_list', {}) }
 
     it 'provides a default limit' do
-      expect(client).to receive(:users_list).with(limit: 100, cursor: nil)
+      expect(client).to receive(:users_list).with({ limit: 100, cursor: nil })
       cursor.first
     end
     it 'handles blank response metadata' do
@@ -36,17 +36,17 @@ RSpec.describe Slack::Web::Api::Pagination::Cursor do
         it 'sleeps after a TooManyRequestsError' do
           expect(client).to(
             receive(:users_list)
-              .with(limit: 100, cursor: nil)
+              .with({ limit: 100, cursor: nil })
               .ordered
               .and_return(Slack::Messages::Message.new(response_metadata: { next_cursor: 'next' }))
           )
           expect(client).to(
-            receive(:users_list).with(limit: 100, cursor: 'next').ordered.and_raise(error)
+            receive(:users_list).with({ limit: 100, cursor: 'next' }).ordered.and_raise(error)
           )
           expect(cursor).to receive(:sleep).once.ordered.with(9)
           expect(client).to(
             receive(:users_list)
-              .with(limit: 100, cursor: 'next')
+              .with({ limit: 100, cursor: 'next' })
               .ordered
               .and_return(Slack::Messages::Message.new)
           )
@@ -60,11 +60,11 @@ RSpec.describe Slack::Web::Api::Pagination::Cursor do
         it 'raises the error after hitting the max retries' do
           expect(client).to(
             receive(:users_list)
-              .with(limit: 100, cursor: nil)
+              .with({ limit: 100, cursor: nil })
               .and_return(Slack::Messages::Message.new(response_metadata: { next_cursor: 'next' }))
           )
           expect(client).to(
-            receive(:users_list).with(limit: 100, cursor: 'next').exactly(5).times.and_raise(error)
+            receive(:users_list).with({ limit: 100, cursor: 'next' }).exactly(5).times.and_raise(error)
           )
           expect(cursor).to receive(:sleep).exactly(4).times.with(9)
           expect { cursor.to_a }.to raise_error(error)
@@ -77,7 +77,7 @@ RSpec.describe Slack::Web::Api::Pagination::Cursor do
     let(:cursor) { described_class.new(client, 'users_list', limit: 42) }
 
     it 'overrides default limit' do
-      expect(client).to receive(:users_list).with(limit: 42, cursor: nil)
+      expect(client).to receive(:users_list).with({ limit: 42, cursor: nil })
       cursor.first
     end
   end

data/spec/slack/web/client_spec.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 require 'spec_helper'
+require 'faraday/typhoeus'
 
 RSpec.describe Slack::Web::Client do
   before do
@@ -275,13 +276,28 @@ RSpec.describe Slack::Web::Client do
       end
 
       context 'parsing error' do
-        before {  stub_slack_request.to_return(body: '<html></html>') }
+        context 'when the response is not JSON' do
+          before do
+            stub_slack_request.to_return(body: '<html></html>', headers: { 'Content-Type' => 'text/html' })
+          end
 
-        it 'raises ParsingError' do
-          expect { request }.to raise_error(Slack::Web::Api::Errors::ParsingError).with_message('parsing_error')
-          expect(exception.response.body).to eq('<html></html>')
-          expect(exception.cause).to be_a(Faraday::ParsingError)
-          expect(exception.cause.cause.cause).to be_a(JSON::ParserError)
+          it 'raises ParsingError' do
+            expect { request }.to raise_error(Slack::Web::Api::Errors::ParsingError).with_message('parsing_error')
+            expect(exception.response.body).to eq('<html></html>')
+            expect(exception.cause).to be_a(Faraday::ParsingError)
+            expect(exception.cause.cause).to be_a(JSON::ParserError)
+          end
+        end
+
+        context 'when the response is malformed JSON' do
+          before { stub_slack_request.to_return(body: '{') }
+
+          it 'raises ParsingError' do
+            expect { request }.to raise_error(Slack::Web::Api::Errors::ParsingError).with_message('parsing_error')
+            expect(exception.response.body).to eq('{')
+            expect(exception.cause).to be_a(Faraday::ParsingError)
+            expect(exception.cause.cause).to be_a(JSON::ParserError)
+          end
         end
       end
 
@@ -318,7 +334,9 @@ RSpec.describe Slack::Web::Client do
         end
 
         context 'with a HTML response' do
-          before { stub_slack_request.to_return(status: 500, body: '<html></html>') }
+          before do
+            stub_slack_request.to_return(status: 500, body: '<html></html>', headers: { 'Content-Type' => 'text/html' })
+          end
 
           it 'raises UnavailableError' do
             expect { request }.to raise_error(Slack::Web::Api::Errors::UnavailableError).with_message('unavailable_error')

data/spec/slack/web/faraday/response/raise_error_spec.rb

@@ -26,7 +26,7 @@ RSpec.describe Slack::Web::Faraday::Response::RaiseError do
       let(:body) { { 'ok' => 'true' } }
 
       it 'is nil' do
-        expect(raise_error_obj.on_complete(env)).to eq nil
+        expect(raise_error_obj.on_complete(env)).to be_nil
       end
     end
 

data/spec/support/real_time/connected_client.rb

@@ -11,7 +11,7 @@ RSpec.shared_context 'connected client' do |opts|
       config.store_class = (opts || {})[:store_class] || Slack::RealTime::Stores::Store
     end
     allow(Slack::RealTime::Socket).to(
-      receive(:new).with(url, ping: 30, logger: Slack::Logger.default).and_return(socket)
+      receive(:new).with(url, { ping: 30, logger: Slack::Logger.default }).and_return(socket)
     )
     allow(socket).to receive(:start_sync)
     allow(socket).to receive(:connect!)