slack-ruby-client 0.16.0 → 0.17.0

data/spec/slack/real_time/rtm_connect_spec.rb

@@ -3,7 +3,7 @@
 
 #
 # to re-record a rtm_connect fixture run with
-# SLACK_API_TOKEN=... CONCURRENCY=faye-websocket rspec spec/slack/real_time/rtm_connect_spec.rb
+# SLACK_API_TOKEN=... CONCURRENCY=async-websocket rspec spec/slack/real_time/rtm_connect_spec.rb
 # edit rtm_connect.yml and remove the token, fix wss:// path (run specs, fix failures)
 #
 

data/spec/slack/real_time/rtm_start_spec.rb

@@ -3,7 +3,7 @@
 
 #
 # to re-record a rtm_start fixture run with
-# SLACK_API_TOKEN=... CONCURRENCY=faye-websocket rspec spec/slack/real_time/rtm_start_spec.rb
+# SLACK_API_TOKEN=... CONCURRENCY=async-websocket rspec spec/slack/real_time/rtm_start_spec.rb
 # edit rtm_start.yml and remove the token, fix wss:// path (run specs, fix failures)
 #
 

data/spec/slack/web/api/endpoints/admin_conversations_spec.rb

@@ -28,11 +28,6 @@ RSpec.describe Slack::Web::Api::Endpoints::AdminConversations do
       expect { client.admin_conversations_delete }.to raise_error ArgumentError, /Required arguments :channel_id missing/
     end
   end
-  context 'admin.conversations_disconnectShared' do
-    it 'requires channel_id' do
-      expect { client.admin_conversations_disconnectShared }.to raise_error ArgumentError, /Required arguments :channel_id missing/
-    end
-  end
   context 'admin.conversations_getConversationPrefs' do
     it 'requires channel_id' do
       expect { client.admin_conversations_getConversationPrefs }.to raise_error ArgumentError, /Required arguments :channel_id missing/

data/spec/slack/web/api/endpoints/custom_specs/conversations_spec.rb

@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+require 'spec_helper'
+
+RSpec.describe Slack::Web::Api::Endpoints::Groups do
+  let(:client) { Slack::Web::Client.new }
+
+  context 'groups' do
+    it 'info', vcr: { cassette_name: 'web/conversations_info' } do
+      json = client.conversations_info(channel: '#mpdm-dblock--rubybot--player1-1')
+      expect(json.channel.name).to eq 'mpdm-dblock--rubybot--player1-1'
+    end
+  end
+end

data/spec/slack/web/api/endpoints/im_spec.rb

@@ -5,35 +5,4 @@ require 'spec_helper'
 
 RSpec.describe Slack::Web::Api::Endpoints::Im do
   let(:client) { Slack::Web::Client.new }
-  context 'im_close' do
-    it 'requires channel' do
-      expect { client.im_close }.to raise_error ArgumentError, /Required arguments :channel missing/
-    end
-  end
-  context 'im_history' do
-    it 'requires channel' do
-      expect { client.im_history }.to raise_error ArgumentError, /Required arguments :channel missing/
-    end
-  end
-  context 'im_mark' do
-    it 'requires channel' do
-      expect { client.im_mark(ts: %q[1234567890.123456]) }.to raise_error ArgumentError, /Required arguments :channel missing/
-    end
-    it 'requires ts' do
-      expect { client.im_mark(channel: %q[D1234567890]) }.to raise_error ArgumentError, /Required arguments :ts missing/
-    end
-  end
-  context 'im_open' do
-    it 'requires user' do
-      expect { client.im_open }.to raise_error ArgumentError, /Required arguments :user missing/
-    end
-  end
-  context 'im_replies' do
-    it 'requires channel' do
-      expect { client.im_replies(thread_ts: %q[1234567890.123456]) }.to raise_error ArgumentError, /Required arguments :channel missing/
-    end
-    it 'requires thread_ts' do
-      expect { client.im_replies(channel: %q[C1234567890]) }.to raise_error ArgumentError, /Required arguments :thread_ts missing/
-    end
-  end
 end

data/spec/slack/web/api/endpoints/mpim_spec.rb

@@ -5,35 +5,4 @@ require 'spec_helper'
 
 RSpec.describe Slack::Web::Api::Endpoints::Mpim do
   let(:client) { Slack::Web::Client.new }
-  context 'mpim_close' do
-    it 'requires channel' do
-      expect { client.mpim_close }.to raise_error ArgumentError, /Required arguments :channel missing/
-    end
-  end
-  context 'mpim_history' do
-    it 'requires channel' do
-      expect { client.mpim_history }.to raise_error ArgumentError, /Required arguments :channel missing/
-    end
-  end
-  context 'mpim_mark' do
-    it 'requires channel' do
-      expect { client.mpim_mark(ts: %q[1593473566.000200]) }.to raise_error ArgumentError, /Required arguments :channel missing/
-    end
-    it 'requires ts' do
-      expect { client.mpim_mark(channel: %q[C012345678]) }.to raise_error ArgumentError, /Required arguments :ts missing/
-    end
-  end
-  context 'mpim_open' do
-    it 'requires users' do
-      expect { client.mpim_open }.to raise_error ArgumentError, /Required arguments :users missing/
-    end
-  end
-  context 'mpim_replies' do
-    it 'requires channel' do
-      expect { client.mpim_replies(thread_ts: %q[1234567890.123456]) }.to raise_error ArgumentError, /Required arguments :channel missing/
-    end
-    it 'requires thread_ts' do
-      expect { client.mpim_replies(channel: %q[C1234567890]) }.to raise_error ArgumentError, /Required arguments :thread_ts missing/
-    end
-  end
 end

data/spec/slack/web/client_spec.rb

@@ -250,21 +250,6 @@ RSpec.describe Slack::Web::Client do
       end
     end
 
-    context 'when calling deprecated methods' do
-      let(:client) { described_class.new }
-
-      it 'produces a warning' do
-        expect(client.logger).to receive(:warn).with(/
-          ^channels\.archive:\ This\ method\ is\ deprecated
-          .+
-          Alternative\ methods:\ conversations\.archive\.
-        /x)
-
-        expect(client).to receive(:post)
-        client.channels_archive(channel: 'test')
-      end
-    end
-
     context 'persistent capability' do
       describe '#initialize' do
         it 'caches the Faraday connection to allow persistent adapters' do
@@ -322,12 +307,22 @@ RSpec.describe Slack::Web::Client do
       end
 
       context '5xx response' do
-        before { stub_slack_request.to_return(status: 500, body: '{}') }
+        context 'with a JSON body' do
+          before { stub_slack_request.to_return(status: 500, body: '{}') }
+
+          it 'raises UnavailableError' do
+            expect { request }.to raise_error(Slack::Web::Api::Errors::UnavailableError).with_message('unavailable_error')
+            expect(exception.response.status).to eq(500)
+          end
+        end
+
+        context 'with a HTML response' do
+          before { stub_slack_request.to_return(status: 500, body: '<html></html>') }
 
-        it 'raises UnavailableError' do
-          expect { request }.to raise_error(Slack::Web::Api::Errors::UnavailableError).with_message('unavailable_error')
-          expect(exception.cause).to be_a(Faraday::ServerError)
-          expect(exception.response.status).to eq(500)
+          it 'raises UnavailableError' do
+            expect { request }.to raise_error(Slack::Web::Api::Errors::UnavailableError).with_message('unavailable_error')
+            expect(exception.response.status).to eq(500)
+          end
         end
       end
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: slack-ruby-client
 version: !ruby/object:Gem::Version
-  version: 0.16.0
+  version: 0.17.0
 platform: ruby
 authors:
 - Daniel Doubrovkine
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-01-24 00:00:00.000000000 Z
+date: 2021-03-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -484,10 +484,10 @@ files:
 - spec/fixtures/slack/web/auth_test_error.yml
 - spec/fixtures/slack/web/auth_test_success.yml
 - spec/fixtures/slack/web/channels_info.yml
+- spec/fixtures/slack/web/conversations_info.yml
 - spec/fixtures/slack/web/conversations_setTopic.yml
 - spec/fixtures/slack/web/conversations_setTopic_one_page.yml
 - spec/fixtures/slack/web/conversations_setTopic_paginated.yml
-- spec/fixtures/slack/web/groups_info.yml
 - spec/fixtures/slack/web/paginated_users_list.yml
 - spec/fixtures/slack/web/rtm_connect.yml
 - spec/fixtures/slack/web/rtm_start.yml
@@ -504,6 +504,8 @@ files:
 - spec/slack/real_time/api/typing_spec.rb
 - spec/slack/real_time/client_spec.rb
 - spec/slack/real_time/concurrency/it_behaves_like_a_realtime_socket.rb
+- spec/slack/real_time/concurrency/with_concurrency_spec.rb
+- spec/slack/real_time/concurrency/without_concurrency_spec.rb
 - spec/slack/real_time/event_handlers/bot_spec.rb
 - spec/slack/real_time/event_handlers/channel_spec.rb
 - spec/slack/real_time/event_handlers/event_handlers_spec.rb
@@ -525,7 +527,6 @@ files:
 - spec/slack/web/api/endpoints/admin_conversations_ekm_spec.rb
 - spec/slack/web/api/endpoints/admin_conversations_restrictAccess_spec.rb
 - spec/slack/web/api/endpoints/admin_conversations_spec.rb
-- spec/slack/web/api/endpoints/admin_conversations_whitelist_spec.rb
 - spec/slack/web/api/endpoints/admin_emoji_spec.rb
 - spec/slack/web/api/endpoints/admin_inviteRequests_approved_spec.rb
 - spec/slack/web/api/endpoints/admin_inviteRequests_denied_spec.rb
@@ -552,10 +553,9 @@ files:
 - spec/slack/web/api/endpoints/chat_scheduledMessages_spec.rb
 - spec/slack/web/api/endpoints/conversations_spec.rb
 - spec/slack/web/api/endpoints/custom_specs/auth_spec.rb
-- spec/slack/web/api/endpoints/custom_specs/channels_spec.rb
 - spec/slack/web/api/endpoints/custom_specs/chat_spec.rb
+- spec/slack/web/api/endpoints/custom_specs/conversations_spec.rb
 - spec/slack/web/api/endpoints/custom_specs/dialog_spec.rb
-- spec/slack/web/api/endpoints/custom_specs/groups_spec.rb
 - spec/slack/web/api/endpoints/custom_specs/users_spec.rb
 - spec/slack/web/api/endpoints/custom_specs/views_spec.rb
 - spec/slack/web/api/endpoints/dnd_spec.rb
@@ -581,7 +581,6 @@ files:
 - spec/slack/web/api/endpoints/users_admin_spec.rb
 - spec/slack/web/api/endpoints/users_prefs_spec.rb
 - spec/slack/web/api/endpoints/users_profile_spec.rb
-- spec/slack/web/api/endpoints/views_spec.rb
 - spec/slack/web/api/endpoints/workflows_spec.rb
 - spec/slack/web/api/error_spec.rb
 - spec/slack/web/api/errors/slack_error_spec.rb
@@ -629,10 +628,10 @@ test_files:
 - spec/fixtures/slack/web/auth_test_error.yml
 - spec/fixtures/slack/web/auth_test_success.yml
 - spec/fixtures/slack/web/channels_info.yml
+- spec/fixtures/slack/web/conversations_info.yml
 - spec/fixtures/slack/web/conversations_setTopic.yml
 - spec/fixtures/slack/web/conversations_setTopic_one_page.yml
 - spec/fixtures/slack/web/conversations_setTopic_paginated.yml
-- spec/fixtures/slack/web/groups_info.yml
 - spec/fixtures/slack/web/paginated_users_list.yml
 - spec/fixtures/slack/web/rtm_connect.yml
 - spec/fixtures/slack/web/rtm_start.yml
@@ -649,6 +648,8 @@ test_files:
 - spec/slack/real_time/api/typing_spec.rb
 - spec/slack/real_time/client_spec.rb
 - spec/slack/real_time/concurrency/it_behaves_like_a_realtime_socket.rb
+- spec/slack/real_time/concurrency/with_concurrency_spec.rb
+- spec/slack/real_time/concurrency/without_concurrency_spec.rb
 - spec/slack/real_time/event_handlers/bot_spec.rb
 - spec/slack/real_time/event_handlers/channel_spec.rb
 - spec/slack/real_time/event_handlers/event_handlers_spec.rb
@@ -670,7 +671,6 @@ test_files:
 - spec/slack/web/api/endpoints/admin_conversations_ekm_spec.rb
 - spec/slack/web/api/endpoints/admin_conversations_restrictAccess_spec.rb
 - spec/slack/web/api/endpoints/admin_conversations_spec.rb
-- spec/slack/web/api/endpoints/admin_conversations_whitelist_spec.rb
 - spec/slack/web/api/endpoints/admin_emoji_spec.rb
 - spec/slack/web/api/endpoints/admin_inviteRequests_approved_spec.rb
 - spec/slack/web/api/endpoints/admin_inviteRequests_denied_spec.rb
@@ -697,10 +697,9 @@ test_files:
 - spec/slack/web/api/endpoints/chat_scheduledMessages_spec.rb
 - spec/slack/web/api/endpoints/conversations_spec.rb
 - spec/slack/web/api/endpoints/custom_specs/auth_spec.rb
-- spec/slack/web/api/endpoints/custom_specs/channels_spec.rb
 - spec/slack/web/api/endpoints/custom_specs/chat_spec.rb
+- spec/slack/web/api/endpoints/custom_specs/conversations_spec.rb
 - spec/slack/web/api/endpoints/custom_specs/dialog_spec.rb
-- spec/slack/web/api/endpoints/custom_specs/groups_spec.rb
 - spec/slack/web/api/endpoints/custom_specs/users_spec.rb
 - spec/slack/web/api/endpoints/custom_specs/views_spec.rb
 - spec/slack/web/api/endpoints/dnd_spec.rb
@@ -726,7 +725,6 @@ test_files:
 - spec/slack/web/api/endpoints/users_admin_spec.rb
 - spec/slack/web/api/endpoints/users_prefs_spec.rb
 - spec/slack/web/api/endpoints/users_profile_spec.rb
-- spec/slack/web/api/endpoints/views_spec.rb
 - spec/slack/web/api/endpoints/workflows_spec.rb
 - spec/slack/web/api/error_spec.rb
 - spec/slack/web/api/errors/slack_error_spec.rb

data/spec/slack/web/api/endpoints/admin_conversations_whitelist_spec.rb

@@ -1,32 +0,0 @@
-# frozen_string_literal: true
-# This file was auto-generated by lib/tasks/web.rake
-
-require 'spec_helper'
-
-RSpec.describe Slack::Web::Api::Endpoints::AdminConversationsWhitelist do
-  let(:client) { Slack::Web::Client.new }
-  context 'admin.conversations.whitelist_add' do
-    it 'requires channel_id' do
-      expect { client.admin_conversations_whitelist_add(group_id: %q[]) }.to raise_error ArgumentError, /Required arguments :channel_id missing/
-    end
-    it 'requires group_id' do
-      expect { client.admin_conversations_whitelist_add(channel_id: %q[]) }.to raise_error ArgumentError, /Required arguments :group_id missing/
-    end
-  end
-  context 'admin.conversations.whitelist_listGroupsLinkedToChannel' do
-    it 'requires channel_id' do
-      expect { client.admin_conversations_whitelist_listGroupsLinkedToChannel }.to raise_error ArgumentError, /Required arguments :channel_id missing/
-    end
-  end
-  context 'admin.conversations.whitelist_remove' do
-    it 'requires channel_id' do
-      expect { client.admin_conversations_whitelist_remove(group_id: %q[], team_id: %q[]) }.to raise_error ArgumentError, /Required arguments :channel_id missing/
-    end
-    it 'requires group_id' do
-      expect { client.admin_conversations_whitelist_remove(channel_id: %q[], team_id: %q[]) }.to raise_error ArgumentError, /Required arguments :group_id missing/
-    end
-    it 'requires team_id' do
-      expect { client.admin_conversations_whitelist_remove(channel_id: %q[], group_id: %q[]) }.to raise_error ArgumentError, /Required arguments :team_id missing/
-    end
-  end
-end

data/spec/slack/web/api/endpoints/custom_specs/channels_spec.rb

@@ -1,13 +0,0 @@
-# frozen_string_literal: true
-require 'spec_helper'
-
-RSpec.describe Slack::Web::Api::Endpoints::Channels do
-  let(:client) { Slack::Web::Client.new }
-
-  context 'channels' do
-    it 'raises deprecation error', vcr: { cassette_name: 'web/channels_info' } do
-      expect { client.channels_info(channel: '#general') }
-        .to raise_error(Slack::Web::Api::Errors::MethodDeprecated, 'method_deprecated')
-    end
-  end
-end

data/spec/slack/web/api/endpoints/custom_specs/groups_spec.rb

@@ -1,13 +0,0 @@
-# frozen_string_literal: true
-require 'spec_helper'
-
-RSpec.describe Slack::Web::Api::Endpoints::Groups do
-  let(:client) { Slack::Web::Client.new }
-
-  context 'groups' do
-    it 'info', vcr: { cassette_name: 'web/groups_info' } do
-      json = client.groups_info(channel: '#mpdm-dblock--rubybot--player1-1')
-      expect(json.group.name).to eq 'mpdm-dblock--rubybot--player1-1'
-    end
-  end
-end

data/spec/slack/web/api/endpoints/views_spec.rb

@@ -1,29 +0,0 @@
-# frozen_string_literal: true
-# This file was auto-generated by lib/tasks/web.rake
-
-require 'spec_helper'
-
-RSpec.describe Slack::Web::Api::Endpoints::Views do
-  let(:client) { Slack::Web::Client.new }
-  context 'views_open' do
-    it 'requires trigger_id' do
-      expect { client.views_open(view: ' ') }.to raise_error ArgumentError, /Required arguments :trigger_id missing/
-    end
-    it 'requires view' do
-      expect { client.views_open(trigger_id: '12345.98765.abcd2358fdea') }.to raise_error ArgumentError, /Required arguments :view missing/
-    end
-  end
-  context 'views_push' do
-    it 'requires trigger_id' do
-      expect { client.views_push(view: ' ') }.to raise_error ArgumentError, /Required arguments :trigger_id missing/
-    end
-    it 'requires view' do
-      expect { client.views_push(trigger_id: '12345.98765.abcd2358fdea') }.to raise_error ArgumentError, /Required arguments :view missing/
-    end
-  end
-  context 'views_update' do
-    it 'requires view' do
-      expect { client.views_update }.to raise_error ArgumentError, /Required arguments :view missing/
-    end
-  end
-end