slack-ruby-client 0.14.5 → 0.14.6

data/spec/slack/web/api/endpoints/apps_permissions_spec.rb

@@ -7,10 +7,10 @@ RSpec.describe Slack::Web::Api::Endpoints::AppsPermissions do
   let(:client) { Slack::Web::Client.new }
   context 'apps.permissions_request' do
     it 'requires scopes' do
-      expect { client.apps_permissions_request(trigger_id: ' ') }.to raise_error ArgumentError, /Required arguments :scopes missing/
+      expect { client.apps_permissions_request(trigger_id: '') }.to raise_error ArgumentError, /Required arguments :scopes missing/
     end
     it 'requires trigger_id' do
-      expect { client.apps_permissions_request(scopes: ' ') }.to raise_error ArgumentError, /Required arguments :trigger_id missing/
+      expect { client.apps_permissions_request(scopes: '') }.to raise_error ArgumentError, /Required arguments :trigger_id missing/
     end
   end
 end

data/spec/slack/web/api/endpoints/apps_permissions_users_spec.rb

@@ -7,13 +7,13 @@ RSpec.describe Slack::Web::Api::Endpoints::AppsPermissionsUsers do
   let(:client) { Slack::Web::Client.new }
   context 'apps.permissions.users_request' do
     it 'requires scopes' do
-      expect { client.apps_permissions_users_request(trigger_id: ' ', user: ' ') }.to raise_error ArgumentError, /Required arguments :scopes missing/
+      expect { client.apps_permissions_users_request(trigger_id: '', user: '') }.to raise_error ArgumentError, /Required arguments :scopes missing/
     end
     it 'requires trigger_id' do
-      expect { client.apps_permissions_users_request(scopes: ' ', user: ' ') }.to raise_error ArgumentError, /Required arguments :trigger_id missing/
+      expect { client.apps_permissions_users_request(scopes: '', user: '') }.to raise_error ArgumentError, /Required arguments :trigger_id missing/
     end
     it 'requires user' do
-      expect { client.apps_permissions_users_request(scopes: ' ', trigger_id: ' ') }.to raise_error ArgumentError, /Required arguments :user missing/
+      expect { client.apps_permissions_users_request(scopes: '', trigger_id: '') }.to raise_error ArgumentError, /Required arguments :user missing/
     end
   end
 end

data/spec/slack/web/api/endpoints/conversations_spec.rb

@@ -63,7 +63,7 @@ RSpec.describe Slack::Web::Api::Endpoints::Conversations do
   end
   context 'conversations_rename' do
     it 'requires channel' do
-      expect { client.conversations_rename(name: ' ') }.to raise_error ArgumentError, /Required arguments :channel missing/
+      expect { client.conversations_rename(name: '') }.to raise_error ArgumentError, /Required arguments :channel missing/
     end
     it 'requires name' do
       expect { client.conversations_rename(channel: 'C1234567890') }.to raise_error ArgumentError, /Required arguments :name missing/

data/spec/slack/web/api/errors/slack_error_spec.rb

@@ -11,6 +11,28 @@ RSpec.describe Slack::Web::Api::Errors::SlackError do
     rescue described_class => e
       expect(e.response).not_to be_nil
       expect(e.response.status).to eq 200
+      expect(e.message).to eql 'not_authed'
+      expect(e.error).to eql 'not_authed'
+      expect(e.response_metadata).to be_nil
+    end
+  end
+
+  it 'provides access to any response_metadata', vcr: { cassette_name: 'web/views_open_error' } do
+    begin
+      client.views_open(trigger_id: 'trigger_id', view: {})
+      raise 'Expected to receive Slack::Web::Api::Errors::SlackError.'
+    rescue described_class => e
+      expect(e.response).not_to be_nil
+      expect(e.response.status).to eq 200
+      expect(e.message).to eql 'invalid_arguments'
+      expect(e.error).to eql 'invalid_arguments'
+      expect(e.response_metadata).to eq(
+        'messages' => [
+          "[ERROR] missing required field: title [json-pointer:\/view]",
+          "[ERROR] missing required field: blocks [json-pointer:\/view]",
+          "[ERROR] missing required field: type [json-pointer:\/view]"
+        ]
+      )
     end
   end
 end

data/spec/slack/web/faraday/response/raise_error_spec.rb

@@ -28,12 +28,34 @@ RSpec.describe Slack::Web::Faraday::Response::RaiseError do
       end
     end
 
-    context 'with a single error in the body' do
-      let(:body) { { 'error' => 'already_in_channel' } }
+    context 'with a single known error in the body' do
+      let(:body) do
+        {
+          'ok' => false,
+          'error' => 'already_in_channel',
+          'response_metadata' => { 'messages' => [] }
+        }
+      end
+
+      it 'raises an error of the matching type with the error message' do
+        expect { raise_error_obj.on_complete(env) }.to(
+          raise_error(Slack::Web::Api::Errors::AlreadyInChannel, 'already_in_channel')
+        )
+      end
+    end
+
+    context 'with a single unknown error in the body' do
+      let(:body) do
+        {
+          'ok' => false,
+          'error' => 'unknown_error',
+          'response_metadata' => { 'messages' => [] }
+        }
+      end
 
       it 'raises a SlackError with the error message' do
         expect { raise_error_obj.on_complete(env) }.to(
-          raise_error(Slack::Web::Api::Errors::SlackError, 'already_in_channel')
+          raise_error(Slack::Web::Api::Errors::SlackError, 'unknown_error')
         )
       end
     end
@@ -41,6 +63,7 @@ RSpec.describe Slack::Web::Faraday::Response::RaiseError do
     context 'with multiple errors in the body' do
       let(:body) do
         {
+          'ok' => false,
           'errors' => [
             { 'error' => 'already_in_channel' },
             { 'error' => 'something_else_terrible' }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: slack-ruby-client
 version: !ruby/object:Gem::Version
-  version: 0.14.5
+  version: 0.14.6
 platform: ruby
 authors:
 - Daniel Doubrovkine
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-12-23 00:00:00.000000000 Z
+date: 2020-03-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -258,7 +258,19 @@ files:
 - UPGRADING.md
 - bin/commands.rb
 - bin/commands/admin_apps.rb
+- bin/commands/admin_apps_approved.rb
 - bin/commands/admin_apps_requests.rb
+- bin/commands/admin_apps_restricted.rb
+- bin/commands/admin_conversations.rb
+- bin/commands/admin_emoji.rb
+- bin/commands/admin_inviteRequests.rb
+- bin/commands/admin_inviteRequests_approved.rb
+- bin/commands/admin_inviteRequests_denied.rb
+- bin/commands/admin_teams.rb
+- bin/commands/admin_teams_admins.rb
+- bin/commands/admin_teams_owners.rb
+- bin/commands/admin_teams_settings.rb
+- bin/commands/admin_users.rb
 - bin/commands/admin_users_session.rb
 - bin/commands/api.rb
 - bin/commands/apps.rb
@@ -356,7 +368,19 @@ files:
 - lib/slack/version.rb
 - lib/slack/web/api/endpoints.rb
 - lib/slack/web/api/endpoints/admin_apps.rb
+- lib/slack/web/api/endpoints/admin_apps_approved.rb
 - lib/slack/web/api/endpoints/admin_apps_requests.rb
+- lib/slack/web/api/endpoints/admin_apps_restricted.rb
+- lib/slack/web/api/endpoints/admin_conversations.rb
+- lib/slack/web/api/endpoints/admin_emoji.rb
+- lib/slack/web/api/endpoints/admin_inviteRequests.rb
+- lib/slack/web/api/endpoints/admin_inviteRequests_approved.rb
+- lib/slack/web/api/endpoints/admin_inviteRequests_denied.rb
+- lib/slack/web/api/endpoints/admin_teams.rb
+- lib/slack/web/api/endpoints/admin_teams_admins.rb
+- lib/slack/web/api/endpoints/admin_teams_owners.rb
+- lib/slack/web/api/endpoints/admin_teams_settings.rb
+- lib/slack/web/api/endpoints/admin_users.rb
 - lib/slack/web/api/endpoints/admin_users_session.rb
 - lib/slack/web/api/endpoints/api.rb
 - lib/slack/web/api/endpoints/apps.rb
@@ -399,6 +423,7 @@ files:
 - lib/slack/web/api/endpoints/users_profile.rb
 - lib/slack/web/api/endpoints/views.rb
 - lib/slack/web/api/error.rb
+- lib/slack/web/api/errors.rb
 - lib/slack/web/api/errors/slack_error.rb
 - lib/slack/web/api/errors/too_many_requests_error.rb
 - lib/slack/web/api/mixins.rb
@@ -425,6 +450,7 @@ files:
 - lib/slack/web/api/templates/command.erb
 - lib/slack/web/api/templates/commands.erb
 - lib/slack/web/api/templates/endpoints.erb
+- lib/slack/web/api/templates/errors.erb
 - lib/slack/web/api/templates/method.erb
 - lib/slack/web/api/templates/method_spec.erb
 - lib/slack/web/client.rb
@@ -452,6 +478,7 @@ files:
 - spec/fixtures/slack/web/rtm_start.yml
 - spec/fixtures/slack/web/users_info.yml
 - spec/fixtures/slack/web/users_list.yml
+- spec/fixtures/slack/web/views_open_error.yml
 - spec/integration/integration_spec.rb
 - spec/slack/config_spec.rb
 - spec/slack/events/config_spec.rb
@@ -476,9 +503,21 @@ files:
 - spec/slack/real_time/store_spec.rb
 - spec/slack/slack_spec.rb
 - spec/slack/version_spec.rb
+- spec/slack/web/api/endpoints/admin_apps_approved_spec.rb
 - spec/slack/web/api/endpoints/admin_apps_requests_spec.rb
+- spec/slack/web/api/endpoints/admin_apps_restricted_spec.rb
 - spec/slack/web/api/endpoints/admin_apps_spec.rb
+- spec/slack/web/api/endpoints/admin_conversations_spec.rb
+- spec/slack/web/api/endpoints/admin_emoji_spec.rb
+- spec/slack/web/api/endpoints/admin_inviteRequests_approved_spec.rb
+- spec/slack/web/api/endpoints/admin_inviteRequests_denied_spec.rb
+- spec/slack/web/api/endpoints/admin_inviteRequests_spec.rb
+- spec/slack/web/api/endpoints/admin_teams_admins_spec.rb
+- spec/slack/web/api/endpoints/admin_teams_owners_spec.rb
+- spec/slack/web/api/endpoints/admin_teams_settings_spec.rb
+- spec/slack/web/api/endpoints/admin_teams_spec.rb
 - spec/slack/web/api/endpoints/admin_users_session_spec.rb
+- spec/slack/web/api/endpoints/admin_users_spec.rb
 - spec/slack/web/api/endpoints/api_spec.rb
 - spec/slack/web/api/endpoints/apps_permissions_resources_spec.rb
 - spec/slack/web/api/endpoints/apps_permissions_scopes_spec.rb
@@ -570,6 +609,7 @@ test_files:
 - spec/fixtures/slack/web/rtm_start.yml
 - spec/fixtures/slack/web/users_info.yml
 - spec/fixtures/slack/web/users_list.yml
+- spec/fixtures/slack/web/views_open_error.yml
 - spec/integration/integration_spec.rb
 - spec/slack/config_spec.rb
 - spec/slack/events/config_spec.rb
@@ -594,9 +634,21 @@ test_files:
 - spec/slack/real_time/store_spec.rb
 - spec/slack/slack_spec.rb
 - spec/slack/version_spec.rb
+- spec/slack/web/api/endpoints/admin_apps_approved_spec.rb
 - spec/slack/web/api/endpoints/admin_apps_requests_spec.rb
+- spec/slack/web/api/endpoints/admin_apps_restricted_spec.rb
 - spec/slack/web/api/endpoints/admin_apps_spec.rb
+- spec/slack/web/api/endpoints/admin_conversations_spec.rb
+- spec/slack/web/api/endpoints/admin_emoji_spec.rb
+- spec/slack/web/api/endpoints/admin_inviteRequests_approved_spec.rb
+- spec/slack/web/api/endpoints/admin_inviteRequests_denied_spec.rb
+- spec/slack/web/api/endpoints/admin_inviteRequests_spec.rb
+- spec/slack/web/api/endpoints/admin_teams_admins_spec.rb
+- spec/slack/web/api/endpoints/admin_teams_owners_spec.rb
+- spec/slack/web/api/endpoints/admin_teams_settings_spec.rb
+- spec/slack/web/api/endpoints/admin_teams_spec.rb
 - spec/slack/web/api/endpoints/admin_users_session_spec.rb
+- spec/slack/web/api/endpoints/admin_users_spec.rb
 - spec/slack/web/api/endpoints/api_spec.rb
 - spec/slack/web/api/endpoints/apps_permissions_resources_spec.rb
 - spec/slack/web/api/endpoints/apps_permissions_scopes_spec.rb