slack-ruby-client 0.14.4 → 0.14.5

data/spec/slack/web/client_spec.rb

@@ -1,11 +1,14 @@
+# frozen_string_literal: true
 require 'spec_helper'
 
 RSpec.describe Slack::Web::Client do
   before do
     Slack::Config.reset
   end
+
   context 'with defaults' do
-    let(:client) { Slack::Web::Client.new }
+    let(:client) { described_class.new }
+
     describe '#initialize' do
       it 'sets user-agent' do
         expect(client.user_agent).to eq Slack::Web::Config.user_agent
@@ -18,30 +21,36 @@ RSpec.describe Slack::Web::Client do
       end
     end
   end
+
   context 'with custom settings' do
     describe '#initialize' do
       Slack::Web::Config::ATTRIBUTES.each do |key|
-        context key do
-          let(:client) { Slack::Web::Client.new(key => 'custom') }
+        context key.to_s do
+          let(:client) { described_class.new(key => 'custom') }
+
           it "sets #{key}" do
-            expect(client.send(key)).to_not eq Slack::Web::Config.send(key)
+            expect(client.send(key)).not_to eq Slack::Web::Config.send(key)
             expect(client.send(key)).to eq 'custom'
           end
         end
       end
     end
   end
+
   context 'global config' do
     after do
-      Slack::Web::Client.config.reset
+      described_class.config.reset
     end
-    let(:client) { Slack::Web::Client.new }
+
+    let(:client) { described_class.new }
+
     context 'user-agent' do
       before do
-        Slack::Web::Client.configure do |config|
+        described_class.configure do |config|
           config.user_agent = 'custom/user-agent'
         end
       end
+
       describe '#initialize' do
         it 'sets user-agent' do
           expect(client.user_agent).to eq 'custom/user-agent'
@@ -54,38 +63,43 @@ RSpec.describe Slack::Web::Client do
         end
       end
     end
+
     context 'token' do
       before do
         Slack.configure do |config|
           config.token = 'global default'
         end
       end
+
       it 'defaults token to global default' do
-        client = Slack::Web::Client.new
+        client = described_class.new
         expect(client.token).to eq 'global default'
       end
       context 'with web config' do
         before do
-          Slack::Web::Client.configure do |config|
+          described_class.configure do |config|
             config.token = 'custom web token'
           end
         end
+
         it 'overrides token to web config' do
-          client = Slack::Web::Client.new
+          client = described_class.new
           expect(client.token).to eq 'custom web token'
         end
         it 'overrides token to specific token' do
-          client = Slack::Web::Client.new(token: 'local token')
+          client = described_class.new(token: 'local token')
           expect(client.token).to eq 'local token'
         end
       end
     end
+
     context 'proxy' do
       before do
-        Slack::Web::Client.configure do |config|
+        described_class.configure do |config|
           config.proxy = 'http://localhost:8080'
         end
       end
+
       describe '#initialize' do
         it 'sets proxy' do
           expect(client.proxy).to eq 'http://localhost:8080'
@@ -95,13 +109,15 @@ RSpec.describe Slack::Web::Client do
         end
       end
     end
+
     context 'SSL options' do
       before do
-        Slack::Web::Client.configure do |config|
+        described_class.configure do |config|
           config.ca_path = '/ca_path'
           config.ca_file = '/ca_file'
         end
       end
+
       describe '#initialize' do
         it 'sets ca_path and ca_file' do
           expect(client.ca_path).to eq '/ca_path'
@@ -114,13 +130,16 @@ RSpec.describe Slack::Web::Client do
         end
       end
     end
+
     context 'logger option' do
       let(:logger) { Logger.new(STDOUT) }
+
       before do
-        Slack::Web::Client.configure do |config|
+        described_class.configure do |config|
           config.logger = logger
         end
       end
+
       describe '#initialize' do
         it 'sets logger' do
           expect(client.logger).to eq logger
@@ -130,13 +149,15 @@ RSpec.describe Slack::Web::Client do
         end
       end
     end
+
     context 'timeout options' do
       before do
-        Slack::Web::Client.configure do |config|
+        described_class.configure do |config|
           config.timeout = 10
           config.open_timeout = 15
         end
       end
+
       describe '#initialize' do
         it 'sets timeout and open_timeout' do
           expect(client.timeout).to eq 10
@@ -149,13 +170,15 @@ RSpec.describe Slack::Web::Client do
         end
       end
     end
+
     context 'per-request options' do
       it 'applies timeout', vcr: { cassette_name: 'web/rtm_start', allow_playback_repeats: true } do
         # reuse the same connection for the test, otherwise it creates a new one every time
         conn = client.send(:connection)
         expect(client).to receive(:connection).and_return(conn)
 
-        # get the yielded request to reuse in the next call to rtm_start so that we can examine request.options later
+        # get the yielded request to reuse in the next call to
+        # rtm_start so that we can examine request.options later
         request = nil
         response = conn.post do |r|
           r.path = 'rtm.start'
@@ -170,10 +193,14 @@ RSpec.describe Slack::Web::Client do
         expect(request.options.timeout).to eq 3
       end
     end
+
     context 'calling undocumented methods' do
-      let(:client) { Slack::Web::Client.new }
+      let(:client) { described_class.new }
+
       it 'produces a warning' do
-        expect(client.logger).to receive(:warn).with('The users.admin.setInactive method is undocumented.')
+        expect(client.logger).to(
+          receive(:warn).with('The users.admin.setInactive method is undocumented.')
+        )
         expect(client).to receive(:post)
         client.users_admin_setInactive(user: 'U092BDCLV')
       end

data/spec/slack/web/faraday/response/raise_error_spec.rb

@@ -1,8 +1,10 @@
+# frozen_string_literal: true
 require 'spec_helper'
 
 RSpec.describe Slack::Web::Faraday::Response::RaiseError do
+  subject(:raise_error_obj) { described_class.new }
+
   describe '#on_complete' do
-    let(:subject) { described_class.new }
     let(:status) { 200 }
     let(:response) { nil }
     let(:body) { {} }
@@ -12,7 +14,9 @@ RSpec.describe Slack::Web::Faraday::Response::RaiseError do
       let(:status) { 429 }
 
       it 'raises a TooManyRequestsError' do
-        expect { subject.on_complete(env) }.to raise_error(Slack::Web::Api::Errors::TooManyRequestsError)
+        expect { raise_error_obj.on_complete(env) }.to(
+          raise_error(Slack::Web::Api::Errors::TooManyRequestsError)
+        )
       end
     end
 
@@ -20,7 +24,7 @@ RSpec.describe Slack::Web::Faraday::Response::RaiseError do
       let(:body) { { 'ok' => 'true' } }
 
       it 'is nil' do
-        expect(subject.on_complete(env)).to eq nil
+        expect(raise_error_obj.on_complete(env)).to eq nil
       end
     end
 
@@ -28,7 +32,9 @@ RSpec.describe Slack::Web::Faraday::Response::RaiseError do
       let(:body) { { 'error' => 'already_in_channel' } }
 
       it 'raises a SlackError with the error message' do
-        expect { subject.on_complete(env) }.to raise_error(Slack::Web::Api::Errors::SlackError, 'already_in_channel')
+        expect { raise_error_obj.on_complete(env) }.to(
+          raise_error(Slack::Web::Api::Errors::SlackError, 'already_in_channel')
+        )
       end
     end
 
@@ -43,7 +49,12 @@ RSpec.describe Slack::Web::Faraday::Response::RaiseError do
       end
 
       it 'raises a SlackError with the concatenated error messages' do
-        expect { subject.on_complete(env) }.to raise_error(Slack::Web::Api::Errors::SlackError, 'already_in_channel,something_else_terrible')
+        expect { raise_error_obj.on_complete(env) }.to(
+          raise_error(
+            Slack::Web::Api::Errors::SlackError,
+            'already_in_channel,something_else_terrible'
+          )
+        )
       end
     end
   end

data/spec/spec_helper.rb

@@ -1,10 +1,11 @@
+# frozen_string_literal: true
 $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..'))
 
 require 'rubygems'
 require 'rspec'
 require 'timecop'
 
-require 'slack-ruby-client'
+require 'slack_ruby_client'
 
 Dir[File.join(File.dirname(__FILE__), 'support', '**/*.rb')].each do |file|
   require file

data/spec/support/queue_with_timeout.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # http://spin.atomicobject.com/2014/07/07/ruby-queue-pop-timeout/
 class QueueWithTimeout
   def initialize

data/spec/support/real_time/concurrency/mock.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Slack
   module RealTime
     module Concurrency

data/spec/support/real_time/connected_client.rb

@@ -1,18 +1,24 @@
+# frozen_string_literal: true
 RSpec.shared_context 'connected client' do |opts|
   let(:client) { Slack::RealTime::Client.new(opts || {}) }
   let(:ws) { double(Slack::RealTime::Concurrency::Mock::WebSocket) }
   let(:url) do
-    Slack::RealTime.config.store_class == Slack::RealTime::Stores::Store ?
-      'wss://ms173.slack-msgs.com/websocket/lqcUiAvrKTP-uuid=' :
+    if Slack::RealTime.config.store_class == Slack::RealTime::Stores::Store
+      'wss://ms173.slack-msgs.com/websocket/lqcUiAvrKTP-uuid='
+    else
       'wss://mpmulti-w5tz.slack-msgs.com/websocket/uid'
+    end
   end
   let(:socket) { double(Slack::RealTime::Socket, connected?: true) }
+
   before do
     Slack::RealTime.configure do |config|
       config.concurrency = Slack::RealTime::Concurrency::Mock
       config.store_class = (opts || {})[:store_class] || Slack::RealTime::Stores::Store
     end
-    allow(Slack::RealTime::Socket).to receive(:new).with(url, ping: 30, logger: Slack::Logger.default).and_return(socket)
+    allow(Slack::RealTime::Socket).to(
+      receive(:new).with(url, ping: 30, logger: Slack::Logger.default).and_return(socket)
+    )
     allow(socket).to receive(:start_sync)
     allow(socket).to receive(:connect!)
     allow(ws).to receive(:on)

data/spec/support/real_time/event.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Slack
   module RealTime
     class Event

data/spec/support/token.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 RSpec.configure do |config|
   config.before do
     @old_token = Slack::Config.token

data/spec/support/vcr.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'vcr'
 require 'webmock/rspec'
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: slack-ruby-client
 version: !ruby/object:Gem::Version
-  version: 0.14.4
+  version: 0.14.5
 platform: ruby
 authors:
 - Daniel Doubrovkine
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-07-28 00:00:00.000000000 Z
+date: 2019-12-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -154,16 +154,44 @@ dependencies:
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.73.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.73.0
+- !ruby/object:Gem::Dependency
+  name: rubocop-performance
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.61.1
+        version: 1.4.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.4.1
+- !ruby/object:Gem::Dependency
+  name: rubocop-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.34.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.61.1
+        version: 1.34.0
 - !ruby/object:Gem::Dependency
   name: timecop
   requirement: !ruby/object:Gem::Requirement
@@ -229,6 +257,8 @@ files:
 - Rakefile
 - UPGRADING.md
 - bin/commands.rb
+- bin/commands/admin_apps.rb
+- bin/commands/admin_apps_requests.rb
 - bin/commands/admin_users_session.rb
 - bin/commands/api.rb
 - bin/commands/apps.rb
@@ -247,11 +277,13 @@ files:
 - bin/commands/emoji.rb
 - bin/commands/files.rb
 - bin/commands/files_comments.rb
+- bin/commands/files_remote.rb
 - bin/commands/groups.rb
 - bin/commands/im.rb
 - bin/commands/migration.rb
 - bin/commands/mpim.rb
 - bin/commands/oauth.rb
+- bin/commands/oauth_v2.rb
 - bin/commands/pins.rb
 - bin/commands/reactions.rb
 - bin/commands/reminders.rb
@@ -266,6 +298,7 @@ files:
 - bin/commands/users_admin.rb
 - bin/commands/users_prefs.rb
 - bin/commands/users_profile.rb
+- bin/commands/views.rb
 - bin/slack
 - examples/hi_real_time/Gemfile
 - examples/hi_real_time/hi.gif
@@ -322,6 +355,8 @@ files:
 - lib/slack/real_time/stores/store.rb
 - lib/slack/version.rb
 - lib/slack/web/api/endpoints.rb
+- lib/slack/web/api/endpoints/admin_apps.rb
+- lib/slack/web/api/endpoints/admin_apps_requests.rb
 - lib/slack/web/api/endpoints/admin_users_session.rb
 - lib/slack/web/api/endpoints/api.rb
 - lib/slack/web/api/endpoints/apps.rb
@@ -340,11 +375,13 @@ files:
 - lib/slack/web/api/endpoints/emoji.rb
 - lib/slack/web/api/endpoints/files.rb
 - lib/slack/web/api/endpoints/files_comments.rb
+- lib/slack/web/api/endpoints/files_remote.rb
 - lib/slack/web/api/endpoints/groups.rb
 - lib/slack/web/api/endpoints/im.rb
 - lib/slack/web/api/endpoints/migration.rb
 - lib/slack/web/api/endpoints/mpim.rb
 - lib/slack/web/api/endpoints/oauth.rb
+- lib/slack/web/api/endpoints/oauth_v2.rb
 - lib/slack/web/api/endpoints/pins.rb
 - lib/slack/web/api/endpoints/presence.rb
 - lib/slack/web/api/endpoints/reactions.rb
@@ -360,6 +397,7 @@ files:
 - lib/slack/web/api/endpoints/users_admin.rb
 - lib/slack/web/api/endpoints/users_prefs.rb
 - lib/slack/web/api/endpoints/users_profile.rb
+- lib/slack/web/api/endpoints/views.rb
 - lib/slack/web/api/error.rb
 - lib/slack/web/api/errors/slack_error.rb
 - lib/slack/web/api/errors/too_many_requests_error.rb
@@ -380,6 +418,8 @@ files:
 - lib/slack/web/api/patches/chat.5.postEphemeral-text-or-attachments.patch
 - lib/slack/web/api/patches/chat.6.block-kit-support.patch
 - lib/slack/web/api/patches/dialog.1.open-json-support.patch
+- lib/slack/web/api/patches/views.1.view-json.patch
+- lib/slack/web/api/patches/views.1.views-published.patch
 - lib/slack/web/api/schema/group.json
 - lib/slack/web/api/schema/method.json
 - lib/slack/web/api/templates/command.erb
@@ -398,7 +438,7 @@ files:
 - lib/tasks/real_time.rake
 - lib/tasks/update.rake
 - lib/tasks/web.rake
-- screenshots/register-bot.png
+- screenshots/create-app.png
 - slack-ruby-client.gemspec
 - slack.png
 - spec/fixtures/slack/web/429_error.yml
@@ -436,6 +476,8 @@ files:
 - spec/slack/real_time/store_spec.rb
 - spec/slack/slack_spec.rb
 - spec/slack/version_spec.rb
+- spec/slack/web/api/endpoints/admin_apps_requests_spec.rb
+- spec/slack/web/api/endpoints/admin_apps_spec.rb
 - spec/slack/web/api/endpoints/admin_users_session_spec.rb
 - spec/slack/web/api/endpoints/api_spec.rb
 - spec/slack/web/api/endpoints/apps_permissions_resources_spec.rb
@@ -452,14 +494,17 @@ files:
 - spec/slack/web/api/endpoints/custom_specs/dialog_spec.rb
 - spec/slack/web/api/endpoints/custom_specs/groups_spec.rb
 - spec/slack/web/api/endpoints/custom_specs/users_spec.rb
+- spec/slack/web/api/endpoints/custom_specs/views_spec.rb
 - spec/slack/web/api/endpoints/dnd_spec.rb
 - spec/slack/web/api/endpoints/emoji_spec.rb
 - spec/slack/web/api/endpoints/files_comments_spec.rb
+- spec/slack/web/api/endpoints/files_remote_spec.rb
 - spec/slack/web/api/endpoints/files_spec.rb
 - spec/slack/web/api/endpoints/im_spec.rb
 - spec/slack/web/api/endpoints/migration_spec.rb
 - spec/slack/web/api/endpoints/mpim_spec.rb
 - spec/slack/web/api/endpoints/oauth_spec.rb
+- spec/slack/web/api/endpoints/oauth_v2_spec.rb
 - spec/slack/web/api/endpoints/pins_spec.rb
 - spec/slack/web/api/endpoints/reactions_spec.rb
 - spec/slack/web/api/endpoints/reminders_spec.rb
@@ -473,6 +518,7 @@ files:
 - spec/slack/web/api/endpoints/users_admin_spec.rb
 - spec/slack/web/api/endpoints/users_prefs_spec.rb
 - spec/slack/web/api/endpoints/users_profile_spec.rb
+- spec/slack/web/api/endpoints/views_spec.rb
 - spec/slack/web/api/error_spec.rb
 - spec/slack/web/api/errors/service_unavailable_spec.rb
 - spec/slack/web/api/errors/slack_error_spec.rb
@@ -548,6 +594,8 @@ test_files:
 - spec/slack/real_time/store_spec.rb
 - spec/slack/slack_spec.rb
 - spec/slack/version_spec.rb
+- spec/slack/web/api/endpoints/admin_apps_requests_spec.rb
+- spec/slack/web/api/endpoints/admin_apps_spec.rb
 - spec/slack/web/api/endpoints/admin_users_session_spec.rb
 - spec/slack/web/api/endpoints/api_spec.rb
 - spec/slack/web/api/endpoints/apps_permissions_resources_spec.rb
@@ -564,14 +612,17 @@ test_files:
 - spec/slack/web/api/endpoints/custom_specs/dialog_spec.rb
 - spec/slack/web/api/endpoints/custom_specs/groups_spec.rb
 - spec/slack/web/api/endpoints/custom_specs/users_spec.rb
+- spec/slack/web/api/endpoints/custom_specs/views_spec.rb
 - spec/slack/web/api/endpoints/dnd_spec.rb
 - spec/slack/web/api/endpoints/emoji_spec.rb
 - spec/slack/web/api/endpoints/files_comments_spec.rb
+- spec/slack/web/api/endpoints/files_remote_spec.rb
 - spec/slack/web/api/endpoints/files_spec.rb
 - spec/slack/web/api/endpoints/im_spec.rb
 - spec/slack/web/api/endpoints/migration_spec.rb
 - spec/slack/web/api/endpoints/mpim_spec.rb
 - spec/slack/web/api/endpoints/oauth_spec.rb
+- spec/slack/web/api/endpoints/oauth_v2_spec.rb
 - spec/slack/web/api/endpoints/pins_spec.rb
 - spec/slack/web/api/endpoints/reactions_spec.rb
 - spec/slack/web/api/endpoints/reminders_spec.rb
@@ -585,6 +636,7 @@ test_files:
 - spec/slack/web/api/endpoints/users_admin_spec.rb
 - spec/slack/web/api/endpoints/users_prefs_spec.rb
 - spec/slack/web/api/endpoints/users_profile_spec.rb
+- spec/slack/web/api/endpoints/views_spec.rb
 - spec/slack/web/api/error_spec.rb
 - spec/slack/web/api/errors/service_unavailable_spec.rb
 - spec/slack/web/api/errors/slack_error_spec.rb