slack-ruby-bot 0.12.0 → 0.16.1

data/spec/slack-ruby-bot/commands/bot_messages_spec.rb

@@ -0,0 +1,26 @@
+# frozen_string_literal: true
+
+describe SlackRubyBot::App do
+  def app
+    SlackRubyBot::App.new
+  end
+
+  let(:client) { subject.send(:client) }
+  let(:message_hook) { SlackRubyBot::Hooks::Message.new }
+
+  context 'default' do
+    it 'does not respond to bot messages' do
+      expect(client).to_not receive(:message)
+      message_hook.call(client, Hashie::Mash.new(text: "#{SlackRubyBot.config.user} hi", subtype: 'bot_message'))
+    end
+  end
+  context 'with allow_bot_messages=true' do
+    before do
+      SlackRubyBot::Config.allow_bot_messages = true
+    end
+    it 'responds to self' do
+      expect(client).to receive(:message)
+      message_hook.call(client, Hashie::Mash.new(text: "#{SlackRubyBot.config.user} hi", subtype: 'bot_message'))
+    end
+  end
+end

data/spec/slack-ruby-bot/commands/bot_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe SlackRubyBot::Bot do
   let! :command do
     Class.new(SlackRubyBot::Bot) do

data/spec/slack-ruby-bot/commands/commands_command_classes_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe SlackRubyBot::Commands::Base do
   let! :command1 do
     Class.new(SlackRubyBot::Commands::Base) do

data/spec/slack-ruby-bot/commands/commands_permitted_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe SlackRubyBot::Commands, 'permitted?' do
   let! :command do
     Class.new(SlackRubyBot::Commands::Base) do

data/spec/slack-ruby-bot/commands/commands_precedence_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe SlackRubyBot::Commands do
   let! :command do
     Class.new(SlackRubyBot::Commands::Base) do

data/spec/slack-ruby-bot/commands/commands_regexp_escape_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe SlackRubyBot::Commands do
   let! :command do
     Class.new(SlackRubyBot::Commands::Base) do

data/spec/slack-ruby-bot/commands/commands_regexp_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe SlackRubyBot::Commands do
   let! :command do
     Class.new(SlackRubyBot::Commands::Base) do

data/spec/slack-ruby-bot/commands/commands_spaces_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe SlackRubyBot::Commands do
   let! :command do
     Class.new(SlackRubyBot::Commands::Base) do

data/spec/slack-ruby-bot/commands/commands_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe SlackRubyBot::Commands do
   let! :command do
     Class.new(SlackRubyBot::Commands::Base) do

data/spec/slack-ruby-bot/commands/commands_with_block_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe SlackRubyBot::Commands do
   let! :command do
     Class.new(SlackRubyBot::Commands::Base) do

data/spec/slack-ruby-bot/commands/commands_with_expression_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe SlackRubyBot::Commands do
   let! :command do
     Class.new(SlackRubyBot::Commands::Base) do

data/spec/slack-ruby-bot/commands/direct_messages_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe SlackRubyBot do
   def app
     SlackRubyBot::App.new

data/spec/slack-ruby-bot/commands/empty_text_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe SlackRubyBot::Commands do
   let! :command do
     Class.new(SlackRubyBot::Commands::Base) do

data/spec/slack-ruby-bot/commands/help_spec.rb

@@ -1,25 +1,27 @@
+# frozen_string_literal: true
+
 describe SlackRubyBot::Commands::Help do
   def app
     SlackRubyBot::App.new
   end
   it 'help' do
-    message = <<MSG
-*Weather Bot* - This bot tells you the weather.
+    message = <<~MSG
+      *Weather Bot* - This bot tells you the weather.
 
-*Commands:*
-*clouds* - Tells you how many clouds there're above you.
-*command_without_description*
-*What's the weather in <city>?* - Tells you the weather in a <city>.
+      *Commands:*
+      *clouds* - Tells you how many clouds there're above you.
+      *command_without_description*
+      *What's the weather in <city>?* - Tells you the weather in a <city>.
 
-*Other commands:*
-*help* - Shows help information.
-*hi* - Says hello.
-*hello* - Says hello.
+      *Other commands:*
+      *help* - Shows help information.
+      *hi* - Says hello.
+      *hello* - Says hello.
 
-For getting description of the command use: *help <command>*
+      For getting description of the command use: *help <command>*
 
-For more information see https://github.com/slack-ruby/slack-ruby-bot, please.
-MSG
+      For more information see https://github.com/slack-ruby/slack-ruby-bot, please.
+    MSG
 
     expect(message: "#{SlackRubyBot.config.user} help").to respond_with_slack_message(message)
   end

data/spec/slack-ruby-bot/commands/hi_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe SlackRubyBot::Commands::Hi do
   def app
     SlackRubyBot::App.new

data/spec/slack-ruby-bot/commands/match_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe SlackRubyBot::Commands do
   let! :command do
     Class.new(SlackRubyBot::Commands::Base) do

data/spec/slack-ruby-bot/commands/message_loop_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe SlackRubyBot::App do
   def app
     SlackRubyBot::App.new

data/spec/slack-ruby-bot/commands/nil_message_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe SlackRubyBot::Commands do
   let! :command do
     Class.new(SlackRubyBot::Commands::Base) do

data/spec/slack-ruby-bot/commands/non_breaking_space_spec.rb

@@ -0,0 +1,29 @@
+# frozen_string_literal: true
+
+describe SlackRubyBot::Commands do
+  let! :command do
+    Class.new(SlackRubyBot::Commands::Base) do
+      command 'non_breaking_space' do |client, data, match|
+        client.say(channel: data.channel, text: match['expression'])
+      end
+    end
+  end
+  it 'sends a message with non-breaking space after bot name' do
+    expect(message: "#{SlackRubyBot.config.user}\u00a0non_breaking_space message").to respond_with_slack_message('message')
+  end
+  it 'sends a message with non-breaking space after command' do
+    expect(message: "#{SlackRubyBot.config.user} non_breaking_space\u00a0message").to respond_with_slack_message('message')
+  end
+  it 'sends a message with all non-breaking spaces' do
+    expect(message: "#{SlackRubyBot.config.user}\u00a0non_breaking_space\u00a0message").to respond_with_slack_message('message')
+  end
+  it 'sends a message with trailing non-breaking spaces' do
+    expect(message: "#{SlackRubyBot.config.user} non_breaking_space message\u00a0").to respond_with_slack_message("message\u00a0")
+  end
+  it 'sends a message with multiple non-breaking spaces' do
+    expect(message: "#{SlackRubyBot.config.user} non_breaking_space message1\u00a0message2").to respond_with_slack_message("message1\u00a0message2")
+  end
+  it 'sends a message with non-breaking spaces on multiple lines' do
+    expect(message: "#{SlackRubyBot.config.user} non_breaking_space message1\u00a0message2\nmessage3\u00a0message4").to respond_with_slack_message("message1\u00a0message2\nmessage3\u00a0message4")
+  end
+end

data/spec/slack-ruby-bot/commands/not_implemented_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe SlackRubyBot::Commands::Base do
   let! :command do
     Class.new(SlackRubyBot::Commands::Base) do

data/spec/slack-ruby-bot/commands/operators_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe SlackRubyBot::Commands do
   let! :command do
     Class.new(SlackRubyBot::Commands::Base) do

data/spec/slack-ruby-bot/commands/operators_with_block_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe SlackRubyBot::Commands do
   let! :command do
     Class.new(SlackRubyBot::Commands::Base) do

data/spec/slack-ruby-bot/commands/scan_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe SlackRubyBot::Commands do
   let! :command do
     Class.new(SlackRubyBot::Commands::Base) do

data/spec/slack-ruby-bot/commands/send_message_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe SlackRubyBot::Commands do
   let! :command do
     Class.new(SlackRubyBot::Commands::Base) do

data/spec/slack-ruby-bot/commands/support/attrs_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe SlackRubyBot::Commands::Support::Attrs do
   let(:help_attrs) { described_class.new('WeatherBot') }
 

data/spec/slack-ruby-bot/commands/support/help_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe SlackRubyBot::Commands::Support::Help do
   let(:bot_class) { Testing::WeatherBot }
   let(:command_class) { Testing::HelloCommand }

data/spec/slack-ruby-bot/commands/support/match_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe SlackRubyBot::Commands::Support::Match do
   context 'initialized with invalid args' do
     subject { -> { described_class.new('invalid-match-data') } }

data/spec/slack-ruby-bot/commands/unknown_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe SlackRubyBot::Commands::Unknown do
   it 'invalid command' do
     expect(message: "#{SlackRubyBot.config.user} foobar").to respond_with_slack_message("Sorry <@user>, I don't understand that command!")

data/spec/slack-ruby-bot/config_spec.rb

@@ -1,61 +1,6 @@
-describe SlackRubyBot::Config do
-  describe '.send_gifs?' do
-    after { ENV.delete 'SLACK_RUBY_BOT_SEND_GIFS' }
-
-    context 'without giphy is false', unless: WithGiphy.env? do
-      it 'by default' do
-        expect(SlackRubyBot::Config.send_gifs?).to be false
-      end
-      it 'when set to true' do
-        SlackRubyBot::Config.send_gifs = true
-        expect(SlackRubyBot::Config.send_gifs?).to be false
-      end
-      it 'when set to true via SLACK_RUBY_BOT_SEND_GIFS' do
-        ENV['SLACK_RUBY_BOT_SEND_GIFS'] = 'true'
-        expect(SlackRubyBot::Config.send_gifs?).to be false
-      end
-    end
-    context 'with giphy', if: WithGiphy.env? do
-      it 'default is true' do
-        expect(SlackRubyBot::Config.send_gifs?).to be true
-      end
-      context 'set to false' do
-        it 'is false' do
-          SlackRubyBot::Config.send_gifs = false
-          expect(SlackRubyBot::Config.send_gifs?).to be false
-        end
-      end
-      context 'set to false via SLACK_RUBY_BOT_SEND_GIFS' do
-        it 'is false' do
-          ENV['SLACK_RUBY_BOT_SEND_GIFS'] = 'false'
-          expect(SlackRubyBot::Config.send_gifs?).to be false
-        end
-      end
-      context 'set to true' do
-        it 'is true' do
-          SlackRubyBot::Config.send_gifs = true
-          expect(SlackRubyBot::Config.send_gifs?).to be true
-        end
-      end
-      context 'set to true via SLACK_RUBY_BOT_SEND_GIFS' do
-        it 'is true' do
-          ENV['SLACK_RUBY_BOT_SEND_GIFS'] = 'true'
-          expect(SlackRubyBot::Config.send_gifs?).to be true
-        end
-      end
-      context 'when using both methods' do
-        it 'config setting takes precedence' do
-          ENV['SLACK_RUBY_BOT_SEND_GIFS'] = 'true'
-          SlackRubyBot::Config.send_gifs = false
-          expect(SlackRubyBot::Config.send_gifs?).to be false
-          ENV['SLACK_RUBY_BOT_SEND_GIFS'] = 'false'
-          SlackRubyBot::Config.send_gifs = true
-          expect(SlackRubyBot::Config.send_gifs?).to be true
-        end
-      end
-    end
-  end
+# frozen_string_literal: true
 
+describe SlackRubyBot::Config do
   describe '#reset!' do
     it 'sets all config attributes to nil' do
       SlackRubyBot::Config::ATTRS.each do |attr|

data/spec/slack-ruby-bot/hooks/hello_spec.rb

@@ -0,0 +1,51 @@
+# frozen_string_literal: true
+
+describe SlackRubyBot::Hooks::Hello do
+  let(:logger) { double(:logger, info: nil) }
+  let(:hello_hook) { described_class.new(logger) }
+
+  describe '#call' do
+    let(:team_name) { 'Example Team' }
+    let(:team_id) { SecureRandom.uuid }
+    let(:team_domain) { 'example' }
+    let(:team) { double(:team, name: team_name, id: team_id, domain: team_domain) }
+    let(:client) { instance_double(SlackRubyBot::Client, team: team) }
+
+    def receive_hello
+      hello_hook.call(client, double)
+    end
+
+    it 'logs the connection' do
+      expect(logger).to receive(:info).with("Successfully connected team #{team_name} (#{team_id}) to https://#{team_domain}.slack.com.")
+      receive_hello
+    end
+
+    context 'with no client' do
+      let(:client) { nil }
+      it 'does nothing' do
+        expect(logger).not_to receive(:info)
+        receive_hello
+      end
+    end
+
+    context 'when client has no team' do
+      let(:team) { nil }
+      it 'does nothing' do
+        expect(logger).not_to receive(:info)
+        receive_hello
+      end
+    end
+
+    context 'when hook is received multiple times' do
+      before do
+        receive_hello
+      end
+
+      it 'logs the reconnections' do
+        expect(logger).to receive(:info).with(/^Successfully reconnected .+ after \S+s\.$/).twice
+        receive_hello
+        receive_hello
+      end
+    end
+  end
+end

data/spec/slack-ruby-bot/hooks/hook_support_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe SlackRubyBot::Hooks::HookSupport do
   subject do
     Class.new do
@@ -54,11 +56,6 @@ describe SlackRubyBot::Hooks::HookSupport do
     end
   end
 
-  describe '#hooks' do
-    subject { super().new }
-    it { expect(subject.hooks).to eq subject.send(:_hooks) }
-  end
-
   describe '#_hooks' do
     it 'returns a SlackRubyBot::Hooks::Set instance' do
       hooks_set = subject.new.send(:_hooks)

data/spec/slack-ruby-bot/hooks/message_spec.rb

@@ -1,12 +1,16 @@
+# frozen_string_literal: true
+
 describe SlackRubyBot::Hooks::Message do
   let(:message_hook) { described_class.new }
 
   describe '#call' do
     it 'doesn\'t raise an error when message is a frozen string' do
-      message_hook.call(
-        SlackRubyBot::Client.new,
-        Hashie::Mash.new(text: 'message'.freeze)
-      )
+      expect do
+        message_hook.call(
+          SlackRubyBot::Client.new,
+          Hashie::Mash.new(text: 'message'.freeze) # rubocop:disable Style/RedundantFreeze
+        )
+      end.to_not raise_error
     end
   end
 
@@ -30,37 +34,6 @@ describe SlackRubyBot::Hooks::Message do
       expect(built_in_command_classes).to_not include SlackRubyBot::Commands::Unknown
     end
   end
-  describe '#message_to_self_not_allowed?' do
-    context 'with allow_message_loops set to true' do
-      before do
-        SlackRubyBot::Config.allow_message_loops = true
-      end
-      it do
-        expect(message_hook.send(:message_to_self_not_allowed?)).to be false
-      end
-    end
-    context 'with allow_message_loops set to false' do
-      before do
-        SlackRubyBot::Config.allow_message_loops = false
-      end
-      it do
-        expect(message_hook.send(:message_to_self_not_allowed?)).to be true
-      end
-    end
-  end
-  describe '#message_to_self?' do
-    let(:client) { Hashie::Mash.new(self: { 'id' => 'U0K8CKKT1' }) }
-    context 'with message to self' do
-      it do
-        expect(message_hook.send(:message_to_self?, client, Hashie::Mash.new(user: 'U0K8CKKT1'))).to be true
-      end
-    end
-    context 'with message to another user' do
-      it do
-        expect(message_hook.send(:message_to_self?, client, Hashie::Mash.new(user: 'U0K8CKKT2'))).to be false
-      end
-    end
-  end
   describe '#message' do
     let(:client) { Hashie::Mash.new(self: { 'id' => 'U0K8CKKT1' }) }
     it 'invokes a command' do