slack-ruby-bot 0.12.0 → 0.13.0

data/spec/slack-ruby-bot/app_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe SlackRubyBot::App do
   def app
     SlackRubyBot::App.new

data/spec/slack-ruby-bot/client_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe SlackRubyBot::Client do
   describe '#send_gifs?' do
     context 'without giphy is false', unless: WithGiphy.env? do

data/spec/slack-ruby-bot/commands/about_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe SlackRubyBot::Commands::Default do
   it 'lowercase' do
     expect(message: SlackRubyBot.config.user).to respond_with_slack_message(SlackRubyBot::ABOUT)

data/spec/slack-ruby-bot/commands/aliases_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe SlackRubyBot do
   def client
     SlackRubyBot::Client.new aliases: %w[:emoji: alias каспаров B0?.@(*^$]

data/spec/slack-ruby-bot/commands/attachment_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe SlackRubyBot::Commands do
   context 'optional fields to scan' do
     let! :command do

data/spec/slack-ruby-bot/commands/bot_message_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe SlackRubyBot::Commands::Unknown do
   def app
     SlackRubyBot::App.new

data/spec/slack-ruby-bot/commands/bot_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe SlackRubyBot::Bot do
   let! :command do
     Class.new(SlackRubyBot::Bot) do

data/spec/slack-ruby-bot/commands/commands_command_classes_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe SlackRubyBot::Commands::Base do
   let! :command1 do
     Class.new(SlackRubyBot::Commands::Base) do

data/spec/slack-ruby-bot/commands/commands_permitted_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe SlackRubyBot::Commands, 'permitted?' do
   let! :command do
     Class.new(SlackRubyBot::Commands::Base) do

data/spec/slack-ruby-bot/commands/commands_precedence_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe SlackRubyBot::Commands do
   let! :command do
     Class.new(SlackRubyBot::Commands::Base) do

data/spec/slack-ruby-bot/commands/commands_regexp_escape_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe SlackRubyBot::Commands do
   let! :command do
     Class.new(SlackRubyBot::Commands::Base) do

data/spec/slack-ruby-bot/commands/commands_regexp_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe SlackRubyBot::Commands do
   let! :command do
     Class.new(SlackRubyBot::Commands::Base) do

data/spec/slack-ruby-bot/commands/commands_spaces_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe SlackRubyBot::Commands do
   let! :command do
     Class.new(SlackRubyBot::Commands::Base) do

data/spec/slack-ruby-bot/commands/commands_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe SlackRubyBot::Commands do
   let! :command do
     Class.new(SlackRubyBot::Commands::Base) do

data/spec/slack-ruby-bot/commands/commands_with_block_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe SlackRubyBot::Commands do
   let! :command do
     Class.new(SlackRubyBot::Commands::Base) do

data/spec/slack-ruby-bot/commands/commands_with_expression_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe SlackRubyBot::Commands do
   let! :command do
     Class.new(SlackRubyBot::Commands::Base) do

data/spec/slack-ruby-bot/commands/direct_messages_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe SlackRubyBot do
   def app
     SlackRubyBot::App.new

data/spec/slack-ruby-bot/commands/empty_text_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe SlackRubyBot::Commands do
   let! :command do
     Class.new(SlackRubyBot::Commands::Base) do

data/spec/slack-ruby-bot/commands/help_spec.rb

@@ -1,25 +1,27 @@
+# frozen_string_literal: true
+
 describe SlackRubyBot::Commands::Help do
   def app
     SlackRubyBot::App.new
   end
   it 'help' do
-    message = <<MSG
-*Weather Bot* - This bot tells you the weather.
+    message = <<~MSG
+      *Weather Bot* - This bot tells you the weather.
 
-*Commands:*
-*clouds* - Tells you how many clouds there're above you.
-*command_without_description*
-*What's the weather in <city>?* - Tells you the weather in a <city>.
+      *Commands:*
+      *clouds* - Tells you how many clouds there're above you.
+      *command_without_description*
+      *What's the weather in <city>?* - Tells you the weather in a <city>.
 
-*Other commands:*
-*help* - Shows help information.
-*hi* - Says hello.
-*hello* - Says hello.
+      *Other commands:*
+      *help* - Shows help information.
+      *hi* - Says hello.
+      *hello* - Says hello.
 
-For getting description of the command use: *help <command>*
+      For getting description of the command use: *help <command>*
 
-For more information see https://github.com/slack-ruby/slack-ruby-bot, please.
-MSG
+      For more information see https://github.com/slack-ruby/slack-ruby-bot, please.
+    MSG
 
     expect(message: "#{SlackRubyBot.config.user} help").to respond_with_slack_message(message)
   end

data/spec/slack-ruby-bot/commands/hi_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe SlackRubyBot::Commands::Hi do
   def app
     SlackRubyBot::App.new

data/spec/slack-ruby-bot/commands/match_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe SlackRubyBot::Commands do
   let! :command do
     Class.new(SlackRubyBot::Commands::Base) do

data/spec/slack-ruby-bot/commands/message_loop_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe SlackRubyBot::App do
   def app
     SlackRubyBot::App.new

data/spec/slack-ruby-bot/commands/nil_message_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe SlackRubyBot::Commands do
   let! :command do
     Class.new(SlackRubyBot::Commands::Base) do

data/spec/slack-ruby-bot/commands/not_implemented_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe SlackRubyBot::Commands::Base do
   let! :command do
     Class.new(SlackRubyBot::Commands::Base) do

data/spec/slack-ruby-bot/commands/operators_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe SlackRubyBot::Commands do
   let! :command do
     Class.new(SlackRubyBot::Commands::Base) do

data/spec/slack-ruby-bot/commands/operators_with_block_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe SlackRubyBot::Commands do
   let! :command do
     Class.new(SlackRubyBot::Commands::Base) do

data/spec/slack-ruby-bot/commands/scan_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe SlackRubyBot::Commands do
   let! :command do
     Class.new(SlackRubyBot::Commands::Base) do

data/spec/slack-ruby-bot/commands/send_gif_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe SlackRubyBot::Commands, if: WithGiphy.env? do
   let! :command do
     Class.new(SlackRubyBot::Commands::Base) do

data/spec/slack-ruby-bot/commands/send_message_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe SlackRubyBot::Commands do
   let! :command do
     Class.new(SlackRubyBot::Commands::Base) do

data/spec/slack-ruby-bot/commands/send_message_with_gif_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe SlackRubyBot::Commands, if: WithGiphy.env? do
   let! :command do
     Class.new(SlackRubyBot::Commands::Base) do

data/spec/slack-ruby-bot/commands/support/attrs_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe SlackRubyBot::Commands::Support::Attrs do
   let(:help_attrs) { described_class.new('WeatherBot') }
 

data/spec/slack-ruby-bot/commands/support/help_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe SlackRubyBot::Commands::Support::Help do
   let(:bot_class) { Testing::WeatherBot }
   let(:command_class) { Testing::HelloCommand }

data/spec/slack-ruby-bot/commands/support/match_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe SlackRubyBot::Commands::Support::Match do
   context 'initialized with invalid args' do
     subject { -> { described_class.new('invalid-match-data') } }

data/spec/slack-ruby-bot/commands/unknown_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe SlackRubyBot::Commands::Unknown do
   it 'invalid command' do
     expect(message: "#{SlackRubyBot.config.user} foobar").to respond_with_slack_message("Sorry <@user>, I don't understand that command!")

data/spec/slack-ruby-bot/config_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe SlackRubyBot::Config do
   describe '.send_gifs?' do
     after { ENV.delete 'SLACK_RUBY_BOT_SEND_GIFS' }

data/spec/slack-ruby-bot/hooks/hello_spec.rb

@@ -0,0 +1,51 @@
+# frozen_string_literal: true
+
+describe SlackRubyBot::Hooks::Hello do
+  let(:logger) { double(:logger, info: nil) }
+  let(:hello_hook) { described_class.new(logger) }
+
+  describe '#call' do
+    let(:team_name) { 'Example Team' }
+    let(:team_id) { SecureRandom.uuid }
+    let(:team_domain) { 'example' }
+    let(:team) { double(:team, name: team_name, id: team_id, domain: team_domain) }
+    let(:client) { instance_double(SlackRubyBot::Client, team: team) }
+
+    def receive_hello
+      hello_hook.call(client, double)
+    end
+
+    it 'logs the connection' do
+      expect(logger).to receive(:info).with("Successfully connected team #{team_name} (#{team_id}) to https://#{team_domain}.slack.com.")
+      receive_hello
+    end
+
+    context 'with no client' do
+      let(:client) { nil }
+      it 'does nothing' do
+        expect(logger).not_to receive(:info)
+        receive_hello
+      end
+    end
+
+    context 'when client has no team' do
+      let(:team) { nil }
+      it 'does nothing' do
+        expect(logger).not_to receive(:info)
+        receive_hello
+      end
+    end
+
+    context 'when hook is received multiple times' do
+      before do
+        receive_hello
+      end
+
+      it 'logs the reconnections' do
+        expect(logger).to receive(:info).with(/^Successfully reconnected .+ after \S+s\.$/).twice
+        receive_hello
+        receive_hello
+      end
+    end
+  end
+end

data/spec/slack-ruby-bot/hooks/hook_support_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe SlackRubyBot::Hooks::HookSupport do
   subject do
     Class.new do

data/spec/slack-ruby-bot/hooks/message_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe SlackRubyBot::Hooks::Message do
   let(:message_hook) { described_class.new }
 
@@ -5,7 +7,7 @@ describe SlackRubyBot::Hooks::Message do
     it 'doesn\'t raise an error when message is a frozen string' do
       message_hook.call(
         SlackRubyBot::Client.new,
-        Hashie::Mash.new(text: 'message'.freeze)
+        Hashie::Mash.new(text: 'message')
       )
     end
   end

data/spec/slack-ruby-bot/hooks/set_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe SlackRubyBot::Hooks::Set do
   let(:client) { Slack::RealTime::Client.new }
 

data/spec/slack-ruby-bot/initializers/giphy_client_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 if ENV.key?('WITH_GIPHY_CLIENT')
   describe Giphy do
     before do

data/spec/slack-ruby-bot/initializers/giphy_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 if ENV.key?('WITH_GIPHY')
   describe Giphy do
     let(:burrito_gif) { 'https://media3.giphy.com/media/xTiTndNDuNFxUW5Xoc/giphy.gif' }

data/spec/slack-ruby-bot/mvc/controller/controller_to_command_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe SlackRubyBot::MVC::Controller::Base, 'initialization' do
   let(:model) { double('model') }
   let(:view) { double('view') }

data/spec/slack-ruby-bot/rspec/respond_with_error_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 describe RSpec do
   let! :command do
     Class.new(SlackRubyBot::Commands::Base) do

data/spec/slack-ruby-bot/rspec/respond_with_slack_message_spec.rb

@@ -1,6 +1,10 @@
+# frozen_string_literal: true
+
 describe RSpec do
   let! :command do
     Class.new(SlackRubyBot::Commands::Base) do
+      command 'no message' do |client, data, _match|
+      end
       command 'single message with as_user' do |client, data, _match|
         client.say(text: 'single response', channel: data.channel, as_user: true)
       end
@@ -25,6 +29,22 @@ describe RSpec do
     expect(message: "#{SlackRubyBot.config.user} single message")
       .to respond_with_slack_message(/single response/i)
   end
+  it 'respond with any message' do
+    expect(message: "#{SlackRubyBot.config.user} single message")
+      .to respond_with_slack_message
+  end
+  it 'correctly reports error' do
+    expect do
+      expect(message: "#{SlackRubyBot.config.user} single message")
+        .to respond_with_slack_message('another response')
+    end.to raise_error RSpec::Expectations::ExpectationNotMetError, "expected to receive message with text: another response once,\n received:[{:text=>\"single response\", :channel=>\"channel\"}]"
+  end
+  it 'correctly reports error without message' do
+    expect do
+      expect(message: "#{SlackRubyBot.config.user} no message")
+        .to respond_with_slack_message('another response')
+    end.to raise_error RSpec::Expectations::ExpectationNotMetError, "expected to receive message with text: another response once,\n received:none"
+  end
   it 'respond_with_single_message_using_partial_regex_match' do
     expect(message: "#{SlackRubyBot.config.user} single message")
       .to respond_with_slack_message(/si[n|N]gle/)

data/spec/slack-ruby-bot/rspec/respond_with_slack_messages_spec.rb

@@ -1,6 +1,13 @@
+# frozen_string_literal: true
+
 describe RSpec do
   let! :command do
     Class.new(SlackRubyBot::Commands::Base) do
+      command 'do not respond' do |client, data, _match|
+      end
+      command 'respond once' do |client, data, _match|
+        client.say(text: 'response', channel: data.channel, as_user: true)
+      end
       command 'respond with as_user' do |client, data, _match|
         5.times do |i|
           client.say(text: "response #{i}", channel: data.channel, as_user: true)
@@ -29,6 +36,26 @@ describe RSpec do
     expect(message: "#{SlackRubyBot.config.user} respond 5 times")
       .to respond_with_slack_messages(expected_responses)
   end
+  it 'respond with multiple messages' do
+    expect(message: "#{SlackRubyBot.config.user} respond 5 times")
+      .to respond_with_slack_messages
+  end
+  it 'respond once' do
+    expect do
+      expect(message: "#{SlackRubyBot.config.user} respond once")
+        .to respond_with_slack_messages
+    end.to raise_error RSpec::Expectations::ExpectationNotMetError, 'Expected to receive multiple messages, got 1'
+  end
+  it 'do not respond' do
+    expect(message: "#{SlackRubyBot.config.user} do not respond")
+      .to_not respond_with_slack_messages
+  end
+  it 'correctly reports error on do not respond' do
+    expect do
+      expect(message: "#{SlackRubyBot.config.user} do not respond")
+        .to respond_with_slack_messages
+    end.to raise_error RSpec::Expectations::ExpectationNotMetError, 'Expected to receive multiple messages, got none'
+  end
   it 'respond_with_multiple_messages_using_string_matches' do
     expected_responses = []
     5.times { |i| expected_responses.push("response #{i}") }
@@ -41,6 +68,15 @@ describe RSpec do
     expect(message: "#{SlackRubyBot.config.user} respond 5 times")
       .not_to respond_with_slack_messages(expected_responses)
   end
+  it 'correctly reports error' do
+    expect do
+      expected_responses = []
+      6.times { |i| expected_responses.push("response #{i}") }
+      expect(message: "#{SlackRubyBot.config.user} respond 5 times")
+        .to respond_with_slack_messages(expected_responses)
+    end.to raise_error RSpec::Expectations::ExpectationNotMetError, 'Expected text: response 5, got none'
+  end
+
   it 'respond_with_multiple_messages_using_string_matches_with_extra_arg' do
     expected_responses = []
     5.times { |i| expected_responses.push("response #{i}") }