slack-api 1.1.2 → 1.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8ab8f375e0cdb00b0c0780a8b9596651b1aa6c35
-  data.tar.gz: 5c3f9059587cb8e50c546950bb91b5e6de93bdf9
+  metadata.gz: 841242a07455c9fe43175c96551000c156daae4e
+  data.tar.gz: c371473964ac40799fead68a389f52162d1ad8ea
 SHA512:
-  metadata.gz: bb854eacfe009d2a01ca08a2e51d72cbddd1a0ebee24d7931bb5da2b8b2323c3dfb91c96c50eabaaf194e4520c436c4086dbd171f77c19dd4f1d26b3f3582699
-  data.tar.gz: e5b2963399ed3496e1f3cf6d33479de7a55da94f84769a621eb32bb7f4e1969d2c27ab1f8431ff1fd0866aefef8ae61b5d0efad8f3ec946076af4c47a12a3399
+  metadata.gz: 57afaef0b98185fc93f72fba6b54c7244349de5fd8d61d35102f2901a0f72e8ee0d2814f0d667cb4a5e6c3e8632901680579557451be073540374c1fa916c9f9
+  data.tar.gz: aa79615d31b8a232403ee7c6daf64ee8fd2718cf4e10c4a45afaa7373caf97e9b61f7e952695b6624e6c477b3deec251229727ff789cf981c2f75f492b0574be

data/.coveralls.yml

@@ -0,0 +1,2 @@
+service_name: travis-pro
+repo_token: PuedicWJBfk5ghyEc9wUOhloMzBfCeOsL

data/.rspec

@@ -1,2 +1,2 @@
 --color
---format progress
+--format documentation

data/.travis.yml

@@ -0,0 +1,5 @@
+rvm:
+  - 2.1.2
+
+git:
+  submodules: false

data/Guardfile

@@ -0,0 +1,13 @@
+clearing true
+guard :rspec, cmd: "bundle exec rspec" do
+  require "guard/rspec/dsl"
+  dsl = Guard::RSpec::Dsl.new(self)
+
+  rspec = dsl.rspec
+  watch(rspec.spec_helper) { rspec.spec_dir }
+  watch(rspec.spec_support) { rspec.spec_dir }
+  watch(rspec.spec_files)
+
+  ruby = dsl.ruby
+  dsl.watch_spec_files_for(ruby.lib_files)
+end

data/README.md

@@ -1,5 +1,9 @@
 # Slack
 
+[![Gem Version](https://badge.fury.io/rb/slack-api.svg)](http://badge.fury.io/rb/slack-api)
+[![Build Status](https://travis-ci.org/aki017/slack-ruby-gem.svg)](https://travis-ci.org/aki017/slack-ruby-gem)
+[![Coverage Status](https://coveralls.io/repos/aki017/slack-ruby-gem/badge.svg?branch=spec)](https://coveralls.io/r/aki017/slack-ruby-gem?branch=spec)
+
 A Ruby wrapper for the Slack API
 
 ## Installation

data/Rakefile

@@ -1,2 +1,13 @@
 require "bundler/gem_tasks"
 require_relative "./lib/generators/tasks/generate"
+
+Bundler.setup :default, :development
+
+require 'rspec/core'
+require 'rspec/core/rake_task'
+
+RSpec::Core::RakeTask.new(:spec) do |spec|
+  spec.pattern = FileList['spec/**/*_spec.rb']
+end
+
+task default: [:spec]

data/lib/slack/request.rb

@@ -25,7 +25,7 @@ module Slack
 
     # Perform an HTTP request
     def request(method, path, options)
-      options.merge!(token: token)
+      options = options.merge(token: token)
       response = connection.send(method) do |request|
         case method
         when :get, :delete

data/lib/slack/version.rb

@@ -1,3 +1,3 @@
 module Slack
-  VERSION = "1.1.2"
+  VERSION = "1.1.3"
 end

data/slack.gemspec

@@ -19,8 +19,13 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
 
   spec.add_development_dependency "bundler", "~> 1.5"
-  spec.add_development_dependency "rspec", "~> 2.4"
-  spec.add_development_dependency "webmock", "~> 1.6"
+  spec.add_development_dependency "simplecov"
+  spec.add_development_dependency "coveralls"
+  spec.add_development_dependency "rspec"
+  spec.add_development_dependency "webmock"
+  spec.add_development_dependency "vcr"
+  spec.add_development_dependency "guard"
+  spec.add_development_dependency "guard-rspec"
   spec.add_development_dependency "rake"
   spec.add_development_dependency 'erubis', '~> 2.7.0'
   spec.add_development_dependency "json-schema"

data/spec/api_spec.rb

@@ -0,0 +1,23 @@
+require_relative './spec_helper'
+
+RSpec.describe Slack::Client, :vcr do
+  describe :api do
+    describe :test do
+      it "with valid token" do
+        expect(
+          valid_client.api_test
+        ).to valid_response
+      end
+
+      it "with extra arguments" do
+        extra = {
+          "foo" => "bar",
+          "hello" => "world"
+        }
+        expect(
+          valid_client.api_test(extra)["args"]
+        ).to include(extra)
+      end
+    end
+  end
+end

data/spec/auth_spec.rb

@@ -0,0 +1,22 @@
+require_relative './spec_helper'
+
+RSpec.describe Slack::Client, :vcr do
+  describe :auth do
+    describe :test do
+      it "with valid token" do
+        expect(
+          valid_client.auth_test
+        ).to valid_response
+      end
+
+      it "with invalid token" do
+        expect(
+          invalid_client.auth_test
+        ).to include({
+          "ok" => false,
+          "error" => "invalid_auth"
+        })
+      end
+    end
+  end
+end

data/spec/channels_spec.rb

@@ -0,0 +1,247 @@
+require_relative './spec_helper'
+
+RSpec.describe Slack::Client, :vcr do
+  describe :channels do
+    describe :archive do
+      it "without name" do
+        expect{valid_client.channels_archive}.to raise_error ArgumentError
+      end
+
+      it "with name" do
+        expect(
+          valid_client.channels_archive(channel: test_channel_id)
+        ).to include({
+          "ok" => true
+        })
+      end
+    end
+
+    describe :history do
+      it "without name" do
+        expect{valid_client.channels_history}.to raise_error ArgumentError
+      end
+
+      it "with name" do
+        expect(
+          valid_client.channels_history(channel: test_channel_id)
+        ).to include({
+          "ok" => true
+        })
+      end
+    end
+
+    describe :info do
+      it "without name" do
+        expect{valid_client.channels_info}.to raise_error ArgumentError
+      end
+
+      it "with name" do
+        expect(
+          valid_client.channels_info(channel: test_channel_id)
+        ).to include({
+          "ok" => true
+        })
+      end
+    end
+
+    describe :create do
+      it "without name" do
+        expect{valid_client.channels_create}.to raise_error ArgumentError
+      end
+
+      it "with test_channel_name" do
+        response = valid_client.channels_create name: test_channel_name
+
+        expect(response).to include({ "ok" => true })
+        expect(response["channel"]).to include({ "name" => test_channel_name })
+      end
+
+      it "with taken name" do
+        response = valid_client.channels_create name: "general"
+
+        expect(response).to include({
+          "ok" => false,
+          "error" => "name_taken"
+        })
+      end
+    end
+
+    describe :list do
+      it "with valid token" do
+        response = valid_client.channels_list
+
+        expect(response).to include({ "ok" => true })
+      end
+    end
+
+    describe :invite do
+      it "without arguments" do
+        expect{valid_client.channels_invite}.to raise_error ArgumentError
+      end
+
+      it "without argument(channel)" do
+        expect{valid_client.channels_invite(user: test_user_id)}.to raise_error ArgumentError
+      end
+
+      it "without argument(user)" do
+        expect{valid_client.channels_invite(channel: test_channel_id)}.to raise_error ArgumentError
+      end
+
+      it "with valid arguments" do
+        expect(
+          valid_client.channels_invite(user: another_user_id, channel: test_channel_id)
+        ).to include({
+          "ok" => true
+        })
+      end
+    end
+
+    describe :leave do
+      it "without argument" do
+        expect{valid_client.channels_leave}.to raise_error ArgumentError
+      end
+
+      it "with channel" do
+        expect(
+          valid_client.channels_leave(channel: test_channel_id)
+        ).to include({
+          "ok" => true
+        })
+      end
+    end
+
+    describe :join do
+      it "without :name" do
+        expect{valid_client.channels_join}.to raise_error ArgumentError
+      end
+
+      it "with :name" do
+        expect(
+          valid_client.channels_join(name: test_channel_name)
+        ).to include({
+          "ok" => true
+        })
+      end
+    end
+
+    describe :kick do
+      it "without arguments" do
+        expect{valid_client.channels_kick}.to raise_error ArgumentError
+      end
+      it "without :channel" do
+        expect{valid_client.channels_kick(name: another_user_id)}.to raise_error ArgumentError
+      end
+      it "without :name" do
+        expect{valid_client.channels_kick(channel: test_channel_id)}.to raise_error ArgumentError
+      end
+      it "with arguments" do
+        expect(
+          valid_client.channels_kick(user: another_user_id, channel: test_channel_id)
+        ).to include({
+          "ok" => true
+        })
+      end
+    end
+
+    describe :mark do
+      it "without arguments" do
+        expect{valid_client.channels_mark}.to raise_error ArgumentError
+      end
+
+      it "without ts" do
+        expect{valid_client.channels_mark(channel: test_channel_id)}.to raise_error ArgumentError
+      end
+
+      it "without channel" do
+        expect{valid_client.channels_mark(ts: 0)}.to raise_error ArgumentError
+      end
+      it "with argument" do
+        expect(
+          valid_client.channels_mark(channel: test_channel_id, ts: 0)
+        ).to include({
+          "ok" => true
+        })
+      end
+    end
+
+    describe :rename do
+      it "without arguments" do
+        expect{valid_client.channels_rename}.to raise_error ArgumentError
+      end
+
+      it "without channel" do
+        expect{valid_client.channels_rename(name: another_channel_name)}.to raise_error ArgumentError
+      end
+
+      it "without name" do
+        expect{valid_client.channels_rename(channel: test_channel_id)}.to raise_error ArgumentError
+      end
+
+      it "with name" do
+        expect(
+          valid_client.channels_rename(channel: test_channel_id, name: another_channel_name)
+        ).to include({
+          "ok" => true
+        })
+      end
+    end
+
+    describe :setPurpose do
+      it "without arguments" do
+        expect{valid_client.channels_setPurpose}.to raise_error ArgumentError
+      end
+
+      it "without channel" do
+        expect{valid_client.channels_setPurpose(purpose: "TestPurpose")}.to raise_error ArgumentError
+      end
+
+      it "without topic" do
+        expect{valid_client.channels_setPurpose(channel: test_channel_id)}.to raise_error ArgumentError
+      end
+
+      it "with arguments" do
+        expect(
+          valid_client.channels_setPurpose(channel: test_channel_id, purpose: "TestPurpose")
+        ).to include({
+          "ok" => true
+        })
+      end
+    end
+
+    describe :setTopic do
+      it "without arguments" do
+        expect{valid_client.channels_setTopic}.to raise_error ArgumentError
+      end
+
+      it "without channel" do
+        expect{valid_client.channels_setTopic(topic: "TestTopic")}.to raise_error ArgumentError
+      end
+
+      it "without topic" do
+        expect{valid_client.channels_setTopic(channel: test_channel_id)}.to raise_error ArgumentError
+      end
+
+      it "with arguments" do
+        expect(
+          valid_client.channels_setTopic(channel: test_channel_id, topic: "TestTopic")
+        ).to include({
+          "ok" => true
+        })
+      end
+    end
+
+    describe :unarchive do
+      it "without :channel" do
+        expect{valid_client.channels_join}.to raise_error ArgumentError
+      end
+
+      it "with :channel" do
+        expect(
+          valid_client.channels_unarchive(channel: test_channel_id)
+        ).to include({
+          "ok" => true
+        })
+      end
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -1,7 +1,86 @@
+require 'simplecov'
+require 'coveralls'
+
+SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[
+  SimpleCov::Formatter::HTMLFormatter,
+  Coveralls::SimpleCov::Formatter
+]
+SimpleCov.start do
+  add_filter '.bundle/'
+end
+
+require 'slack'
+require 'webmock/rspec'
+require 'vcr'
+WebMock.disable_net_connect!(allow_localhost: true)
+
+# this helper is not good
+module Helpers
+  def valid_token
+    $stderr.puts "Please set valid_token to ENV['TOKEN']" if ENV['TOKEN'].nil?
+    @token ||= ENV['TOKEN'] || (print "Token: "; gets.strip)
+  end
+
+  def valid_client
+    @valid_client ||= Slack::Client.new(token: valid_token)
+  end
+
+  def invalid_token
+    "dummy_token"
+  end
+
+  def invalid_client
+    @invalid_client ||= Slack::Client.new(token: invalid_token)
+  end
+
+  def test_user_id
+    @test_user_id ||= valid_client.auth_test["user_id"]
+  end
+
+  def test_user_name
+    @test_user_name ||= valid_client.auth_test["user"]
+  end
+
+  def another_user_name
+    @another_user_name ||= "aki017"
+  end
+
+
+  def another_user_id
+    @another_user_id ||= "U0399SL90" #valid_client.
+  end
+
+  def test_channel_name
+    @ntest_channel_name ||= "gem_testroom"
+  end
+
+  def test_channel_id
+    @test_channel_id ||= "C04NL1FKT"
+  end
+
+  def another_channel_name
+    @another_channel_name ||= "gem_testroom2"
+  end
+
+  def valid_response
+    include({ "ok" => true })
+  end
+end
+
+include Helpers
 RSpec.configure do |config|
-  config.treat_symbols_as_metadata_keys_with_true_values = true
   config.run_all_when_everything_filtered = true
-  config.filter_run :focus
+  config.treat_symbols_as_metadata_keys_with_true_values = true
 
   config.order = 'random'
+  config.include Helpers
+end
+
+VCR.configure do |c|
+  c.cassette_library_dir = 'spec/vcr'
+  c.hook_into :webmock
+  c.allow_http_connections_when_no_cassette = true
+  c.default_cassette_options = { :record => :new_episodes }
+  c.configure_rspec_metadata!
+  c.filter_sensitive_data("<TOKEN>") { valid_token }
 end