skylight 1.6.0 → 1.6.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c1219b6ae71c3331396631a73e0866eb68d681eace43059b1c8690daca5e3634
-  data.tar.gz: 1b95ca11947bd572ebf69d5677cb9450533da0f86745a5733af64c4b3bed6fad
+  metadata.gz: '08db1b03b0415378e94cba4a1e93f3856bec795769a3bee7786942fdfdb77a30'
+  data.tar.gz: 294a813cdcf2cfc7b343f7a2c2126628101c1c1a2b320e58c5286d79a5ded016
 SHA512:
-  metadata.gz: 55c2b9c85310d9cb40afa744364759c854ac5b94787a285947986d85477b3df4119ff14da33b44e53fc2383499d61b70d0373aecbcebd9cbfbbe5d0fb11a022f
-  data.tar.gz: ff24d96979a028ba73c8c7d9942ae312d63a6a2eefe49354648fe39832e7f189babd2a85a1f4e06b7de6857c3188efae97f4b1f5e7fff9c30efecafc7b60a94a
+  metadata.gz: 9c5d6044ebeb3d41030716f10642a422c0e3346be27b7820edefc4e0d0abd006b773686cf9a231f7f8300c22db2dd15e76175a18340f4d86aa11170199e7d799
+  data.tar.gz: 851f31e79a7e4d0924c6c02292a1aaf84c424f72dc8f0cfd6235f570a6358d7abb855df31e24bd0dc36c5ead5efc72a4ac78591195e9cd032deddeb2a46511bd

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+## 1.6.1 (April 12, 2018)
+
+* [IMPROVEMENT] Include endpoint name in error logging
+* [BUGFIX] Make sure to correctly release broken traces
+* [BUGFIX] Keep the `require` method private when overwriting
+
 ## 1.6.0 (March 21, 2018)
 
 * [FEATURE] Time spent the Rails router is now identified separately in the trace
@@ -14,7 +20,7 @@
 ## 1.5.0 (December 6, 2017)
 
 * [FEATURE] [Coach](https://github.com/gocardless/coach) instrumentation. Enabled automatically via ActiveSupport::Notifications.
-* [FEATURE] Option to enable or disable agent by setting SKYLIGHT_ENABLE via ENV.
+* [FEATURE] Option to enable or disable agent by setting SKYLIGHT_ENABLED via ENV.
 * [IMPROVEMENT] Better logging for certain error cases.
 * [BUGFIX] Backport a SPEC compliance fix for older Rack::ETag to resolve case where the Middleware probe could cause empty traces.
 * [BUGFIX] Fix a case where using the non-block form of `Skylight.instrument` with `Skylight.done` could cause lost trace data.

data/lib/skylight/probes.rb

@@ -75,6 +75,8 @@ end
 # Allow hooking require
 # @api private
 module ::Kernel
+  private
+
   alias require_without_sk require
 
   def require(name)

data/lib/skylight/trace.rb

@@ -65,7 +65,7 @@ module Skylight
 
       nil
     rescue => e
-      error "failed to record span; msg=%s", e.message
+      error "failed to record span; msg=%s; endpoint=%s", e.message, endpoint
       broken!
       nil
     end
@@ -90,7 +90,7 @@ module Skylight
 
       start(now - gc_time, cat, title, desc)
     rescue => e
-      error "failed to instrument span; msg=%s", e.message
+      error "failed to instrument span; msg=%s; endpoint=%s", e.message, endpoint
       broken!
       nil
     end
@@ -100,7 +100,7 @@ module Skylight
       return if broken?
       stop(span, Util::Clock.nanos - gc_time)
     rescue => e
-      error "failed to close span; msg=%s", e.message
+      error "failed to close span; msg=%s; endpoint=%s", e.message, endpoint
       broken!
       nil
     end
@@ -128,16 +128,21 @@ module Skylight
     end
 
     def submit
-      return if broken?
-
       t { "submitting trace" }
 
+      # This must always be called to clean up properly
+      release
+
+      if broken?
+        t { "broken, not submitting" }
+        return
+      end
+
       if @submitted
         t { "already submitted" }
         return
       end
 
-      release
       @submitted = true
 
       traced

data/lib/skylight/version.rb

@@ -1,4 +1,4 @@
 module Skylight
-  VERSION = '1.6.0'
+  VERSION = '1.6.1'
 end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: skylight
 version: !ruby/object:Gem::Version
-  version: 1.6.0
+  version: 1.6.1
 platform: ruby
 authors:
 - Tilde, Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-03-21 00:00:00.000000000 Z
+date: 2018-04-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -211,7 +211,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.3
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: Skylight is a smart profiler for Rails apps