skylight 1.4.1 → 1.4.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e263d7e1080db2243929478e4ab47e57cdb84c23
-  data.tar.gz: d9c7c72fceb7d13d119c348a3140f4272d5a1268
+  metadata.gz: 105d68740021ca155e6ec59ee20f1ec1ff573adf
+  data.tar.gz: 8a22e7652fdbd11ccce601c0a01bb4fbfce04b5f
 SHA512:
-  metadata.gz: 38c23124462a1d155c896444ddf373eeb9746e9fa7842ffdbc4cc2925b35c10339cc9e1577ca2ddf52303ed95f3c671cb672fb055323a03fd576b12a643468c0
-  data.tar.gz: 1e3a43b629cccec1d191d5ecf561ea55907fc0a6908fba66d5f4798d3c97d2bebc4aba0f6bcb7118fcb77ba4fbeb4d772258f9ba12a15689b1943c3a040c6530
+  metadata.gz: 0f02ebef671a0bd6659f6a676dee1d575ff0eb1127b2b5abeadfbadf8afedf1dcb0d1c44d94aff4c7b3f916d3c8768cfb9f00efea5d9b6c8f23624036448cf76
+  data.tar.gz: 87f36f9d25661fb9f4c686256a331ccad82476c1a65e1b885046bd05bc512826ff2b2ab31fee240306bfb9debad08b45d05383205137f13deda11c5d8fd8a640

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 1.4.2 (October 11, 2017)
+
+* [BUGFIX] For experimental deploy tracking support, resolve an error that occurred if the Git SHA and description were not set.
+
 ## 1.4.1 (October 10, 2017)
 
 * [BUGFIX] Fix an issue that would prevent the daemon from starting up on FreeBSD.

data/lib/skylight/util/deploy.rb

@@ -1,5 +1,6 @@
 require 'json'
 require 'uri'
+require 'skylight/util/logging'
 
 module Skylight
   module Util
@@ -40,13 +41,21 @@ module Skylight
           URI.encode_www_form(
             timestamp:   timestamp,
             deploy_id:   id.to_s[0..100], # Keep this sane
-            git_sha:     git_sha[0..40], # A valid SHA will never exceed 40
-            description: description[0..255]) # Avoid massive descriptions
+            git_sha:     git_sha ? git_sha[0..40] : nil, # A valid SHA will never exceed 40
+            description: description ? description[0..255] : nil) # Avoid massive descriptions
         end
 
       end
 
       class DefaultDeploy < EmptyDeploy
+        include Logging
+
+        def initialize(*)
+          super
+          if description && !id
+            warn "The configured deploy will be ignored as an id or git_sha must be provided."
+          end
+        end
 
         def id
           config.get(:'deploy.id') || git_sha

data/lib/skylight/version.rb

@@ -1,4 +1,4 @@
 module Skylight
-  VERSION = '1.4.1'
+  VERSION = '1.4.2'
 end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: skylight
 version: !ruby/object:Gem::Version
-  version: 1.4.1
+  version: 1.4.2
 platform: ruby
 authors:
 - Tilde, Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-10-10 00:00:00.000000000 Z
+date: 2017-10-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport