skylight 0.3.0 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8b4298b0fe8f4bccf1697e4ef0e46812b551cab8
-  data.tar.gz: 1f6b6bdf4a985fb43df3a3a39a4e134e047cdc00
+  metadata.gz: 4005d9f17790586799b47b937adeaf32049239cb
+  data.tar.gz: b58afb77fd648bfbdc904a305161fb57a47ceeb1
 SHA512:
-  metadata.gz: 333807718ef1d39e532506dbae88dd1e5b3a46ec44e87c767ba1673d73547e8a200480fac36267188b49d80f53e5951293eb0f7ee908b496cbc83b6bdc629c97
-  data.tar.gz: c8dfc5041e90345954f94c57afff9314230f7b230bc59e6197ea0aea6b7a7a76f29a3d53c6b001581bac4fbb26362a8ed72193f46ffddbea951b8a27ef6d91b0
+  metadata.gz: e7c5939f477c3902f1684b20fb5030aef6bdc7554dd395589792dcbd6421224b75a60a9fd0e8d4292296afede7c3e582e8cf399af866e67ad8d2f7b855ccbfd1
+  data.tar.gz: 9c5a136bc94db3c8bc51c80ec4ae191a23d6cb5e9eded4dc0e5bdcb1a60e5e1dd006bad9965bb9c9402195b8684849cb4783ec4160b705bbab9800ec2d586789

data/CHANGELOG.md

@@ -1,3 +1,35 @@
+## 0.3.1 (March 8, 2014)
+
+* Fix requires to allow CLI to function without native extension.
+
+## 0.3.0 (February 28, 2014)
+
+* Native Rust agent
+* Send exceptions occurring during HTTP requests to the client.
+* Warn users when skylight is potentially disabled incorrectly.
+* Update SQL Lexer to 0.0.6
+* Log the backtraces of unhandled exceptions
+* Add support for disabling GC tracking
+* Add support for disabling agent
+
+## 0.2.7 (February 26, 2014)
+
+* Disable annotations to reduce memory load.
+
+## 0.2.6 (February 25, 2014)
+
+* `inspect` even whitelisted payload props
+* Ignore Errno::EINTR for 'ps' call
+
+## 0.2.5 (February 21, 2014)
+
+* Revert "Update SqlLexer to 0.0.4"
+
+## 0.2.4 (February 20, 2014)
+
+* Whitelist process action annotation keys.
+* Update SqlLexer to 0.0.4
+
 ## 0.2.3 (December 20, 2013)
 
 * Fix SQL lexing for comments, arrays, double-colon casting, and multiple queries

data/lib/skylight.rb

@@ -13,10 +13,22 @@ rescue LoadError
   raise if ENV.key?("SKYLIGHT_REQUIRED")
 end
 
+module Skylight
+  TRACE_ENV_KEY      = 'SKYLIGHT_ENABLE_TRACE_LOGS'.freeze
+
+  autoload :Api,          'skylight/api'
+  autoload :CLI,          'skylight/cli'
+  autoload :Config,       'skylight/config'
+
+  module Util
+    autoload :Logging,       'skylight/util/logging'
+    autoload :HTTP,          'skylight/util/http'
+  end
+end
+
 if has_native_ext
 
 module Skylight
-  TRACE_ENV_KEY      = 'SKYLIGHT_ENABLE_TRACE_LOGS'.freeze
   STANDALONE_ENV_KEY = 'SKYLIGHT_STANDALONE'.freeze
   STANDALONE_ENV_VAL = 'server'.freeze
 
@@ -32,7 +44,6 @@ module Skylight
     require 'skylight/vm/gc'
   end
 
-  autoload :Config,       'skylight/config'
   autoload :GC,           'skylight/gc'
   autoload :Helpers,      'skylight/helpers'
   autoload :Instrumenter, 'skylight/instrumenter'
@@ -175,9 +186,4 @@ module Skylight
   end
 end
 
-end
-
-module Skylight
-  autoload :Api,          'skylight/api'
-  autoload :CLI,          'skylight/cli'
-end
+end

data/lib/skylight/api.rb

@@ -1,7 +1,5 @@
 module Skylight
   class Api
-    include Util::Logging
-
     attr_reader :config, :http
 
     def initialize(config, service = :accounts)

data/lib/skylight/version.rb

@@ -1,4 +1,4 @@
 module Skylight
-  VERSION = '0.3.0'
+  VERSION = '0.3.1'
 end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: skylight
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.1
 platform: ruby
 authors:
 - Tilde, Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-02-28 00:00:00.000000000 Z
+date: 2014-03-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -139,7 +139,6 @@ files:
 - lib/sql_lexer.rb
 - lib/sql_lexer/lexer.rb
 - lib/sql_lexer/version.rb
-- too-many-sockets.md
 homepage: http://www.skylight.io
 licenses: []
 metadata: {}
@@ -159,7 +158,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.0
+rubygems_version: 2.2.1
 signing_key: 
 specification_version: 4
 summary: Skylight is a ruby application monitoring tool. Currently in closed beta.

data/too-many-sockets.md

@@ -1,62 +0,0 @@
-We received a notification (Zendesk #280) from a customer that they were unable to SSH
-into their box, and that their service provider discovered that Skylight
-was triggering socket buffer limits.
-
-The customer immediately disabled Skylight, which fixed the bug for him.
-
-Customer Information:
-
-* Using Skylight 0.2.3
-* Ruby 2.0.0p353
-* Also had New Relic installed (Bug #46)
-* Recently upgraded to Rails 4
-* Passenger Enterprise with a max-pool size of 12 and zero-downtime deploys
-* He had a maxsockbuf of 32MB
-
-The customer also reported 134 open sockets in the server process.
-
-Separately, we discovered that New Relic was making our payloads
-extremely large.
-
-Our working hypothesis was that the large New Relic payloads were
-triggering the max buffer condition, which was then cascading into more
-failures.
-
-Upon further investigation, we discovered a few things:
-
-* If the client hits a kernel buffer limit (via EWOULDBLOCK that lasts
-  more than 5s), it closes down its socket
-* The server expects to recover from this situation by getting the
-  client socket in its read list from IO.select. It would then try to
-  read from it, get an EOF, and close the socket.
-* If the server does not get the client socket in its read list for some
-  (unknown) reason, this would result in an ever-growing list of sockets
-  on the server side.
-
-We are not sure why the sockets would not appear in the read list, but
-we hypothesize that when the OpenVZ limit is reached, the kernel no
-longer includes the socket in the read list, causing the server to never
-close the socket.
-
-Mitigation strategies:
-
-* The New Relic fix (#46) should reduce the likelihood of encountering
-  this in the first place
-* We want to add a Hello heartbeat from the client. If the server
-  doesn't receive a message every 1m (or 2m, TBD), it will close the
-  socket even if it's not in the read list.
-
-We are worried that if the server process ever gets stuck, this
-condition can occur. We are also considering a server heartbeat back to
-the clients, so they can take corrective action if the agent gets stuck.
-
-Some mitigations for this situation:
-
-* Kill the server process when a respawn is necessary. This will ensure
-  that a stuck agent process doesn't duplicate into N servers.
-* Before connecting to the server socket, pre-check the server process 
-  with kill -0.
-
-For next time: 
-* Request skylight.log for easier debugging
-* Form a best practices for customer bug reporting on doc site