skylight 0.2.6 → 0.2.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: aeab120eedbac08fcc96da45ff2d3011b38e3167
-  data.tar.gz: 458036ec6fee23c0d43a96e278e941d7d7fda74b
+  metadata.gz: edae1bae15bae8f3c6570992aeef722d03a6daba
+  data.tar.gz: 0bf27cb52e79314929c6d1e11e38956dcc93fa77
 SHA512:
-  metadata.gz: 549584ea4aaa394da8734b153d314a40162f30e3d925a707c2035dd4824c7e48bb2d1b5c74add4bc64a0124bdbea1e278da89634c624b39eacfefe1762cb1cc9
-  data.tar.gz: 63e18b1a1dfb2b43414dff94dadbbf82dac6cd00c6a0b11419521846ab42d2de7e6ab6974f3a4ed724a04244af7dfac2c01ffbdcc1af9ef36223dc9bf55137c7
+  metadata.gz: 30f1914554e84ef1ec3f7e728787a36cc12b8aa469798ec18bc8ba3f142bc6c305fd98f2917d09eb058acbf691282ff113cc1aa302ca22db2c5c5af8b026560c
+  data.tar.gz: 292f7e33dc69706101430e2f0e6c21712d00526c7d789f7ca7bcaa02e1f622501c26ef493de776acbe7f448032ec0909f8f58dac60ad66d7e94df56cf3690fa7

data/lib/skylight/messages/span.rb

@@ -136,7 +136,7 @@ module Skylight
               category: category,
               title: title,
               description: description),
-            annotations: to_annotations(annotations),
+            annotations: nil,
             started_at: @started_at,
             duration: duration && duration > 0 ? duration : nil,
             children: @children > 0 ? @children : nil)

data/lib/skylight/version.rb

@@ -1,4 +1,4 @@
 module Skylight
-  VERSION = '0.2.6'
+  VERSION = '0.2.7'
 end
 

metadata

@@ -1,27 +1,27 @@
 --- !ruby/object:Gem::Specification
 name: skylight
 version: !ruby/object:Gem::Version
-  version: 0.2.6
+  version: 0.2.7
 platform: ruby
 authors:
 - Tilde, Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-02-25 00:00:00.000000000 Z
+date: 2014-02-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: 3.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '>='
       - !ruby/object:Gem::Version
         version: 3.0.0
 description: 
@@ -32,9 +32,6 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
-- CHANGELOG.md
-- README.md
-- bin/skylight
 - lib/skylight.rb
 - lib/skylight/api.rb
 - lib/skylight/cli.rb
@@ -142,7 +139,9 @@ files:
 - lib/sql_lexer.rb
 - lib/sql_lexer/lexer.rb
 - lib/sql_lexer/version.rb
-- too-many-sockets.md
+- CHANGELOG.md
+- README.md
+- bin/skylight
 homepage: http://www.skylight.io
 licenses: []
 metadata: {}
@@ -152,17 +151,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - '>='
     - !ruby/object:Gem::Version
       version: 1.9.2
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.0
+rubygems_version: 2.0.3
 signing_key: 
 specification_version: 4
 summary: Skylight is a ruby application monitoring tool. Currently in closed beta.

data/too-many-sockets.md

@@ -1,62 +0,0 @@
-We received a notification (Zendesk #280) from a customer that they were unable to SSH
-into their box, and that their service provider discovered that Skylight
-was triggering socket buffer limits.
-
-The customer immediately disabled Skylight, which fixed the bug for him.
-
-Customer Information:
-
-* Using Skylight 0.2.3
-* Ruby 2.0.0p353
-* Also had New Relic installed (Bug #46)
-* Recently upgraded to Rails 4
-* Passenger Enterprise with a max-pool size of 12 and zero-downtime deploys
-* He had a maxsockbuf of 32MB
-
-The customer also reported 134 open sockets in the server process.
-
-Separately, we discovered that New Relic was making our payloads
-extremely large.
-
-Our working hypothesis was that the large New Relic payloads were
-triggering the max buffer condition, which was then cascading into more
-failures.
-
-Upon further investigation, we discovered a few things:
-
-* If the client hits a kernel buffer limit (via EWOULDBLOCK that lasts
-  more than 5s), it closes down its socket
-* The server expects to recover from this situation by getting the
-  client socket in its read list from IO.select. It would then try to
-  read from it, get an EOF, and close the socket.
-* If the server does not get the client socket in its read list for some
-  (unknown) reason, this would result in an ever-growing list of sockets
-  on the server side.
-
-We are not sure why the sockets would not appear in the read list, but
-we hypothesize that when the OpenVZ limit is reached, the kernel no
-longer includes the socket in the read list, causing the server to never
-close the socket.
-
-Mitigation strategies:
-
-* The New Relic fix (#46) should reduce the likelihood of encountering
-  this in the first place
-* We want to add a Hello heartbeat from the client. If the server
-  doesn't receive a message every 1m (or 2m, TBD), it will close the
-  socket even if it's not in the read list.
-
-We are worried that if the server process ever gets stuck, this
-condition can occur. We are also considering a server heartbeat back to
-the clients, so they can take corrective action if the agent gets stuck.
-
-Some mitigations for this situation:
-
-* Kill the server process when a respawn is necessary. This will ensure
-  that a stuck agent process doesn't duplicate into N servers.
-* Before connecting to the server socket, pre-check the server process 
-  with kill -0.
-
-For next time: 
-* Request skylight.log for easier debugging
-* Form a best practices for customer bug reporting on doc site