skylight-core 2.0.0.beta2 → 2.0.0.beta3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f58661790467599ec0c5cbd72079670d76c9d57d471e240838567799c4e6ecbe
-  data.tar.gz: b7bef1b6c95412f55ba2f2df058311cc3ce21dfbe1bc20f50c9e0bab0f35aed9
+  metadata.gz: 237d8a95eb9bd92d8ab981fda27862546cdccfccc4aa0ebb3f5c1bd32bc69494
+  data.tar.gz: 61cd69d8abe954e0033f1c9303a45cb11b7a58561f4c784d3b41c3e2c1896172
 SHA512:
-  metadata.gz: 036a7e5f00b3af5eb266a2dc85168a061d171e22c6cf42250b09389c663df4b2a3cf4ad3fe008d3c19b84aab8eb23f192d86979a97695049a0e5e79e66d7bd79
-  data.tar.gz: 1ea741d116e218e01de5a3c2ade56a94823b8f5c6ece6797fcecb0a4ced8845fbcd136ca3bf99eec5eb89dc0c4f76f22b3518e1dc50229652af49c19baeffa0d
+  metadata.gz: b2fecfbbf37b22227727a69d2cde96a585e75e06d3bdd2f272521bff757b6c507a2d144398558e956666b55d4bef0e7121c1f02beeac06142d2c303b08d21999
+  data.tar.gz: ff10cbe2195702b05506df19491ab229b6824daa58fae7cf56afe67d46abdcca1f16faf716ca871a5ab0c3bd0505d729f91b217fd9088f8245a760df55ec9f42

data/lib/skylight/core/config.rb

@@ -14,8 +14,9 @@ module Skylight::Core
     # @api private
     MUTEX = Mutex.new
 
+    def self.log_name; "Skylight" end
     def self.env_matcher; /^(?:SK|SKYLIGHT)_(.+)$/ end
-    def self.native_env_prefix; "SKYLIGHT_" end
+    def self.env_prefix; "SKYLIGHT_" end
 
     # Map environment variable keys with Skylight configuration keys
     def self.env_to_key
@@ -47,7 +48,7 @@ module Skylight::Core
         :log_file             => '-'.freeze,
         :log_level            => 'INFO'.freeze,
         :alert_log_file       => '-'.freeze,
-        :log_sql_parse_errors => false,
+        :log_sql_parse_errors => true,
         :enable_segments      => true,
         :'heroku.dyno_info_path' => '/etc/heroku/dyno'
       }
@@ -320,7 +321,7 @@ module Skylight::Core
         value = send_or_get(key)
         unless value.nil?
           env_key = self.class.env_to_key.key(key) || key.upcase
-          ret << "#{self.class.native_env_prefix}#{env_key}" << cast_for_env(value)
+          ret << "#{self.class.env_prefix}#{env_key}" << cast_for_env(value)
         end
       end
 
@@ -412,15 +413,19 @@ module Skylight::Core
   private
 
     def create_logger(out)
-      if out.is_a?(String)
-        out = File.expand_path(out, root)
-        # May be redundant since we also do this in the permissions check
-        FileUtils.mkdir_p(File.dirname(out))
-      end
+      l = begin
+        if out.is_a?(String)
+          out = File.expand_path(out, root)
+          # May be redundant since we also do this in the permissions check
+          FileUtils.mkdir_p(File.dirname(out))
+        end
 
-      Logger.new(out)
-    rescue
-      Logger.new(STDOUT)
+        Logger.new(out)
+      rescue
+        Logger.new(STDOUT)
+      end
+      l.progname = self.class.log_name
+      l
     end
 
     def load_logger
@@ -429,13 +434,17 @@ module Skylight::Core
         out = STDOUT if out == '-'
 
         l = create_logger(out)
-        l.level =
-          case get(:log_level)
-          when /^debug$/i then Logger::DEBUG
-          when /^info$/i  then Logger::INFO
-          when /^warn$/i  then Logger::WARN
-          when /^error$/i then Logger::ERROR
-          end
+        if trace?
+          l.level = Logger::DEBUG
+        else
+          l.level =
+            case get(:log_level)
+            when /^debug$/i then Logger::DEBUG
+            when /^info$/i  then Logger::INFO
+            when /^warn$/i  then Logger::WARN
+            when /^error$/i then Logger::ERROR
+            end
+        end
       end
 
       l

data/lib/skylight/core/fanout.rb

@@ -39,6 +39,10 @@ module Skylight
         end
       end
 
+      def self.broken!
+        registered.each(&:broken!)
+      end
+
     end
   end
 end

data/lib/skylight/core/gc.rb

@@ -30,6 +30,11 @@ module Skylight::Core
       @profiler.enable if @profiler
     end
 
+    # Total time in microseconds for GC over entire process lifetime
+    def total_time
+      @profiler ? @profiler.total_time : nil
+    end
+
     def track
       unless @profiler
         win = Window.new(nil)

data/lib/skylight/core/instrumentable.rb

@@ -3,22 +3,13 @@ module Skylight
     module Instrumentable
 
       def self.included(base)
+        base.extend(Util::Logging)
         base.extend(ClassMethods)
 
         base.const_set(:LOCK, Mutex.new)
 
         base.class_eval do
-          at_exit do
-            if RUBY_VERSION == '1.9.2'
-              # workaround for MRI bug losing exit status in at_exit block
-              # http://bugs.ruby-lang.org/issues/5218
-              exit_status = $!.status if $!.is_a?(SystemExit)
-              stop!
-              exit exit_status if exit_status
-            else
-              stop!
-            end
-          end
+          at_exit { stop! }
         end
 
         Skylight::Core::Fanout.register(base)
@@ -38,6 +29,10 @@ module Skylight
           nil
         end
 
+        def probe(*args)
+          Skylight::Core::Probes.probe(*args)
+        end
+
         # Start instrumenting
         def start!(config=nil)
           return @instrumenter if @instrumenter
@@ -51,11 +46,17 @@ module Skylight
             @instrumenter = instrumenter_class.new(config).start!
           end
         rescue => e
-          message = sprintf("[SKYLIGHT] [#{VERSION}] Unable to start Instrumenter; msg=%s; class=%s", e.message, e.class)
-          if config && config.respond_to?(:logger)
-            config.logger.warn message
+          level, message = if e.is_a? ConfigError
+            [:warn, sprintf("Unable to start Instrumenter due to a configuration error: %s", e.message)]
+          else
+            [:error, sprintf("Unable to start Instrumenter; msg=%s; class=%s", e.message, e.class)]
+          end
+
+          if config && config.respond_to?("log_#{level}") && config.respond_to?(:log_trace)
+            config.send("log_#{level}", message)
+            config.log_trace e.backtrace.join("\n")
           else
-            warn message
+            warn "[#{name.upcase}] #{message}"
           end
           false
         end
@@ -127,6 +128,11 @@ module Skylight
           instrumenter.done(span, meta)
         end
 
+        def broken!
+          return unless instrumenter
+          instrumenter.broken!
+        end
+
         # Temporarily disable
         def disable
           unless instrumenter
@@ -137,6 +143,11 @@ module Skylight
           instrumenter.disable { yield }
         end
 
+        def config
+          return unless instrumenter
+          instrumenter.config
+        end
+
       end
 
     end

data/lib/skylight/core/instrumenter.rb

@@ -135,7 +135,7 @@ module Skylight::Core
 
       ensure
         @trace_info.current = nil
-        t { "submitting trace" }
+        t { "instrumenter submitting trace" }
         trace.submit
       end
     end
@@ -202,6 +202,11 @@ module Skylight::Core
       trace.span_correlation_header(span)
     end
 
+    def broken!
+      return unless trace = @trace_info.current
+      trace.broken!
+    end
+
     def done(span, meta=nil)
       return unless trace = @trace_info.current
       trace.done(span, meta)
@@ -232,6 +237,7 @@ module Skylight::Core
         true
       rescue => e
         warn "failed to submit trace to worker; err=%s", e
+        t { "BACKTRACE:\n#{e.backtrace.join("\n")}" }
         false
       end
     end

data/lib/skylight/core/middleware.rb

@@ -42,14 +42,14 @@ module Skylight::Core
     end
 
     def self.with_after_close(resp, &block)
-      # Responses should be finished but in some situations they aren't
+      # Responses should be arrays but in some situations they aren't
       #   e.g. https://github.com/ruby-grape/grape/issues/1041
-      if resp.respond_to?(:finish)
-        resp = resp.finish
-      end
+      # The safest approach seems to be to rely on implicit destructuring
+      #   since that is currently what Rack::Lint does.
+      # See also https://github.com/rack/rack/issues/1239
+      status, headers, body = resp
 
-      resp[2] = BodyProxy.new(resp[2], &block)
-      resp
+      [status, headers, BodyProxy.new(body, &block)]
     end
 
     include Util::Logging
@@ -76,6 +76,10 @@ module Skylight::Core
     end
 
     def call(env)
+      if instrumentable.tracing?
+        error "Already instrumenting. Make sure the Middleware hasn't been added more than once."
+      end
+
       if env["REQUEST_METHOD"] == "HEAD"
         t { "middleware skipping HEAD" }
         @app.call(env)

data/lib/skylight/core/normalizers/sql.rb

@@ -31,10 +31,16 @@ module Skylight::Core
           extracted_title, sql = extract_binds(trace.instrumenter, payload, binds)
           [ name, extracted_title || title, sql ]
         rescue => e
-          # FIXME: Rust errors get written to STDERR and don't come through here
-          if config[:log_sql_parse_errors]
-            config.logger.warn "failed to extract binds in SQL; sql=#{payload[:sql].inspect}; exception=#{e.inspect}"
+          if e.is_a?(Skylight::SqlLexError)
+            if config[:log_sql_parse_errors]
+              config.logger.error "[#{e.formatted_code}] Failed to extract binds from SQL query. " \
+                                  "It's likely that this query uses more advanced syntax than we currently support. " \
+                                  "sql=#{payload[:sql].inspect}"
+            end
+          else
+            config.logger.error "Failed to extract binds in SQL; sql=#{payload[:sql].inspect}; exception=#{e.inspect}"
           end
+
           [ name, title, nil ]
         end
       end

data/lib/skylight/core/probes/action_view.rb

@@ -10,11 +10,9 @@ module Skylight::Core
               layout = nil
 
               if path
-                if method(:find_layout).arity == 3
-                  # Rails 5
+                if ::ActionView.gem_version >= Gem::Version.new('5.x')
                   layout = find_layout(path, locals.keys, [formats.first])
                 else
-                  # Rails 4
                   layout = find_layout(path, locals.keys)
                 end
               end

data/lib/skylight/core/probes/active_model_serializers.rb

@@ -19,7 +19,7 @@ module Skylight::Core
 
           if !version || version < Gem::Version.new("0.5.0")
             # Using $stderr here isn't great, but we don't have a logger accessible
-            $stderr.puts "[SKYLIGHT] [#{Skylight::Core::VERSION}] Instrumention is only available for " \
+            $stderr.puts "[SKYLIGHT::CORE] [#{Skylight::Core::VERSION}] Instrumention is only available for " \
                           "ActiveModelSerializers version 0.5.0 and greater."
             return
           end

data/lib/skylight/core/probes/excon.rb

@@ -14,7 +14,7 @@ module Skylight::Core
             ::Excon.defaults[:middlewares].insert(idx, Probes::Excon::Middleware)
           else
             # Using $stderr here isn't great, but we don't have a logger accessible
-            $stderr.puts "[SKYLIGHT] [#{Skylight::Core::VERSION}] The installed version of Excon doesn't " \
+            $stderr.puts "[SKYLIGHT::CORE] [#{Skylight::Core::VERSION}] The installed version of Excon doesn't " \
                           "support Middlewares. The Excon probe will be disabled."
           end
         end

data/lib/skylight/core/probes/grape.rb

@@ -12,7 +12,7 @@ module Skylight::Core
 
           if version < Gem::Version.new("0.10.0")
             # Using $stderr here isn't great, but we don't have a logger accessible
-            $stderr.puts "[SKYLIGHT] [#{Skylight::Core::VERSION}] The Grape probe only works with version 0.10.0+ " \
+            $stderr.puts "[SKYLIGHT::CORE] [#{Skylight::Core::VERSION}] The Grape probe only works with version 0.10.0+ " \
                           "and will be disabled."
 
             return

data/lib/skylight/core/probes/middleware.rb

@@ -2,7 +2,57 @@ module Skylight::Core
   module Probes
     module Middleware
       class Probe
+        def self.add_instrumentation(middleware, default_name: "Anonymous Middleware", category: "rack.middleware")
+          middleware.instance_eval <<-RUBY, __FILE__, __LINE__ + 1
+            alias call_without_sk call
+            def call(*args, &block)
+              traces = Skylight::Core::Fanout.registered.map do |r|
+                r.instrumenter ? r.instrumenter.current_trace : nil
+              end.compact
+
+              return call_without_sk(*args, &block) if traces.empty?
+
+              begin
+                name = self.class.name || "#{default_name}"
+
+                traces.each{|t| t.endpoint = name }
+
+                spans = Skylight::Core::Fanout.instrument(title: name, category: "#{category}")
+                resp = call_without_sk(*args, &block)
+
+                Skylight::Core::Middleware.with_after_close(resp) do
+                  Skylight::Core::Fanout.done(spans)
+                end
+              rescue Exception => e
+                # FIXME: Log this?
+                Skylight::Core::Fanout.done(spans, exception_object: e)
+                raise
+              end
+            end
+          RUBY
+        end
+
         def install
+          ActionDispatch::MiddlewareStack.class_eval do
+            alias build_without_sk build
+
+            if ::ActionPack.gem_version >= Gem::Version.new('5.x')
+              # Rails 5
+              def build(app = Proc.new)
+                Skylight::Core::Probes::Middleware::Probe.add_instrumentation(app, default_name: "Rack App", category: "rack.app")
+                build_without_sk(app)
+              end
+            else
+              # Rails 3 and 4
+              def build(app, &block)
+                app ||= block
+                raise "MiddlewareStack#build requires an app" unless app
+                Skylight::Core::Probes::Middleware::Probe.add_instrumentation(app, default_name: "Rack App", category: "rack.app")
+                build_without_sk(app)
+              end
+            end
+          end
+
           ActionDispatch::MiddlewareStack::Middleware.class_eval do
             alias build_without_sk build
             def build(*args)
@@ -18,33 +68,7 @@ module Skylight::Core
               # On Rails 3, ActionDispatch::Session::CookieStore is frozen, for one
               return middleware if middleware.frozen?
 
-              middleware.instance_eval do
-                alias call_without_sk call
-                def call(*args, &block)
-                  traces = Skylight::Core::Fanout.registered.map do |r|
-                    r.instrumenter ? r.instrumenter.current_trace : nil
-                  end.compact
-
-                  return call_without_sk(*args, &block) if traces.empty?
-
-                  begin
-                    name = self.class.name || "Anonymous Middleware"
-
-                    traces.each{|t| t.endpoint = name }
-
-                    spans = Skylight::Core::Fanout.instrument(title: name, category: "rack.middleware")
-                    resp = call_without_sk(*args, &block)
-
-                    Skylight::Core::Middleware.with_after_close(resp) do
-                      Skylight::Core::Fanout.done(spans)
-                    end
-                  rescue Exception => e
-                    # FIXME: Log this?
-                    Skylight::Core::Fanout.done(spans, exception_object: e)
-                    raise
-                  end
-                end
-              end
+              Skylight::Core::Probes::Middleware::Probe.add_instrumentation(middleware)
 
               middleware
             end

data/lib/skylight/core/probes/moped.rb

@@ -6,7 +6,7 @@ module Skylight::Core
         def install
           unless defined?(::Moped::Instrumentable)
             # Using $stderr here isn't great, but we don't have a logger accessible
-            $stderr.puts "[SKYLIGHT] [#{Skylight::Core::VERSION}] The installed version of Moped doesn't " \
+            $stderr.puts "[SKYLIGHT::CORE] [#{Skylight::Core::VERSION}] The installed version of Moped doesn't " \
                           "support instrumentation. The Moped probe will be disabled."
 
             return

data/lib/skylight/core/probes/redis.rb

@@ -7,7 +7,7 @@ module Skylight::Core
 
           if !version || version < Gem::Version.new("3.0.0")
             # Using $stderr here isn't great, but we don't have a logger accessible
-            $stderr.puts "[SKYLIGHT] [#{Skylight::Core::VERSION}] The installed version of Redis doesn't " \
+            $stderr.puts "[SKYLIGHT::CORE] [#{Skylight::Core::VERSION}] The installed version of Redis doesn't " \
                           "support Middlewares. At least version 3.0.0 is required."
             return
           end

data/lib/skylight/core/probes/sinatra.rb

@@ -5,7 +5,7 @@ module Skylight::Core
         def install
           if ::Sinatra::VERSION < '1.4.0'
             # Using $stderr here isn't great, but we don't have a logger accessible
-            $stderr.puts "[SKYLIGHT] [#{Skylight::VERSION}] Sinatra must be version 1.4.0 or greater."
+            $stderr.puts "[SKYLIGHT::CORE] [#{Skylight::VERSION}] Sinatra must be version 1.4.0 or greater."
             return
           end
 

data/lib/skylight/core/railtie.rb

@@ -119,7 +119,7 @@ module Skylight::Core
     end
 
     def activate?
-      key = "#{self.class.config_class.native_env_prefix}ENABLED"
+      key = "#{self.class.config_class.env_prefix}ENABLED"
       if ENV.key?(key)
         ENV[key] !~ /^false$/i
       else

data/lib/skylight/core/test.rb

@@ -56,6 +56,9 @@ module Skylight
                   mock_spans[sp][:meta] = meta
                 end
 
+                def native_span_started(sp)
+                end
+
                 def native_span_set_exception(sp, exception_object, exception)
                   mock_spans[sp][:exception_object] = exception_object
                   mock_spans[sp][:exception] = exception

data/lib/skylight/core/trace.rb

@@ -50,8 +50,12 @@ module Skylight::Core
       @instrumenter.config
     end
 
+    def broken?
+      !!@broken
+    end
+
     def record(cat, title=nil, desc=nil)
-      return if @broken
+      return if broken?
 
       title.freeze if title.is_a?(String)
       desc.freeze  if desc.is_a?(String)
@@ -65,12 +69,12 @@ module Skylight::Core
       nil
     rescue => e
       error "failed to record span; msg=%s", e.message
-      @broken = true
+      broken!
       nil
     end
 
     def instrument(cat, title=nil, desc=nil, meta=nil)
-      return if @broken
+      return if broken?
       t { "instrument: #{cat}, #{title}" }
 
       title.freeze if title.is_a?(String)
@@ -81,7 +85,8 @@ module Skylight::Core
       desc          = @instrumenter.limited_description(desc)
 
       if desc == Instrumenter::TOO_MANY_UNIQUES
-        debug "[SKYLIGHT] [#{Skylight::Core::VERSION}] A payload description produced <too many uniques>"
+        error "[E0002] The number of unique span descriptions allowed per-request has been exceeded " \
+                  "for endpoint: #{endpoint}."
         debug "original desc=%s", original_desc
         debug "cat=%s, title=%s, desc=%s", cat, title, desc
       end
@@ -89,17 +94,18 @@ module Skylight::Core
       start(now - gc_time, cat, title, desc, meta)
     rescue => e
       error "failed to instrument span; msg=%s", e.message
-      @broken = true
+      broken!
       nil
     end
 
     def span_correlation_header(span)
+      return unless span
       native_span_get_correlation_header(span)
     end
 
     def done(span, meta=nil)
       return unless span
-      return if @broken
+      return if broken?
 
       if meta && (meta[:exception_object] || meta[:exception])
         native_span_set_exception(span, meta[:exception_object], meta[:exception])
@@ -108,7 +114,7 @@ module Skylight::Core
       stop(span, Util::Clock.nanos - gc_time)
     rescue => e
       error "failed to close span; msg=%s", e.message
-      @broken = true
+      broken!
       nil
     end
 
@@ -117,6 +123,11 @@ module Skylight::Core
       @instrumenter.current_trace = nil
     end
 
+    def broken!
+      debug "trace is broken"
+      @broken = true
+    end
+
     def traced
       time = gc_time
       now = Util::Clock.nanos
@@ -130,9 +141,9 @@ module Skylight::Core
     end
 
     def submit
-      return if @broken
+      t { "submitting trace; broken=#{broken?}" }
 
-      t { "submitting trace" }
+      return if broken?
 
       if @submitted
         t { "already submitted" }
@@ -159,6 +170,7 @@ module Skylight::Core
       native_span_set_title(sp, title.to_s) if title
       native_span_set_description(sp, desc.to_s) if desc
       native_span_set_meta(sp, meta) if meta
+      native_span_started(sp)
 
       @spans << sp
       t { "started span: #{sp} - #{cat}, #{title}" }
@@ -171,9 +183,21 @@ module Skylight::Core
 
       expected = @spans.pop
       unless span == expected
-        error "invalid span nesting"
-        # TODO: Actually log span title here
+        message = "[E0001] Spans were closed out of order. Expected to see '#{native_span_get_title(expected)}', " \
+                    "but got '#{native_span_get_title(span)}' instead."
+
+        if native_span_get_category(span) == "rack.middleware"
+          message << "\n#{native_span_get_title(span)} may be a Middleware that doesn't fully conform " \
+                      "to the Rack SPEC."
+        end
+
+        message << "\nThis request will not be tracked. Please contact support@skylight.io for more information."
+
+        error message
+
         t { "expected=#{expected}, actual=#{span}" }
+
+        broken!
       end
 
       time = self.class.normalize_time(time)

data/lib/skylight/core/util/logging.rb

@@ -25,36 +25,41 @@ module Skylight::Core
 
     module Logging
 
-      def self.trace?
-        ENV[Skylight::TRACE_ENV_KEY]
+      def log_env_prefix
+        if c = config_for_logging
+          c.class.env_prefix
+        else
+          "SKYLIGHT_"
+        end
       end
 
-      if trace?
-        # The second set is picked up by YARD
-        def trace(msg, *args)
-          log :debug, msg, *args
-        end
+      def trace?
+        !!ENV["#{log_env_prefix}ENABLE_TRACE_LOGS"]
+      end
 
-        def t
-          log :debug, yield
-        end
-      else
-        # Logs if `ENV[TRACE_ENV_KEY]` is set.
-        #
-        # @param (see #debug)
-        #
-        # See {TRACE_ENV_KEY}.
-        def trace(msg, *args)
-        end
+      def raise_on_error?
+        !!ENV["#{log_env_prefix}RAISE_ON_ERROR"]
+      end
 
-        # Evaluates and logs the result of the block if `ENV[TRACE_ENV_KEY]` is set
-        #
-        # @yield block to be evaluted
-        # @yieldreturn arguments for {#debug}
-        #
-        # See {TRACE_ENV_KEY}.
-        def t
-        end
+      # Logs if tracing
+      #
+      # @param (see #debug)
+      #
+      # See {trace?}.
+      def trace(msg, *args)
+        return unless trace?
+        log :debug, msg, *args
+      end
+
+      # Evaluates and logs the result of the block if tracing
+      #
+      # @yield block to be evaluted
+      # @yieldreturn arguments for {#debug}
+      #
+      # See {trace?}.
+      def t
+        return unless trace?
+        log :debug, yield
       end
 
       # @param msg (see #log)
@@ -79,7 +84,7 @@ module Skylight::Core
       # @param args (see #log)
       def error(msg, *args)
         log :error, msg, *args
-        raise sprintf(msg, *args) if ENV['SKYLIGHT_RAISE_ON_ERROR']
+        raise sprintf(msg, *args) if raise_on_error?
       end
 
       alias log_trace trace
@@ -94,29 +99,40 @@ module Skylight::Core
         sprintf(*args)
       end
 
-      # @param level [String,Symbol] the method on `logger` to use for logging
-      # @param msg [String] the message to log
-      # @param args [Array] values for `Kernel#sprintf` on `msg`
-      def log(level, msg, *args)
-        c = if respond_to?(:config)
+      def config_for_logging
+        if respond_to?(:config)
           config
         elsif self.is_a?(Config)
           self
         end
+      end
 
-        return unless c
-
-        if logger = c.logger
-          return unless logger.respond_to?(level)
-
-          if args.length > 0
-            logger.send level, sprintf("[SKYLIGHT] [#{Skylight::Core::VERSION}] #{msg}", *args)
+      # @param level [String,Symbol] the method on `logger` to use for logging
+      # @param msg [String] the message to log
+      # @param args [Array] values for `Kernel#sprintf` on `msg`
+      def log(level, msg, *args)
+        c = config_for_logging
+        logger = c ? c.logger : nil
+
+        if logger
+          if logger.respond_to?(level)
+            if args.length > 0
+              logger.send level, sprintf(msg, *args)
+            else
+              logger.send level, msg
+            end
+            return
           else
-            logger.send level, "[SKYLIGHT] [#{Skylight::Core::VERSION}] #{msg}"
+            Kernel.warn "Invalid logger"
           end
         end
+
+        # Fallback
+        module_name = self.is_a?(Module) ? name : self.class.name
+        root_name = module_name.split('::').first.upcase
+        puts sprintf("[#{root_name}] #{msg}", *args)
       rescue Exception => e
-        if ENV[Skylight::TRACE_ENV_KEY]
+        if trace?
           puts "[ERROR] #{e.message}"
           puts e.backtrace
         end

data/lib/skylight/core/version.rb

@@ -1,6 +1,6 @@
 module Skylight
   module Core
-    VERSION = '2.0.0-beta2'
+    VERSION = '2.0.0-beta3'
   end
 end
 

data/lib/skylight/core.rb

@@ -6,9 +6,6 @@ module Skylight
     autoload :Normalizers,  'skylight/core/normalizers'
   end
 
-  # @api private
-  TRACE_ENV_KEY = 'SKYLIGHT_ENABLE_TRACE_LOGS'.freeze
-
   # Some methods exepected to be defined by the native code (OUTDATED)
   #
   #   * Skylight::Core::Util::Clock#native_hrtime

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: skylight-core
 version: !ruby/object:Gem::Version
-  version: 2.0.0.beta2
+  version: 2.0.0.beta3
 platform: ruby
 authors:
 - Tilde, Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-02-05 00:00:00.000000000 Z
+date: 2018-03-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport