skunk 0.3.1 → 0.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 31e5fabed605521119f56bd2d3391bf8f206562deeea374685ed9c2fa549e0f9
-  data.tar.gz: e5a42b34af7d2162a25b4ab91abaa33dec4930c4c58ee44c9ecd1e74f05661e2
+  metadata.gz: 9d3c745cc66587d122f3765510fae8271ff4f9fe050a01b98de8691e247f2948
+  data.tar.gz: 8bc479b7593c3fdcfc2555649e2a3c08d77ef624eda2148d9ba5c6b56e62d1e8
 SHA512:
-  metadata.gz: 6ec99d947845d5bb77f2efa446078e0fc20658c67b1bd75e618dbbe3d453403e080798124cf7d60e5799573e636ac6847fdecd1a4b37ad8404e766937530133b
-  data.tar.gz: 51cdff8ee198c28b6281d5176e103b9af3f716656ef411716a945f9c21dbfe36894533849ac7b1090904073a10b0dc5131f7228fc16a23e4d0e7894abd77db81
+  metadata.gz: f2537c79bc13dcdc590d52076f46934ed522489cd2c4afe82aea8aca4064e274ece9391c9813188dffd79a23a080e46e36809afdd9c9731de528cfb84adbe3ac
+  data.tar.gz: a8b72fddcd6118858c4cf161c1aa99f3de087e22794cc3c6f68a8b1e1e6d94b2d9f1015a995aed65fd69305e254173b5f4ce615a8d5fe042893fe652274ca394

data/.reek.yml

@@ -1,28 +1,33 @@
 # Auto generated by Reeks --todo flag
 ---
 detectors:
-  UtilityFunction:
+  Attribute:
     exclude:
-    - capture_output_streams
-    - Skunk::Command::Compare#analyse_modified_files
-    - Skunk::Command::Compare#build_details_path
+    - Skunk::Command::StatusReporter#analysed_modules
+  FeatureEnvy:
+    exclude:
+    - Skunk::Command::StatusReporter#table
   InstanceVariableAssumption:
     exclude:
-    - Skunk::Cli::Application
     - Skunk::Cli::Command::Default
+    - Skunk::Cli::Options::Argv
     - RubyCritic::AnalysedModulesCollection
-  TooManyStatements:
-    exclude:
-    - initialize
-    - Skunk::Cli::Application#execute
   IrresponsibleModule:
     exclude:
     - Skunk::Cli::Command::Help
+    - Skunk::Cli::Options::Argv
     - Skunk::Cli::Options
     - RubyCritic::AnalysedModulesCollection
-  Attribute:
+  NestedIterators:
     exclude:
-    - Skunk::Command::StatusReporter#analysed_modules
-  FeatureEnvy:
+    - Skunk::Cli::Options::Argv#parse
+  TooManyStatements:
     exclude:
-    - Skunk::Command::StatusReporter#table
+    - initialize
+    - Skunk::Cli::Application#execute
+    - Skunk::Cli::Options::Argv#parse
+  UtilityFunction:
+    exclude:
+    - capture_output_streams
+    - Skunk::Command::Compare#analyse_modified_files
+    - Skunk::Command::Compare#build_details_path

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    skunk (0.3.1)
+    skunk (0.3.2)
       rubycritic (~> 4.2.1)
       terminal-table (~> 1.8.0)
 

data/lib/skunk/cli/application.rb

@@ -1,16 +1,21 @@
 # frozen_string_literal: true
 
+require "rubycritic/cli/options"
+require "rubycritic/cli/application"
+
 require "skunk"
 require "skunk/rubycritic/analysed_module"
 require "skunk/cli/options"
 require "skunk/cli/command_factory"
 
-require "rubycritic/cli/application"
-
 module Skunk
   module Cli
     # Knows how to execute command line commands
     class Application < RubyCritic::Cli::Application
+      def initialize(argv)
+        @options = Skunk::Cli::Options.new(argv)
+      end
+
       def execute
         parsed_options = @options.parse.to_h
         reporter = Skunk::Cli::CommandFactory.create(parsed_options).execute

data/lib/skunk/cli/commands/help.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require "skunk/cli/commands/base"
+require "rubycritic/commands/help"
 
 module Skunk
   module Cli

data/lib/skunk/cli/commands/status_reporter.rb

@@ -13,7 +13,7 @@ module Skunk
       HEADINGS = %w[file stink_score churn_times_cost churn cost coverage].freeze
 
       TEMPLATE = ERB.new(<<-TEMPL
-<%= ttable %>\n
+<%= _ttable %>\n
 StinkScore Total: <%= total_stink_score %>
 Modules Analysed: <%= analysed_modules_count %>
 StinkScore Average: <%= stink_score_average %>
@@ -26,7 +26,7 @@ TEMPL
       def update_status_message
         opts = table_options.merge(headings: HEADINGS, rows: table)
 
-        ttable = Terminal::Table.new(opts)
+        _ttable = Terminal::Table.new(opts)
 
         @status_message = TEMPLATE.result(binding)
       end

data/lib/skunk/cli/options.rb

@@ -1,10 +1,34 @@
 # frozen_string_literal: true
 
-require "rubycritic/cli/options"
+require "skunk/cli/options/argv"
+require "rubycritic/cli/options/file"
 
 module Skunk
   module Cli
-    class Options < RubyCritic::Cli::Options
+    # Knows how to parse options passed to the CLI application
+    class Options
+      attr_reader :argv_options, :file_options
+
+      def initialize(argv)
+        @argv_options = Argv.new(argv)
+        @file_options = RubyCritic::Cli::Options::File.new
+      end
+
+      def parse
+        argv_options.parse
+        file_options.parse
+        self
+      end
+
+      # :reek:NilCheck
+      def to_h
+        file_hash = file_options.to_h
+        argv_hash = argv_options.to_h
+
+        file_hash.merge(argv_hash) do |_, file_option, argv_option|
+          Array(argv_option).empty? ? file_option : argv_option
+        end
+      end
     end
   end
 end

data/lib/skunk/cli/options/argv.rb

@@ -0,0 +1,41 @@
+# frozen_string_literal: true
+
+require "rubycritic/cli/options/argv"
+
+module Skunk
+  module Cli
+    # :nodoc:
+    class Options
+      # Extends RubyCritic::Cli::Options::Argv to parse a subset of the
+      # parameters accepted by RubyCritic
+      class Argv < RubyCritic::Cli::Options::Argv
+        def parse # rubocop:disable Metrics/MethodLength
+          parser.new do |opts|
+            opts.banner = "Usage: skunk [options] [paths]\n"
+
+            opts.on(
+              "-p", "--path [PATH]",
+              "Set path where report will be saved (tmp/skunk by default)"
+            ) do |path|
+              @root = path
+            end
+
+            opts.on("-b", "--branch BRANCH", "Set branch to compare") do |branch|
+              self.base_branch = String(branch)
+              set_current_branch
+              self.mode = :compare_branches
+            end
+
+            opts.on_tail("-v", "--version", "Show gem's version") do
+              self.mode = :version
+            end
+
+            opts.on_tail("-h", "--help", "Show this message") do
+              self.mode = :help
+            end
+          end.parse!(@argv)
+        end
+      end
+    end
+  end
+end

data/lib/skunk/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Skunk
-  VERSION = "0.3.1"
+  VERSION = "0.3.2"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: skunk
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.3.2
 platform: ruby
 authors:
 - Ernesto Tagwerker
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-11-19 00:00:00.000000000 Z
+date: 2019-11-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubycritic
@@ -196,6 +196,7 @@ files:
 - lib/skunk/cli/commands/help.rb
 - lib/skunk/cli/commands/status_reporter.rb
 - lib/skunk/cli/options.rb
+- lib/skunk/cli/options/argv.rb
 - lib/skunk/rubycritic/analysed_module.rb
 - lib/skunk/rubycritic/analysed_modules_collection.rb
 - lib/skunk/version.rb