skinny_controllers 0.6.2 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f16b93f4e0724245262a2ad6a08184e64856c686
-  data.tar.gz: ef7a73a27ee75c3bbf6b93da279676b441956277
+  metadata.gz: bfd1fac9652be4c71127faeea92909e2587462b5
+  data.tar.gz: 8ef6996a05fd1dfc06682003c69654b130a4ae9d
 SHA512:
-  metadata.gz: f434627729f255be2934939bceb324bb64af99193b4299eb7a512af6b588f35dd0ccbfacfa0133f8d57c955c155aa4c819460e79715c22437d377b2e3d62e14d
-  data.tar.gz: 4a53721fd7bec0bc449cc2004c491ac4a8949916c080195f792caad2fc1180575e26c1ddea5a80d336e1db48ede60bc267b5920a2f73eb9e85a39fb0e9fe62b2
+  metadata.gz: 9c516408f33f026117fc3f2e4a432ed1d6e8ace278417fc69a878e691f80f37b7a075745ae4331d6960c4d77f4780f81f4740be35f0a9bc3316e73d34ab95137
+  data.tar.gz: 5c2bf53aa6ae2de2fed209c3bf9caa62c901cebbe5bf5c2fd9b989beb67b9067cb96956ee9326bcc66e24e0b9af850dca0372dab3b466caebce0deaee7b9a7f9

data/README.md

@@ -74,6 +74,21 @@ end
 Note that `each_serializer` and `serializer` is not part of `SkinnyControllers`, and is part of [ActiveModel::Serializers](https://github.com/rails-api/active_model_serializers).
 
 
+### What if your model is namespaced?
+
+All you have to do is set the `model_class`, and `model_key`.
+
+```ruby
+class ItemsController < ApiController # or whatever your superclass is
+  include SkinnyControllers::Diet
+  self.model_class = NameSpace::Item
+  self.model_key = 'item'
+end
+```
+`model_key` specifies the key to look for params when creating / updating the model.
+
+Note that while `model_key` doesn't *have* to be specified, it would default to name_space/item. So, just keep that in mind.  
+
 ### What if you want to call your own operations?
 
 Sometimes, magic is scary. You can call anything you want manually (operations and policies).

data/lib/skinny_controllers/diet.rb

@@ -4,13 +4,17 @@ module SkinnyControllers
 
     included do
       cattr_accessor :model_class
+      cattr_accessor :model_key
     end
 
     # TODO: what if we want multiple operations per action?
     #
     # @return an instance of the operation with default parameters
     def operation
-      @operation ||= operation_class.new(current_user, params, params_for_action, action_name)
+      @operation ||= operation_class.new(
+        current_user,
+        params, params_for_action,
+        action_name, model_key)
     end
 
     # Assumes the operation name from the controller name
@@ -46,7 +50,9 @@ module SkinnyControllers
       return {} if action_name == 'destroy'
 
       model_key =
-        if model_class
+        if self.model_key.present?
+          self.model_key
+        elsif model_class
           # model_class should be a class
           model_class.name.underscore
         else

data/lib/skinny_controllers/lookup/model.rb

@@ -24,7 +24,8 @@ module SkinnyControllers
         # Namespace::ModelOperations::Verb => Namespace::ModelOperations
         namespace = operation_name.deconstantize
         # Namespace::ModelOperations => ModelOperations
-        nested_namespace = namespace.demodulize
+        # nested_namespace = namespace.demodulize
+        nested_namespace = namespace.gsub(SkinnyControllers.operations_namespace, '')
         # ModelOperations => Model
         nested_namespace.gsub(SkinnyControllers.operations_suffix, '')
       end

data/lib/skinny_controllers/lookup/namespace.rb

@@ -0,0 +1,32 @@
+module SkinnyControllers
+  module Lookup
+    module Namespace
+      module_function
+
+      # iterate through the namespaces until one doesn't exist, and create the rest
+      def create_namespace(desired_namespace)
+        if klass = desired_namespace.safe_constantize
+          return klass
+        end
+
+        namespaces = desired_namespace.split('::')
+        existing = []
+        previous = Object
+
+        namespaces.each do |namespace|
+          current = (existing + [namespace]).join('::')
+          begin
+            Object.const_get(current)
+          rescue NameError => e
+            previous.const_set(namespace, Module.new)
+          end
+
+          existing << namespace
+          previous = current.constantize
+        end
+
+        previous
+      end
+    end
+  end
+end

data/lib/skinny_controllers/lookup/operation.rb

@@ -36,12 +36,15 @@ module SkinnyControllers
 
       # @return [Class] namespace for the default operation class
       def default_operation_namespace_for(model_name)
+        # binding.pry
         desired_namespace = namespace_from_model(model_name)
         parent_namespace = SkinnyControllers.operations_namespace
         namespace = "#{parent_namespace}::#{desired_namespace}".safe_constantize
-        namespace || Object.const_set(desired_namespace, Module.new)
+        namespace || Namespace.create_namespace(desired_namespace)
       end
 
+
+
       # @example 'Object' => 'ObjectOperations'
       # @return [String] the operation namespace based on the model name
       def namespace_from_model(model_name)

data/lib/skinny_controllers/lookup/policy.rb

@@ -18,7 +18,22 @@ module SkinnyControllers
 
       def define_policy_class(name)
         default_policy = SkinnyControllers::Policy::Default
-        Object.const_set(name, default_policy.dup)
+        namespace_klass = Object
+        # if we are namespaced, we need to get / create the namespace if it doesn't exist already
+        if (name.include?('::'))
+          namespaces = name.split('::')
+          namespace = namespaces[0..-2].join('::').presence
+          namespace = namespace == name ? 'Object' : namespace
+          if (namespace.presence && namespace != name )
+            namespace_klass = Namespace.create_namespace(namespace)
+          end
+        end
+
+        # naw remove the namespace from the name
+        name = name.gsub(namespace_klass.name + '::', '')
+
+        # finally, define the new policy class
+        namespace_klass.const_set(name, default_policy.dup)
       end
 
       # @param [String] class_name name of the operation class

data/lib/skinny_controllers/operation/base.rb

@@ -15,7 +15,7 @@ module SkinnyControllers
     class Base
       include ModelHelpers
 
-      attr_accessor :params, :current_user, :authorized_via_parent, :action, :params_for_action
+      attr_accessor :params, :current_user, :authorized_via_parent, :action, :params_for_action, :model_key
 
       def self.run(current_user, params)
         object = new(current_user, params)
@@ -26,12 +26,13 @@ module SkinnyControllers
       # @param [Hash] controller_params the params hash raw from the controller
       # @param [Hash] params_for_action optional params hash, generally the result of strong parameters
       # @param [string] action the current action on the controller
-      def initialize(current_user, controller_params, params_for_action = nil, action = nil)
+      def initialize(current_user, controller_params, params_for_action = nil, action = nil, model_key = nil)
         self.authorized_via_parent = false
         self.current_user = current_user
         self.action = action || controller_params[:action]
         self.params = controller_params
         self.params_for_action = params_for_action || controller_params
+        self.model_key = model_key
       end
 
       def id_from_params

data/lib/skinny_controllers/operation/model_helpers.rb

@@ -49,7 +49,8 @@ module SkinnyControllers
       end
 
       def model_param_name
-        model_name.underscore
+        # model_key comes from Operation::Base
+        self.model_key || model_name.underscore
       end
 
       # @param [Hash] scoped_params

data/lib/skinny_controllers/version.rb

@@ -1,3 +1,3 @@
 module SkinnyControllers
-  VERSION = '0.6.2'
+  VERSION = '0.7.0'
 end

data/lib/skinny_controllers.rb

@@ -7,6 +7,7 @@ require 'active_support/core_ext/string/inflections'
 
 # files for this gem
 require 'skinny_controllers/default_verbs'
+require 'skinny_controllers/lookup/namespace'
 require 'skinny_controllers/lookup/controller'
 require 'skinny_controllers/lookup/model'
 require 'skinny_controllers/lookup/operation'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: skinny_controllers
 version: !ruby/object:Gem::Version
-  version: 0.6.2
+  version: 0.7.0
 platform: ruby
 authors:
 - L. Preston Sego III
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-01-26 00:00:00.000000000 Z
+date: 2016-01-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -191,6 +191,7 @@ files:
 - lib/skinny_controllers/diet.rb
 - lib/skinny_controllers/lookup/controller.rb
 - lib/skinny_controllers/lookup/model.rb
+- lib/skinny_controllers/lookup/namespace.rb
 - lib/skinny_controllers/lookup/operation.rb
 - lib/skinny_controllers/lookup/policy.rb
 - lib/skinny_controllers/operation/base.rb
@@ -221,8 +222,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.8
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
-summary: SkinnyControllers-0.6.2
+summary: SkinnyControllers-0.7.0
 test_files: []