skinny_controllers 0.3 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f549f005c93de6eb099efb11b80a429c99077cf0
-  data.tar.gz: 44dd3003008e227b826fff4c51b3c1e9d28cf9d7
+  metadata.gz: ab06e95b7202701fab9189c65efc971ca5422b71
+  data.tar.gz: 8696ce2bc5873152f14f1743b7d5ec349c7f31ad
 SHA512:
-  metadata.gz: 975ae25a383bee2c3b88d79b126c95be07c379cf69382ce24666ef0963cd89a6e312fa8cd530944f784c0ec63599b2afcdc294678cfe9f13f58bd4c649ee5c6d
-  data.tar.gz: c0a2877d7e19e90deaa5c5e43f54222ffc256fd2a7b1487ad79fd149011504288ffea052e8510bd9dd164bff20dd319f9e940727277a1d791a01ee683af92e15
+  metadata.gz: 022423564d78053df74fa1ea751a121d02eb45f8349c347ed906daacdf3d5e89751bc9cd462817aedcfd093d400cb415da0994e437f1502fdcd037100401d231
+  data.tar.gz: 830c2b021accec0eca75ee25dadf9e7d423a9d29ff282c7b6da6c1a6f336005e832bc734c437f9fa48840e927943e004cc38748c918e18c0f4626a75f5cd90ae

data/README.md

@@ -56,7 +56,7 @@ In `EventSummariesController`, you would make the following additions:
 ```ruby
 class EventSummariesController < ApiController # or whatever your superclass is
   include SkinnyControllers::Diet
-  model_class = Event
+  self.model_class = Event
 
   def index
     render json: model, each_serializer: EventSummariesSerializer
@@ -139,3 +139,9 @@ The following options are available:
 |`accessible_to_method`|`is_accessible_to?`| method to call an the object that the user might be able to access |
 |`accessible_to_scope`| `accessible_to`| scope / class method on an object that the user might be able to access |
 |`action_map`| see [skinny_controllers.rb](./lib/skinny_controllers.rb#L61)| |
+
+
+## TODO
+
+ - Configurable Error Renderer
+   - Default to JSON API format errors?

data/lib/skinny_controllers/lookup/model.rb

@@ -9,7 +9,7 @@ module SkinnyControllers
       def class_from_operation(operation_name)
         # "Namespace::Model" => "Model"
         model_name = Model.name_from_operation(operation_name)
-        # object_type_of_interest.demodulize
+        # model_name.demodulize
 
         # "Model" => Model
         model_name.constantize

data/lib/skinny_controllers/lookup/policy.rb

@@ -6,10 +6,19 @@ module SkinnyControllers
       # @param [String] name the name of the model
       # @return [Class] the policy class
       def class_from_model(name)
-        (
-          "#{namespace}::#{name}" +
-          SkinnyControllers.policy_suffix
-        ).constantize
+        policy_class_name = class_name_from_model(name)
+        klass = policy_class_name.safe_constantize
+        klass || define_policy_class(policy_class_name)
+      end
+
+      def class_name_from_model(name)
+        parent_namespace = namespace.present? ? "#{namespace}::" : ''
+        "#{parent_namespace}#{name}" + SkinnyControllers.policy_suffix
+      end
+
+      def define_policy_class(name)
+        default_policy = SkinnyControllers::Policy::Default
+        Object.const_set(name, default_policy.dup)
       end
 
       # @param [String] class_name name of the operation class

data/lib/skinny_controllers/operation/base.rb

@@ -39,23 +39,23 @@ module SkinnyControllers
         @id_from_params
       end
 
-      def object_class
-        @object_class ||= Lookup::Model.class_from_operation(self.class.name)
+      def model_class
+        @model_class ||= Lookup::Model.class_from_operation(self.class.name)
       end
 
-      def object_type_of_interest
+      def model_name
         @object_type_name ||= Lookup::Model.name_from_operation(self.class.name)
       end
 
       def association_name_from_object
-        object_type_of_interest.tableize
+        model_name.tableize
       end
 
       # Takes the class name of self and converts it to a Policy class name
       #
       # @example In Operation::Event::Read, Policy::EventPolicy is returned
       def policy_class
-        @policy_class ||= Lookup::Policy.class_from_model(object_type_of_interest)
+        @policy_class ||= Lookup::Policy.class_from_model(model_name)
       end
 
       # Converts the class name to the method name to call on the policy

data/lib/skinny_controllers/operation/model_helpers.rb

@@ -5,20 +5,21 @@ module SkinnyControllers
         # TODO: not sure if multiple ids is a good idea here
         # if we don't have a(ny) id(s), get all of them
         @model ||=
-          if id_from_params
-            model_from_id
-          elsif params[:scope]
+          if params[:scope]
             model_from_scope
           elsif (key = params.keys.grep(/\_id$/)).present?
             # hopefully there is only ever one of these passed
-            model_from_named_id(key.first)
+            id = params[key.first]
+            model_from_named_id(key.first, id)
+          elsif id_from_params
+            model_from_id
           else
             model_from_params
           end
       end
 
       def sanitized_params
-        keys = (object_class.column_names & params.keys)
+        keys = (model_class.column_names & params.keys)
         params.slice(*keys).symbolize_keys
       end
 
@@ -35,7 +36,7 @@ module SkinnyControllers
       end
 
       def model_from_params
-        ar_proxy = object_class.where(sanitized_params)
+        ar_proxy = model_class.where(sanitized_params)
 
         if ar_proxy.respond_to? SkinnyControllers.accessible_to_scope
           # It's better to filter in sql, than in the app, so if there is
@@ -47,8 +48,8 @@ module SkinnyControllers
         ar_proxy
       end
 
-      def model_from_named_id(key)
-        name, id = key.split('_')
+      def model_from_named_id(key, id)
+        name, _id = key.split('_')
         name = name.camelize
         model_from_scope(
           id: id,
@@ -66,7 +67,7 @@ module SkinnyControllers
       end
 
       def model_from_id
-        object_class.find(id_from_params)
+        model_class.find(id_from_params)
       end
     end
   end

data/lib/skinny_controllers/policy/allow_all.rb

@@ -0,0 +1,9 @@
+module SkinnyControllers
+  module Policy
+    class AllowAll < Base
+      def default?; true; end
+      def read?; true; end
+      def read_all?; true; end
+    end
+  end
+end

data/lib/skinny_controllers/policy/default.rb

@@ -0,0 +1,9 @@
+module SkinnyControllers
+  module Policy
+    class Default < Base
+      # See <#Base>.read?
+      # See <#Base>.read_all?
+      # See <#Base>.default?
+    end
+  end
+end

data/lib/skinny_controllers/policy/deny_all.rb

@@ -0,0 +1,9 @@
+module SkinnyControllers
+  module Policy
+    class DenyAll < Base
+      def default?; false; end
+      def read?; false; end
+      def read_all?; false; end
+    end
+  end
+end

data/lib/skinny_controllers/version.rb

@@ -1,3 +1,3 @@
 module SkinnyControllers
-  VERSION = 0.3
+  VERSION = '0.3.1'
 end

data/lib/skinny_controllers.rb

@@ -12,6 +12,9 @@ require 'skinny_controllers/lookup/model'
 require 'skinny_controllers/lookup/operation'
 require 'skinny_controllers/lookup/policy'
 require 'skinny_controllers/policy/base'
+require 'skinny_controllers/policy/default'
+require 'skinny_controllers/policy/deny_all'
+require 'skinny_controllers/policy/allow_all'
 require 'skinny_controllers/operation/model_helpers'
 require 'skinny_controllers/operation/base'
 require 'skinny_controllers/operation/default'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: skinny_controllers
 version: !ruby/object:Gem::Version
-  version: '0.3'
+  version: 0.3.1
 platform: ruby
 authors:
 - L. Preston Sego III
@@ -196,7 +196,10 @@ files:
 - lib/skinny_controllers/operation/base.rb
 - lib/skinny_controllers/operation/default.rb
 - lib/skinny_controllers/operation/model_helpers.rb
+- lib/skinny_controllers/policy/allow_all.rb
 - lib/skinny_controllers/policy/base.rb
+- lib/skinny_controllers/policy/default.rb
+- lib/skinny_controllers/policy/deny_all.rb
 - lib/skinny_controllers/version.rb
 homepage: https://github.com/NullVoxPopuli/skinny-controllers
 licenses:
@@ -221,5 +224,5 @@ rubyforge_project:
 rubygems_version: 2.4.8
 signing_key: 
 specification_version: 4
-summary: SkinnyControllers-0.3
+summary: SkinnyControllers-0.3.1
 test_files: []