skinny_controllers 0.10.2 → 0.10.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 88a478d9713a8699d9cb95ba18a3b5484b678112
-  data.tar.gz: 2589fbbf6e1a07dc300bcede1d45008d7123cc6e
+  metadata.gz: bbb96f7788da37f889f320a1f37d8e7ca37ea510
+  data.tar.gz: 20bf1cb7ecc856907df5a27d8a5f983c04902336
 SHA512:
-  metadata.gz: cc9476fe7c40cfee230dcc239e7e19ce45a11008903360ffae93d0e004963c713ef401d5313bc34479ad7d5b965cbb9a4e334e34532ad13114f18cd505206919
-  data.tar.gz: b104a3ec1b2a4df86badbb7f81a262ed7800735e08ef188fd05583964790241ec09eb1049b8d69ab2a55a8c33cb55b36d08966d179aca9ea4fe5e5ef5db3fa16
+  metadata.gz: f732c190f25ddb33ac707d3dd4f14edbd010f3a53974cb776e02a5abfa153980da9a1f7343050babd72b64baff86503258eddb7d39ecd3d303e19d521d00d9db
+  data.tar.gz: 43e3c08f3d80b0a4f3ef53b71513514e3084f507c77df1ab7306690ff1beb3f1ba2e670c5bf054092badd94732bdc1125bea4e564b5d894d21c9bc6426afb6ff

data/README.md

@@ -543,7 +543,7 @@ This may not be horribly apparent, but here is a table overviewing some highleve
 
 | Feature | - | skinny_controllers | [trailblazer](https://github.com/apotonick/trailblazer) |
 |----|----|----|----|
-| Purpose |-| API - works very well with [ActiveModel::Serializers](https://github.com/rails-api/active_model_serializers)| General - additional featers for server-side rendered views |
+| Purpose |-| API - works very well with [ActiveModel::Serializers](https://github.com/rails-api/active_model_serializers)| General - additional features for server-side rendered views |
 | Added Layers |-| Operations, Policies | Operations, Policies, Forms |
 | Validation |-| stay in models | moved to operations via contract block |
 | Additional objects|-| none | contacts, representers, callbacks, cells |

data/lib/skinny_controllers/diet.rb

@@ -103,9 +103,9 @@ module SkinnyControllers
       action_params_method = "#{action_name}_#{model_key}_params"
       model_params_method = "#{model_key}_params"
 
-      if respond_to? action_params_method, true
+      if respond_to?(action_params_method, true)
         send(action_params_method)
-      elsif respond_to? model_params_method, true
+      elsif respond_to?(model_params_method, true)
         send(model_params_method)
       else
         params

data/lib/skinny_controllers/lookup/ensure_existence.rb

@@ -1,5 +1,7 @@
 module SkinnyControllers
   class Lookup
+    # NOTE: This is a lot of hackery.
+    #       Please Explicitly Define things if you are able
     module EnsureExistence
       module_function
 
@@ -43,8 +45,9 @@ module SkinnyControllers
     end
 
     def namespace_lookup(qualified_name)
-      return if qualified_name.blank?
-      klass = qualified_name.safe_constantize
+      klass = class_for_qualified_name(qualified_name)
+      # Return if the constant exists, or if we can't travel
+      # up any higher.
       return klass if klass
       return unless qualified_name.include?('::')
 
@@ -65,9 +68,7 @@ module SkinnyControllers
     end
 
     def policy_lookup(qualified_name)
-      return if qualified_name.blank?
-      klass = qualified_name.safe_constantize
-
+      klass = class_for_qualified_name(qualified_name)
       # Return if the constant exists, or if we can't travel
       # up any higher.
       return klass if klass
@@ -87,9 +88,7 @@ module SkinnyControllers
     end
 
     def operation_lookup(qualified_name)
-      return if qualified_name.blank?
-      klass = qualified_name.safe_constantize
-
+      klass = class_for_qualified_name(qualified_name)
       # Return if the constant exists, or if we can't travel
       # up any higher.
       return klass if klass
@@ -113,5 +112,14 @@ module SkinnyControllers
       # recurse
       operation_lookup(next_lookup)
     end
+
+    private
+
+    def class_for_qualified_name(qualified_name)
+      # Validate the name.
+      return if qualified_name.blank?
+
+      qualified_name.safe_constantize
+    end
   end
 end

data/lib/skinny_controllers/lookup/namespace.rb

@@ -17,7 +17,6 @@ module SkinnyControllers
         namespaces.each do |namespace|
           current = (existing + [namespace]).join('::')
           begin
-            # binding.pry
             Object.const_get(current)
           rescue NameError
             SkinnyControllers.logger.warn("Module #{namespace} not found, creating...")

data/lib/skinny_controllers/operation/base.rb

@@ -22,8 +22,8 @@ module SkinnyControllers
         :_lookup
 
       class << self
-        def run(current_user, params)
-          object = new(current_user, params)
+        def run(*args)
+          object = new(*args)
           object.run
         end
 
@@ -50,17 +50,27 @@ module SkinnyControllers
         action = nil,
         lookup = nil,
         options = {})
+
+
+
         self.authorized_via_parent = false
         self.current_user = current_user
         self.action = action || controller_params[:action]
-        self.params = controller_params
-        self.params_for_action = params_for_action || controller_params
+        self.params = params_to_hash(controller_params)
+        self.params_for_action = params_to_hash(params_for_action || controller_params)
+
         self._lookup = lookup
         self.options = options
         self.model_key = options[:model_params_key]
         self.association_name = options[:association_name]
       end
 
+      def params_to_hash(parameters)
+        return parameters.to_unsafe_hash if parameters.respond_to?(:to_unsafe_hash)
+
+        parameters.to_h
+      end
+
       def lookup
         @lookup ||= begin
           _lookup || Lookup.from_operation(

data/lib/skinny_controllers/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module SkinnyControllers
-  VERSION = '0.10.2'
+  VERSION = '0.10.3'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: skinny_controllers
 version: !ruby/object:Gem::Version
-  version: 0.10.2
+  version: 0.10.3
 platform: ruby
 authors:
 - L. Preston Sego III
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-12-01 00:00:00.000000000 Z
+date: 2017-07-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -235,9 +235,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.6.11
 signing_key: 
 specification_version: 4
-summary: SkinnyControllers-0.10.2
+summary: SkinnyControllers-0.10.3
 test_files: []
-has_rdoc: