skinbaron_api_client 0.2.1 → 0.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bac140e69332695d80e8a5f324a8becc9fb88052e80fddd0774d849bba2d1ee5
-  data.tar.gz: cb4c3b9386949e5cd4ca9b05136a02a7015ca722e48b5fec0d71c44da3c3de8b
+  metadata.gz: 0b973d5e86049bfa020fae424126e8957b00fa91c613c5d4e145628123bb7289
+  data.tar.gz: 0f16584da1097db5facf8544e78882c73c343391d09842c2d17e06c296ab79b7
 SHA512:
-  metadata.gz: f79f5e0ffcfd24a8ffec58da35ffa995e12da53e2e57abfb01e5f51aef6b44d3fb61419a45ecb12bba292da22ee062b0806db911af84e45e2c4f2339b8b5403c
-  data.tar.gz: 50b1432feb1bb58928a27fd68fb59e22351b3dcb2db8e492e4baf694876ab24abe7152c10b0844bc206a1e0f1d9546cb3577604f76d7c806ac5b007fe40ce738
+  metadata.gz: c79cb0d5c9f0860977f9f494168124cb7f347645bd1c79c85e7be8980d4a086f2013f05f16addba7f764839dbaf92f55637da36f4b57dfad433db1e0a645cd16
+  data.tar.gz: dc6fe1a9d00e216fcb622b2279bcba13a59b4886d3e71fc7cf96680c67e8a62e5c45a1b7b8f72481860bf765e5a6e2b2dbb50ef2679280533f18664b1eda0366

data/lib/skinbaron_api_client/client.rb

@@ -4,14 +4,11 @@
 
 require_relative "configuration"
 require_relative "http_client"
-require_relative "error_handling"
 require_relative "logger"
 require_relative "endpoints/search"
 
 module SkinbaronApiClient
   class Client
-    include ErrorHandling
-
     attr_reader :config, :http_client, :search_endpoint
 
     def initialize(**options)

data/lib/skinbaron_api_client/endpoints/search.rb

@@ -27,10 +27,11 @@ module SkinbaronApiClient
           enforce_request_delay(delay_seconds: options[:request_delay] || DEFAULT_REQUEST_DELAY)
           body["after_saleid"] = last_saleid if last_saleid
 
-          puts "REQUEST IS BEING MADE" if @config.debug
           response = @skinbaron_client.http_client.post(endpoint: "Search", body: body)
           @last_request_time = Time.now
 
+          raise TooManyRequestsError, "Too many requests" if response[:status] == 429
+
           response_body = JSON.parse(response[:body])
           current_page_listings = response_body["sales"]
 

data/lib/skinbaron_api_client/exceptions/exceptions.rb

@@ -0,0 +1,11 @@
+module SkinbaronApiClient
+  class Error < StandardError; end
+
+  class AuthenticationError < Error; end
+
+  class RequestError < Error; end
+
+  class ResponseError < Error; end
+
+  class TooManyRequestsError < Error; end
+end

data/lib/skinbaron_api_client/http_client.rb

@@ -1,13 +1,10 @@
 require "http"
 require "json"
-require_relative "error_handling"
 require_relative "logger"
 
 module SkinbaronApiClient
   # HTTP client for making requests to the Skinbaron API
   class HttpClient
-    include ErrorHandling
-
     attr_reader :base_url, :headers, :debug
 
     def initialize(base_url:, headers: {}, debug: false)
@@ -16,7 +13,7 @@ module SkinbaronApiClient
       @debug = debug
     end
 
-    with_error_handling def post(endpoint:, body: {})
+    def post(endpoint:, body: {})
       url = "#{base_url}/#{endpoint}"
       debug_log "Making POST request to: #{url}"
       debug_log "Request body: #{body.to_json}"
@@ -30,6 +27,7 @@ module SkinbaronApiClient
                           })
 
       http_response = HTTP.headers(headers).post(url, json: body)
+      raise AuthenticationError, "Authentication failed" if http_response.body.to_s.include? "wrong or unauthenticated"
 
       Logger.instance.log({
                             type: "RESPONSE",

data/lib/skinbaron_api_client/logger.rb

@@ -54,9 +54,6 @@ module SkinbaronApiClient
         @request_logger.info(JSON.pretty_generate(log_data))
         @request_logger.info("#{"=" * 80}\n")
       end
-    rescue JSON::ParserError => e
-      @logger.error("LOGGER: failed to parse search response", error: e.message)
-      @logger.error("LOGGER: Response: #{JSON.pretty_generate(log_data)}")
     end
 
     LEVELS.each do |level|

data/lib/skinbaron_api_client/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module SkinbaronApiClient
-  VERSION = "0.2.1"
+  VERSION = "0.2.3"
 end

data/lib/skinbaron_api_client.rb

@@ -7,7 +7,6 @@ require "json"
 require_relative "skinbaron_api_client/version"
 require_relative "skinbaron_api_client/client"
 require_relative "skinbaron_api_client/logger"
-require_relative "skinbaron_api_client/error_handling"
 
 # Example usage:
 #
@@ -17,11 +16,4 @@ require_relative "skinbaron_api_client/error_handling"
 # response = skinbaron.search(item: "AK-47 | Asiimov")
 #
 module SkinbaronApiClient
-  class Error < StandardError; end
-
-  class AuthenticationError < Error; end
-
-  class RequestError < Error; end
-
-  class ResponseError < Error; end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: skinbaron_api_client
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.3
 platform: ruby
 authors:
 - Sam Schams
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-12-29 00:00:00.000000000 Z
+date: 2025-02-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: http
@@ -64,7 +64,7 @@ files:
 - lib/skinbaron_api_client/client.rb
 - lib/skinbaron_api_client/configuration.rb
 - lib/skinbaron_api_client/endpoints/search.rb
-- lib/skinbaron_api_client/error_handling.rb
+- lib/skinbaron_api_client/exceptions/exceptions.rb
 - lib/skinbaron_api_client/http_client.rb
 - lib/skinbaron_api_client/logger.rb
 - lib/skinbaron_api_client/version.rb

data/lib/skinbaron_api_client/error_handling.rb

@@ -1,64 +0,0 @@
-# frozen_string_literal: true
-
-module SkinbaronApiClient
-  # Mixin for adding error handling capabilities to API client classes.
-  # Provides methods for response validation and error logging.
-  module ErrorHandling
-    def self.included(base)
-      base.extend(ClassMethods)
-    end
-
-    # Class methods for decorating instance methods with error handling.
-    # Provides the with_error_handling decorator for wrapping methods.
-    module ClassMethods
-      def with_error_handling(method_name)
-        original_method = instance_method(method_name)
-
-        define_method(method_name) do |*args, **kwargs|
-          response = original_method.bind(self).call(*args, **kwargs)
-
-          check_response_success(response)
-          check_response_authentication(response)
-
-          response
-        rescue HTTP::Error => e
-          log_error(message: "HTTP request failed", error: e)
-          raise RequestError, "HTTP request failed: #{e.message}"
-        rescue JSON::ParserError => e
-          log_error(message: "JSON parsing failed", error: e)
-          raise ResponseError, "Invalid JSON response: #{e.message}"
-        end
-      end
-    end
-
-    private
-
-    def logger
-      SkinbaronApiClient::Logger.instance
-    end
-
-    def log_error(message:, error:)
-      logger.error(
-        message,
-        {
-          error_class: error.class.name,
-          error_message: error.message,
-          backtrace: error.backtrace&.first(5)
-        }
-      )
-    end
-
-    def check_response_success(response)
-      return if response[:status]&.success?
-
-      raise ResponseError, "Request failed with status #{response[:status]}. Response: #{response[:body]}"
-    end
-
-    def check_response_authentication(response)
-      return unless response[:body].to_s.include? "wrong or unauthenticated request"
-
-      logger.error("Authentication failed", { body: response[:body] })
-      raise AuthenticationError, "Authentication failed: #{response[:body]}"
-    end
-  end
-end